Richard Cohen
a8943dc315
Refactor: remove unnecessary GNCSearch*Private
...
- rename parent to parent_instance
- remove unused member dummy
2023-06-13 11:39:10 +01:00
Richard Cohen
4eb20b2456
Refactor: hide implementation of GNCSearch* (move from .h to .c)
2023-06-13 11:38:56 +01:00
Richard Cohen
5d3eaa51c7
Refactor: DECLARE_FINAL GNCSearchOwner < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
8cb697b8a9
Refactor: DECLARE_FINAL GNCSearchString < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
b1d1f6b8d1
Refactor: DECLARE_FINAL GNCSearchReconciled < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
bd6083278d
Refactor: DECLARE_FINAL GNCSearchNumeric < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
f1a77ca782
Refactor: DECLARE_FINAL GNCSearchInt64 < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
0b215793b6
Refactor: DECLARE_FINAL GNCSearchDouble < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
f935d7868b
Refactor: DECLARE_FINAL GNCSearchDate < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
74517c44a5
Refactor: DECLARE_FINAL GNCSearchBoolean < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
a6dcdb6a68
Refactor: DECLARE_FINAL GNCSearchAccount < GNCSearchCoreType
2023-06-13 11:37:59 +01:00
Richard Cohen
53ab52fa4e
Refactor: DECLARE_DERIVABLE GNCSearchCoreType < GObject
...
- remove unused GNCSearchParam *param
2023-06-13 11:36:57 +01:00
John Ralls
38118a2ad6
Bug 798948 - XML file corrupted by saving twice in extremely short period
...
Prevent reentrance with gnc_file_save_in_progress().
2023-06-12 17:00:45 -07:00
John Ralls
75fb523c36
Merge Simon Arlott's 'bug-798695' into stable.
2023-06-12 15:48:50 -07:00
John Ralls
57b8006a66
Merge Simon Arlott's 'bug-777472' into stable.
2023-06-12 15:45:41 -07:00
John Ralls
2e20b37d04
Merge Paolo Maero's 'money-out' into stable.
2023-06-12 14:45:19 -07:00
John Ralls
0d1ba1ebe7
Merge Richard Cohen's 'y2038-fixes' into stable.
2023-06-12 14:44:11 -07:00
John Ralls
fb7c0328bc
Merge Richard Cohen's 'remove-unused-osx_accel_map' into stable.
2023-06-12 14:43:09 -07:00
John Ralls
770b5a4be9
Add new completioncell-gnome.c to POTFILES.in
2023-06-12 11:19:29 -07:00
John Ralls
0c64c98a93
[stock-txn-asst] Remove conflict markers.
2023-06-12 11:18:11 -07:00
Christopher Lam
8ec6a4cb12
[Scrub.c] 8628ca8715
rewritten to avoid QofQuery
...
because QofQuery will include the blank transaction which must not be
scrubbed.
2023-06-12 23:59:37 +08:00
John Ralls
6d60c11252
Merge Bob Fewell's 'revised-reg-desc' into stable.
2023-06-11 13:11:41 -07:00
John Ralls
96e349ba8d
Merge Christopher Lam's 'stock-txns-mvc' into stable.
2023-06-11 13:08:51 -07:00
John Ralls
c4e0ddb819
[stock-txn-asst] Don't use the initial value in amount edit widgets.
...
Unless they're valid. Otherwise the invalid value will log an error
that will prevent later valid input from working.
2023-06-11 12:22:24 -07:00
John Ralls
186963109d
[stock-txn-asst] Remove some superflous declarations.
2023-06-11 12:22:02 -07:00
John Ralls
43b161c28b
[stock-txn-asst] Add comments explaining workings.
2023-06-10 18:24:07 -07:00
John Ralls
f4ac1f40fe
[stock-txn-asst] Extract page classes for StockAssistantView.
2023-06-10 18:24:07 -07:00
John Ralls
fdfa8353dd
[stock-txn-asst] Extract StockTransactionEntry classes.
2023-06-10 18:24:07 -07:00
John Ralls
b3b071e011
[stock-txn-asst] StockAssistantModel variable names
...
Rename member variables with m_ prefix, remove this-> from
in-class references to those variables.
2023-06-10 18:24:07 -07:00
John Ralls
cebc7198f2
[stock-txn-asst] Reformat StockAssistantModel
...
Moving the ctor and dtor to immediately after the variables and
moving the longer function defs out of the class decl.
2023-06-10 18:24:07 -07:00
John Ralls
925999e070
[stock-txn-asst] Refactor check_page into a constructor.
...
Because it is one.
2023-06-10 18:24:07 -07:00
John Ralls
4ebc028740
[stock-txn-asst] Refactor gtest-assistant-stock-transaction.cpp
...
For better readability. Removes gratuitous parameterized test
suite because the StockAssistantModel is stateful and can't
use easyTestCases when it and the book are re-created for
each instance, as is the case when the easyTestCases is passed
as a parameter set to a test suite.
Also replaced the shared_ptr<QofBook> with a unique_ptr.
2023-06-10 18:24:07 -07:00
John Ralls
74f707bfa7
[asst-stock-trans] StockAssistantModel instance variable names
...
Should start with m_. Also designating them with this-> isn't
idiomatic or necessary, and long functions shouldn't be defined
in the class/struct body.
2023-06-10 18:24:07 -07:00
John Ralls
6d36d1d7ee
[asst-stock-trans] Rename primary callbacks to clarify their purpose.
2023-06-10 18:24:07 -07:00
Christopher Lam
0d9dd3b789
[assistant-stock-transaction] support additional txn_types
2023-06-10 18:24:07 -07:00
Christopher Lam
55046f22d2
reduce number of bools in txn_type info: fees_capitalize
2023-06-10 18:24:07 -07:00
Christopher Lam
d67f0b3c99
reduce number of bools in txn_type info: input_new_balance
...
input_new_balance merged into stock_amount FieldMask
2023-06-10 18:24:07 -07:00
Christopher Lam
d92d5b4bd2
test suite for assistant-stock-transaction.cpp
2023-06-10 18:24:03 -07:00
Christopher Lam
f36e5d56ed
[assistant-stock-transaction] refactor using MVC
2023-06-10 18:21:00 -07:00
Richard Cohen
7d26b8c05f
Fail the test if still using 32bit time_t in 2038
...
gtest-gnc-option.cpp and gtest-gnc-optiondb.cpp need to call
time() for g_date_set_time_t()
2023-06-08 14:30:32 +01:00
Richard Cohen
d63248dad2
Update Y2038 comments
2023-06-08 14:30:28 +01:00
Richard Cohen
7b1ad4ec19
Remove unused osx_accel_map
...
Since a143f8b5ed
on 2023-03-11,
accelerator-map-osx is the file that is used
2023-06-08 14:10:39 +01:00
John Ralls
3307b802fe
Merge Richard Cohen's 'remove-unused-remnants-of-register2' into stable.
...
message to explain why this merge is necessary, # especially if it merges
an updated upstream into a topic branch. # # Lines starting with '#' will
be ignored, and an empty message aborts # the commit.
2023-06-07 19:51:33 -07:00
Simon Arlott
5923a59cfc
Bug 777472 - reconcile does not work if transaction selected
...
If there's an existing transaction with pending edits when starting
reconciliation, that transaction can appear in the list of transactions and
be modified by the reconciliation but as soon as navigation to another
transaction occurs the pending edit will be saved, overwriting the change
to mark it as reconciled. The result is that reconciliation appears to have
failed or not marked the transaction as reconciled.
This commonly happens when marking several transactions as cleared before
performing reconciliation. If the last transaction is still being edited
it will typically be saved after the reconciliation finishes and overwrite
any change made.
Check that there's no outstanding activity in the current register page
before starting a reconciliation.
It is still possible to start modifying a transaction after the
reconciliation window is open but this will stop the most common issue with
the process.
Starting a reconciliation from the account tree is left unprotected.
2023-06-07 20:13:46 +01:00
Richard Cohen
6cc6ac8681
Refactor: remove unused GncCellRendererPopupEntry
2023-06-07 17:54:52 +01:00
Richard Cohen
0f2c6a002f
Refactor: remove unused GncCellRendererPopup
2023-06-07 17:54:52 +01:00
Richard Cohen
98b43768dd
Refactor: remove unused GncCellRendererDate
2023-06-07 17:54:52 +01:00
Richard Cohen
3bff7c926e
Refactor: remove unused gnc_tree_view_add_date_column()
2023-06-07 17:54:52 +01:00
Richard Cohen
4bbcde7296
Refactor: remove unused gnc_tree_view_add_combo_column()
2023-06-07 17:54:52 +01:00
Christopher Lam
3ccb5c4896
Merge branch 'wordsmithing' into stable #1658
2023-06-07 22:00:06 +08:00