Commit Graph

21251 Commits

Author SHA1 Message Date
Christopher Lam
5873980c0c replace guile strftime with gnc-print-time64
addendum to ed42f8ac

guile's strftime is/was buggy; cannot handle non-UTF8 locales. Use
gnc_print_time64 instead. see the following

http://lists.gnu.org/archive/html/bug-guile/2019-05/msg00003.html
2019-05-28 18:42:32 +08:00
John Ralls
957df9a32b Add a +0000 offset to ISO8601 timestamps in the XML backend.
Apparently GnuCash for Android hard-coded the offset spec into their
parser, so it can't import XML files without it.
2019-05-27 14:51:06 -07:00
John Ralls
f76226f912 Fix broken CSV Import tests. 2019-05-27 14:51:06 -07:00
Geert Janssens
e557b021d3 CsvImport - Fix mishandling of quoted empty fields 2019-05-27 22:42:10 +02:00
Christopher Lam
ed42f8acb6 Bug 797197 - Transaction report: Error message when sorting on month
guile's strftime is/was buggy; cannot handle non-UTF8 locales. Use
gnc_print_time64 instead. see the following

http://lists.gnu.org/archive/html/bug-guile/2019-05/msg00003.html
2019-05-27 21:20:29 +08:00
Geert Janssens
8447f42674 Bug 797126 - It is annoying to run cmake to get an updated mo file
Add missing dependency in order to make the po-gmo and po-gmo-build targets acually work.
2019-05-27 14:50:36 +02:00
Geert Janssens
712714cf94 Bug 797207 - Chart reports show blank when run from the build directory
jqplot files were not copied to the build environment
2019-05-27 14:50:36 +02:00
Christopher Lam
49334906ae [test-report-utilities] reactivate 'debugging tools' section
This commit reactivates test section, which was disabled to hide a
date-related test failure. See Bug 797139 for more details.
2019-05-27 20:46:06 +08:00
Adrian Panella
6888bb30a2 [budget report] Fix multiple currency budget rollup 2019-05-25 10:50:52 -05:00
Geert Janssens
be1484841c One more minor cmake cleanup 2019-05-25 12:11:53 +02:00
Geert Janssens
b7479e8fb0 Bump minimum cmake version to 3.5
This version is available for all supported platforms and distros
(CentOS can have a version via EPEL, which is required anyway)

Advantages:
- one cmake version for all platforms
- we can drop all conditions based on cmake version
2019-05-25 12:04:51 +02:00
Christopher Lam
ae76a29453 [aging] bugfix avoid report-crash when no APAR account exists
need additional sanity checks.

in a book with no suitable AP/AR account, from 'Customers Overview'
spreadsheet, clicking 'Customer Listing' may call aging.scm renderer
with account = #f leading to report crash.
2019-05-25 15:30:54 +08:00
Christopher Lam
efe88f13a8 [balsheet-pnl] link pnl->transaction-report inherits common-currency 2019-05-25 15:30:54 +08:00
John Ralls
2d4f771bed Merge Adrién Panella's 'budget' into maint. 2019-05-23 09:50:20 -07:00
Christopher Lam
311f7d26e6 [dialog-tax-table] implement renaming of Tax Table name
Adds a new button 'Rename' in dialog-tax-table.
2019-05-20 15:43:23 +08:00
Adrian Panella
f6df367f50 [budget] Remove unused code
Remove some priv attributes and code that were never used
2019-05-18 14:35:28 -05:00
Adrian Panella
51dda77057 Bug 577968 - Values are not stored by pressing <TAB> in budget page
Also fix duplicates: 760194
2019-05-18 14:35:28 -05:00
Adrian Panella
91aceaa71b Bug 781345 - Equity disregarded by budget totals 2019-05-18 14:35:28 -05:00
Adrian Panella
d16a236ece [Budget] Fix negative Numbers Not Colored Red 2019-05-18 14:35:11 -05:00
Adrian Panella
0319144ba6 Bug 788157 - Open Budget Menu Item Doesn't Select Default Budget 2019-05-17 23:12:19 -05:00
Adrian Panella
5bb54d073c [budget] Fix error in qof_book property path
The "Default budget" property had an erroneus path
and was not returning any value.
2019-05-17 23:12:19 -05:00
Adrian Panella
df1cc5902b Bug 676810 - Wrong accounting in multi-currency budget report
Adds multicurrency support in budget page
Convert currencies before summing up to parent and totals.
2019-05-17 23:12:11 -05:00
Adrian Panella
52895eabd1 Bug 679800 - Shortcut to allow population of all budgeting periods
Add functionality to change at once the budget for all
periods of selected accounts.
It can :
replace with a new value
unset the budget
add a value to current budget
multiply current budget with value

Solvese issue #679800 and a duplicates (#639404, #760634)
2019-05-17 23:11:48 -05:00
Christopher Lam
b26276cba4 Bug 797241 - Some reports skip transactions of the last day of the selected period
portfolio.scm and advanced-portfolio.scm were not taking into account
transactions dated on the report-date. expand query so that end-date
is 23:59:59 rather than somewhere mid-day.
2019-05-17 23:07:19 +08:00
Robert Fewell
416b79d304 Reformat source files gnc-accounting-period.*
Change tabs to white space and some other white space changes.
2019-05-17 11:01:24 +01:00
Robert Fewell
037f5ed5be Bug 797089 - Wrong time for accounting period end date
In the Preferences/Accounting Period, there is an option to specify
absolute dates but the end date was being set to start of day instead
of end of day, changed this.
2019-05-17 11:01:24 +01:00
Robert Fewell
5ad3cd0d60 Deleting TaxTable entries can crash application
Change the switch statement to include GNC_AMT_TYPE_VALUE to return a
value for row_text[1] and change default to set it to NULL
2019-05-17 11:01:24 +01:00
Robert Fewell
fade13f813 Setup some default sorting for the TaxTable entries 2019-05-17 11:01:24 +01:00
Robert Fewell
36574f08fb After editing the TaxTables the selection has moved 2019-05-17 11:01:24 +01:00
Christopher Lam
e3fb593edc Bug 797240 - Multicolumn report not showing each report name
reportname was not correctly applied as the chart-title
2019-05-17 11:11:30 +08:00
Geert Janssens
539be984e5 Fix mnemonic behavior on business preferences page 2019-05-16 19:01:31 +02:00
Frank H. Ellenberger
aeb7e690b5 Use standard buttons and add more mnenoics to Aqbanking dialogs
Part of Bug 797232
2019-05-16 17:37:28 +02:00
Christopher Lam
f779b81719 [balsheet-pnl] unrealized-gain calculator bugfix
The unrealized-gain calculator was flawed.

The fixed function is copied from balance-sheet.scm and adapted to
balsheet-pnl.scm vars.

This fixed function matches unrealized-gains amounts from
balance-sheet.scm
2019-05-16 19:08:07 +08:00
Christopher Lam
0ecfc911ca [balsheet-pnl] chart: set report-currency to most used currency
This is a usability upgrade.

This balsheet-pnl report does *not* enforce a report currency; it can
print, process and multilevel-total monetary amounts in their original
currency.

But a linked chart needs one. By default it uses global
report_currency which may not match the book's most used currencies.

This commit will scan the accountlist, retrieve the most common
currency used, and set it as the report-currency for the linked
chart.

The book-main-currency function *may* be upgraded to
report-utilities.scm in the future.

Case example:
* set gnc_default_report_currency to USD
* load book.gnucash with majority accounts in EUR, some in GBP
* run balsheet-pnl.scm - shows EUR and GBP amounts and mixed totals.
* click link to barchart - would not succeed because all amounts
  converted to USD0.00. this commit will ensure barchart's target
  currency is set to EUR thereby showing useful chart.
2019-05-16 19:05:53 +08:00
Adrian Panella
93bf1a0f23 Bug 646361 - Estimate budget option to have same amount in each budget period
If set, all periods get the same budget, from the average
of the reference period.
2019-05-15 21:53:35 -05:00
Mike Evans
75a919b283 Bug 751290 - Rethinking the invoice ledger view
Fix indent and add a note for translators.
2019-05-15 07:12:50 +01:00
Frank H. Ellenberger
a63adac4c5 Rise minimum required CMake version for Linux to 3.2
This will allow us to use modules like FindIntl.
https://lists.gnucash.org/logs/2019/05/14.html#T17:32:19
2019-05-15 00:18:25 +02:00
Frank H. Ellenberger
29f605bd1b Move I18N modules in one section of CMakelists.txt 2019-05-14 23:44:18 +02:00
Frank H. Ellenberger
7cb4c1d7b1 Cleanup of no longer used Gettext flags
We don't need HAVE_GETTEXT conditional code
2019-05-14 23:44:18 +02:00
John Ralls
fc567208f3 Bug 797233 - Balance Sheet, Chart of Accounts, and other reports...
crash when involving foreign currency stocks.

Scheme's inexact->exact function just converts the floating-point
representation of a number into an exact rational (documented in the
API Reference, Simple Generic Data Types, Numerical data types, Exact
and Inexact Numbers), which isn't what we want.

We want the number converted to exact directly from the string and to do
that we have gnc-fq-helper preface it with #e.
2019-05-14 13:34:07 -07:00
John Ralls
217418bb8c Merge Adrián Panella's 'numeric' into maint. 2019-05-14 10:09:16 -07:00
Adrian Panella
f905467a44 [numeric] Fix constructor from strings in range (0 ,1)
Fix error that caused strings in the form 0.nnn to be
converted to negative numerics.
2019-05-13 23:05:11 -05:00
Frank H. Ellenberger
6b0f3ce641 Unify optionally required Python version - PR #481 supplement 2019-05-14 04:24:26 +02:00
John Ralls
e6c50357bb Fix test error string to match actual error. 2019-05-13 15:19:19 -07:00
John Ralls
8738644af0 Merge David Palma's fix-division into maint. 2019-05-13 15:15:36 -07:00
Geert Janssens
d4c524a9ef Fix test dependency issue 2019-05-13 20:14:58 +02:00
Christopher Lam
7b1a262eea [balsheet-pnl] refinements to barchart
* barchart should inherit the period selected. this requires
  redefining the periodlist - we need the exact symbol to set the
  barchart's period option.

* balsheet: disable barchart if period is disabled - it makes no sense
  to create link to networth barchart for single-date balsheet

* reorder some options for better usability

* note this may affect saved-reports / saved-tabs but only those
  running bleeding edge maint. I do not intend to make any further
  options changes on this report.
2019-05-13 16:55:31 +08:00
Christopher Lam
67830a0e35 [report-gnome] compact functions
* inline single-use functions
* use srfi-1 list processing functions
* minimise set! calls
2019-05-13 16:55:20 +08:00
Christopher Lam
668b1f6b7b [report-gnome] fix whitespace 2019-05-13 16:55:20 +08:00
Robert Fewell
c38c4557a5 Bug 797051 - Change Overwrite price confirmation
Change when you cancel the overwrite price confirmation so that you
return back to the 'Price Editor' instead of closing it.
2019-05-12 11:58:26 +01:00