Commit Graph

21251 Commits

Author SHA1 Message Date
Robert Fewell
a560980617 Remove some obsolete code
Remove some code that was used in the old transaction import assistant
to do with embedding an account picker dialog in an assistant.
2019-05-12 11:58:26 +01:00
Robert Fewell
e76ebf4c60 Change the Placeholder warning in the Account picker
When an account is selected it is checked for being a placeholder and
if it is a warning dialog was created. This was pointed out as being
disruptive so this change controls the sensitivity of the OK button and
displays a warning in the account picker dialog.
2019-05-12 11:58:26 +01:00
Robert Fewell
ea0982eb33 Stop some errors when cancelling the QIF import
The imported_account_tree variable is only set when the 'start import'
button is pressed on assistant page 'QIF import' so only process the
undo from there.
2019-05-12 11:58:26 +01:00
Robert Fewell
35b3d6d187 Bug 668349 - Scroll to selected accounts in QIF import tree views 2019-05-12 11:58:26 +01:00
Robert Fewell
d7b40c788b Bug 754710 - Add column sorting to Qif import Match views 2019-05-12 11:58:26 +01:00
Robert Fewell
9504b7067d Bug 728873 - In Qif importer use the enter on account entry
Focus is already on the account entry so enable the use of the enter
key to proceed to the next page when you are finished changing the
account name for a qif file.
2019-05-12 11:58:26 +01:00
Robert Fewell
1dc99f1fa6 Going back from 'Qif files you have loaded' crashes
Once you have unloaded all files on the above page and go back Gnucash
will crash as it was using an invalid file, check for selected_file in
the ...import_account_prepare function.
2019-05-12 11:58:26 +01:00
Robert Fewell
29063fc9d2 With no files in the Qif importer it is possible to proceed
On the page 'Qif files you have loaded' it is possible to unload files
and if all files are unloaded it was still possible to proceed so
disable the next button if no files are in the list.
2019-05-12 11:58:26 +01:00
Robert Fewell
bb49a177cf Bug 583277 - Ask for confirmation for cancelling QIF import 2019-05-12 11:58:26 +01:00
Robert Fewell
bca3bd379e Bug 642824 - Check for Placeholder Accounts in Qif Import
Placeholder accounts do not allow transactions so when the account
picker dialog is presented, add an error dialog for placeholder
selection and a column to display that the account is a placeholder.
2019-05-12 11:58:26 +01:00
Robert Fewell
ac0eb00141 Bug 397927 - Save the window size/position for Qif Account picker dialog 2019-05-12 11:58:26 +01:00
Robert Fewell
b41cb2f5c2 Bug 797215 - Add sorting to QIF duplicates page 2019-05-12 11:58:26 +01:00
Robert Fewell
e353804d64 Rename some variables to be more notebook specific in previous assistant-qif-import.c change 2019-05-12 11:58:26 +01:00
Robert Fewell
bfbf2c1396 Bug 797204 - Qif import Tradable commodities page
This bug has two elements, the first is that when you have a large
number of tradable commodities you get an assistant page for each one
and if too many you loose site of the assistant buttons. To fix this a
notebook was added to the tradable commodities assistant page with the
individual commodities being added to notebook pages.

The second part was that when editing these an intrusive dialogue was
being raised that displayed the same information as the tooltip which
blocked input. These were removed and the assistant next button enabled
when all entries are valid.
2019-05-12 11:58:26 +01:00
Robert Fewell
b05506ca72 Reformat assistant-qif-import.c source file part4/4 2019-05-12 11:58:26 +01:00
Robert Fewell
75632dae57 Reformat assistant-qif-import.c source file part3/4 2019-05-12 11:58:26 +01:00
Robert Fewell
2e105c94e7 Reformat assistant-qif-import.c source file part2/4 2019-05-12 11:58:26 +01:00
Robert Fewell
aa5601b432 Reformat assistant-qif-import.c source file part1/4 2019-05-12 11:58:26 +01:00
David Palma
aab89065da
Bug 796949 - Fix division and rounding of zero.
Fix division of 128-bit integers so that the remainder inherits the dividend's sign.
Fix rounding for truncated zero.
2019-05-11 23:23:59 +01:00
Christopher Lam
94c5fe9f1d [balsheet-pnl] fix stress-options failure
retained-earnings-fn will return a list of monetary (for different
currencies) or a monetary (all currencies converted). either must be
negated. handle separate paths separately.
2019-05-10 22:35:31 +08:00
Christopher Lam
e983d07cb1 [balsheet-pnl] Initial commit 2019-05-10 22:08:26 +08:00
Christopher Lam
101f840255 [taxtxf] compact get-acct-tax-info 2019-05-10 20:02:16 +08:00
Robert Fewell
7345a4adfa Change dialog-job to use GtkGrids 2019-05-10 12:20:37 +01:00
Robert Fewell
1a40caee9d Change dialog-order to use GtkGrids 2019-05-10 12:20:37 +01:00
Robert Fewell
3b73c49e80 Change dialog-invoice to use GtkGrid widgets
There was a column alignment error between the labels and widgets as
they were using separate vboxs so moving them all to a Gtkgrid
eliminates this.
2019-05-10 12:20:31 +01:00
Robert Fewell
a26a7c5908 Change assistant-ab-initial.glade so it displays correctly
The text on the first page was squashed as the width could not be
negotiated properly as all the text was set to wrap automaticity and on
subsequent pages there was no wide widgets. Moved the first text row to
a separate widget and not wrap-able so a decent width can be negotiated.
2019-05-10 11:56:23 +01:00
Robert Fewell
5846543279 Bug 797232 - Convert dialog-ab.glade to gtk3 2019-05-10 11:55:40 +01:00
John Ralls
d624894099 Bug 797186 - gtk crash closing parent window edit->stylesheets
Free then NULL, not the other way around.
2019-05-09 19:33:08 -05:00
Christopher Zimmermann
7b6b86000d Bug 797230 - Use after free in
gnucash__sheet_style_destroy.
2019-05-09 19:13:41 -05:00
Christopher Lam
48c3c8bc51 [commodity-utils] partially revert eac79bd506
The eac79bd506 commit was slightly overzealous - if pair was #f,
originally this make-exchange-function would create a function that
returns (gnc:make-gnc-monetary domestic 0); I thought it was
acceptable to return #f instead but this would lead to report
crash. Revert previous behaviour.
2019-05-07 20:36:40 +08:00
John Ralls
810d283e73 "Second fix, revert extraneous change in prior fix." 2019-05-06 21:41:17 -07:00
John Ralls
eec00c8a3f Fix Travis failure. 2019-05-06 21:17:54 -07:00
Frank H. Ellenberger
f1fe106d5c de.po: Remove forgotten fuzzy flag from "Issue _SEPA Transaction..."
5219 übersetzte Meldungen, 39 ungenaue Übersetzungen, 2 unübersetzte
Meldungen.

https://lists.gnucash.org/pipermail/gnucash-de/2019-May/010593.html
2019-05-06 19:35:27 +02:00
Mike Evans
0cb60dd224 Repair unintended indent changes,
This happened in commit 126dc3a for bug 797168
2019-05-06 13:40:21 +01:00
Mike Evans
9e43f6bc42 Implement "printing" to a pdf.
This removes the export to PDF button and uses the standard print
dialog with an option to print tp pdf.
The filename is pre-populated, with the path set to the default, $HOME
on linux.
There is no remembering of past output directories.  Maybe a later
update will do this.
2019-05-05 14:19:34 +01:00
Christopher Lam
6e246ef8ad [options] compact option-setter in generator
slightly more compact, avoids confusing structure whereby 'option' is
both the lambda's argument and the definition of argument.
2019-05-04 06:19:59 +08:00
Christopher Lam
6dd04cfa58 [stylesheet-plain] compact functions 2019-05-04 06:19:59 +08:00
Christopher Lam
1338162d14 [stylesheets] *reindent/delete-trailing-whitespace/untabify* 2019-05-04 06:19:59 +08:00
Christopher Lam
375013f9ea [commodity-utils] simplify gnc:make-exchange-function
Remove assigning exchangelist to exchange-alist.

Removes need to test foreign-amount against 0 - multiplication will
result in 0 anyway. The only functional change is the condition
whereby foreign's commodity is not present in exchangelist; previously
it would return (gnc:make-gnc-monetary domestic 0); now it returns #f.

This function *is* allowed to return #f for invalid or missing prices;
see the (and foreign ...) conditional.
2019-05-04 06:19:59 +08:00
Christopher Lam
e111c5bb07 [commodity-utils] use scheme division instead of gnc-numeric
with small change to test due to increased precision
2019-05-04 06:19:59 +08:00
Christopher Lam
f2aacf94cc [commodity-utils] remove price-is-not-zero? and work-done
because now we're not adding invalid prices to pricelist, and avoids
set! calls

also fix typo in deprecation message
2019-05-04 06:19:59 +08:00
Christopher Lam
fbcf488237 [commodity-utils] refactor resolve-unknown-comm 2019-05-04 06:19:59 +08:00
Christopher Lam
ce675eaac6 [commodity-utils] refactor get-exchange-cost-totals 2019-05-04 06:19:59 +08:00
Christopher Lam
b2dc906bcd [commodity-utils] refactor get-exchange-totals 2019-05-04 06:19:59 +08:00
Christopher Lam
9ef2a2f3dd [commodity-utils] refactor inst price calculator 2019-05-04 06:19:59 +08:00
Christopher Lam
91f3e9fefe [commodity-utils] refactor totalavg price calculator
use exact rationals, therefore test suite amended
2019-05-04 06:19:59 +08:00
Frank H. Ellenberger
76936bc646 [I18N] Improve doc-page of CSV transaction importer
Text based on
https://lists.gnucash.org/pipermail/gnucash-devel/2019-May/043795.html
2019-05-03 23:08:43 +02:00
John Ralls
8fb2111636 Merge Christoph Holtermann's 'pycons-more-verbose' into maint. 2019-05-03 13:26:42 -07:00
c-holtermann
24ac69d8a9 make python shell startup more understandable 2019-05-03 18:13:52 +02:00
Frank H. Ellenberger
53e4e8a976 Use standard buttons in "Tip of the Day" 2019-05-03 13:15:32 +02:00