Fix the neutral offset calculations so that the fixed UTC time doesn't
change the date in the timezones near the international date line. Divide
offset by 60 instead of 3600 so that the Chatham Islands (GMT-12:45 with DST)
use 9:59 instead of 10:59 like the rest of NZ (GMT-12).
Remove the scheme from file URIs before displaying
error messages and change the one file error message that can show up in
database dialogs to say "file/URI foo" instead of "file foo".
This series of changes modifies the Average Cost report function to
finding the average amount-weighted price of all transactions recording
a "buy" of the report commodity so that the correct amount is now
reported without the need of a capital gains split--though one is still
needed to get the Trial Balance report to balance.
Since book-wide averages are not what most users expect, it also changes
the default pricing option on all reports to "Nearest in Time", which is
what most confused users have selected after asking about it in the
mailing lists. This also fixes
Bug 340991 - Default price source for reports not good.
Reverse the direction of splits with negative amounts as they represent a
sale of the transaction commodity. Accumulate buys and sells of commodities
into separate comm-lists and use only the buy-side ones for the report-commodity
in the calculation.
Extract helper functions and add a parameter, eliminating gnc:make-exchange-cost-alist
and gnc:get-exchange-cost-totals.
This makes it more clear the differences between the two algorithms and
makes it easier to correct the algorithm for the cost case.
There are errors when closing the application to do with gnc_uri when
trying to create a filename from an empty book_id value to update the
page title. Added a test for empty book_id as well as it being null.
When the format is set to unset, the kvp data will now be removed and
added a function to retrieve the 'Fancy Date Format' and test for it
being valid, if not retrieve the preference date format.
There is a requirement to delete the "Fancy Date Format" book KVP data
when set to unset. This was not possible as is as it would delete all
the 'Business' options. This is still possible by passing a null list.
Update category-barchart.scm to use new pair for plot width and height
setting default to be both 100% of view. Also updated html-barchart.scm
and html-linechart.scm to use these new values.
