Disallow the use of tabs in all glade GtkTextView's. This is mainly
used for notes fields and showing log entries. Some views were not
editable but for consistency the setting was also added to them.
Previously the account color slot has been populated with "Not Set"
when any field for the account has been edited and saved. This routine
should run once and remove all such entries.
When importing the account tree CSV file, change the importing of
colours so that only valid colours for accounts are updated, invalid
colours will result in the account color key slot being removed.
If an existing account colour was specified and subsequently removed
the color key would be "Not Set". Change this to remove the key when
the colour is changed to default, i.e. removed.
While using the tab key to navigate the fields of the edit account
dialogue, it stops in the notes field as it accepts tabs so by
disallowing use keyboard navigation can proceed.
If there is more than one account source in the import it makes it
difficult to allocate the transactions so add a toggle button to show
or hide the source account column with the default being that of the
calling function.
The amount column was being sorted by string as opposed to amount value.
Added a DOUBLE value to the model store to hold a converted gnc_numeric
amount value and use that for sorting the tree view amount column. Also
made the amount column right justified so numbers align.
There are a very few left that need deeper study, but this gets
rid of most of the noise. For the most part it's just getting rid of
extra variables or removing an assignment that is always
replaced later but before any reads of the variable. A few are
discarded result variables.
It can't, because if b is 0 the function would have
returned already; since b.m_hi is 0 b.m_lo can't be. The assert
reassures clang that this is the case.
We need to compare the magnitudes of the remainder and the denominator
in order to round negative numbers correctly. Note that while gnc_numeric
is constrained to a positive denominator the C++ rounding functions cannot
assume that constraint in all cases.
Combined with the previous commit, this fixes
Bug 796949 - Incorrect conversion of 0,01 USD to EUR
So that the returned price tuple has the two commodities of interest
converted to a common currency. Before the first pair that that shared
any random currency would be returned, perhaps creating an absurd result.
When the csv preview page is first loaded the header combo will not
work till refreshed which can be done by selecting another separator.
By adding a g_idle_add to the preview_page_prepare to rebuild the table
the combos become active.
