Commit Graph

23481 Commits

Author SHA1 Message Date
Robert Fewell
d518500a30 Change source files gnc-account-sel.* for space and tabs 2020-11-22 10:38:57 +00:00
Robert Fewell
faaa580de7 GNCAccountSel with a New button
If the GNCAccountSel widget is set to be modal, using the 'New' button
returns the newly created account so use it for the selection.
2020-11-22 10:37:59 +00:00
Robert Fewell
026856122c Bug 355498 - When there is only one result from a 'Find', select it. 2020-11-22 10:36:55 +00:00
Robert Fewell
ae39df07eb Bug 720564 - Search in General Ledger
If you search from a General Ledger the search results will update the
General Ledger and the only way to get back the contents is to close
and reopen the General Ledger.

This change makes it the same as any other register in that the search
results are opened in a new search page.
2020-11-22 10:35:32 +00:00
Triyan W. Nugroho
562b4be220 Update Indonesian translation for GnuCash.
5430 translated messages, 114 fuzzy translations, 4 untranslated
messages.
2020-11-21 20:39:01 +01:00
John Ralls
4332c5841f Merge branch 'github-action' into maint; adds macOS unit tests. 2020-11-17 16:56:19 -08:00
John Ralls
4b7bc94e9d Implement Github-actions tests on macOS. 2020-11-17 16:55:42 -08:00
John Ralls
5de4fe5dff Merge Ralf Habacker's add-opening-balance-accounts into maint. 2020-11-16 09:27:29 -08:00
Ralf Habacker
63580d91ba Add feature GNC_FEATURE_EQUITY_TYPE_OPENING_BALANCE
When the above function is activated, the slot 'equity type' is used and
set in relation to opening balances and the checkbox for marking the
opening balance in the accounts dialog can be changed.
2020-11-16 08:51:51 +01:00
Ralf Habacker
2bdc7dd1c9 Update opening balance account on adding, editing and deleting accounts 2020-11-16 08:51:51 +01:00
Ralf Habacker
a2aca9da66 Do not create additional opening balance account on creating new gnucash file
Without this patch an additional opening balance account is created by the
assistant-hierarchy.
2020-11-16 08:51:51 +01:00
Ralf Habacker
f8dcd23023 Add support for the opening balance accounts flag
Up to now, opening balance accounts have been identified by means of
fixed names and their translations, which in some cases is not
appropriate.

With this commit, therefore, opening balance accounts can now be
identified by a special slot, which should solve the above problem.

in gnc_find_or_create_equity_account(), when querying the
EQUITY_OPENING_BALANCE type, the system now first searches for an
account with an existing 'equity-type' slot having the value
'opening-balance' and returns it as an opening balance account if
one exists. If no corresponding account is found, the search is
continued as before. An account found in the process is automatically
given the status of an opening balance account (it is given an
'equity-type' slot with value 'opening-balance') to simplify the
future search.

The opening balance status of an account is visualized in the account
settings dialog with a check box. If a Gnucash file does not yet contain
an opening balance account, one can be selected in the account settings
dialog.

https://bugs.gnucash.org/show_bug.cgi?id=797836
2020-11-16 08:51:51 +01:00
Ralf Habacker
573f7aaa0b Add slot "equity-type" with value "opening-balance" to account templates
The slots are added by running `util/add-opening-balances` on the
gnucash sources.
2020-11-16 08:51:51 +01:00
Ralf Habacker
1cce12f8be Add script to add slots with key 'equity-type' and value 'opening-balance' to detected opening balance accounts 2020-11-16 08:51:51 +01:00
Robert Fewell
fdbbc1305e Change source files gnucash-sheet/header.* for space and tabs 2020-11-15 14:44:42 +00:00
Robert Fewell
8ad9d0a22d Bug 644242 - Register Panning Problem
If the horizontal scrollbar is present for a register and you start to
tab from one cell to the next one that is not in view the sheet does
not scroll to keep the active cell in view.

This commit fixes that by getting the active cell horizontal offset and
width and comparing it to the sheet width and window width.
2020-11-15 14:44:42 +00:00
Robert Fewell
20f2efbe11 Bug 797901 - File History not updated
To reproduce this, with an existing list of four recently opened files,
open a fifth file whose name must differ from those already in the list
and you will observe that the file history list is not updated.

This was down to when doing the 'File->Open', a call is made to
gnc_close_gui_component_by_session which closes the existing pages and
as part of that the preference callbacks for the history plugin page
were being removed along with some others like for tab placement.

To fix this added the removal inside an if statement that checks to see
if the window is quitting or not.
2020-11-15 14:37:57 +00:00
Christopher Lam
ea78fa5516 Remove debugging statement 2020-11-15 18:37:17 +08:00
Christopher Lam
3e2be271fc Bug 798005 - Import of QIF file sets expenses to zero, deposits are fine
recongizes numbers with trailing negative sign.
2020-11-15 18:34:06 +08:00
Geert Janssens
e9a117b21b Bug 798008 - Option '--log' cannot be specified more than once
Wrapping the std::vector to hold the log flags is unneeded and actually harmful.
Just work on the vector directly. If user doesn't specify any '--log' options
the vector will just be empty.
2020-11-13 10:58:14 +01:00
John Ralls
79951e094f Merge branch 'github-action' into maint 2020-11-12 19:32:36 -08:00
John Ralls
0b670680d7 Implement CI tests on ArchLinux via docker container. 2020-11-12 19:32:10 -08:00
John Ralls
60f263e0d2 Merge branch 'github-action' into maint 2020-11-12 15:53:03 -08:00
John Ralls
d751913cb9 Fix typo in .gitattributes, text not test. 2020-11-12 15:52:33 -08:00
John Ralls
4e91a33be3 Use LTDL_LIBRARY_PATH instead of (DY)LD_LIBRARY_PATH
With GnuCash's main libraries now linked at startup instead of being
dlopened at runtime except by Guile we can restrict the library path
renaming to Gnu Libtool's environment variable.
2020-11-12 15:52:33 -08:00
John Ralls
31c9c5e080 Add Ubuntu-20 tests. 2020-11-12 13:54:26 -08:00
John Ralls
b22bf07bc4 Setup Github Actions with CI testing for Ubuntu 18.04 2020-11-12 11:57:19 -08:00
Robert Fewell
a519b913a6 Windows Build failure in dialog-dup-trans.c
Windows build failed on creating gchar *format with g_strdup_printf
parameter '%ld' expects argument of type 'long int', but argument 3 has
type 'size_t' {aka 'unsigned int'}
Fixed by replacing strlen with g_utf8_strlen.
2020-11-10 19:05:37 +00:00
Frank H. Ellenberger
49b3bdeb09 I18N: Ammend intro of autoclear window
Split text in titles and section
and use CSS instead of markup.
2020-11-10 12:24:09 +01:00
Cristian Klein
4718604f3b Document complexity in UI 2020-11-10 12:24:09 +01:00
Frank H. Ellenberger
1aba062109 Add a few more CSS classes for labels 2020-11-10 12:24:09 +01:00
John Ralls
08a0da8c4e Fix typo in .gitattributes, text not test. 2020-11-09 14:26:15 -08:00
John Ralls
194a021da4 Use LTDL_LIBRARY_PATH instead of (DY)LD_LIBRARY_PATH
With GnuCash's main libraries now linked at startup instead of being
dlopened at runtime except by Guile we can restrict the library path
renaming to Gnu Libtool's environment variable.
2020-11-09 13:50:51 -08:00
Christopher Lam
6a6396edca Revert "[auto-clear] provide live feedback when a valid end_amount is input"
This reverts commit afcf1765f6.

Not satisfactory. Introduces unacceptable delay after each
keystroke. Will try again when knapsack algorithm is improved to
generate toclear_list as GHashTable value.
2020-11-09 19:54:54 +08:00
John Ralls
e09a26ba3a Merge Christian Gruber's 'test_import_backend' into maint. 2020-11-08 14:27:26 -08:00
John Ralls
26fa239f89 Merge Christian Klein's 'auto-clear-tests' into maint. 2020-11-08 13:44:41 -08:00
Robert Fewell
bbc6887b0f Change source files dialog-dup-trans.* for space and tabs 2020-11-08 13:06:39 +00:00
Robert Fewell
4c2df4c2ad Bug 645379 - Problem with Number field when duplicating a transaction
When you duplicate a transaction, the dialog presented has a
GtkSpinbutton for the number field and non-numeric values are being
discarded. The register and transfer dialog have a GtkEntry for this
field so change this dialog to using them also.
2020-11-08 13:06:39 +00:00
Cristian Klein
69789b2b93 [auto-tests] Stick to CodingStandard for member variables 2020-11-08 09:58:57 +01:00
Cristian Klein
f26215feae [auto-tests] Fix misspelling 2020-11-08 09:58:17 +01:00
John Ralls
2290fa7c22 Fix exception when converting to decimal values that reduce to N/1.
Before this the loop wouldn't terminate until the denominator had been
reduced to 0 and trying to create a GncRational with a 0 denominator
throws.
2020-11-07 16:22:18 -08:00
John Ralls
d03dc07b8d Remove redundant and incorrectly named constant. 2020-11-07 13:20:22 -08:00
John Ralls
3bcf57e7f2 Fix timezone transition times.
This is responsible for test failures on DST transition days.

See the comments in gnc-timezone.cpp for an explanation of why this is
correct. The rubric was tested on macOS, Arch Linux, Debian Unstable,
Fedora 33, and Ubuntu 18.04 to confirm universal applicability.
2020-11-07 11:02:54 -08:00
Robert Fewell
b6c0a62bbd Add confirmation of Main Window close when more than one
If you have more than one Gnucash window open is is very easy to close
the wrong window with the 'x' and in doing so change your saved pages.
The way to save the configuration of all windows and pages is to use
'File->Quit'.
2020-11-06 13:52:38 +00:00
Robert Fewell
39ad1e9ebb Add two key combinations to the main notebook
Add ability to do key combination Ctrl+Alt+Menu to bring up the main
notebook menu so pages can be selected.
Also add Ctrl+Alt+a to jump to the Accounts page with the 'a' being
translatable.
2020-11-06 13:52:38 +00:00
Robert Fewell
c0e1341139 Intercept the Ctrl+Alt+PgUp/Down for a report page
With the focus on the webkit webview, this key sequence can be used to
scroll the view. For the key sequence to work for tab page switching a
callback is connected to the 'key-press-event' for the webkit view and
checked for the sequence and passed to the notebook if required.
2020-11-06 13:52:38 +00:00
Robert Fewell
5c48244e8d Fix report page focus
Currently the setting of keyboard focus is to the scroll window but
should be to the Webkit webview so correct this.
2020-11-06 13:52:38 +00:00
Robert Fewell
b51a70675f Bug 797944 - Crash when opening new file from existing one
If you have report pages that are left open when the current book is
'Saved' and then use the 'File->Open' to open a new book Gnucash may
crash. This was traced to the use of a g_idle_add to delay loading the
reports in the pages that was not being cleared when the first book was
closed.

To fix this the g_idle_add has been removed and the loading of the
report has been moved to the page focus function. By using a flag to
indicate when pages are being restored, the report loading is delayed
until the page is focused which has also decreased book loading time
especially if no report pages were the current page when the book was
closed.
2020-11-06 13:52:38 +00:00
Robert Fewell
bf9b267266 Change down arrow to align more with existing widgets
Instead of using the icon name 'go-down' use 'pan-down-symbolic'
2020-11-06 13:22:39 +00:00
Robert Fewell
4b5202f55d Bug 688917 - Edit style sheet help button not working
Setup the connection between the help button and the edit style sheet
section in the help.
2020-11-06 13:14:31 +00:00