Commit Graph

11594 Commits

Author SHA1 Message Date
Andreas Köhler
d9bba3325a Bug #506265: Hide the right-most register column by unsetting the sample text.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17530 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-16 00:57:08 +00:00
Andreas Köhler
9bec639663 Correct specified numbers of columns of AP/AR and STOCK/CURRENCY registers.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17529 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-16 00:57:00 +00:00
Andreas Köhler
8c50c35016 Hide the sx from txn dialog und show it only when the txn is valid.
There is no reason for popping up a window under a modal error dialog and close
it once the user acknowledged the error.

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17528 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-15 18:24:48 +00:00
Andreas Köhler
d7cad46659 Negate amount in exchange rate dialog when swapping accounts.
This is the case when entering an amount for a split with an account whose base
commodity equals the register's one, but differs from the transaction currency.
Then, debit and credit accounts in the transfer dialog are swapped, so the
amount should be negated as well.

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17527 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-15 17:36:59 +00:00
Andreas Köhler
afdb73a911 In check_one_price_date(), replace an strcmp() by safe_strcmp().
When there is no source string set on a price, do not crash on it.
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17526 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-15 13:13:57 +00:00
Andreas Köhler
dff8d7b22d Correctly set price sources in price editor dialog by reading it from the gui.
On trunk, the price tied to a price editor dialog is not initialized with a
source string anymore, so correctly read it from the gui before
committing the price.

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17525 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-15 13:13:48 +00:00
Andreas Köhler
d8c11a7c02 Bug #549595, #552306: Correct retval of gnc_int_link_or_make_backup(), add ENOSYS and ENOTSUP.
The return value of link(2) on files residing on sshfs will be ENOSYS, on
network hfsplus file systems on mac ENOTSUP, so add them to the list of those
errnos that trigger copy_file as fallback in gnc_int_link_or_make_backup() or
are allowed in gnc_file_be_get_file_lock() showing that hardlinks are not
supported.

To avoid silent data loss in the case of an unexpected errno in
gnc_int_link_or_make_backup(), correctly set the backend error.

Patches from Micha Lenk and Boris Zbarsky.
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17524 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-15 13:13:40 +00:00
Charles Day
e803ad8245 Bug #141003: Revise r17489 to escape the British Pound symbol in Scheme with "\xa3" (for strings) or #\243 (for characters).
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17509 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-14 20:03:48 +00:00
Charles Day
8e9551af98 Bug #551038: Don't destroy the options database before destroying the options dialog that depends on it.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17508 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-14 17:48:58 +00:00
Charles Day
6f4cecf48e Bug #340041, #436342: Make the register keep track of whether the exchange rate has been reset. This prevents a zero exchange rate from being ambiguous: previously the register could not tell the difference between "the user has not specified an exchange rate" and "the user has specified a rate of zero".
Much of this patch consists of new ENTER(), DEBUG() and LEAVE() calls for debugging. Nearly all of the rest is refactoring. The code that detected and acted on changes to the account cell has been placed into its own function, gnc_split_register_check_account(). The several calls needed to checking a cell for changes have been combined in gnc_split_register_check_cell().

About 15 lines represent actual changes in functionality. Specifically, the code does a better job of recognizing when an exchange rate needs to be requested from the user, and when it does not. When an account cell is changed in the register, and the new account is denominated in the same commodity as the original, the original exchange rate is used. On the other hand, if the commodity differs, the rate is reset to zero. The register remembers that the zero exchange rate is due to the reset (i.e. was not user-entered) so that the the exchange rate dialog can be presented. Finally, the cell contents are checked before doing a save; previously the checks were missed in certain cases, e.g. if the user pressed "Enter" or clicked the close button.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17507 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-14 16:52:34 +00:00
Charles Day
a22d84c1a2 Register: Log some debugging information just before crashing because of g_assert_not_reached(). This should hopefully provide some new information to help track down the underlying cause of bug #414407, #420409, #468106, and #551643.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17506 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-14 16:05:53 +00:00
Phil Longstaff
633c1a75d1 If current lots version has account_guid constraint that it can't be null,
remove it and bump table version number.



git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17505 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-13 18:49:57 +00:00
Andreas Köhler
a80da3764d Win32: Always try to install Date-Manip and as fallback DateManip.
It seems that the PPM repositories for ActivePerl v5.6 and v5.8 have been
changed so that DateManip cannot be found anymore.  Keep it for second try
nonetheless.

BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17504 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-13 14:45:41 +00:00
Phil Longstaff
6b62aa321e Remove constraint that lot.account_guid must not be null. Unfortunately,
sqlite doesn't support ALTER TABLE which modifies column constraints, so
existing databases can't be modified programmatically.



git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17503 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-13 02:05:09 +00:00
Andreas Köhler
693f93c0f4 Treat AB_Job_StatusPending as a good status, do not ask the user to repeat.
According to Martin Preuss a lot of banks set the status of a
transaction job to pending, signifying that they accepted the job but
have not yet executed it.  This also means that we cannot detect whether
the account is actually overdrafted.

Instead, ignore the return value of AB_Banking_ExecuteJobs() (it will
almost always be 0) and only check the job's status against
AB_Job_StatusFinished and AB_Job_StatusPending.  If the status is
different, ask the user whether he wants to repeat, as usual.

BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17502 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-11 06:58:23 +00:00
Derek Atkins
7ac1d9f1e1 export the various QOF_PARAM_* settings to guile
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17500 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-10 17:52:16 +00:00
Andreas Köhler
18676dd579 Bug #506873, Win32: Add support for Finance-Quote with ActivePerl 5.10.
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17499 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-10 16:16:50 +00:00
Derek Atkins
1d32da84d5 Use G_GINT64_FORMAT instead of %lld for x86_64
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17498 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-06 18:13:32 +00:00
Derek Atkins
38d8ce62aa Add SQL glade file so "make check" succeeds
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17497 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-06 18:12:45 +00:00
Andreas Köhler
10f0a34355 Bug #539962: Remove return value from some void functions.
Patch from Halton Huo.
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17496 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-06 17:22:36 +00:00
Andreas Köhler
64720faaa1 Bug #548601: Do not import unawaited zero balances from aqbanking.
Check whether an unawaited balance is zero and simply ignore it in this case.
Unawaited here means that the user asked the application to fetch transactions,
issue a transaction or anything else not resembling the fetching of account
balances.

Patch from Micha Lenk.
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17495 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-06 17:21:00 +00:00
Andreas Köhler
641625844e Bug #540148: Allow building against libgoffice-0.8, i.e. goffice >= v0.7.0.
Patch from Halton Huo.

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17494 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-06 17:20:52 +00:00
Charles Day
737473bce4 Bug #378734, #520570, #545316, #549115: Fix GNCDateEdit widget popup calendar problems.
-Fix popup button behavior (sometimes non-responsive)
-Make calendar clickable in modal dialogs
-Update design to be more like GtkComboBox, less like GtkCombo
-Adjust a few signal names, e.g. "focus-out-event" vs. "focus_out_event"
-Lose the GtkFrame shadowing; perhaps the GtkFrame is no longer needed 
-Add comments
-Add a few ENTER() and LEAVE() calls for debugging
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17493 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-05 05:08:33 +00:00
Andreas Köhler
ad9d3c7747 Bug #546064: Make gnucash.desktop survive a desktop entry specification 1.0 verification.
Patch from Saïvann Carignan.
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17492 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-03 20:43:17 +00:00
Charles Day
da0415bfb5 Bug #141002: QIF Import: Allow minus signs at the end of numeric values, e.g. "$10.00-".
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17490 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-03 00:11:32 +00:00
Charles Day
b55b08e4cf Bug #141003: QIF Import: Allow the British Pound symbol and the dollar symbol to be used interchangeably.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17489 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-02 20:20:09 +00:00
Christian Stimming
a1d189431e Add ignore pattern to POTFILES.in creation to ignore swig generated files.
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17488 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-02 07:13:13 +00:00
Andreas Köhler
0f1b50c2d4 Fix the i18n of the first and last string in the list of tips of the day.
Add a call to g_strstrip() on the tips to remove unwanted whitespace.
The first and last item should appear translated now.

BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17485 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-09-01 20:44:51 +00:00
Charles Day
c2eb587552 Bug 549738: Make "today" the default date of the aging reports.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17483 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-31 23:30:56 +00:00
Andreas Köhler
a2f05a3eae Bug #526313: Add currency Venezuelan Bolivar Fuerte (VEF).
It will replace the Venezuelan Bolivar (VEB) in 2008.
Patch from Frank H. Ellenberger.
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17482 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-31 04:20:22 +00:00
Charles Day
a1dd4517b9 Win32 build: Fix a typo to get trunk working on win32/mingw again.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17479 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-26 17:09:03 +00:00
Charles Day
fd987c0b3d Bug #548891: QIF Import: Prevent crashing when the mapping preferences can't be saved.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17477 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-21 17:47:10 +00:00
Charles Day
a8820e769b AUTHORS: Add Frank Ellenberger and update my own details.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17476 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-21 00:13:36 +00:00
Phil Longstaff
7c36cf65f6 Add begin-edit/commit-edit calls around lot manipulation when posting
an invoice.  This keeps the sql backend from trying to save a lot with
a null account.



git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17475 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-20 12:31:00 +00:00
Phil Longstaff
290b0c6f12 Additional win32 packaging changes for installation (including libdbi).
Provided by Nathan Buchanan



git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17474 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-20 12:09:10 +00:00
Phil Longstaff
0bf3700fa2 Add support to build trunk with libdbi and dbi backend on win32/mingw
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17473 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-17 16:38:31 +00:00
Charles Day
390fbb00e7 Bug #543061: Fix the smallest fraction of IDR currency to match ISO 4217.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17472 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-15 17:04:36 +00:00
Charles Day
9a69bfd8c2 Bug #454340: Prevent duplicate rows after editing a security. These changes are similar to what was done for the price tree model in r17441 and r17470.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17471 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-14 16:41:33 +00:00
Charles Day
6209ea2f0f Update a few comments to fix typos and inaccuracies, or to add further clarification.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17470 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-14 15:52:34 +00:00
Charles Day
8ed5e2853a Usability: Security Editor: Previously, nothing happened when a namespace row was activated. Now these rows will expand or collapse. It is often easier to double-click the row than hunt for the expander.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17469 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-13 17:47:08 +00:00
Charles Day
9a653982fe Usability: Sort commodity trees on the commodity name by default. This allows for a consistent default sort even if commodities are quickly removed from and re-added to the model. This can happen, for example, when a commodity is edited in the Security Editor.
BP 


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17468 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-13 17:44:11 +00:00
Charles Day
fca4b45dcc Prices: Emit a qof event when a price is changed. This allows the Price Editor to immediately update its display. Previously, price changes would only get shown when the mouse happened to pass over the affected row. Theoretically other parts of GnuCash, such as reports, could now be made to watch for price changes and automatically refresh themselves.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17467 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-12 20:12:37 +00:00
Christian Stimming
9812f77182 Bug #529816: Clarify i18n strings and comments concerning CUSIP and ISIN.
Patch by Frank H. Ellenberger.
BP

git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17464 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-12 19:14:52 +00:00
Charles Day
b3c41e46ce Transfer dialog: Don't round quotes pulled from the price db.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17463 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-12 18:05:37 +00:00
Charles Day
d89d96ce88 Bug #547335: Get the exchange rate dialog "to" amount working again when launched via the register instead of the menu.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17462 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-11 21:55:50 +00:00
Charles Day
c20038064f Bug #545722: Get the GNCDateEdit control working on Win32 again. Don't assume that the content returned by localtime() will not be changed out from under you.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17459 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-08 23:38:45 +00:00
Charles Day
10df25faca Bug #522095: Refresh the summary bar when new prices are downloaded.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17458 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-08 21:36:48 +00:00
Charles Day
5dd0c682ed Don't round values that will be displayed as expressions. Save some space in fractional displays by, for example, showing "1 + 1/8" instead of "1 + 1 / 8". Simplify fractional display of values less than 1 by, for example, showing "1/3" instead of "0 + 1 / 3".
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17457 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-07 19:40:15 +00:00
Charles Day
eb29fc8e6d Make gnc_numeric values of zero always convertible to decimal form.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17456 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-07 18:18:00 +00:00
Charles Day
96863860d0 Bug #541970: When finding a "nearest in time" price, break ties by preferring the older price. This has the benefit of using a price that actually existed at the given time, and better addresses the case in which both price times have been defaulted to midnight. Previously, the newer price was preferred.
BP


git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@17454 57a11ea4-9604-0410-9ed3-97b8803252fd
2008-08-04 16:41:15 +00:00