the list rather than making a copy of each commodity. When a copy is made, this
copy is stored in the db, but is never deleted. This causes problems (loss of
reference from account/tx to commodity) when the file is reloaded.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18407 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Mike Alexander (plus documentation comment by me):
Neither gnc:make-complex-boolean-option nor gnc:make-simple-boolean-option
(which calls it) correctly stores its result in the KVP that it is using.
This is because it calls kvp-frame-get-slot-path-gslist and
kvp-frame-set-slot-path-gslist to get and set the value. Both of these are
implemented in C and the code in kvp-scm.c can't convert a Scheme boolean value
to or from a KvpValue since there is no boolean type in KvpValue. There are
already a few places that have comments suggesting that there should be a
KVP_TYPE_BOOLEAN type, but adding this would be non-trivial. For now I'll
supply a patch that will store the boolean value as a string (which is what
code in xaccAccountSetAutoInterestXfer in Account.c does).
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18404 57a11ea4-9604-0410-9ed3-97b8803252fd
Usually an imported DTAUS file describes debit notes, which means "our
account" is credited (and the other debited). But DTAUS can also contain
transfers, which means "our account" is debited. In the DTAUS case, the
value would still be positive, so we have to query the transaction type
for this case as well. This is now fixed. (Needs aqbanking-4.1.10 though
because the earlier versions forgot to set the TypeTransfer.)
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18402 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Matt Lavin <matt.lavin@gmail.com> (with const added by myself).
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18401 57a11ea4-9604-0410-9ed3-97b8803252fd
This change will crash the Windows version at startup, unfortunately
with unknown reason.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18400 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Mike Alexander.
This is the fixed version of r18352 which was reverted in r18360.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18396 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch contributed by Luke Duncan:
I would like to have an option for the budget report that allows it to omit
accounts that have zero balance and no budget value specified over the entire
budget term. This avoids showing entire rows of blank cells without the user
having to manually select which accounts have a budget value or balance for the
term of the budget. The user can select all expense and income accounts and it
only shows the accounts that have actual (nonzero) data to display.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18394 57a11ea4-9604-0410-9ed3-97b8803252fd
The Dutch translator wrote:
Would it be possible to differentiate between the instance of the _verb_
"Deposit" in src/register/ledger-core/split-register.c:2184 (the verb) and
the occurrances of the _noun_ "Deposit" in src/app-utils/prefs.scm (via
intl-scm/guile-strings.c:6732) and
src/import-export/csv/gnc-csv-model.c:37? This would help me
tremendously with my efforts.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18391 57a11ea4-9604-0410-9ed3-97b8803252fd
number to ensure it is higher than some minimum value.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18385 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Colin Law:
Patch that provides a new option in the Register preferences to
specify whether, when tab is hit after entering the description for a
memorised transaction in Basic Ledger view, that the cursor skips to
the value field (as at present) or just tabs to the Transfer field.
The option defaults to include the Transfer field so gnucash operation
is unaffected unless user modifies the option.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18377 57a11ea4-9604-0410-9ed3-97b8803252fd
In r17725 and r17751, I introduced the extra XML child element
<recurrence:weekend_adj>, but this means a gnucash-2.2.x cannot read
the SX recurrence of a >=2.3.x file anymore, which is bad. In order
to improve this broken backward compatibility for at least the common
case, we don't write out this XML element as long as it is only "none".
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18376 57a11ea4-9604-0410-9ed3-97b8803252fd
packaged webkit is retrieved from sourceforge.net, not gnucash.org.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18370 57a11ea4-9604-0410-9ed3-97b8803252fd
The current build doesn't even start. We revert this change so that
we go back to the previous behaviour where we at least started the
main window.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18369 57a11ea4-9604-0410-9ed3-97b8803252fd
The newest build doesn't even start the gnucash main window (only the
splash screen). Hence, we revert the changed slib version because this might
affect that behaviour.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18368 57a11ea4-9604-0410-9ed3-97b8803252fd
This can be enabled again as soon as we pgsql binaries available
which do not depend on MSVCR71.DLL anymore.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18366 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Tim M: The attached patch is an improvement to the original patch
which supplies the correct number of columns to gnucash for the
general_ledger register view if the register is a template.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18365 57a11ea4-9604-0410-9ed3-97b8803252fd
(Note: The newer slib version doesn't yet fix the issue which caused r18360)
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18363 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Colin Law: Attached is a patch to fix compiler warnings in
split-register-model.c. In fact for me they prevent compilation,
possibly because I have specified --enable-compile-warnings. I have
inspected the code and it appears that the warnings are unfounded, the
code appears to be safe, though I can see why the warnings were
generated.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18361 57a11ea4-9604-0410-9ed3-97b8803252fd
The bugfix was using the guile function "@" which apparently isn't available
on quite a number of platforms, including the Windows guile-1.6.8 which
we're shipping in our windows binary. So we need to fix the original bug
in a different way without the "@" function.
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18360 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Tim M:
The attached patch is an enhancement to the original reg_run_balance patch
that was implemented. This patch has been created off of a recent trunk (in
the last week). It makes the following changes:
1. Add a gboolean to the argument list of the gnc_split_register_get_rbaln()
function. If the new boolean value is set to TRUE, then the function will
return the running balance for the parent account and all subaccounts. If
set to FALSE, the function will only return the running balance of the
parent account and will not include the subaccounts. The function has been
modified also to accomodate this change.
2. Update existing calls to the function to add the boolean value.
This patch does not actually implement a runtime balance for single account
register view or normal balance column because of potential issues that will
need to be addressed, but it opens up the possibility for easy
implementation of such a change.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18355 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Tim M:
I noticed yesterday a bug in the reg run balance patch that was applied,
there is now a "Balance" column displayed in the template transaction
register. If you open the scheduled transaction editor, then open a
scheduled transaction and go to the "Template Transaction" tab, there is a
"Balance" column displayed on the far right side of the register.
The attached patch fixes this defect so that the RBALN column is not
displayed in template registers.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18354 57a11ea4-9604-0410-9ed3-97b8803252fd
Patch by Mike Alexander: I tracked it down to the set of changes made in
r18253 to automatically load all the reports in the standard-reports directory.
This changed standard-reports.scm to use resolve-module instead of use-modules
to load reports. One difference between these two is that resolve-module
doesn't make the interface for the loaded module available to the module
containing the call to resolve-module. This causes a crash when
gnc:register-report-create in standard-reports.scm tries to call
gnc:register-report-create-internal which is located in register.scm (one of
the modules loaded using resolve-module). I fixed it by explicitly defining
that interface using the "@" guile function after the modules are loaded. You
could also probably just add back a call to use-module for that module, but
this seems to work and makes it explicit what interface is needed.
Signed-off-by: Christian Stimming <stimming@tuhh.de>
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18352 57a11ea4-9604-0410-9ed3-97b8803252fd
When opening an invoice search dialog from a specific company, list is populated by all invoices.
Patch by Geert Janssens
git-svn-id: svn+ssh://svn.gnucash.org/repo/gnucash/trunk@18349 57a11ea4-9604-0410-9ed3-97b8803252fd
