vim-patch:9.1.0399: block_editing errors out when using del (#28867)

Problem:  block_editing errors out when using del
          (@Jamarley)
Solution: Change ins_len from size_t to int and
          properly check that it doesn't become negative

There is a check in os.c that verifies that `ins_len` does not become
negative:
```
if (pre_textlen >= 0 && (ins_len = len - pre_textlen - offset) > 0)
```
However this only works, if ins_len can actually become negative and
unfortunately, ins_len has been declared as `size_t` so instead of
becoming negative it will wrap around and be very large.

So let's define it as integer, after which the condition above
properly catches this condition.

fixes: vim/vim#14734
closes: vim/vim#14735

d5c8c0920e

Co-authored-by: Christian Brabandt <cb@256bit.org>
This commit is contained in:
zeertzjq 2024-05-20 21:45:02 +08:00 committed by GitHub
parent 36a9da6547
commit 91892f56b6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -2105,4 +2105,12 @@ func Test_getregion_maxcol()
bwipe!
endfunc
func Test_visual_block_cursor_delete()
new
call setline(1, 'ab')
exe ":norm! $\<c-v>hI\<Del>\<ESC>"
call assert_equal(['b'], getline(1, 1))
bwipe!
endfunc
" vim: shiftwidth=2 sts=2 expandtab