chore: make clippy warnings fail CI, fix them (#1038)

* chore: make clippy warnings fail CI, fix them

* chore: pin docker cache action

.github/workflows/build-packages.yaml

@@ -23,7 +23,7 @@ jobs:
         uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
 
       - name: Docker Cache
-        uses: AndreKurait/docker-cache@0.6.0
+        uses: AndreKurait/docker-cache@eb0683e3972ed3066587b7199d3a0e9bd114bd3c #0.6.0
         with:
           key: docker-${{ matrix.target-os }}-${{ hashFiles('pkg/images/') }}
 

.github/workflows/rust.yml

@@ -43,7 +43,7 @@ jobs:
       - name: Install clippy
         run: rustup component add clippy
       - name: Run clippy
-        run: cargo clippy --all --all-features --verbose
+        run: cargo clippy --all --all-features -- --deny clippy::all
 
   check-audit:
     runs-on: ubuntu-24.04

lact-daemon/src/server/gpu_controller/amd.rs

@@ -1032,7 +1032,7 @@ impl GpuController for AmdGpuController {
                         .handle
                         .get_memory_clock_levels()
                         .inspect_err(|err| {
-                            debug!("could not get active memory power state: {err:#}")
+                            debug!("could not get active memory power state: {err:#}");
                         })
                         .ok()
                         .and_then(|levels| levels.active),

lact-gui/src/app.rs

@@ -530,10 +530,10 @@ impl AsyncComponent for AppModel {
             sender.input(AppMsg::Error(Arc::new(err)));
         }
 
-        if let Some(gpu_id) = initial_gpu_id {
-            if let Err(err) = model.update_gpu_data_full(gpu_id, sender.clone()).await {
-                sender.input(AppMsg::Error(Arc::new(err)));
-            }
+        if let Some(gpu_id) = initial_gpu_id
+            && let Err(err) = model.update_gpu_data_full(gpu_id, sender.clone()).await
+        {
+            sender.input(AppMsg::Error(Arc::new(err)));
         }
 
         let widgets = view_output!();