Merge pull request #320 from vettagroup/vettacontrib

Fix replaceRootNote and circuit stats priorQuery
This commit is contained in:
Robert Chacón
2023-03-30 18:21:26 -06:00
committed by GitHub
7 changed files with 7 additions and 7 deletions

View File

@@ -134,7 +134,7 @@ class NetworkGraph:
node.parentId = self.exceptionCPEs[node.displayName]
self.nodes.append(node)
def replaceRootNote(self, node: NetworkNode) -> None:
def replaceRootNode(self, node: NetworkNode) -> None:
# Replaces the automatically generated root node
# with a new node. Useful when you have a top-level
# node specified (e.g. "uispSite" in the UISP

View File

@@ -145,7 +145,7 @@ def buildFullGraph():
# If this is the uispSite node, it becomes the root. Otherwise, add it to the
# node soup.
if name == uispSite:
net.replaceRootNote(node)
net.replaceRootNode(node)
else:
net.addRawNode(node)

View File

@@ -53,7 +53,7 @@ class TestGraph(unittest.TestCase):
from integrationCommon import NetworkGraph, NetworkNode, NodeType
graph = NetworkGraph()
node = NetworkNode("Test", type = NodeType.site)
graph.replaceRootNote(node)
graph.replaceRootNode(node)
self.assertEqual(graph.nodes[0].id, "Test")
def add_child_by_named_parent(self):

View File

@@ -331,7 +331,7 @@ def getCircuitLatencyStats(subscriberCircuits):
# If we can't identify RTT this time around, use most recently recorded RTT
# None by default, change if found in priorQuery
circuit['stats']['sinceLastQuery']['tcpLatency'] = None
if circuit['stats']['priorQuery'] != None:
if 'priorQuery' in circuit['stats'] and circuit['stats']['priorQuery'] != None:
if 'priorQuery' in circuit['stats']:
if 'tcpLatency' in circuit['stats']['priorQuery']:
circuit['stats']['sinceLastQuery']['tcpLatency'] = circuit['stats']['priorQuery']['tcpLatency']

View File

@@ -135,7 +135,7 @@ class NetworkGraph:
node.parentId = self.exceptionCPEs[node.displayName]
self.nodes.append(node)
def replaceRootNote(self, node: NetworkNode) -> None:
def replaceRootNode(self, node: NetworkNode) -> None:
# Replaces the automatically generated root node
# with a new node. Useful when you have a top-level
# node specified (e.g. "uispSite" in the UISP

View File

@@ -176,7 +176,7 @@ def buildFullGraph():
# If this is the uispSite node, it becomes the root. Otherwise, add it to the
# node soup.
if name == uispSite:
net.replaceRootNote(node)
net.replaceRootNode(node)
else:
net.addRawNode(node)

View File

@@ -53,7 +53,7 @@ class TestGraph(unittest.TestCase):
from integrationCommon import NetworkGraph, NetworkNode, NodeType
graph = NetworkGraph()
node = NetworkNode("Test", type = NodeType.site)
graph.replaceRootNote(node)
graph.replaceRootNode(node)
self.assertEqual(graph.nodes[0].id, "Test")
def add_child_by_named_parent(self):