Commit Graph

1018 Commits

Author SHA1 Message Date
Dave Taht
4e68ecc205 Some notes regarding good error handling
Bug #209, among others.
2023-01-29 19:45:36 -08:00
Dave Taht
7c18da1953 A few other thoughts 2023-01-29 19:31:47 -08:00
Dave Taht
4b097defa9 More comments wanted on and in lqos.conf.new.discuss 2023-01-29 19:12:47 -08:00
Dave Taht
6c7548c77e More fixes for how the conf file should work.
It was hilarious that I already missed the new "bridge"
section in my first attempt. Imagine what it is like for the
users?

Pithy notes:

I think this is an artifact of history, as a bool.

disable_rxvlan = true
disable_txvlan = true

There are a zillion other options in ethtool -h for
coalesing things, besides this.

disable_offload = [ "gso", "tso", "lro", "sg", "gro" ]
2023-01-29 18:22:42 -08:00
Dave Taht
6c81a2a8c1 Trying to unify configuration variables somewhat
We have a lot of configuration stuff, written in several very
different styles. We have hidden knowledge (like port numbers)
buried elsewhere. We have overly wordy variables names, and not
clear separation of each concept. We have a need to keep some
data secure (passwords to the apis), and others, need to be common.

Ideally there would be more of a secrets file for secrets to
point to, on the security case.

Having one file to rule them all is not exactly the right way
forward, but parsing one file *format* might prove simpler.

Please, everyone, think about how to best to express oneself,
I took a stab at it via this commit.
2023-01-29 09:52:58 -08:00
Robert Chacón
8d59d0594d Solved https://github.com/LibreQoE/LibreQoS/issues/206 2023-01-29 07:44:58 -07:00
Dave Taht
ea40e6293c Put arrows in the summary spans
Still would like a format like

LIBREQOS MONITOR UP OTHER STATUS INFO and the summary down/up stats to
line up with the table below it.
2023-01-29 07:10:11 +00:00
Dave Taht
e175f15845 lqos_utils: Scale bits/s relative to gbit/s etc
Essentially right justify these functions.
2023-01-28 18:33:53 -08:00
Herbert Wolverson
0e97e6a868 Attempting to resolve issues with lqos_node_manager not seeing
statistics, while lqtop still works.

1) Add warning and error logging to lqos_node_manager if any
   part of the statistics gathering process fails.
2) (Hopefully temporarily) use the non-persistent bus client,
   again logging any issues.
3) Improve the statistics gathering timer code.
2023-01-27 19:47:19 +00:00
Herbert Wolverson
fcad4fa90a Remove warnings from lqtop 2023-01-26 20:50:12 +00:00
Herbert Wolverson
6e92a07a00 Fix panic in LibreQoS.py on update if an IP address mapping needed
deleting.

* Adjust the Python integration `delete_ip_mapping` function to
  not require a secondary "upload" parameter - because the
  Python code is unaware of whether there needs to be a
  separation of the two at this point.
* Change ENOEXIST return code in BPF map delete to NOT be an
  error - it indicates that there was nothing to do, rather
  than something not working.
2023-01-25 22:59:06 +00:00
Herbert Wolverson
a88dd8fe5e #183 - Hide memory status panel on sizes smaller than 'large' 2023-01-25 17:34:48 +00:00
Herbert Wolverson
74116e97e8 Fix crash when queuingStructure.json contains [children] entries.
Affects ISSUE #206

* Add a blank node for [children] in the QueueNode parser.
* Add two unit tests to cover loading content with and without
  [children] entries.
2023-01-25 17:03:21 +00:00
Robert Chacón
9e0725c02c Merge pull request #227 from LibreQoE/attemptFix3235
Fix for #214
2023-01-25 08:32:05 -07:00
Robert Chacón
92047e9f0a Omit refreshLatencyGraphs() until reintroduced later 2023-01-25 05:10:40 -07:00
Robert Chacón
aacf6b058e Update LibreQoS.py 2023-01-25 05:01:18 -07:00
Robert Chacón
e2bd517881 Fix bug: import logging module 2023-01-24 20:24:09 -07:00
Robert Chacón
d25dfd1b87 Resurrect lqTools.py. Not yet compatible with OnAStick mode. https://github.com/LibreQoE/LibreQoS/issues/52 2023-01-24 20:19:14 -07:00
Herbert Wolverson
ecdf4e3baf Python linter caught an error - should be fixed (oddly, it ran). 2023-01-24 18:35:06 +00:00
Herbert Wolverson
4632839177 Merge branch 'main' of https://github.com/LibreQoE/LibreQoS 2023-01-24 18:32:40 +00:00
Herbert Wolverson
8fc4aed48b * Adds a bus call to ask Rust to validate the CSV file. If it can't read it,
it returns readable error messages explaining where it encountered a problem.
* Adds the bus call to the Python-Rust bridge.
* Adjusts LibreQoS.py to call the new bridge code and alert if Rust can't
  read the ShapedDevices.csv file.
2023-01-24 18:30:52 +00:00
Dave Täht
b504237c56 Merge pull request #220 from interduo/patch-17
improvement: put warning in README and add some MD formatting tags
2023-01-24 09:59:03 -08:00
Dave Täht
f96bad8c54 Merge pull request #223 from interduo/patch-20
add rust/remove_pinned_maps.sh command to readme
2023-01-24 08:07:26 -08:00
Robert Chacón
66549e4245 Reduce console verbosity https://github.com/LibreQoE/LibreQoS/issues/225 2023-01-24 09:04:01 -07:00
Dave Täht
cd6dccce10 Merge pull request #219 from interduo/patch-16
improvement: bump version in comment
2023-01-24 08:02:53 -08:00
Robert Chacón
1c2086e7a8 Attempt fix for https://github.com/LibreQoE/LibreQoS/issues/214 2023-01-24 08:50:17 -07:00
Robert Chacón
c875f4dd3f Update requirements.txt 2023-01-24 08:26:06 -07:00
Robert Chacón
3793a2a024 Update lint_python.yml 2023-01-24 08:22:39 -07:00
Interduo
37c6161ca3 add rust/remove_pinned_maps.sh command to readme 2023-01-24 15:43:53 +01:00
Herbert "TheBracket
2a240c5090 Merge pull request #222 from interduo/patch-19
bugfix: set proper path
2023-01-24 06:36:38 -08:00
Herbert "TheBracket
d1bc1a6399 Merge pull request #221 from interduo/patch-18
bugfix: proper path
2023-01-24 06:36:14 -08:00
Interduo
f6927c3c27 bugfix: set propper path 2023-01-24 15:31:00 +01:00
Interduo
64d47268ac bugfix: propper path 2023-01-24 15:27:49 +01:00
Interduo
b93b944cb0 improvement: put warning in README and add some MD formatting tags 2023-01-24 14:46:57 +01:00
Interduo
55fbf8a444 improvement: bump version in comment 2023-01-24 12:58:21 +01:00
Robert Chacón
d72e27b171 Merge pull request #215 from interduo/patch-12
bugfix: slowly ubuntu starting when one of network interface is not up
2023-01-23 15:13:50 -07:00
Herbert Wolverson
c9810f93b6 Merge branch 'main' of https://github.com/LibreQoE/LibreQoS 2023-01-23 22:01:05 +00:00
Herbert Wolverson
11428f65e7 Fix "lqosd is running" error when it clearly isn't.
* Fix the Python code to actually call `is_lqosd_alive()` instead of just
checking that it exists (`is_lqosd_alive`).
* Fix the os.exit command syntax.
* Cleanup the blocking Tokio/lqosd request handler to pass better messages.
* Catch the "file not found" and replace it with a nicer message.
2023-01-23 21:59:02 +00:00
Dave Täht
6d475564b8 Merge pull request #218 from interduo/patch-15
bugfix: unit files needs to be enabled
2023-01-23 09:54:04 -08:00
Dave Täht
8dc19a8f9c Merge pull request #216 from interduo/patch-13
improvement: add alpha version setup guide
2023-01-23 07:42:32 -08:00
Interduo
49b3e046e9 bugfix: unit files needs to be enabled 2023-01-23 16:31:06 +01:00
Interduo
42f62c1078 improvement: add alpha version setup guide 2023-01-23 15:26:50 +01:00
Interduo
6da4820f1a Update TESTING-1.4.md 2023-01-23 15:11:41 +01:00
Interduo
9653e40943 Update TESTING-1.4.md 2023-01-23 15:09:19 +01:00
Dave Täht
c329304fea Merge pull request #210 from interduo/patch-10
improvement: add autostart systemd unit files
2023-01-23 05:33:27 -08:00
Dave Täht
07fce55540 Merge pull request #213 from interduo/patch-11
bugfix: change sqm mode to ack-filter was impossible
2023-01-23 05:31:57 -08:00
Dave Täht
6783b9beac Merge pull request #211 from interduo/patch-8
bugfix: propper path
2023-01-23 05:28:45 -08:00
Dave Täht
328af81553 Merge pull request #212 from interduo/patch-9
bugfix: propper path in lqosd documentation
2023-01-23 05:28:14 -08:00
Interduo
f5b3163c81 Update config.html 2023-01-23 14:13:38 +01:00
Interduo
e19a6f8c23 improvement: add autostart systemd unit files 2023-01-23 14:02:57 +01:00