IntenseWebs/WordPress
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use px instead of in in device preview

Browse Source 
Devices are not consistent in how they handle `in` units. `in` was an attempt to cleverly disguise the exact size of the 'tablet'. The PHP code standards mentions avoiding clever code ( https://make.wordpress.org/core/handbook/best-practices/coding-standards/php/#clever-code ) but we should extend that idea to the css code as well.

Props celloexpressions
Fixes #36457


Built from https://develop.svn.wordpress.org/trunk@37247


git-svn-id: http://core.svn.wordpress.org/trunk@37213 1a063a9b-81f0-0310-95a4-ce76da25c4cd
This commit is contained in:
Aaron Jorbin
2016-04-19 20:50:29 +00:00
parent 0be2153bfb
commit ee0ef3ca36
5 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
wp-admin/css/themes-rtl.css
View File

@@ -1592,9 +1592,9 @@ body.full-overlay-active {
}
.preview-tablet .wp-full-overlay-main {
margin: auto -3in auto 0;
width: 6in; /* Size is loosely based on a typical "tablet" device size. Intentionally ambiguous - this does not represent any particular device precisely. */
height: 9in;
margin: auto -360px auto 0;
width: 720px; /* Size is loosely based on a typical "tablet" device size. Intentionally ambiguous - this does not represent any particular device precisely. */
height: 1080px;
max-height: 100%;
max-width: 100%;
right: 50%;

2
wp-admin/css/themes-rtl.min.css vendored
View File

File diff suppressed because one or more lines are too long

6
wp-admin/css/themes.css
View File

@@ -1592,9 +1592,9 @@ body.full-overlay-active {
}
.preview-tablet .wp-full-overlay-main {
margin: auto 0 auto -3in;
width: 6in; /* Size is loosely based on a typical "tablet" device size. Intentionally ambiguous - this does not represent any particular device precisely. */
height: 9in;
margin: auto 0 auto -360px;
width: 720px; /* Size is loosely based on a typical "tablet" device size. Intentionally ambiguous - this does not represent any particular device precisely. */
height: 1080px;
max-height: 100%;
max-width: 100%;
left: 50%;

2
wp-admin/css/themes.min.css vendored
View File

File diff suppressed because one or more lines are too long

2
wp-includes/version.php
View File

@@ -4,7 +4,7 @@
*
* @global string $wp_version
*/
$wp_version = '4.6-alpha-37244';
$wp_version = '4.6-alpha-37247';
/**
* Holds the WordPress DB revision, increments when changes are made to the WordPress DB schema.