discourse/config/initializers/100-flags.rb

# frozen_string_literal: true

# On initialize, reset flags cache
Rails.application.config.to_prepare do
  if Discourse.cache.is_a?(Cache) &&
       !ActiveRecord::Base.connection.migration_context.needs_migration?
    Flag.reset_flag_settings!
  end
end
FIX: setup with db:create db:migrate (#29609) After data seed, we should reset Redis cache to ensure that the correct flags are cached. However, `db:create` is skipping Redis https://github.com/discourse/discourse/blob/main/lib/tasks/db.rake#L39 And uses `ActiveSupport::Cache::MemoryStore.new` https://github.com/discourse/discourse/blob/e2292d4c5914875ad0e303770c56db7cc96847e3/lib/discourse.rb#L523 Therefore, the reset flags cache was moved to initializers and evaluated only when the cache is Redis and Flags table already exists. Meta: https://meta.discourse.org/t/development-install-fails-when-running-bin-rails-db-migrate/332754 2024-11-05 22:06:17 -06:00			`# frozen_string_literal: true`

			`# On initialize, reset flags cache`
			`Rails.application.config.to_prepare do`
FIX: migrations must be finished to reset flags cache (#29693) Bug introduced here: https://github.com/discourse/discourse/pull/29609 It was checking if `flags` table existed before resetting the cache. However, `require_message` flag was added in further migration: https://github.com/discourse/discourse/blob/main/db/migrate/20240714231226_duplicate_flags_custom_type_to_require_message.rb#L5 When the admin tried to update Discourse which already has `flags` table but no `require_message` column, it was causing the error. Therefore, we should ensure that all migrations are finished before resetting flags cache. Meta: https://meta.discourse.org/t/update-failing-column-require-message-does-not-exist/335030 2024-11-10 19:14:14 -06:00			`if Discourse.cache.is_a?(Cache) &&`
			`!ActiveRecord::Base.connection.migration_context.needs_migration?`
FIX: setup with db:create db:migrate (#29609) After data seed, we should reset Redis cache to ensure that the correct flags are cached. However, `db:create` is skipping Redis https://github.com/discourse/discourse/blob/main/lib/tasks/db.rake#L39 And uses `ActiveSupport::Cache::MemoryStore.new` https://github.com/discourse/discourse/blob/e2292d4c5914875ad0e303770c56db7cc96847e3/lib/discourse.rb#L523 Therefore, the reset flags cache was moved to initializers and evaluated only when the cache is Redis and Flags table already exists. Meta: https://meta.discourse.org/t/development-install-fails-when-running-bin-rails-db-migrate/332754 2024-11-05 22:06:17 -06:00			`Flag.reset_flag_settings!`
			`end`
			`end`