FIX: MaxMindDB download failures caused a crash on rebuild (#20737)

We did not properly define the "name" variable leading to the error handling
to crash.

This quick fix ensures it can gracefully fail.
This commit is contained in:
Sam 2023-03-20 18:23:54 +11:00 committed by GitHub
parent 4a3c13a37b
commit 0364ef5efe
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -277,8 +277,12 @@ task "assets:precompile" => "assets:precompile:before" do
puts "Downloading MaxMindDB..."
mmdb_thread =
Thread.new do
name = "unknown"
begin
geolite_dbs.each { |db| DiscourseIpInfo.mmdb_download(db) }
geolite_dbs.each do |db|
name = db
DiscourseIpInfo.mmdb_download(db)
end
if GlobalSetting.maxmind_backup_path.present?
copy_maxmind(DiscourseIpInfo.path, GlobalSetting.maxmind_backup_path)