IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-04 02:13:26 -05:00
Code Issues Packages Projects Releases Wiki Activity

DEV: fix flaky invite_mailer_spec test (#35664)

Browse Source 
conversation:
https://dev.discourse.org/t/flaky-test-mailers-invite-mailer-spec-rb-93/165998/15

---------

Co-authored-by: David Taylor <david@taylorhq.com>
This commit is contained in:
marstall
2025-10-29 11:14:36 -04:00
committed by GitHub
co-authored by David Taylor
parent ad36231ada
commit 060ba2ad94
1 changed files with 22 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/mailers/invite_mailer_spec.rb
+22 -18
View File
@@ -76,26 +76,25 @@ RSpec.describe InviteMailer do
end
end
# TODO: Very flaky test
# 1) InviteMailer send_invite when inviting to site with template modifier allows plugins to customize the invite template
# Failure/Error: expect(mail.subject).to eq("[Discourse] Custom Invite from Bruce Wayne (bruce0)")
# expected: "[Discourse] Custom Invite from Bruce Wayne (bruce0)"
# got: "[Discourse] Custom Invite from Bruce Wayne (bruce3)"
skip "with template modifier" do
context "with template modifier" do
fab!(:invite)
let(:plugin) { Plugin::Instance.new }
let(:custom_template) { "plugin_custom_invite_template" }
I18n.backend.store_translations(
:en,
{
plugin_custom_invite_template: {
subject_template: "[%{site_name}] Custom Invite from %{inviter_name}",
text_body_template:
"Custom invite body: %{invite_link}\n\nFrom: %{inviter_name}\nSite: %{site_domain_name}",
before do
I18n.backend.store_translations(
:en,
{
plugin_custom_invite_template: {
subject_template: "[%{site_name}] Custom Invite from %{inviter_name}",
text_body_template:
"Custom invite body: %{invite_link}\n\nFrom: %{inviter_name}\nSite: %{site_domain_name}",
},
},
},
)
)
end
after { I18n.backend.reload! }
it "allows plugins to customize the invite template" do
plugin_instance = Plugin::Instance.new
@modifier_block = Proc.new { |template, passed_invite| custom_template }
@@ -107,8 +106,13 @@ RSpec.describe InviteMailer do
)
mail = InviteMailer.send_invite(invite)
expect(mail.subject).to eq("[Discourse] Custom Invite from Bruce Wayne (bruce0)")
expect(mail.subject).to eq(
I18n.t(
"#{custom_template}.subject_template",
site_name: "Discourse",
inviter_name: "#{invite.invited_by.name} (#{invite.invited_by.username})",
),
)
DiscoursePluginRegistry.unregister_modifier(
plugin_instance,
:invite_forum_mailer_template,