IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Ensure sequential replaceText calls work correctly (#30951)

Browse Source 
`replaceText` will replace some text, then call `selectText()` to
restore the cursor position. However, selectText was asynchronous, so
calling `replaceText()` multiple times in the same runloop iteration
would cause the cursor to jump to an unexpected place. This likely
explains some of the weird behavior we've seen with upload-markdown
replacement
This commit is contained in:
David Taylor
2025-01-23 13:08:43 +00:00
committed by GitHub
parent 10f34ddf86
commit 26134b897a
1 changed files with 10 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/assets/javascripts/discourse/app/lib/textarea-text-manipulation.js
View File

@@ -1,5 +1,5 @@
import { setOwner } from "@ember/owner";
import { next, schedule } from "@ember/runloop";
import { schedule } from "@ember/runloop";
import { service } from "@ember/service";
import { isEmpty } from "@ember/utils";
import $ from "jquery";
@@ -127,20 +127,16 @@ export default class TextareaTextManipulation {
}
selectText(from, length, opts = { scroll: true }) {
next(() => {
this.textarea.selectionStart = from;
this.textarea.selectionEnd = from + length;
if (opts.scroll === true || typeof opts.scroll === "number") {
const oldScrollPos =
typeof opts.scroll === "number"
? opts.scroll
: this.textarea.scrollTop;
if (!this.capabilities.isIOS) {
this.textarea.focus();
}
this.textarea.scrollTop = oldScrollPos;
this.textarea.selectionStart = from;
this.textarea.selectionEnd = from + length;
if (opts.scroll === true || typeof opts.scroll === "number") {
const oldScrollPos =
typeof opts.scroll === "number" ? opts.scroll : this.textarea.scrollTop;
if (!this.capabilities.isIOS) {
this.textarea.focus();
}
});
this.textarea.scrollTop = oldScrollPos;
}
}
replaceText(oldVal, newVal, opts = {}) {