FIX: Don't ever grant badges when they're disabled

app/services/badge_granter.rb

@@ -12,6 +12,7 @@ class BadgeGranter
 
   def grant
     return if @granted_by and !Guardian.new(@granted_by).can_grant_badges?(@user)
+    return unless @badge.enabled?
 
     find_by = { badge_id: @badge.id, user_id: @user.id }
 

spec/components/cooked_post_processor_spec.rb

@@ -604,11 +604,18 @@ describe CookedPostProcessor do
 
       before { Oneboxer.stubs(:onebox) }
 
-      it "awards a badge for using an emoji" do
+      it "awards a badge for using an onebox" do
         cpp.post_process_oneboxes
         cpp.grant_badges
         expect(post.user.user_badges.where(badge_id: Badge::FirstOnebox).exists?).to eq(true)
       end
+
+      it "doesn't award the badge when the badge is disabled" do
+        Badge.where(id: Badge::FirstOnebox).update_all(enabled: false)
+        cpp.post_process_oneboxes
+        cpp.grant_badges
+        expect(post.user.user_badges.where(badge_id: Badge::FirstOnebox).exists?).to eq(false)
+      end
     end
 
     context "reply_by_email" do

spec/services/badge_granter_spec.rb

@@ -106,7 +106,14 @@ describe BadgeGranter do
 
       expect(user_badge.granted_at).to eq(time)
       expect(Notification.where(user_id: user.id).count).to eq(0)
+    end
 
+    it "doesn't grant disabled badges" do
+      badge = Fabricate(:badge, badge_type_id: BadgeType::Bronze, enabled: false)
+      time = 1.year.ago
+
+      user_badge = BadgeGranter.grant(badge, user, created_at: time)
+      expect(user_badge).to eq(nil)
     end
 
     it 'grants multiple badges' do