IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-09 04:28:29 -05:00
Code Issues Packages Projects Releases Wiki Activity

DEV: Replace the use of Ember's .findBy for native methods on arrays (#34557)

Browse Source 
Use the native array `.find` instead of Ember's `.findBy` which was deprecated.
This commit is contained in:
Sérgio Saquetim
2025-09-24 15:32:13 -03:00
committed by GitHub
parent 491573a470
commit 5b031945f7
86 changed files with 219 additions and 163 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/discourse-adplugin/admin/assets/javascripts/admin/controllers/admin-plugins-house-ads-show.js
+3 -1
View File
@@ -127,7 +127,9 @@ export default class adminPluginsHouseAdsShow extends Controller {
}
);
this.houseAdsController.model.removeObject(
this.houseAdsController.model.findBy("id", this.buffered.id)
this.houseAdsController.model.find(
(item) => item.id === this.buffered.id
)
);
this.router.transitionTo("adminPlugins.houseAds.index");
} catch (error) {
plugins/discourse-adplugin/admin/assets/javascripts/admin/routes/admin-plugins-house-ads-show.js
+2 -3
View File
@@ -13,9 +13,8 @@ export default class AdminPluginsHouseAdsShow extends DiscourseRoute {
});
} else {
return new TrackedObject(
this.modelFor("adminPlugins.houseAds").findBy(
"id",
parseInt(params.ad_id, 10)
this.modelFor("adminPlugins.houseAds").find(
(item) => item.id === parseInt(params.ad_id, 10)
)
);
}