IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2025-02-25 18:55:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Double trigger of close user menu (#30732)

Browse Source 
When clicking the "new features" notification item for
admins that navigates to /whats-new, the user notification
menu was not closing. This was happening because inside
the UserMenu::Menu component, the `routeDidChange` event
was firing and calling `closeUserMenu()`, however this is already
called inside the `Header` component via `toggleHamburger()`.

This is _only_ happening for the "new features" notification
item, other items have already been destroyed and they do not get
the `routeDidChange` event. No idea why, but this fixes the issue
in a global way.
This commit is contained in:
Martin Brennan
2025-01-15 10:38:08 +10:00
committed by GitHub
parent 73b28815e3
commit 5bc522e836
4 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
config/locales/client.en.yml
View File

@@ -2941,7 +2941,7 @@ en:
membership_request_consolidated: "new membership requests"
reaction: "new reaction"
votes_released: "Vote was released"
new_features: "new Discourse features have been released!"
new_features: "New Discourse features have been released!"
admin_problems: "new advice on your site dashboard"
upload_selector: