DEV: Use the correct (local) event argument (#36502)

All those accidentally rely on the global `event` variable.

We'll eventually add:

```js
{
  languageOptions: {
    globals: {
      event: "off",
    },
  },
},
```

…to lint-configs
This commit is contained in:
Jarek Radosz
2025-12-08 13:31:57 +01:00
committed by GitHub
parent 86dd2c4dc9
commit 5cc2d3f711
6 changed files with 16 additions and 9 deletions
@@ -357,7 +357,7 @@ export default class GlimmerSiteHeader extends Component {
}
@bind
onSwipeStart(swipeEvent) {
onSwipeStart(swipeEvent, fullEvent) {
const center = swipeEvent.center;
const swipeOverValidElement = document
.elementsFromPoint(center.x, center.y)
@@ -366,13 +366,14 @@ export default class GlimmerSiteHeader extends Component {
ele.classList.contains("panel-body") ||
ele.classList.contains("header-cloak")
);
if (
swipeOverValidElement &&
(swipeEvent.direction === "left" || swipeEvent.direction === "right")
) {
scrollLock(true, document.querySelector(".panel-body"));
} else {
event.preventDefault();
fullEvent.preventDefault();
}
}
@@ -96,14 +96,20 @@ export default class GrippieDragResize extends Modifier {
this.performDragHandler(
this.resizableElement,
this.grippiePosition,
this.onThrottledDrag
this.onThrottledDrag,
event
),
event,
THROTTLE_RATE
);
}
performDragHandler(resizableElement, grippiePosition, onThrottledDrag) {
performDragHandler(
resizableElement,
grippiePosition,
onThrottledDrag,
event
) {
resizableElement.classList.add("clear-transitions");
const currentMousePos = mouseYPos(event);
+2 -2
View File
@@ -98,7 +98,7 @@ export default class SwipeModifier extends Modifier {
lock(this.element);
}
this.onDidStartSwipeCallback?.(event.detail);
this.onDidStartSwipeCallback?.(event.detail, event);
}
/**
@@ -106,7 +106,7 @@ export default class SwipeModifier extends Modifier {
* @param {Event} event - The swipe end event.
*/
@bind
onDidEndSwipe() {
onDidEndSwipe(event) {
if (this.lockBody) {
unlock(this.element);
}
@@ -63,7 +63,7 @@ export default class ChatMessage extends Component {
toggleCheckIfPossible = modifier((element) => {
let addedListener = false;
const handler = () => {
const handler = (event) => {
if (!this.pane.selectingMessages) {
return;
}
@@ -24,7 +24,7 @@ export default {
);
const openQuickChannelSelector = (e) => {
if (isInputSelection(event.target) && !isChatComposer(event.target)) {
if (isInputSelection(e.target) && !isChatComposer(e.target)) {
return;
}
e.preventDefault();
@@ -24,7 +24,7 @@ export default class DiscourseReactionsPicker extends Component {
}
@action
pointerOver() {
pointerOver(event) {
if (event.pointerType !== "mouse") {
return;
}