FIX: avoid updating hamburgerVisible in the same computation (#27956)

This commit is contained in:
Kris
2024-07-18 08:39:17 -04:00
committed by GitHub
parent 4c8812737c
commit 6344e3f937

View File

@@ -3,6 +3,7 @@ import { tracked } from "@glimmer/tracking";
import { getOwner } from "@ember/application";
import { hash } from "@ember/helper";
import { action } from "@ember/object";
import { schedule } from "@ember/runloop";
import { service } from "@ember/service";
import { modifier as modifierFn } from "ember-modifier";
import { and, eq, not, or } from "truth-helpers";
@@ -109,15 +110,17 @@ export default class GlimmerHeader extends Component {
@action
closeCurrentMenu() {
if (this.search.visible) {
this.toggleSearchMenu();
} else if (this.header.userVisible) {
this.toggleUserMenu();
document.getElementById(USER_BUTTON_ID)?.focus();
} else if (this.header.hamburgerVisible) {
this.toggleHamburger();
document.getElementById(HAMBURGER_BUTTON_ID)?.focus();
}
schedule("afterRender", () => {
if (this.search.visible) {
this.toggleSearchMenu();
} else if (this.header.userVisible) {
this.toggleUserMenu();
document.getElementById(USER_BUTTON_ID)?.focus();
} else if (this.header.hamburgerVisible) {
this.toggleHamburger();
document.getElementById(HAMBURGER_BUTTON_ID)?.focus();
}
});
}
@action