mirror of
https://github.com/discourse/discourse.git
synced 2024-11-29 12:13:58 -06:00
UX: improve topic composition on mobile
- tighten up space used for composer body - stop collapsing and expanding so much
This commit is contained in:
parent
3812c07958
commit
7b5b255168
@ -76,6 +76,13 @@ export default Ember.Component.extend({
|
||||
}
|
||||
},
|
||||
|
||||
@observes('composeState')
|
||||
disableFullscreen() {
|
||||
if (this.get('composeState') !== Composer.OPEN) {
|
||||
positioningWorkaround.blur();
|
||||
}
|
||||
},
|
||||
|
||||
didInsertElement() {
|
||||
this._super();
|
||||
const $replyControl = $('#reply-control');
|
||||
|
@ -7,6 +7,8 @@ function applicable() {
|
||||
}
|
||||
|
||||
let workaroundActive = false;
|
||||
let composingTopic = false;
|
||||
|
||||
export function isWorkaroundActive() {
|
||||
return workaroundActive;
|
||||
}
|
||||
@ -22,27 +24,38 @@ function positioningWorkaround($fixedElement) {
|
||||
var done = false;
|
||||
var originalScrollTop = 0;
|
||||
|
||||
positioningWorkaround.blur = function(evt) {
|
||||
if (workaroundActive) {
|
||||
done = true;
|
||||
|
||||
$('#main-outlet').show();
|
||||
$('header').show();
|
||||
|
||||
fixedElement.style.position = '';
|
||||
fixedElement.style.top = '';
|
||||
fixedElement.style.height = '';
|
||||
|
||||
$(window).scrollTop(originalScrollTop);
|
||||
|
||||
if (evt) {
|
||||
evt.target.removeEventListener('blur', blurred);
|
||||
}
|
||||
workaroundActive = false;
|
||||
}
|
||||
};
|
||||
|
||||
var blurredNow = function(evt) {
|
||||
if (!done && _.include($(document.activeElement).parents(), fixedElement)) {
|
||||
// something in focus so skip
|
||||
return;
|
||||
}
|
||||
|
||||
done = true;
|
||||
|
||||
$('#main-outlet').show();
|
||||
$('header').show();
|
||||
|
||||
fixedElement.style.position = '';
|
||||
fixedElement.style.top = '';
|
||||
fixedElement.style.height = '';
|
||||
|
||||
$(window).scrollTop(originalScrollTop);
|
||||
|
||||
if (evt) {
|
||||
evt.target.removeEventListener('blur', blurred);
|
||||
if (composingTopic) {
|
||||
return false;
|
||||
}
|
||||
workaroundActive = false;
|
||||
|
||||
positioningWorkaround.blur(evt);
|
||||
|
||||
};
|
||||
|
||||
var blurred = _.debounce(blurredNow, 250);
|
||||
@ -73,7 +86,20 @@ function positioningWorkaround($fixedElement) {
|
||||
|
||||
fixedElement.style.top = '0px';
|
||||
|
||||
const height = Math.max(parseInt(window.innerHeight*0.6), 350);
|
||||
let ratio = 0.6;
|
||||
let min = 350;
|
||||
|
||||
composingTopic = false;
|
||||
|
||||
if ($('#reply-control select.category-combobox').length > 0) {
|
||||
composingTopic = true;
|
||||
// creating a topic, less height
|
||||
ratio = 0.54;
|
||||
min = 300;
|
||||
}
|
||||
|
||||
const height = Math.max(parseInt(window.innerHeight*ratio), min);
|
||||
|
||||
fixedElement.style.height = height + "px";
|
||||
|
||||
// I used to do this, but it seems like we don't need to with position
|
||||
|
Loading…
Reference in New Issue
Block a user