IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-07 19:55:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Spec ambiguity when selecting category dropdowns (#35215)

Browse Source 
https://github.com/discourse/discourse/pull/35211 introduced some specs
that require selecting parent category dropdown, but there are two
dropdowns and spec is confoosed.
This commit is contained in:
Natalie Tay
2025-10-07 00:45:09 +08:00
committed by GitHub
parent 8841ce71c1
commit 8a468904af
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
spec/system/category_localizations_spec.rb
+10 -9
View File
@@ -26,6 +26,13 @@ describe "Category Localizations", type: :system do
SiteSetting.desktop_category_page_style = "categories_boxes"
end
def get_category_dropdown(nth)
selector = ".category-breadcrumb li:nth-child(#{nth}) .category-drop"
expect(page).to have_css(selector)
el = find(selector, visible: :all)
PageObjects::Components::SelectKit.new(el)
end
context "when content localization setting is disabled" do
before { SiteSetting.content_localization_enabled = false }
@@ -184,7 +191,7 @@ describe "Category Localizations", type: :system do
expect(sidebar).to have_section_link("Solicitudes")
sidebar.click_section_link("Solicitudes")
category_dropdown = PageObjects::Components::SelectKit.new(".category-drop")
category_dropdown = get_category_dropdown(1)
expect(category_dropdown).to have_selected_name("Solicitudes")
expect(category_page.category_box(subcat)).to have_text("Subcategoría")
expect(category_page.category_box(subcat)).to have_text("Una subcategoría de un padre")
@@ -193,14 +200,8 @@ describe "Category Localizations", type: :system do
category_page.category_box(subcat).click
parent_category_dropdown =
PageObjects::Components::SelectKit.new(
".category-breadcrumb li:nth-child(1) .category-drop",
)
sub_category_dropdown =
PageObjects::Components::SelectKit.new(
".category-breadcrumb li:nth-child(2) .category-drop",
)
parent_category_dropdown = get_category_dropdown(1)
sub_category_dropdown = get_category_dropdown(2)
expect(parent_category_dropdown).to have_selected_name("Solicitudes")
expect(sub_category_dropdown).to have_selected_name("Subcategoría")
end