IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-08 12:08:12 -05:00
Code Issues Packages Projects Releases Wiki Activity

FIX: Remove redundant allowedGroups parameter (#34244)

Browse Source 
Remove frontend code that automatically adds
allowedGroups="trust_level_0" to public events.


https://meta.discourse.org/t/non-staff-members-cannot-create-calendar-events/376796
This commit is contained in:
Krzysztof Kotlarek
2025-08-12 11:56:26 +08:00
committed by GitHub
parent b4526201ab
commit 91d26abb10
4 changed files with 8 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/discourse-calendar/assets/javascripts/discourse/lib/raw-event-helper.js
-4
View File
@@ -63,10 +63,6 @@ export function buildParams(startsAt, endsAt, event, siteSettings) {
params.allowedGroups = (event.rawInvitees || []).join(",");
}
if (event.status === "public") {
params.allowedGroups = "trust_level_0";
}
if (event.reminders && event.reminders.length) {
params.reminders = event.reminders
.map((r) => {
plugins/discourse-calendar/spec/system/post_event_spec.rb
+1 -1
View File
@@ -66,7 +66,7 @@ describe "Post event", type: :system do
time = Time.now.strftime("%Y-%m-%d %H:%M")
EXPECTED_BBCODE = <<~EVENT
[event start="#{time}" status="public" timezone="Europe/Paris" allowedGroups="trust_level_0"]
[event start="#{time}" status="public" timezone="Europe/Paris"]
foo
bar
[/event]
plugins/discourse-calendar/test/javascripts/acceptance/post-event-builder-test.js
+1 -1
View File
@@ -61,7 +61,7 @@ acceptance("Post event - composer", function (needs) {
assert
.dom(".d-editor-input")
.hasValue(
`[event start="2022-07-01 12:00" status="public" timezone="Europe/Paris" end="2022-07-01 13:00" allowedGroups="trust_level_0"]\n[/event]`,
`[event start="2022-07-01 12:00" status="public" timezone="Europe/Paris" end="2022-07-01 13:00"]\n[/event]`,
"bbcode is correct"
);
});
plugins/discourse-calendar/test/javascripts/integration/components/rich-editor-extension-test.js
+6 -6
View File
@@ -8,16 +8,16 @@ module("Integration | Component | rich-editor-extension", function (hooks) {
const testCases = {
"event alone": [
[
`[event start="2025-03-21 15:41" status="public" timezone="Europe/Paris" allowedGroups="trust_level_0"]\n[/event]\n`,
`<div class="discourse-post-event discourse-post-event-preview ProseMirror-selectednode" data-start="2025-03-21 15:41" data-status="public" data-timezone="Europe/Paris" data-allowed-groups="trust_level_0" contenteditable="false" draggable="true"><div class="event-preview-status">Public</div><div class="event-preview-dates"><span class="start">March 21, 2025 2:41 PM</span></div></div>`,
`[event start="2025-03-21 15:41" status="public" timezone="Europe/Paris" allowedGroups="trust_level_0"]\n[/event]\n`,
`[event start="2025-03-21 15:41" status="public" timezone="Europe/Paris"]\n[/event]\n`,
`<div class="discourse-post-event discourse-post-event-preview ProseMirror-selectednode" data-start="2025-03-21 15:41" data-status="public" data-timezone="Europe/Paris" contenteditable="false" draggable="true"><div class="event-preview-status">Public</div><div class="event-preview-dates"><span class="start">March 21, 2025 2:41 PM</span></div></div>`,
`[event start="2025-03-21 15:41" status="public" timezone="Europe/Paris"]\n[/event]\n`,
],
],
"event with content around": [
[
`Hello world\n\n[event start="2025-03-21 15:41" status="public" timezone="Europe/Paris" allowedGroups="trust_level_0"]\n[/event]\nGoodbye world`,
`<p>Hello world</p><div class="discourse-post-event discourse-post-event-preview" data-start="2025-03-21 15:41" data-status="public" data-timezone="Europe/Paris" data-allowed-groups="trust_level_0" contenteditable="false" draggable="true"><div class="event-preview-status">Public</div><div class="event-preview-dates"><span class="start">March 21, 2025 2:41 PM</span></div></div><p>Goodbye world</p>`,
`Hello world\n\n[event start="2025-03-21 15:41" status="public" timezone="Europe/Paris" allowedGroups="trust_level_0"]\n[/event]\nGoodbye world`,
`Hello world\n\n[event start="2025-03-21 15:41" status="public" timezone="Europe/Paris"]\n[/event]\nGoodbye world`,
`<p>Hello world</p><div class="discourse-post-event discourse-post-event-preview" data-start="2025-03-21 15:41" data-status="public" data-timezone="Europe/Paris" contenteditable="false" draggable="true"><div class="event-preview-status">Public</div><div class="event-preview-dates"><span class="start">March 21, 2025 2:41 PM</span></div></div><p>Goodbye world</p>`,
`Hello world\n\n[event start="2025-03-21 15:41" status="public" timezone="Europe/Paris"]\n[/event]\nGoodbye world`,
],
],
};