mirror of
https://github.com/discourse/discourse.git
synced 2025-02-25 18:55:32 -06:00
PERF: Do not calculate gaps for TopicViewPostsSerializer.
The client doesn't use the gaps results when loading new posts.
This commit is contained in:
@@ -12,10 +12,18 @@ module PostStreamSerializerMixin
|
||||
true
|
||||
end
|
||||
|
||||
def include_gaps?
|
||||
true
|
||||
end
|
||||
|
||||
def post_stream
|
||||
result = { posts: posts }
|
||||
result[:stream] = object.filtered_post_ids if include_stream?
|
||||
result[:gaps] = GapSerializer.new(object.gaps, root: false) if object.gaps.present?
|
||||
|
||||
if include_gaps? && object.gaps.present?
|
||||
result[:gaps] = GapSerializer.new(object.gaps, root: false)
|
||||
end
|
||||
|
||||
result
|
||||
end
|
||||
|
||||
|
||||
@@ -12,6 +12,10 @@ class TopicViewPostsSerializer < ApplicationSerializer
|
||||
false
|
||||
end
|
||||
|
||||
def include_gaps?
|
||||
false
|
||||
end
|
||||
|
||||
def include_timeline_lookup?
|
||||
false
|
||||
end
|
||||
|
||||
@@ -22,5 +22,6 @@ RSpec.describe TopicViewPostsSerializer do
|
||||
expect(posts.first["id"]).to eq(post.id)
|
||||
expect(body["post_stream"]["stream"]).to eq(nil)
|
||||
expect(body["post_stream"]["timeline_lookup"]).to eq(nil)
|
||||
expect(body["post_stream"]["gaps"]).to eq(nil)
|
||||
end
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user