FEATURE: Poll breakdown 2.0 (#10345)

Browse Source

The poll breakdown modal replaces the grouped pie charts feature.

Includes:

* MODAL: Untangle `onSelectPanel`
Previously modal-tab component would call on click the onSelectPanel callback with itself (modal-tab) as `this` which severely limited its usefulness. Now showModal binds the callback to its controller.

"The PR includes a fix/change to d-modal (b7f6ec6) that hasn't been extracted to a separate PR because it's not currently possible to test a change like this in abstract, i.e. with dynamically created controllers/components in tests. The percentage/count toggle test for the poll breakdown feature is essentially a test for that d-modal modification."

...

This commit is contained in:

Jarek Radosz

2020-08-06 17:57:06 +02:00

committed by GitHub

parent 76c02cac65

commit cd4f251891

26 changed files with 708 additions and 294 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

7

public/javascripts/chartjs-plugin-datalabels.min.js vendored Normal file

File diff suppressed because one or more lines are too long