IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-09-05 04:40:41 -05:00
Code Issues Packages Projects Releases Wiki Activity
41,739 Commits 1,018 Branches 579 Tags
002c6763440c65bd6587dbe5b8e820b3713f406c
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Penar Musaraj 06e1af2b1d FIX: Giphy oneboxing when the response is an image (#13199) 2021-05-28 15:10:32 -04:00
Penar Musaraj 526dbc99b2 UX: Don't show reply prompt if current topic is closed (#13197) 
A non-staff user cannot post to a closed topic, so we should not
show them the modal asking "Which topic do you want to reply to?"

This also fixes an issue I ran into while testing the above change, in
Ember CLI an error was being raised because related messages were being
set inside a computed property.
 2021-05-28 13:47:51 -04:00
Penar Musaraj 47e09700fe FIX: Support pausing GIFs for giphy/tenor oneboxes (#13194) 2021-05-28 08:40:30 -04:00
Penar Musaraj 726500bc59 FEATURE: Enable pausing images from Giphy and Tenor (#13185) 2021-05-27 15:00:38 -04:00
Penar Musaraj bcbb5b4dae UX: Show grandparent category badge in sticky header on desktop (#13184) 2021-05-27 11:35:28 -04:00
Penar Musaraj 855e854cb8 DEV: Enable optional chaining in all contexts (#13180) 
* Revert "FIX: We can't use `?.` yet (#13168)"
 2021-05-27 09:56:35 -04:00
Penar Musaraj 1270c7ad15 UX: Twitter onebox layout adjustments (#13181) 2021-05-27 15:35:32 +10:00
Penar Musaraj bc4b41cfb6 DEV: Do not prompt to run yarn in dev env (#13167) 2021-05-26 22:16:28 -04:00
Penar Musaraj ea68bab135 FIX: Close hyperlink modal on ESC key (#13166) 2021-05-26 15:11:12 -04:00
Penar Musaraj 787f989fb9 FIX: add body class and remove jQuery usage in footer-nav component (#13162) 2021-05-26 13:03:34 -04:00
Penar Musaraj 452ea7e32e FIX: Properly break overflowing long links in topic map (#13146) 2021-05-25 15:43:58 -04:00
Penar Musaraj 6e9ee3db03 FIX: Sort user bookmarks by reminder date (#13145) 2021-05-25 15:23:46 -04:00
Penar Musaraj 29f3621f45 FIX: Disable lightboxing of animated images (#13099) 2021-05-20 15:19:44 -04:00
Penar Musaraj b21f74060e FIX: Layout of date input in poll builder (#13057) 2021-05-13 10:27:03 -04:00
Penar Musaraj b0d66b4b2f FIX: Support pausing inline animated images (#13033) 2021-05-12 09:49:04 -04:00
Penar Musaraj f9bb6399e0 DEV: Remove SCSS color vars fallbacks (#13035) 
They are no longer needed.
 2021-05-12 08:56:15 -04:00
Penar Musaraj 033a1fb2af DEV: Minor changes to /theme-qunit landing page (#13032) 2021-05-11 10:45:07 -04:00
Penar MusarajandJarek Radosz e8f6e00dc9 DEV: Show warning in admin UI for core SCSS color vars (#12984) 
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
 2021-05-11 09:01:06 -04:00
Penar Musaraj 81616fbdc4 DEV: Fix flaky d-editor test (#13005) 2021-05-10 13:00:18 -04:00
Penar Musaraj 49de5dadf7 DEV: Ember CLI postinstall hook and shortcut (#12987) 2021-05-10 09:34:24 -04:00
Penar Musaraj 116ae8ebc1 DEV: update styleguide guidance for colors and font sizes (#12975) 2021-05-07 09:30:27 -04:00
Penar Musaraj 82ecd9fdd5 DEV: tiny refactor in watched words (#12969) 2021-05-06 11:37:05 -04:00
Penar Musaraj b61d4663ec FIX: Prevent infinite loop when replacing watched words (#12967) 2021-05-06 11:06:25 -04:00
Penar Musaraj aec52ce043 UX: Admin watched words UI tweaks (#12956) 2021-05-06 12:40:07 +10:00
Penar Musaraj 10d229ff71 Revert "FIX: excludes .svg-as-img from JS sizing (#12906)" (#12931) 
This reverts commit 2f0205e5c8.
 2021-05-03 14:40:18 -04:00
Penar Musaraj 9bc126949e DEV: Support referencing public images in plugins in SCSS (#12930) 2021-05-03 14:40:02 -04:00
Penar Musaraj 7b5f31ff04 FIX: Wizard locale change wasn't applying to some elements (#12915) 2021-04-30 12:14:16 -04:00
Penar Musaraj 28cefb666a FIX: light color scheme picker should default to user selection (#12913) 
Fixes a bug in user preferences > interface, the light scheme dropdown
was defaulting to "Theme Default" even when the user had selected a
different scheme.
 2021-04-30 11:31:01 -04:00
Penar Musaraj 54b7a0d06c FIX: Keep filter UI after editing post (#12898) 2021-04-29 14:56:23 -04:00
Penar Musaraj e832088edf UX: Fix styling for long label in multi-select choices (#12877) 2021-04-28 15:12:01 -04:00
Penar Musaraj 548c044809 FIX: Improvements to animated image pausing (#12839) 2021-04-28 10:48:00 -04:00
Penar Musaraj 886f4b589e FIX: Bug when scrolling in iOS Safari with composer open (#12831) 
Regression was introduced in c54609.

This ensures the full height composer styling only applies when (window
height - viewport height > 0). Previously it was being wrongly triggered
when that calculation returned a negative number.
 2021-04-25 22:14:13 -04:00
Penar Musaraj dd3e16c1e4 DEV: Add group join/leave events (#12817) 2021-04-23 12:47:18 -04:00
Penar Musaraj 139ba69117 FIX: Do not add CSS transition effect to animated images (#12803) 
Followup to c11d75da87, the transition
delays the pause/play action.
 2021-04-22 14:05:48 -04:00
Penar MusarajandJarek Radosz c11d75da87 FEATURE: Allow pausing animated images in posts (#12795) 
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
 2021-04-22 11:28:35 -04:00
Penar Musaraj fd6f0db788 DEV: Fix flaky Ember test (#12802) 2021-04-22 10:25:20 -04:00
Penar Musaraj 95223938a5 FIX: Exclude emoji images from JS sizing (#12796) 
Should remove jumpiness when using the experimental
`disable_image_size_calculations` site setting.
 2021-04-21 20:51:44 -04:00
Penar Musaraj 24715115f5 DEV: Experiment with relative image sizes and native image lazy loading (#12759) 2021-04-21 12:41:45 -04:00
Penar Musaraj 886cf72b0e FIX: Fall back to hardcoded version when period check disabled (#12784) 
When `SiteSetting.version_checks?` is disabled, the Discourse version is
not stored in Redis, so we need to fall back to the hardcoded value.
 2021-04-21 12:40:27 -04:00
Penar Musaraj c47e6a2004 FIX: Use CDN urls for theme settings of type upload (#12773) 2021-04-20 18:42:02 -04:00
Penar Musaraj d44deb45f3 FIX: Use CDN urls for theme uploads (#12769) 2021-04-20 13:25:35 -04:00
Penar Musaraj ff601504f7 DEV: Fix linting (#12754) 2021-04-19 09:28:07 -04:00
Penar MusarajandKris f0000f5017 UX: Mobile styling for discard draft modal buttons (#12735) 
Co-authored-by: Kris  <kris.aubuchon@discourse.org>
 2021-04-19 09:23:41 -04:00
Penar Musaraj 9581d71372 FIX: Allow CodeCommit-style theme .git url format (#12739) 2021-04-16 12:46:34 -04:00
Penar Musaraj 35f977f8a5 UX: Prevent some composer buttons from receiving focus (#12719) 2021-04-16 11:10:02 -04:00
Penar Musaraj c54609bfcd UX: Full height composer on mobile Android (#12709) 2021-04-15 09:02:24 -04:00
Penar Musaraj abb0a4bae2 DEV: Add SCSS helper to replace asset-uri and image-uri (#12664) 2021-04-12 13:57:39 +10:00
Penar Musaraj 43d09dbabe DEV: Skip looking for svgo, gifsicle binaries (#12655) 2021-04-09 08:52:06 -04:00
Penar Musaraj e77b9dfd45 DEV: Use Terser for JS minification/compression if available (#12656) 2021-04-09 08:51:49 -04:00
Penar Musaraj eb7ff576e5 FEATURE: Use SVG icons for some oneboxes (#12654) 2021-04-08 09:58:12 -04:00
Penar Musaraj 11e611f845 DEV: Bump discourse_dev to 0.0.7 (#12633) 2021-04-07 10:55:19 -04:00
Penar Musaraj 34596beb52 FIX: Keep current filter while navigating posts in a topic (#12620) 2021-04-06 15:00:25 -04:00
Penar Musaraj cdb99f012b FIX: Retain tags when loading a topic draft in composer (#12616) 2021-04-06 11:49:06 -04:00
Penar Musaraj 769b3ba8ae DEV: Add colors/styling to Ember CLI and qunit tests (#12617) 2021-04-06 11:48:44 -04:00
Penar Musaraj 98ae4e2829 FIX: Clear state after creating new topic (#12615) 2021-04-06 10:17:14 -04:00
Penar Musaraj f56a22bd2e FIX: New Topic button regression in tag page (#12613) 2021-04-06 09:31:49 -04:00
Penar Musaraj 524890c5e4 DEV: Clear filters when navigating to a post (#12557) 2021-03-30 13:55:15 -04:00
Penar Musaraj 65ad8750c7 DEV: Remove draft attributes from topic lists (#12525) 2021-03-30 11:42:26 -04:00
Penar Musaraj 2579127091 UX: Fix tab list alignment in emoji popup (#12548) 2021-03-29 16:30:20 -04:00
Penar Musaraj db7be947df FIX: Allow dismissing Discard Drafts modal via ESC (#12532) 2021-03-26 13:07:19 -04:00
Penar Musaraj edc0f61920 UX: Emoji popup layout adjustments (#12533) 2021-03-26 13:07:04 -04:00
Penar Musaraj 5096920500 FEATURE: Implement nonces for Google Tag Manager integration (#12531) 2021-03-26 11:19:31 -04:00
Penar Musaraj e4f3a04d53 DEV: Move color definition functions to mixins (#12511) 2021-03-24 18:35:52 -04:00
Penar Musaraj b8822c7a87 DEV: Skip composer duplicate link test (#12509) 2021-03-24 15:25:31 -04:00
Penar Musaraj ee17ca9dc6 FIX: 404 error when editing an expanded reply (#12504) 2021-03-24 10:22:27 -04:00
Penar Musaraj 066c59d0e3 FIX: Regression in colors used by non-default theme (#12492) 
eb7f0ec caused this regression, where a non-default theme set to use
the base color scheme was resolving to the default theme's color scheme.
 2021-03-23 12:46:25 -04:00
Penar Musaraj d898e00242 FIX: Clear draft modal correctly when switching topics (#12458) 
Fixes an issue where the "Keep editing" button in the discard draft
modal wouldn't work when switching to a new topic with an open composer
and clicking Reply.

Followup to d470e4f
 2021-03-22 11:32:19 +11:00
Penar Musaraj d470e4fade FEATURE: Allow users to save draft and close composer (#12439) 
We previously included this option conditionally when users were replying
or creating a new topic while they had content already in the composer.

This makes the dialog always include three buttons:
  - Close and discard
  - Close and save draft for later
  - Keed editing

This also changes how the backend notifies the frontend when there is
a current draft topic. This is now sent via the `has_topic_draft`
property in the current user serializer.
 2021-03-19 09:19:15 -04:00
Penar Musaraj aee7ef0dc9 DEV: Fix build due to highlight.js branch issue (#12441) 
Highlight.js changed their default branch from master to main. This switches to the @highlightjs/cdn-assets package, thus sidestepping the problem. It's a slightly cleaner integration though (no need to build locally anymore).
 2021-03-18 18:21:23 -04:00
Penar Musaraj eb7f0ec766 FIX: In components, fall back to default theme color variables (#12423) 
Component SCSS compilation should use the current theme's SCSS color
variables as a fallback before using the default core colors.

This is mostly a backwards-compatibility fix, new themes and components
should use CSS custom properties, which offer better support for on-the-fly
color scheme changes (dark mode support, etc.).
 2021-03-17 13:34:15 -04:00
Penar Musaraj de05c410c5 DEV: Use fewer threads when watching for SCSS changes (#12393) 2021-03-12 16:18:00 -05:00
Penar Musaraj 52d833472c DEV: Refactor plugin SCSS compilation (#12359) 2021-03-12 11:17:42 -05:00
Penar Musaraj 0cd4da51c7 FIX: Include json_schemer in prod (#12351) 2021-03-10 21:32:23 -05:00
Penar Musaraj 10780d2448 DEV: support json_schema in theme settings (#12294) 2021-03-10 20:15:04 -05:00
Penar Musaraj b3bcf2769a UX: Consistent labels in invite form (#12339) 2021-03-10 12:27:53 -05:00
Penar Musaraj de6474a85f DEV: Update highlight.js dependency to 10.6.0 (#12303) 2021-03-10 11:35:00 -05:00
Penar Musaraj 4071af1d09 DEV: Refactor font and category background importers (#12312) 2021-03-10 11:05:56 -05:00
Penar Musaraj 0a656767c7 DEV: use Redis data for version check in DiscourseUpdates (#12293) 
A version bump caused the specs to fail, this switches to using what is
stored in Redis, which is also what is stubbed in the specs.
 2021-03-08 09:05:08 -05:00
Penar Musaraj 6809cccd88 DEV: Add experimental json_scheme site setting type (#12226) 2021-03-01 09:15:17 -05:00
Penar Musaraj bfa3e24e48 FIX: Update digest when updating color definitions in theme component (#12233) 2021-03-01 09:14:58 -05:00
Penar Musaraj cf0192018e FIX: Do not output empty style tags for components (#12229) 2021-03-01 09:14:25 -05:00
Penar Musaraj aa1442fdc3 DEV: Use separate files for theme component stylesheets (take 2) (#12225) 
This switches to outputting a separate file for each theme component CSS
asset. We have separate CSS plugin files, separate JS files
(for plugins/themes/components), it makes sense to do the same for
component CSS assets.

Benefits:
- easier debugging
- fixes a regression with theme component sourcemaps
- changes to theme components are updated individually

With HTTP/2, there is also no performance downside to having additional
files in the initial request.
 2021-02-26 12:30:23 -05:00
Penar Musaraj e74bdfdf8e Revert "DEV: Use separate files for theme component stylesheets (#12214)" (#12224) 
This reverts commit f57a49c2f9.

This had some unexpected side effects, needs some more work.
 2021-02-26 08:20:39 -05:00
Penar Musaraj 45c5fd2172 DEV: Remove JoyPixels emoji option (#12197) 
- removes the option from site settings
- deletes the site setting on existing sites that have it
- marks posts using emojis as requiring a rebake

Note that the actual image files are not removed here, the plan is to
remove them in a few weeks/months (when presumably the rebaking of old
posts has been completed).
 2021-02-26 07:44:52 -05:00
Penar Musaraj f57a49c2f9 DEV: Use separate files for theme component stylesheets (#12214) 
This switches to outputting a separate file for each theme component CSS
asset. We have separate CSS plugin files, separate JS files
(for plugins/themes/components), it makes sense to do the same for
component CSS assets.

Benefits:
- easier debugging
- fixes a regression with theme component sourcemaps
- changes to theme components are updated individually

With HTTP/2, there is also no performance downside to having additional
files in the initial request.
 2021-02-26 07:44:15 -05:00
Penar Musaraj c0fd4ab9d6 DEV: Remove deprecated plugins variables importer (#12168) 2021-02-23 16:20:59 -05:00
Penar Musaraj bd679b95a7 UX: Remove redundant focus style (#12192) 
This style is unnecessary because text inputs and textareas have
focus styles set elsewhere (lines 228 and 288 respectively) and we don't
have any `select` elements.
 2021-02-23 16:20:39 -05:00
Penar Musaraj 76967ee788 UX: use default browser focus styling for checkbox and radio inputs (#12173) 2021-02-23 14:01:02 -05:00
Penar Musaraj e58922e1e3 UX: Styling adjustments for admin new features (#12189) 
- Fixes an alignment issue when emojis have varying widths
- Adjusts mobile alignment
 2021-02-23 11:58:20 -05:00
Penar Musaraj 7fb4633b5a DEV: Remove very old mocha deprecation workaround (#12151) 2021-02-22 20:26:49 -05:00
Penar Musaraj 9063520d89 FIX: Avoid Safari service worker error on back navigation (#12171) 2021-02-22 14:11:20 -05:00
Penar Musaraj 0620f6298e UX: Remove emoji step in wizard (#12169) 2021-02-22 12:14:18 -05:00
Penar Musaraj 5604ce70d4 DEV: More refactoring of SCSS importers (#12143) 2021-02-19 11:22:24 -05:00
Penar Musaraj 7ee660a017 FIX: Sort admin dashboard new updates by latest (#12146) 2021-02-19 11:03:36 -05:00
Penar Musaraj 916e1d85cf FEATURE: Quick theme installs via query parameters (#12128) 2021-02-18 12:51:44 -05:00
Penar Musaraj 4739bdac0a UX: Adjustments to admin theme editor (#12112) 2021-02-17 13:00:34 -05:00
Penar Musaraj 431c6de480 UX: Add editing guidance for remote themes (#12111) 2021-02-17 10:24:34 -05:00
Penar Musaraj 5d8673321f DEV: Add poll:voted event (#12070) 2021-02-12 13:06:27 -05:00
Penar Musaraj 74ca5ec743 FIX: Regression in admin new features (#12068) 2021-02-12 10:49:10 -05:00
Penar Musaraj 900d4187ef DEV: Prevents rate limits for new feature checks on multisite (#12053) 2021-02-12 08:52:59 -05:00