IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-07 11:45:21 -05:00
Code Issues Packages Projects Releases Wiki Activity
37,565 Commits 953 Branches 574 Tags
096eca0ee813fa5ba79d76e6012f251e5f85a8e4
Commit Graph
37565 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Robin Ward 096eca0ee8 FIX: Requests were not being logged correctly 
`enable` was defaulting to `nil` which is not what we wanted.
 2020-05-20 15:09:17 -04:00
Mark VanLandingham e1bd57007b DEV: Specs for AboutController can_see_about_stats? impact (#9843) 2020-05-20 11:30:27 -05:00
Robin Ward ba04bb7552 FIX: Path should be addon not app 2020-05-20 12:13:15 -04:00
Robin Ward 3062036f2f FIX: Allow deprecation to work with Ember CLI 2020-05-20 12:05:56 -04:00
Régis Hanol 8851b79472 DEV: less code for Category#url 2020-05-20 18:01:06 +02:00
Robin Ward 09ca75d17e FIX: select-kit was in the wrong place 
`app/` means we want to merge it into our application there. `addon`
means give it its own module namespace, which is what we wanted.
 2020-05-20 11:51:49 -04:00
Jordan Vidrine 8e7efb48ae FIX: Update default_template.html 2020-05-20 10:39:04 -05:00
Robin Ward 6c9c8dfefd FIX: guidFor is not part of Ember.Object 2020-05-20 11:31:11 -04:00
Mark VanLandingham bd57ae83f1 DEV: Guardian for hiding about stats (#9841) 2020-05-20 10:26:20 -05:00
dependabot-preview[bot]anddependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> cfff8b1f27 Build(deps): Bump puma from 4.3.4 to 4.3.5 (#9836) 
Bumps [puma](https://github.com/puma/puma) from 4.3.4 to 4.3.5.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-05-20 10:37:43 -04:00
Arpit Jalan 4a533ec594 FIX: do not parameterize tag_id (#9839) 
Parameterizing tag_id was breaking tags with non-ascii characters or emoji.

Bug report: https://meta.discourse.org/t/unable-to-see-pm-lists-for-non-ascii-tag/151723/4
 2020-05-20 19:22:20 +05:30
Joffrey JAFFEUX 30631a963f UX: moves editFirstPost in taggable Pms in dropdown on mobile (#9840) 2020-05-20 14:07:00 +02:00
Osama Sayegh 02f44def56 FIX: Don't blow up when trying to parse invalid or non-ASCII URLs (#9838) 
* FIX: Don't blow up when trying to parseinvalid or non-ASCII URLs

Follow-up to https://github.com/discourse/discourse/commit/72f139191e9b3aeebeca31ffa8b75977afe5d816
 2020-05-20 12:46:27 +03:00
Bianca Nenciu fb15da43da Remove old web hooks in favor of 'reviewable' web hook (#9776) 
* FIX: Emit web hooks for flags

* FEATURE: Remove 'flag' web hook in favor of 'reviewable' web hook

* FEATURE: Remove 'queued post' web hook in favor of 'reviewable' web hook

* FIX: Do not set a default value for web hooks with no events
 2020-05-20 12:07:48 +03:00
Guo Xiang Tan 3aecc1990b DEV: Review follow up to 234cd5c3e7. 2020-05-20 16:17:59 +08:00
Guo Xiang Tan 2f03a879f9 DEV: Require rails_failover before global settings. 2020-05-20 16:06:40 +08:00
Guo Xiang Tan f7f436e536 DEV: Install rails_failover gem to test our Redis changes. 2020-05-20 15:40:27 +08:00
Sam Saffron 30bbc485d0 DEV: remove superfluous comment 2020-05-20 16:53:48 +10:00
Sam Saffron e97cb20c2a UX: strip text from PM bookmark and share buttons 
Also organize priorities in an easier to reason about way and
shift bookmark topic so it is after link. (consistent with posts)
 2020-05-20 16:46:49 +10:00
Sam Saffron b031e3220a FIX: migrations should not fail when db is part migrated 
When part migrated the translate overrides may have missing columns
in that case just silently ignore overrides
 2020-05-20 15:28:01 +10:00
Sam Saffron 05f7d5a2de UX: Rename "Edit Message" to "Edit" 
This reduces the space taken by the button.
 2020-05-20 14:12:58 +10:00
Guo Xiang Tan 37983a7815 Fix lint. 2020-05-20 10:33:34 +08:00
Guo Xiang Tan b7387d4611 DEV: Remove code unused code when seeding narrative bot. 2020-05-20 10:22:51 +08:00
Guo Xiang Tan 234cd5c3e7 FIX: Switch discobot to pull avatar from gravatar. 2020-05-20 10:20:08 +08:00
Sam Saffron 6b92c78033 FIX: purge all associated data on user delete 
This commit reorganises the delete dependencies on users and make sure
all are covered. We forgot some on bookmarks, security keys, anon users
and so on.
 2020-05-20 11:27:57 +10:00
Kris a93d0a8fcc UX: Remove bold from category badge text 2020-05-19 21:11:49 -04:00
Martin Brennan e334133294 PERF: Remove foreign keys from bookmarks (#9837) 
As a general rule we do not add FKs in Discourse and instead rely on consistency checks at weekly/daily intervals
 2020-05-20 10:45:49 +10:00
Martin Brennan 72f139191e FIX: S3 store has_been_uploaded? was not taking into account s3 bucket path (#9810) 
In some cases, between Discourse forums the hostname of a URL could match if they are hosting S3 files on the same bucket but the S3 bucket path might not. So e.g. https://testbucket.somesite.com/testpath/some/file/url.png vs https://testbucket.somesite.com/prodpath/some/file/url.png. So has_been_uploaded? was returning true for the second URL, even though it may have been uploaded on a different Discourse forum.

This is a very rare case but must be accounted for, because this impacts UrlHelper.is_local which mistakenly thinks the file has already been downloaded and thus allows the URL to be cooked, where we want to return the full URL to be downloaded using PullHotlinkedImages.
 2020-05-20 10:40:38 +10:00
Gerhard Schlager 0a700d81fc FIX: Restoring backups could fail for database dumps > 8GiB 
This is a temporary fix until we ship a new image with bsdtar.
 2020-05-19 22:36:59 +02:00
Roman Rizzi 52228b1fa6 DEV: These routes don't exist anymore (#9823) 2020-05-19 16:09:03 -03:00
Joffrey JAFFEUX a239900522 UI: reduces category row description margin (#9834) 2020-05-19 20:44:54 +02:00
Joffrey JAFFEUX 05d8091bd3 DEV: adds triggerOnChangeOnTab option to select-kit (#9833) 
Usage:

```
options=(hash triggerOnChangeOnTab=false)
```

This will prevent to select the row when pressing tab.
 2020-05-19 20:39:29 +02:00
dependabot-preview[bot]anddependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> 42229fecad Build(deps): Bump rbtrace from 0.4.12 to 0.4.13 (#9827) 
Bumps [rbtrace](https://github.com/tmm1/rbtrace) from 0.4.12 to 0.4.13.
- [Release notes](https://github.com/tmm1/rbtrace/releases)
- [Commits](https://github.com/tmm1/rbtrace/compare/v0.4.12...v0.4.13)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-05-19 12:46:16 -04:00
dependabot-preview[bot]anddependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> b23fe547ab Build(deps): Bump puma from 4.3.3 to 4.3.4 (#9824) 
Bumps [puma](https://github.com/puma/puma) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/puma/puma/releases)
- [Changelog](https://github.com/puma/puma/blob/master/History.md)
- [Commits](https://github.com/puma/puma/compare/v4.3.3...v4.3.4)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-05-19 12:40:39 -04:00
dependabot-preview[bot]anddependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> 01c27d991a Build(deps-dev): Bump minitest from 5.14.0 to 5.14.1 (#9807) 
Bumps [minitest](https://github.com/seattlerb/minitest) from 5.14.0 to 5.14.1.
- [Release notes](https://github.com/seattlerb/minitest/releases)
- [Changelog](https://github.com/seattlerb/minitest/blob/master/History.rdoc)
- [Commits](https://github.com/seattlerb/minitest/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
 2020-05-19 11:34:53 -04:00
Joffrey JAFFEUX ab6737c44a UX: improves topic-notifications-button loading behavior (#9832) 2020-05-19 17:13:40 +02:00
Daniel Waterworth 38c05a4f07 FIX: Check backtrace and backtrace_locations before trying to print an error 
... during plugin initialization.
 2020-05-19 14:27:22 +01:00
Arpit Jalan f038f8f154 FIX: description for 'uncategorized' category was blank 2020-05-19 18:45:43 +05:30
Daniel Waterworth b4c5ff17a3 FIX: Show a useful message when starting a plugin fails without a backtrace 2020-05-19 14:03:54 +01:00
Joffrey JAFFEUX 7c3663ff73 UX: adds visual feedback when changing topic notifications level (#9831) 2020-05-19 13:27:57 +02:00
Dan Ungureanu 05ca0c908f FIX: GroupArchivedMessage belongs to Group, not User 2020-05-19 14:13:28 +03:00
David Taylor e9f579bd3f DEV: Clean up thumbnail tests correctly 2020-05-19 11:04:02 +01:00
David Taylor 725e38f9d7 DEV: Allow plugins to request topic thumbnail sizes (#9828) 
In plugin.rb, you can register new sizes like

```
register_topic_thumbnail_size [512, 512]
```

For more information about thumbnails see https://github.com/discourse/discourse/commit/03818e642a1ae871bffdc0c39c10f05f0b8b0398
 2020-05-19 10:38:58 +01:00
dave0688 f2574736a2 FEATURE: Add same site cookie 'None' option to make cross domain systems possible (#9374) 
Previously reverted in cb8f8de4, but can be re-applied now that Rack has been updated
 2020-05-19 10:33:46 +01:00
Joffrey JAFFEUX 1647ba4624 FIX: applies flex on topic-footer-main-buttons (#9829) 2020-05-19 11:29:38 +02:00
Joffrey JAFFEUX 7b7c0ef52f DEV: removes brittle test (#9826) 2020-05-19 10:02:40 +02:00
Joffrey JAFFEUX 3623a395dc UI: refinements to topic footer buttons (#9780) 2020-05-19 09:51:34 +02:00
Martin Brennan 779dc30d2e FIX: Join bookmarks migration on users to avoid missing user records 
* the post_actions table has no FK to users, so if a user has been
  deleted we may end up with dangling post_action records, which then
  interferes with the bookmarks migration because bookmarks DO have
  an FK to users
 2020-05-19 16:31:05 +10:00
Guo Xiang Tan 062cb1e1cb UX: Remove caret from notifications-button. 2020-05-19 13:41:13 +08:00
Kris 864fb45ff0 Improve mobile friendliness of crawler view 2020-05-19 00:24:17 -04:00