IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-07-29 15:54:48 -05:00
Code Issues Packages Projects Releases Wiki Activity
52,479 Commits 932 Branches 570 Tags
13735f35fb026a2dab8576957c00eecac7ca839e
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jarek Radosz b43bba7dd7 UX: Improve border-radius stuff in chat-message actions (#25129) 2024-01-04 12:33:07 +01:00
Jarek Radosz b9f6e6d637 DEV: Skip flaky specs (#25111) 
Dynamically adding and removing deprecated or TL-related site settings in specs is leaky
 2024-01-03 12:32:26 +01:00
Jarek Radosz e18bb6e9fb DEV: Bump the content-tag patch (#24990) 2023-12-20 18:59:33 +01:00
Jarek Radosz c2617c25bb DEV: Update rbtrace to 0.5.1 (#24964) 2023-12-19 20:59:21 +01:00
Jarek Radosz 6d7dd658a4 DEV: Update rubocop-discourse to 3.6.0 (#24945) 2023-12-18 13:44:36 +01:00
Jarek Radosz 157a2fce1b DEV: Update actions/upload-artifact to v4 (#24943) 2023-12-18 11:47:22 +01:00
Jarek Radosz 8207e59c00 DEV: Remove unused code (#24915) 
`input:focus + label.alt-placeholder` css is used for styling active input's label
 2023-12-18 11:26:38 +01:00
Jarek Radosz 9f00c16a7a DEV: Make DatePicker placeholder customizable (#24911) 2023-12-15 03:28:57 +01:00
Jarek Radosz 057778b710 DEV: Update content-tag to 1.2.1 (#24888) 2023-12-14 12:00:36 +01:00
Jarek Radosz 8355664c82 FIX: Don't use :true/:false symbols (#24861) 
on line 252 `has_children` is set to true/false (actual booleans) which means `has_children?` was in some cases returning incorrect value…
 2023-12-13 00:27:14 +01:00
Jarek Radosz 607c530252 DEV: Remove ruby 1.9/2.0 benchmark (#24862) 2023-12-13 07:22:15 +08:00
Jarek Radosz 41942357ed DEV: Use class attribute instead of @class arg (#24804) 2023-12-12 13:09:05 +01:00
Jarek Radosz 86b9e784dc DEV: Re-enable browser read timeout in specs (#24844) 
Turns out there's an easier (and properly working) way to do this!

See: https://github.com/teamcapybara/capybara/blob/52eaecea6d154b7d664b0032cd1cbcad4788fe65/lib/capybara/selenium/driver.rb#L68C42-L68C42
 2023-12-12 12:29:23 +01:00
Jarek Radosz 5140caf0e4 DEV: Update actions/labeler to v5 (#24835) 2023-12-12 09:27:58 +08:00
Jarek Radosz 3999f3e826 DEV: Convert PreferenceCheckbox to gjs (#24817) 2023-12-11 22:03:03 +01:00
Jarek Radosz 81de91751e DEV: Remove incorrect "for" attributes (#24805) 
(and correct some html whitespace)
 2023-12-11 15:44:38 +01:00
Jarek Radosz cc74bcdc85 DEV: Correct i18n helper invocation case (#24806) 2023-12-11 15:44:28 +01:00
Jarek Radosz 601510f730 DEV: Increase per-spec timeout to 45s (#24798) 2023-12-08 21:14:41 +01:00
Jarek Radosz b4f65540f2 DEV: Update Gemfile.lock (#24797) 
After 28956a5415 merge
 2023-12-08 15:05:52 -05:00
Jarek Radosz 5b91dc1844 DEV: Set a browser read timeout in capybara (#24757) 2023-12-07 23:46:20 +01:00
Jarek Radosz 694b5f108b DEV: Fix various rubocop lints (#24749) 
These (21 + 3 from previous PRs) are soon to be enabled in rubocop-discourse:

Capybara/VisibilityMatcher
Lint/DeprecatedOpenSSLConstant
Lint/DisjunctiveAssignmentInConstructor
Lint/EmptyConditionalBody
Lint/EmptyEnsure
Lint/LiteralInInterpolation
Lint/NonLocalExitFromIterator
Lint/ParenthesesAsGroupedExpression
Lint/RedundantCopDisableDirective
Lint/RedundantRequireStatement
Lint/RedundantSafeNavigation
Lint/RedundantStringCoercion
Lint/RedundantWithIndex
Lint/RedundantWithObject
Lint/SafeNavigationChain
Lint/SafeNavigationConsistency
Lint/SelfAssignment
Lint/UnreachableCode
Lint/UselessMethodDefinition
Lint/Void

Previous PRs:
Lint/ShadowedArgument
Lint/DuplicateMethods
Lint/BooleanSymbol
RSpec/SpecFilePathSuffix
 2023-12-06 23:25:00 +01:00
Jarek Radosz 8623631a06 DEV: Fix random typos (#24756) 2023-12-06 22:25:26 +01:00
Jarek RadoszandJoffrey JAFFEUX 6eb1cadb73 DEV: Fix RSpec/SpecFilePathSuffix / enable 3 chat spec files (#24750) 
* RSpec/SpecFilePathSuffix
* removes failing specs
* More specific selectors?

---------

Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
 2023-12-06 22:25:11 +01:00
Jarek Radosz 6a66dc1cfb DEV: Fix Lint/BooleanSymbol (#24747) 2023-12-06 13:19:09 +01:00
Jarek Radosz 138bf486d3 DEV: Fix Lint/DuplicateMethods (#24746) 2023-12-06 13:18:34 +01:00
Jarek Radosz 4280c01153 DEV: Fix Lint/ShadowedArgument (#24733) 2023-12-06 13:16:10 +01:00
Jarek Radosz 7196613e2e DEV: Fix various spec linting issues (#24672) 
Duplicated specs, incorrect descriptions, incorrect assertions, incorrect filenames, old todo
 2023-12-04 13:45:19 +01:00
Jarek Radosz e0c876696a DEV: Fix some qunit linting issues (#24686) 
`qunit/literal-compare-order`
`qunit/no-compare-relation-boolean`
`qunit/assert-args`
 2023-12-04 13:32:16 +01:00
Jarek RadoszandDavid Taylor 2029777b86 DEV: Replace AdminWrapper with body-class/html-class (#24683) 
AdminWrapper isn't used (directly) in all-the*

Co-authored-by: David Taylor <david@taylorhq.com>
 2023-12-04 12:53:07 +01:00
Jarek Radosz 74011232e9 FIX: Request html when fetching inline onebox data (#24674) 
We do expect to receive html
 2023-12-04 11:36:42 +10:00
Jarek Radosz 8cf13977a1 DEV: Fix or disable various lint rules (#24630) 
A grab bag of smaller issues (constructor-super, no-fallthrough, ember/no-private-routing-service, no-unreachable, no-async-promise-executor)
 2023-11-29 15:14:53 +01:00
Jarek Radosz 7cac167928 DEV: Fix "ember/no-empty-glimmer-component-classes" lint (#24629) 2023-11-29 15:14:30 +01:00
Jarek Radosz 0f7e4d2eaa DEV: Convert input-tip to gjs (#24624) 2023-11-29 13:00:36 +01:00
Jarek Radosz d38360b23f DEV: Fix ember/no-private-routing-service (#24009) 2023-11-29 12:26:52 +01:00
Jarek Radosz cbe772f6fa DEV: Fix router linting errors (#24012) 
`ember/no-unnecessary-route-path-option`
`ember/routes-segments-snake-case`
 2023-11-29 12:26:31 +01:00
Jarek Radosz d7f618807e DEV: Don't warn about clearing tmp/cache (#24602) 
No reason to print it out every time 😅 (plus, use the ruby method)
 2023-11-28 18:02:27 +01:00
Jarek Radosz 2a3418fe24 DEV: Don't use the deprecated createEvent() (#24601) 2023-11-28 15:05:51 +01:00
Jarek Radosz 9d44d833d5 DEV: Remove unnecessary getURL() calls (#24591) 
`ajax()` already uses it
 2023-11-28 14:32:15 +01:00
Jarek Radosz 0cad82ef55 DEV: Update click-track tests (#24597) 2023-11-28 13:54:30 +01:00
Jarek Radosz 4953bced64 DEV: Remove unused searchTags param (#24590) 2023-11-28 10:56:36 +01:00
Jarek Radosz 4c7793940a DEV: Fix "no-dupe-keys" lint (#24589) 2023-11-28 10:55:52 +01:00
Jarek Radosz e9356c2ec9 DEV: Fix "no-empty" lint (#24588) 2023-11-28 10:55:02 +01:00
Jarek Radosz 70dc6bcfd3 DEV: Fix "no-unsafe-finally" lint (#24587) 2023-11-28 10:54:13 +01:00
Jarek Radosz 916e1371b3 DEV: Fix "ember/no-global-jquery" lint (#24586) 2023-11-28 10:53:38 +01:00
Jarek Radosz 22210a9c15 DEV: Fix "no-setter-return" lint (#24585) 2023-11-28 10:49:49 +01:00
Jarek Radosz cfa7dcaf0a DEV: Remove unnecessary await settled() (#24584) 2023-11-28 10:45:20 +01:00
Jarek Radosz b2dfc320aa DEV: Fix super calls in native chat classes (#24583) 2023-11-28 10:44:47 +01:00
Jarek Radosz a80e32fe75 DEV: Fix no-extra-boolean-cast lint (#24582) 2023-11-28 10:37:23 +01:00
Jarek Radosz cd69891b14 DEV: Fix no-unnecessary-curly-parens lint rule (#24581) 2023-11-28 10:35:36 +01:00
Jarek Radosz 103fab37e3 DEV: Fix no-unnecessary-curly-strings lint rule (#24580) 2023-11-28 10:35:09 +01:00
Jarek Radosz b1e43425bf DEV: Don't use attrs (#24323) 2023-11-27 12:16:31 +01:00
Jarek Radosz 24532653e6 FIX: A typo bug in an import script (#24553) 2023-11-25 18:10:42 +01:00
Jarek Radosz 68960b26be DEV: Consistently use kebab-case in service lookups (#24552) 2023-11-25 18:10:10 +01:00
Jarek Radosz 3912a2dc24 DEV: Don't reload looping tests when cancelling (#24551) 2023-11-25 18:09:36 +01:00
Jarek Radosz 1da4e1be0a DEV: Convert relative-time-picker to gjs (#24324) 2023-11-24 14:16:17 +01:00
Jarek Radosz e98ac4736e DEV: Add "loop until failure" feature to QUnit (#24545) 2023-11-24 13:15:43 +01:00
Jarek Radosz 1f2a25331b DEV: Fix settledState debug message (#24544) 
A properly formatted string instead of circular-JSON error
 2023-11-24 12:18:28 +01:00
Jarek Radosz ec03db7199 DEV: Stringify settledState debug info (#24526) 
So it actually shows up in CI (in a form other than `[Object object]`)
 2023-11-23 13:29:04 +00:00
Jarek Radosz 89bd2b7df0 DEV: Remove unnecessary js: true options from specs (#24463) 2023-11-20 17:22:14 +01:00
Jarek Radosz 8968887e24 DEV: Fix various typos (#24461) 
November 2023 edition
 2023-11-20 16:49:49 +01:00
Jarek Radosz 1a43010603 DEV: Add selectText option to auto-focus modifier (#24458) 2023-11-20 14:53:20 +01:00
Jarek Radosz e56005b783 DEV: Remove category-macro (#24395) 
This discourse-common decorator was dependent on the core app, hence creating a circular reference that was breaking the embroider upgrade. (see: #24391)
 2023-11-16 00:16:19 +01:00
Jarek Radosz 1e1bb45b96 FIX: Add a missing service injection (#24341) 
Fixes the reorder-categories modal.
 2023-11-13 01:31:04 +01:00
Jarek Radosz daf7608905 DEV: Migrate reorder-categories to the new modal API (#24209) 2023-11-08 16:28:53 +01:00
Jarek Radosz 1c8eaa9390 DEV: QUnit CSS tweaks (#24180) 
1. Prevent a white background flash
2. Dark-mode support for two more inputs
 2023-10-31 14:53:42 +01:00
Jarek Radosz 231e02446b DEV: Add a basic account creation system spec (#24179) 2023-10-31 14:53:24 +01:00
Jarek Radosz dbb532bae7 FIX: Full name validation regression (#24178) 
Regressed in 351cbab1a8
 2023-10-31 14:44:27 +01:00
Jarek Radosz bbcf8e421c DEV: Migrate associate-account-confirm to the new modal API (#24138) 
(+ glimmer)
 2023-10-31 11:45:14 +01:00
Jarek Radosz 360289e108 FIX: Account creation regression (#24169) 
Regressed in 351cbab1a8
 2023-10-31 02:05:35 +01:00
Jarek Radosz 08deedfd6e FIX: autotracking.mutation-after-consumption (#24164) 2023-10-31 00:39:52 +01:00
Jarek Radosz 351cbab1a8 DEV: Migrate create-account to the new modal API (#24098) 
plugin/theme-breaking changes:

1. `controller:create-account` is gone (use `component:modal/create-account` in modifyClass, **if** absolutely necessary)
2. `create-account-body` css class is gone (target `.d-modal.create-account` or any of the inner classes: `.modal-outer-container`, `.modal-middle-container`, `.modal-inner-container`, or `.modal-body`)
 2023-10-30 11:01:09 +01:00
Jarek Radosz 125c19e8f7 FIX: Username validation in create-account modal (#24114) 
* Move the create account test
* Clean up username-validation
* Fix the username validation bug
 2023-10-26 20:38:34 +02:00
Jarek Radosz 00dc063d40 FIX: Restore support for custom NavItem class (#24113) 
A followup to 930dc38500
 2023-10-26 18:26:36 +02:00
Jarek Radosz 125ab9f31d UX: Update user field styling in the create-account modal (#24091) 
1. Removes accidental bold from `text` and `multiselect` labels/placeholders
2. Adds the animated label/placeholder combo to `multiselect`
3. Makes the `multiselect` placeholder lighter to match other fields
4. Makes the `dropdown` values darker to match other fields
5. Removes the extra 5px spacing before `confirmation` fields
 2023-10-25 13:03:20 +02:00
Jarek Radosz 2f1acbb12d DEV: Convert user-field to gjs (#24082) 2023-10-24 20:28:47 +02:00
Jarek Radosz 930dc38500 DEV: Convert nav-item to gjs (#24076) 2023-10-24 17:55:09 +02:00
Jarek Radosz 9a497d9e22 DEV: Move toggleAnonymous out of app route (#24077) 2023-10-24 17:54:56 +02:00
Jarek Radosz b3caa90f6e DEV: Check for mobile upload button presence (#24059) 
If rendering would break before `_bindMobileUploadButton` - this would fail too, obscuring the original issue.
 2023-10-23 23:14:17 +02:00
Jarek Radosz c84fe69e10 DEV: Use @discourse/lint-configs (#24038) 2023-10-23 12:08:35 +02:00
Jarek Radosz e31859a33a FIX: Correctly set categoryId on Composer model (#23934) 2023-10-19 10:19:40 -07:00
Jarek Radosz 24dc36cf91 DEV: Fix ember/require-super-in-lifecycle-hooks (#24007) 
and `ember/no-ember-super-in-es-classes`
 2023-10-19 13:47:45 +02:00
Jarek Radosz ac30673b98 DEV: Fix ember/no-settled-after-test-helper (#24008) 2023-10-19 13:47:28 +02:00
Jarek Radosz b45720b158 DEV: Fix ember/no-incorrect-calls-with-inline-anonymous-functions (#24010) 2023-10-19 13:47:01 +02:00
Jarek Radosz 754d13f5fa DEV: Fix ember/require-valid-css-selector-in-test-helpers (#24011) 2023-10-19 13:46:48 +02:00
Jarek Radosz 23af6c23d0 DEV: Fix ember/prefer-ember-test-helpers (#24013) 2023-10-19 13:46:28 +02:00
Jarek Radosz 16d16c8969 DEV: Precompile the transpiler before themes:update (#23997) 2023-10-19 01:00:23 +02:00
Jarek Radosz 75c9635d8b DEV: Remove the transpilation message (#23998) 2023-10-19 01:00:15 +02:00
Jarek Radosz dca23d3a53 DEV: Group @types/* updates (#23992) 2023-10-19 00:01:16 +02:00
Jarek Radosz a5858e60e1 FIX: Transitioning to tag-intersection route (#23931) 
…didn't correctly update location query params.

A followup to 1df3ccc903 (things broke after merging `main` to PR's branch)
 2023-10-13 16:23:04 +01:00
Jarek Radosz 1df3ccc903 FIX: Pass category param on /tags/intersection (#23352) 2023-10-13 02:42:41 +02:00
Jarek Radosz 90743f162a DEV: Add a plugin outlet for conditional-loading-spinner (#23911) 2023-10-12 17:53:53 +02:00
Jarek Radosz 53c9c9c1e6 FIX: Fetch csrf token if needed before uploading (#23825) 2023-10-09 15:47:36 +02:00
Jarek Radosz 81de02525f DEV: Update the content-tag patch (#23840) 2023-10-09 12:01:58 +02:00
Jarek Radosz 484004fc5e DEV: Use Session service rather than singleton (#23813) 
(where applicable)
 2023-10-06 17:14:31 +02:00
Jarek Radosz 2c490773f1 FIX: Always use the current session token in uppy (#23812) 
…rather than the value at the time when uppy is initialized.

Future TODO: extract csrf-fetching logic from ajax helper to Session service.
 2023-10-06 15:26:39 +02:00
Jarek Radosz bd52b1ec7b FIX: Embroider breaking index html structure (#23811) 
The custom html elements we were using for bootstraping were causing Embroider to end the `<head>` tag and immediately start `<body>`. As a result most of `<meta>` tags ended up in the `<body>`.

That mean (among possibly other issues) that the app did not have CSRF token set properly on launch (in the development env)
 2023-10-06 13:41:47 +02:00
Jarek Radosz a27823fd3c DEV: Correctly test post-cooked "widget" (#23806) 
It's a special case widget - its constructor has different contructor arguments:

```js
export default class PostCooked {
  constructor(attrs, decoratorHelper, currentUser) {
...
```

vs

```js
export default class Widget {
  constructor(attrs, register, opts) {
...
```
 2023-10-05 22:19:54 +02:00
Jarek Radosz 8a6aaf9446 DEV: Convert user-status modal to a glimmer component (#23798) 2023-10-05 21:22:28 +02:00
Jarek Radosz 4db41ed28a DEV: Do not manually create app-events on models (#23799) 2023-10-05 21:22:16 +02:00
Jarek Radosz 8421327845 DEV: Format UserStatus#ends_at as a ISO8601 timestamp (#23796) 
…as we do when publishing a mesage bus update: https://github.com/discourse/discourse/blob/07c93918ecbc82cda6cd9a079f27cfed432bcb7e/app/models/user.rb#L871-L871
 2023-10-05 20:41:12 +02:00