Commit Graph
100 Commits
Author SHA1 Message Date
Sam 14310d2eee UX: title in JS must match title on Server
Corrects title flashing with incorrect value on front page reloads
2017-10-04 15:04:42 +11:00
Sam a4d4db4f0c PERF: code not correctly caching git commands
Every check for Discourse version could result in shelling out.
2017-10-04 14:22:38 +11:00
Sam 4ee2fcd3d5 correct flaky spec 2017-10-04 10:47:24 +11:00
Sam 5b96463c40 in production there is no cached it seems 2017-10-03 18:27:09 +11:00
Sam ac01885b60 FEATURE: rake tasks for uploading assets to S3
This opens the door to serving application.js and so on from s3.

Also updates s3 gem for some tagging support
2017-10-03 18:00:53 +11:00
Sam eaa896d8ee FIX: not serving non brotli cdns from cdn_url
(this means that access control allow origin could break)
2017-10-03 11:20:08 +11:00
Sam 9fa575dca1 Update message bus
This corrects a rare race condition.
2017-10-02 15:21:45 +11:00
Sam 8f7062bd7b FEATURE: reduce API key permission to TL0 2017-10-02 10:59:55 +11:00
Sam 41261b32a5 FIX: update message bus
- Corrects broken short polling
- Corrects after fork
2017-09-29 16:58:12 +10:00
Sam 0358931b9f correct erratic spec 2017-09-29 12:58:15 +10:00
Sam f6fdc1ebe8 FEATURE: flexible crawler detection
You can use the crawler user agents site setting to amend what user agents
are considered crawlers based on a string match in the user agent

Also improves performance of crawler detection slightly
2017-09-29 12:31:50 +10:00
Sam 05dd97ffe0 correct iPad sizing 2017-09-29 11:49:10 +10:00
Sam b2575a8ce3 improve keyboard height detection 2017-09-28 21:25:03 +10:00
Sam cfed431ef2 More height hacks for iPhone 2017-09-28 18:06:00 +10:00
Sam d36d5ba8ac Correct iPad fudge factors for keyboard size detection 2017-09-28 17:26:54 +10:00
Sam 8ecf313a81 FIX: correctly raise errors when downloads fail
This corrects an issue where we are hitting Gravatar for 404 over and over

Also ensures file download properly reports errors
2017-09-28 16:35:43 +10:00
Sam b80320da5e no verbose logging for failed downloads of gravatars 2017-09-28 11:32:26 +10:00
Sam a311dd06fe UX: mess with iPad and iPhone sizing to compensate for keyboard
iOS still has no mechanism for figuring out how big the keyboard is, so
we fudge it.
2017-09-27 16:50:28 +10:00
Sam Saffron 4cef3cd762 move fix to top of test 2017-09-01 13:12:47 -04:00
Sam Saffron 936582b8d1 Correct flaky spec
Can fail if the machine running tests has less that 10% free space
2017-09-01 13:10:01 -04:00
Sam Saffron 46ebd0ee40 correct spec and allow for zero allowed iframes 2017-09-01 12:08:55 -04:00
Sam Saffron e283e6aea0 FEATURE: allowed_iframes site setting for allowing iframes
This allows you to whitelist custom iframes if needed in posts
2017-09-01 10:15:44 -04:00
Sam Saffron 7f8a90ef63 remove non english comment 2017-08-31 17:00:37 -04:00
Sam Saffron 3bdade8970 correct fragile spec 2017-08-31 15:55:56 -04:00
Sam Saffron 85ff6b8083 hold back on dropping email for now 2017-08-30 10:40:49 -04:00
Sam 9a861c1b43 Correct previous commit
Selector was way too wide
2017-08-29 16:51:57 -04:00
Sam 5cdb486332 UX: large topic creation area on mobile
This refines the iOS hack and allows for height 100%
on the composer

Also removes annoying box shadows
2017-08-29 15:45:02 -04:00
Sam 04e3526096 Only remove default locale which is the only column we touch
see: https://meta.discourse.org/t/failing-tests-in-discourse-dev-due-to-multisite/68720/5
2017-08-29 14:02:24 -04:00
Sam c705159d22 Remove email column from user table 2017-08-29 11:50:56 -04:00
Sam b3fd091379 annotate stuff 2017-08-29 10:48:22 -04:00
Sam 50203794e6 FIX: staged users should get emails on must_approve_users sites 2017-08-28 17:32:07 -04:00
Sam 41e7bdff38 FIX: don't refresh notifications in a tight loop 2017-08-28 16:52:00 -04:00
Sam 9f0f086b3e FEATURE: allow API to mark accounts as approved on creation 2017-08-28 15:36:46 -04:00
Sam e282f10d94 defer drop alias_level 2017-08-28 13:26:13 -04:00
Sam 552fbd3c8d lint 2017-08-28 12:25:34 -04:00
Sam 6e1809ce32 add a debugging task for running all schedules 2017-08-25 12:19:34 -04:00
Sam fef08c6fee FEATURE: rake db:stats
Basic rake task to provide db stats like largest tables, row count and size
2017-08-25 10:29:04 -04:00
Sam 237968b1b7 PERF: add an index on slug to make sure that slug lookups are quick 2017-08-24 13:33:25 -04:00
Sam bcbee91f0c lint 2017-08-24 13:24:52 -04:00
Sam f60a1b0275 correct erratic spec 2017-08-24 13:19:26 -04:00
Sam a4e3e081c9 correct spec 2017-08-24 10:40:14 -04:00
Sam fdc5c080ea FIX: bump default max for int site settings to a much higher number
(close to long int)
2017-08-24 10:16:41 -04:00
Sam f766ea4257 Correct short url decoding for sha1s leading with zero
This was picked up cause we had a flaky test!
2017-08-23 11:08:18 -04:00
Sam c7532003f3 add more diagnostics for flaky spec 2017-08-23 10:41:57 -04:00
Sam 8dfb1be4d1 FEATURE: unlisted *only* means not listed in topic lists
Remove security by obscurity feature that tries for exact slug match

If you need to hide a topic from users either move to a secure category
or convert to a PM
2017-08-22 17:53:54 -04:00
Sam e8cdb1d8a7 correct flaky spec 2017-08-22 16:54:29 -04:00
Sam d7a2584c6e FEATURE: image uploads now have short urls
Shorten all image uploads to use short urls, this is the client
side implementation.
2017-08-22 16:40:08 -04:00
Sam 117ce24ac3 Correct a flaky spec 2017-08-22 13:56:38 -04:00
Sam ce8030716f FIX: broken badge show page 2017-08-22 13:28:02 -04:00
Sam d4c28f6fcb remove stray puts from spec 2017-08-22 11:46:51 -04:00
Sam bcf7dc38c2 FEATURE: server side support for upload:// markdown
This allows uploads to be specified using short sha1 hash instead of full
URL

Client side change is pending
2017-08-22 11:46:23 -04:00
Sam 505939eab7 correct spec 2017-08-21 14:40:44 -04:00
Sam 2f0c6c99e0 FIX: ip lookup not working
Also add a powered by line so it is clear this makes an external service call
2017-08-21 14:18:49 -04:00
Sam 5c80d4bcdd UX: move close button to bottom and add esc hint. 2017-08-18 15:40:34 -04:00
Sam aeedecd27c correct erratically failing spec 2017-08-18 15:10:37 -04:00
Sam a83bd537f4 FIX: exception in excerpt parser for null nodes 2017-08-17 16:13:30 -04:00
Sam c2a6616035 Correct erratic spec failure 2017-08-17 15:26:31 -04:00
Sam 0c4527323e FIX: queues posts broken for multiple posts 2017-08-17 14:47:09 -04:00
Sam 9246bc3400 support up button from first result 2017-08-17 13:32:30 -04:00
Sam 889b99552a FEATURE: allow ctrl+shift+s to open search 2017-08-17 12:57:08 -04:00
Sam dc4d5677eb FEATURE: use a when search result is focused to add to composer 2017-08-17 12:39:43 -04:00
Sam Saffron aea9db56d4 fix formatting 2017-08-17 08:10:57 -04:00
Sam 91f0f76fb1 update message bus to ruby 2.0 packaged version 2017-08-16 15:05:39 -04:00
Sam 304379d436 FEATURE: up/down arrow will highlight search result
Then you can use enter to visit result.
2017-08-16 14:14:55 -04:00
Sam c68999e128 annotate models
WARNING annotators out there, be to run bin/annotate on RAILS_ENV=test on a clean db
2017-08-16 10:38:11 -04:00
Sam Saffron 56f7b4e01e PERF: reindex search data without loading large post counts 2017-08-16 08:18:59 -04:00
Sam Saffron d27e81a296 Perf: update message_bus to latest 2017-08-16 07:50:12 -04:00
Sam 6002f2ca4a FIX: not splitting words correctly for search tokenizer 2017-08-14 16:19:39 -04:00
Sam 43c0111ca1 FIX: multichoice poll with more than 25 votes
In the past we would double up on avatars due to incorrect logic for
handling offset
2017-08-14 15:33:59 -04:00
Sam 5942ad83c0 Skip inline onebox for domain only 2017-08-02 17:27:58 -04:00
Sam 902be91a5a FEATURE: CTRL+/ to trigger search even from composer 2017-08-02 16:26:03 -04:00
Sam a4e1920604 FIX: inline oneboxer not applying to lists 2017-08-02 16:10:08 -04:00
Sam f6bc572fb8 FEATURE: option to enable inline oneboxes for all domains
Also, change to prefer title over open graph which is often way too sparse
2017-08-02 14:27:31 -04:00
Sam 97fa64d846 FIX: non tag/category # searches should be passed through 2017-08-01 18:15:14 -04:00
Sam 71ad3a48c2 Correct flaky distributed cache test
make distributed cache more testable
2017-08-01 16:11:48 -04:00
Sam cdf7a020c1 correct mistake in spec 2017-07-31 16:40:59 -04:00
Sam 56fd3e1cd4 attempt to stablise flaky spec 2017-07-28 16:59:37 -04:00
Sam a13d146251 Correct post deletion spec so it is async 2017-07-28 10:50:18 -04:00
Sam 64d54bc549 FIX: when quoting add a newline
so **highlight** > quote

Does not end like:

[quote]
test
[quote]~
2017-07-28 10:49:49 -04:00
Sam ae68795d82 FIX: deleting own post results in error 2017-07-28 10:14:11 -04:00
Sam 4f574e7c93 FEATURE: support inline bbcode blocks eg: [quote]test[/quote] 2017-07-27 17:55:17 -04:00
Sam dc42d4411d correct flaky spec 2017-07-26 13:22:19 -04:00
Sam 2d41c5ed3c missing bracket 2017-07-26 13:11:08 -04:00
Sam 68d09e8315 noturbo bench added 2017-07-26 12:41:19 -04:00
Sam 9d774a951a Update libv8 and benchmark 2017-07-26 10:59:41 -04:00
Sam 658c2f52c0 add diagnostics for flaky test 2017-07-25 17:09:13 -04:00
Sam ad8643bfe2 attempt to stablise spec in travis 2017-07-25 16:58:19 -04:00
Sam ccbcbd0343 remove 2 failures that happen if discobot booted 2017-07-25 16:08:03 -04:00
Sam a20bb931b1 FIX: specs failed if discourse-push-notifications booted 2017-07-25 15:52:53 -04:00
Sam ec2506c32b Merge pull request #4996 from ryantm/patch-2
safely call html_safe on category description
2017-07-25 15:34:07 -04:00
Sam 17d56a4cb7 FEATURE: use Markdown for image pasted in as opposed to IMG tags 2017-07-25 15:11:38 -04:00
Sam 0d66a41753 Merge pull request #4989 from begrif/html-safe-category-desc
Stop Rails from escaping the HTML in this description.
2017-07-25 13:41:30 -04:00
Sam 8317fb12e0 FIX: don't escape html of poll options 2017-07-25 13:38:19 -04:00
Sam 400a55eca3 Merge pull request #4995 from davidtaylorhq/qunit-warmup
Improve “server warmup” check for qunit rake task
2017-07-25 11:39:32 -04:00
Sam f2d5bcd439 Stop writing to STDOUT/ERR during tests 2017-07-25 11:37:25 -04:00
Sam c5b5c861f6 extend wait_for in case redis chokes up in test 2017-07-25 11:29:12 -04:00
Sam 283d42d6f3 FEATURE: allow bisect and rspec seed 2017-07-25 11:09:51 -04:00
Sam Saffron c86028f9a5 remove poinless fails from CI
rails master is simply not working now at all, no point testing with it
2017-07-25 09:57:32 -04:00
Sam 4da98cdcfe FIX: allow bbcode to be unquoted for default 2017-07-24 18:36:17 -04:00
Sam 04eac9f14a lets attempt to get these specs working! 2017-07-24 18:35:20 -04:00