When a modal is opened as part of a reviewable action, we automatically mark a reviewable as claimed, so that other site staff won't accidentally start working on that reviewable. If the modal is cancelled out of, however, we weren't removing the claimed flag.
Reorganized post metadata rendering using a Directed Acyclic Graph (DAG)
structure to allow plugins to add, delete, replace or reorder metadata
components.
This commit is applying different techniques to make selecting text of a
post less error prone:
- ensure we only ever show the toolbar when the common ancestor of a
range is cooked
- ensures the menu is not interfering with text selection
The situation was very bad on android but it should also improve other
devices.
Note that one visual change of this commit is that the fast edit menu is
now a standalone modal.
Followup 4fe85fdb53
It's not ideal, but currently the admin-sidebar modifies ADMIN_NAV_MAP,
and the admin search data source relies on this modification to include
plugin pages in search.
This commit removes the cloneJSON added in the previous one and adds a
test to ensure this doesn't regress.
A followup commit will do some refactoring to stop this behaviour of
modifying the global ADMIN_NAV_MAP.
This also enhances the converter step, which stores the Gravatar if it is
set and used. It also fixes the import of uploads which didn't use the
correct user ID.
---------
Co-authored-by: Selase Krakani <849886+s3lase@users.noreply.github.com>
Long ago (~2 years), we had a sidebar section with text content. This
contained "about" content for anonymous visitors. We no longer have this
section so this component is completely unused.
- Refactored the `actions-summary` widget and its related test to
directly use a `post` model instance, ensuring more consistent data
handling. Updated relevant rendering and widget registration logic to
align with the changes.
- Fix displaying the user that deleted the post
- Fix the post action text displayed
The parent component of `ThemeSettingRelativesSelectorComponent`,
`SiteSettingComponent`, has recently been migrated from being a legacy
component to a Glimmer component (in
https://github.com/discourse/discourse/pull/33255), but we missed
updating the child class to use Glimmer's patterns, namely how arguments
are accessed in Glimmer components (`this.args.foo` vs `this.foo`).
There exists a hidden `search_recent_regular_posts_offset_post_id` site
setting which is used to optimize the searching of recent posts through
the use of a partial index. However, we do not want this optimization to
apply when the `before` and `after` advanced search filters are used
since the partial index only contains the most recent posts 1 million
posts and the `before`/`after` filter may be searching for posts that
falls outside of the
most recent posts range.
`SiteSerializer#post_action_types` and `SiteSerializer#topic_flag_types`
both call the `Flag.used_flag_ids` method which executes queries that
becomes very slow on sites with alot of records in either the
`post_actions` or `reviewable_scores` table.
On the `post_actions` table, we execute `SELECT DISTINCT
post_action_type_id FROM post_actions`. On the `reviewable_scores`
table, we execute `SELECT DISTINCT reviewable_scope_type FROM
reviewable_scopes`. The problem with both queries is that it requires
the PG planner to scan through every single row in those tables.
For our use case, all we actually need is to check if a flag is being
referenced by a record in either the `post_actions` or
`reviewable_scores` tables. This commit updates the `Flag.used_flag_ids`
to accept a `flag_ids`
argument and use the argument to check whether the flag ids are
referenced in the `post_action_type_id` or `reviewable_scope_type`
foreign keys.
The `uploads:sync_access_control` rake task should reset the access
control
of all s3 objects linked to an upload record. This means that if the
`s3_use_acls` site setting has been disabled, the rake task should
remove the existing ACL that has been set previously.
Followup 5b236ccc07, a change here
made it so the theme setting name was no longer showing on the
UI, this commit fixes the issue by making sure it's sent from
the server in the same way as site setting humanized names.
Before this change, users were able to see their own whispers even if
they are no longer in the groups specified by the `whispers_allowed_groups` site setting.
This commit fixes that by disallowing users to see their own whispers if
they are no longer part of any `whispers_allowed_groups`.
...so I can override it in a customer plugin.
The goal here is to be able to create the same user data export but
provide the results by uploading to an s3 bucket instead of sending a PM
to the user.
This PR allows `bypass_time_window` to be passed to the
`SendPushNotification` job, to continue sending a PN, even if the user
has been active recently.
Previously, there was no way to edit post localizations, so the
`post.raw` was always returning the localized value. With localization
UI and endpoints now, we want to always return the original raw and the
composer to reflect the original value.
https://github.com/discourse/discourse/pull/33184 will handle the
decision to show the post edit composer or the post localization
composer.
Also fix some issues in the source, wasn't returning a promise
with the early return.
Saw this in the CI log failures:
> ℹ️ Hint: when the assertion failed, the Ember runloop was not in a
settled state. Maybe you missed an `await` further up the test? Or maybe
you need to manually add `await settled()` before your assertion?
(hasPendingTimers, hasRunLoop, isRenderPending)
Renato Atilio
Gary Pendergast
Sam
dependabot[bot]anddependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sérgio Saquetim
Guhyoun Nam
Chris Alberti
Selase Krakani
Joffrey JAFFEUX
Martin Brennan
Jarek Radosz
Gerhard SchlagerandSelase Krakani
Kris
Penar MusarajandBlake Erickson
Osama Sayegh
chapoi
Alan Guo Xiang Tan
zogstrip
Mark VanLandingham
Discourse Translator Bot
Natalie Tay