In the past we have always relied on automatically opening the composer
and auto loading the existing draft when visiting a topic that has a
draft post reply. This is fine to auto load the draft, but when the
composer is closed and reopened on the same page then we have an issue.
The result is that the draft is then deleted because the draft key is
set and the composer body is blank, since it has never been populated
when clicking the reply to post button.
To solve this we can check for existing drafts when clicking the reply
to post button, then load the draft into the composer.
_The challenging part of this change is that we have a number of tests
that were relying on a false positive. Hence in the specs I have
switched some tests to use a fixture that does not have drafts and in
some cases kept the same fixture but mocked the response as having no
drafts returned._
This changes allows the `/my/` prefix redirect to work when the name
param contains uppercase letters.
#### For example:
`/my/messages/group/MyGroup` now redirects to
`/u/username/messages/group/MyGroup`
We want to add an option for admins to carry out the operation silently
when they are updating the category for the selected topics. When the
“Perform this action silently” checkbox has been checked, the
`:notify_category_change sidekiq` job should not be enqueued.
When we are tracking requests in the `Middleware::RequestTracker`, we
have historically added an `X-Discourse-TrackView` response header
for implicitly tracked requests HTML requests, and also explicitly
tracked page view requests when navigating the Ember app.
Within the past couple of years, we introduced the concept of
Browser Page Views (BPVs), which are recorded when requests are made
via AJAX when navigating the app with Ember, and also piggybacked
onto the first MessageBus request on page load. The former is known
as an explicitly tracked request, the latter is a deferred tracked request.
The explicitly tracked browser page views also add the `X-Discourse-TrackView`
header to the response, so it is hard to differentiate which requests are purely
browser page view requests in the logs.
This commit adds a new response header, `X-Discourse-BrowserPageView`,
that acts in a similar way to the existing `X-Discourse-TrackView`
header, but is specifically for requests that are tracked as BPVs (both explicit
and deferred).
**Description**
Changes introduced previously on this
[PR](https://github.com/discourse/discourse/pull/33055) are reverted in
order to improve code and add flexibility to the user notifications
emails pipeline
It's possible for different source files to generate the same compiled
output (e.g. if only a comment changes), so we should include the
sourcemap content when calculating a digest.
Extracted from #33103
1. Use separate caches for plugins and core
2. Don't load plugins in non-plugin jobs
3. Propagate LOAD_PLUGINS to all steps
4. Check annotations of plugin models
5. Update outdated annotations
The Content section in particular has four tabs which are all site setting pages. It does not have one under /settings, like other sections.
The admin search functionality will automatically use /settings for multi-tabbed sections. This results in a 404 when searching for Content site settings.
This PR adds a front-end redirect (replaceWith) for /content/settings to fix the immediate issue.
This is the first in a series of PRs aimed at organizing the guardians and their tests a bit better to make them more discoverable and reduce the amount of "pinballing" around looking for the relevant methods.
There is no change to any functionality, and the tests have been copied over as-is, except where fixture variables needed renaming to fit in the new spec file.
Uses the following shortcuts for the editor heading toolbar:
* Ctrl + Alt + 1: Heading 1
* Ctrl + Alt + 2: Heading 2
* Ctrl + Alt + 3: Heading 3
* Ctrl + Alt + 4: Heading 4
* Ctrl + Alt + 0: Paragraph
On macOS, substitute `Ctrl` with `Cmd` and `Alt` with `Option`.
Also adds composer shortcuts to keyboard shortcut help modal (?)
This commit make it easier for staff to see if a profile is silenced by
aligning it with how suspended notices are shown.
- The number of times a profile has been silenced is shown in the staff
counters banner at the top of the public user profiles.
- Clicking on the silenced note in the staff counters banner goes to a
filtered view of the staff action logs for the user and the silenced
action.
- The profile indicates if a user is silenced and shows the date they
are silenced until. This looks exactly the same as how it currently
displays for suspended users, with the added info of the date. This is
also displayed on the user card, the same as suspended notices currently
are.
## Screenshots
We don't really want to encourage HTML in the RTE,
and BBCode is pretty technical too, so this commit
simplifies the copy of the placeholder for the RTE
The date control here doesn't have a label:
<img width="608" height="170" alt="image"
src="https://github.com/user-attachments/assets/5517d5d2-f64b-4cf9-aad0-f14152a85ffd"
/>
This adds the label, and also removes the headerAriaLabel from the
before/after dropdown — the dropdown has a label applied elsewhere so
this wasn't doing anything (tested with NVDA)
Adding `alt=""` to tell screenreaders to skip these, we don't reliably
have alt content available for onebox images and they tend to be
decorative, so better to omit.
<img width="738" height="151" alt="learn.microsoft.com onebox with the
link whats new in C# 11, there's a purple C# badge to the left of the
link"
src="https://github.com/user-attachments/assets/15bdc830-683f-4c69-a11b-9d54c66fa627"
/>
We already do this in some oneboxes, so this covers some more cases
including the generic.
Seeing the following in
https://github.com/discourse/discourse/actions/runs/16209614945/job/45767099809?pr=33577
```
The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Error: HttpError: You do not have permission to create labels on this repository.: {"resource":"Repository","field":"label","code":"unauthorized"}
Error: You do not have permission to create labels on this repository.: {"resource":"Repository","field":"label","code":"unauthorized"}
```
Related: https://github.com/orgs/community/discussions/156181
This PR introduces a heading/paragraph dropdown menu for the
composer toolbar, that works for both the new rich text editor, and
the old markdown editor.
Features include:
* Dynamically changing the icon based on the heading level
* Checking the current heading level in the dropdown list
* Applying the same heading level to multiple selections
---------
Co-authored-by: chapoi <101828855+chapoi@users.noreply.github.com>
Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Co-authored-by: Renato Atilio <renatoat@gmail.com>
- Add indexes in some places where we were seeing bottlenecks
- Remove redundant ILIKE query
---------
Co-authored-by: Gerhard Schlager <gerhard.schlager@discourse.org>
Concerns the quote controls:
This improves the title so rather than "expand/collapse" for both states
it represents the current action "expand" or "collapse". This is also
added for aria-label.
I've also added aria-label to the "go to the quoted post" arrow.
When a topic is pinned as a site banner, we include automatically
generated anchor links from the post in the banner's content... but do
not include the anchor functionality from the topic (topic seen below)
<img width="246" height="48" alt="image"
src="https://github.com/user-attachments/assets/6f145875-97a3-401c-bef6-ffd5cd6a22d1"
/>
This means we end up with a 0 dimension link in the banner content,
which is still reachable via keyboard and other forms of navigation. You
can see the outlined link below:
<img width="1097" height="174" alt="image"
src="https://github.com/user-attachments/assets/d5d50892-72f3-4ab8-8a33-2f2eb73fdc3d"
/>
This can be confusing if you're using a screenreader, and the anchor
links don't serve much purpose when included in these banners. Hiding
them with CSS avoids the issue.
This adds some new icon aliases so the lock icon can be overridden in
specific scenarios without applying globally to all locks:
* "topic.closed"
* "topic.opened"
* "category.restricted"
This enables customizations like:
```
import { apiInitializer } from "discourse/lib/api";
export default apiInitializer((api) => {
api.replaceIcon("topic.closed", "xmark");
api.replaceIcon("category.restricted", "shield-halved");
});
```
More documentation on this feature in
https://meta.discourse.org/t/change-icons-globally/87751
The `form-kit` container subtitle doesn't play well with the category
description. The issue experienced appears to be due to the flex
direction.
Since we can only update the category description from the topic and not
within the edit category page, I have moved the description to a
read-only span which follows a similar pattern that we use on other
forms.
followup for #33545
The `z-index: calc(z("mobile-composer") + 1);` (1101) was lower dan the
modal overlay on mobile (1300), which made the menu inaccessible.
it's now scoped to the desktop version of dmenu only, which should
suffice for desktop/tablet usecases.
Addressing some z-index issues with the first use of Dmenu within the
composer:
* z-index need an adjustment on mobile/tablets
* z-index need an adjustment when in fullscreen on desktop
Also limiting the max height on desktop to 30vh to avoid it potentially
scrolling of the page without a way to fix it by resizing composer
height.
Meta report:
https://meta.discourse.org/t/composer-more-menu-partly-hidden-behind-header-and-composer/372859
We want to add the ability to enable/disable users selecting Gravatar for their avatar.
This change adds a site setting to enable/disable the option (default to enabled.) This will prevent users from configuring Gravatars from that point on. It does not affect already configured avatars.
We're also taking this chance to hide some of the advanced settings from the UI.
Kris
David Battersby
chapoi
Kelv
Linca
Krzysztof Kotlarek
Martin Brennan
Juan David Martínez Cubillos
Jordan Vidrine
David Taylor
Jarek Radosz
dependabot[bot]anddependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Ted Johansson
Joffrey JAFFEUX
Sérgio Saquetim
Natalie Tay
Ella E.
Amanda Alves BranquinhoandGerhard Schlager
Renato Atilio