IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-09-05 04:40:41 -05:00
Code Issues Packages Projects Releases Wiki Activity
28,222 Commits 1,018 Branches 579 Tags
1ba8e8948d5c0eb4762fb4f9dcd15bed74afc852
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Guo Xiang Tan 3a8f69c3d2 DEV: Assert for 200 response code to avoid changing magic helper in the future. 2018-06-07 16:11:09 +08:00
Guo Xiang Tan 3533bdb83f Remove line that is no longer required. 2018-06-07 15:56:16 +08:00
Guo Xiang Tan 1d5c176ea5 DEV: docker:test rake task should install plugins first before migrating. 2018-06-07 15:20:06 +08:00
Guo Xiang Tan 49f39ca64d Fix another failing spec. 2018-06-07 15:07:39 +08:00
Guo Xiang Tan 610510ebad Fix broken discourse narrative bot spec after upgrade. 2018-06-07 15:03:09 +08:00
Guo Xiang Tan e51b8d3198 Upgrade puppeteer which was accidentally downgraded. 2018-06-07 14:22:44 +08:00
Guo Xiang Tan ad5082d969 Make rubocop happy again. 2018-06-07 13:28:18 +08:00
Guo Xiang Tan 4782f6cd01 Remove controller type spec for post actions. 2018-06-07 12:45:38 +08:00
Guo Xiang Tan 47ddb3a7ca Merge branch 'wizard-controller' of https://github.com/OsamaSayegh/discourse into OsamaSayegh-wizard-controller 2018-06-07 12:27:48 +08:00
Guo Xiang Tan 2bd905c632 Revert "Upgrade Rails to 5.1.6." 
This reverts commit ab66215f5c.
 2018-06-07 09:49:38 +08:00
Guo Xiang Tan 01f126e38f Simplify unicorn config. 2018-06-07 09:03:16 +08:00
Guo Xiang Tan 78c705f5de Remove migration code that is no longer valid. 2018-06-07 08:57:01 +08:00
Guo Xiang Tan cb9596e196 Remove invalid hosted-site plugin. 2018-06-07 08:49:19 +08:00
Guo Xiang Tan ab66215f5c Upgrade Rails to 5.1.6. 2018-06-07 08:34:36 +08:00
Guo Xiang Tan a50cd8675a FIX: Permalink route matcher should always be last. 2018-06-06 14:55:22 +08:00
Guo Xiang Tan a4e6662833 FIX: Disconnects all connections in the pool before forking. 
* We were leaking connections as a result. Connections opened
  before the fork were never closed.
 2018-06-06 14:45:05 +08:00
Guo Xiang Tan aa5805e8b0 Revert "Initialize the v8 context after forking." 
This reverts commit 41c4e32e64.
 2018-06-06 14:33:20 +08:00
Guo Xiang Tan a83ab01264 REFACTOR: Remove extra param for group mentionable and messableable route. 2018-06-06 09:42:09 +08:00
Guo Xiang Tan bc7d9c61e6 Revert smoke test accidentally default to non headless mode. 2018-06-05 19:21:46 +08:00
Guo Xiang Tan a276ffc7b3 Run smoke test without sandbox for now. 2018-06-05 19:08:36 +08:00
Guo Xiang Tan 32c0ff4831 DEV: Install dependencies before running smoke test. 2018-06-05 18:46:41 +08:00
Guo Xiang Tan 478c86e0a4 DEV: Update preview step to be more reliable. 2018-06-05 16:58:15 +08:00
Guo Xiang Tan 41c4e32e64 Initialize the v8 context after forking. 2018-06-05 11:36:38 +08:00
Guo Xiang Tan c27863aad2 DEV: Better output when assertion fails in smoke test. 2018-06-05 10:54:56 +08:00
Guo Xiang Tan a508e6a5f6 DEV: Stablize requests/search_controller_spec. 2018-06-05 10:07:05 +08:00
Guo Xiang Tan aaea24448e DEV: Add specs for https://github.com/discourse/discourse/commit/085eaaf18d153f8a797921805d5b1c1695627deb. 2018-06-05 10:03:26 +08:00
Guo Xiang Tan d600e71b3d FIX: Clean up stale UserExport records daily. 
* Add tests for `UserExport.remove_old_exports`
 2018-06-05 09:43:40 +08:00
Guo Xiang Tan dcba320bf6 Remove spec that isn't testing for anything. 2018-06-05 09:30:02 +08:00
Guo Xiang Tan 725859ba43 DEV: Test discourse-group-track plugin on travis. 2018-06-01 23:43:43 +08:00
Guo Xiang Tan d57a5d3e8c Fix brittle spec. 2018-06-01 11:56:56 +08:00
Guo Xiang Tan 12a0f12530 Fix the build. 2018-06-01 11:24:32 +08:00
Guo Xiang Tan 9ef61e0af5 PERF: Prefer exists? instead of loading AR object. 2018-06-01 09:44:14 +08:00
Guo Xiang Tan 50be06af47 Remove stale code. 2018-06-01 08:18:59 +08:00
Guo Xiang Tan 7fc8a36529 DEV: Take 2 Queue jobs in tests by default. 
On my machine this cuts the time taken to run our test suite
from ~11mins to ~9mins.
 2018-05-31 16:23:23 +08:00
Guo Xiang Tan 56e9ff6853 Revert "DEV: Queue jobs in tests by default." 
Too risky for now

This reverts commit be28154d3b.
 2018-05-31 15:34:46 +08:00
Guo Xiang Tan 2b783997fa Refactor tests to complete assertions within a single it block. 2018-05-31 15:05:47 +08:00
Guo Xiang Tan be28154d3b DEV: Queue jobs in tests by default. 2018-05-31 14:45:47 +08:00
Guo Xiang Tan 95f9b72351 FIX: Update activation email route was returning a generic json error. 2018-05-31 14:19:43 +08:00
Guo Xiang Tan db4af262dc DEV: Create smoke test screenshot directory in rake task. 2018-05-30 16:20:18 +08:00
Guo Xiang Tan fe5a48997c DEV: Store smoke tests failure image in a dedicated tmp folder. 2018-05-30 15:59:07 +08:00
Guo Xiang Tan 30279a4843 DEV: Allow smoke test failure screenshot path to be configured. 2018-05-30 15:42:46 +08:00
Guo Xiang Tan f623740ffc DEV: Stablize DiscourseRedis tests. 2018-05-30 14:45:19 +08:00
Guo Xiang Tan 77c99b6434 Fix condition in travis. 2018-05-30 14:05:16 +08:00
Guo Xiang Tan 1fe6fd759f Move db migrate on Travis into install step. 
This will allow us to collapse the migration logs.
 2018-05-30 12:30:26 +08:00
Guo Xiang Tan 21e9315416 FIX: Use user account email instead of auth email when totp is enabled. 
https://meta.discourse.org/t/github-2fa-flow-broken/88674
 2018-05-30 12:15:12 +08:00
Guo Xiang Tan 543b7cddfb FIX: Extra comma resulted in Github auth email result being an array. 
https://meta.discourse.org/t/github-2fa-flow-broken/88674
 2018-05-30 12:15:12 +08:00
Guo Xiang Tan c1fb111951 FIX: Show poll options when user is in a PM with a bot. 
https://meta.discourse.org/t/discobot-dont-take-users-through-the-poll-tutorial-if-its-not-enabled/76604/9
 2018-05-30 11:16:20 +08:00
Guo Xiang Tan 81b5d61fa7 FIX: topic_destroyed web hook couldn't find topic. 2018-05-28 17:38:02 +08:00
Guo Xiang Tan 754458e6a2 PERF: Minor but we can just pass a hash to where. 
```
Warming up --------------------------------------
          4 x .where     1.040k i/100ms
          1 x .where     1.677k i/100ms
Calculating -------------------------------------
          4 x .where     10.321k (± 5.2%) i/s -     52.000k in
5.053803s
          1 x .where     17.117k (± 3.8%) i/s -     85.527k in
5.004107s

Comparison:
          1 x .where:    17117.1 i/s
          4 x .where:    10321.3 i/s - 1.66x  slower
```
 2018-05-28 16:41:38 +08:00
Guo Xiang Tan 9788ea9cb7 DEV: Write into Rails's tmp instead of system tmp for somke test screenshot. 2018-05-28 16:14:22 +08:00
Guo Xiang Tan 123a22e6d8 DEV: Clean up omniauth after mocking. 2018-05-28 15:12:54 +08:00
Guo Xiang Tan 2bafd2a355 Don't pin version of Fabrication gem. 2018-05-28 15:09:02 +08:00
Guo Xiang Tan 9d6d161628 DEV: Take screenshot when smoke test fails. 2018-05-28 14:19:43 +08:00
Guo Xiang Tan 0b55416742 UX: Don't display all groups option if group directory is disabled.a 
https://meta.discourse.org/t/all-groups-option-leads-to-access-denied-page/88464
 2018-05-28 11:32:55 +08:00
Guo Xiang Tan 857a4e0006 FIX: Viewport in smoke test configured incorrectly. 2018-05-28 10:58:36 +08:00
Guo Xiang Tan 9f873fa66c FIX: Invalid setex expire time in DiscourseNarrativeBot::Actions#reset_rate_limits. 2018-05-25 16:02:15 +08:00
Guo Xiang Tan 9d307a9977 FIX: Destroy notifications and sync notifications count in transaction. 
* Seeing errors where the user is destroyed right when the call to
  reload is made.
 2018-05-25 12:01:36 +08:00
Guo Xiang Tan 755b511b5c PERF: Destroy collapsed notifications in 1 query instead of 3. 2018-05-25 12:01:36 +08:00
Guo Xiang Tan d43895e2a0 Don't log 404s for FinalDestination. 
* We can't do anything about 404s
 2018-05-25 10:11:16 +08:00
Guo Xiang Tan 58fbe74b6f Remove assertion to_not raise_error. 
If an error is raised the test would fail anyway.
 2018-05-25 09:57:08 +08:00
Guo Xiang Tan 3bfd9698c7 PERF: Avoid running the same query twice in TopicViewSerializer#details. 2018-05-24 16:46:13 +08:00
Guo Xiang Tan 1f27c91924 DEV: Better diagnostic when topic tracking state tests fail. 2018-05-24 15:36:41 +08:00
Guo Xiang Tan 43f7cb05c9 FIX: Broken ping event for web hooks due to missing payload. 2018-05-24 15:16:52 +08:00
Guo Xiang Tan b3860c82da FIX: Don't enqueue web hooks inside a deferred queue. 
* The deferred queue is meant for short lived jobs
  and does not guarantee execution. We need to ensure
  that web hooks are always run.
 2018-05-24 15:03:17 +08:00
Guo Xiang Tan 8a1aab4e8a PERF: Select distinct active web hooks at the db level. 2018-05-24 14:56:40 +08:00
Guo Xiang Tan 2aad91d4a2 PERF: Don't bloat the Sidekiq queue with Jobs::SendPushNotification. 2018-05-24 10:04:09 +08:00
Guo Xiang Tan be49da9105 FIX: Don't silently fail if notification fails to create. 2018-05-24 10:04:09 +08:00
Guo Xiang Tan ae3a7ca08d Fix unexpected return error. 2018-05-21 22:28:44 +08:00
Guo Xiang Tan 37ad2dd936 Fix the build. 2018-05-21 17:59:47 +08:00
Guo Xiang Tan aae5575d33 Remove spec file that was accidentally added. 2018-05-21 17:35:55 +08:00
Guo Xiang Tan 467d91347a Missing specs for Group, Tag, Category and Flag web hooks. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan bf84037f79 FIX: Payload for webhooks should be current as of the time the event was triggered. 
https://meta.discourse.org/t/group-category-tag-user-deleted-webhooks-not-firing/87752
 2018-05-21 17:29:58 +08:00
Guo Xiang Tan cba3942850 Refactor WebHookFlagSerializer. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan f0024f5ec7 Inherit from BasicGroupSerializer for WebHookGroupSerializer. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan 00c6b078e3 Trim WebHookUserSerializer. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan 60e7b13f59 Trim WebHookPostSerializer further. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan 3ff0074e9d Trim WebHookTopicSerializer further. 2018-05-21 17:29:58 +08:00
Guo Xiang Tan e78f1d7589 Fix the build take 2. 2018-05-21 14:35:59 +08:00
Guo Xiang Tan b7b08b4173 Fix regression introduced in https://github.com/discourse/discourse/commit/2ceb1070743f2d0081def11cc06bc3a9d8e7dd0e. 2018-05-21 13:26:23 +08:00
Guo Xiang Tan 2ceb107074 Refactor tests to use the json extension instead of headers. 2018-05-21 09:49:46 +08:00
Guo Xiang Tan 2fecb4b46e FIX: Client not setting TopicTimer#based_on_last_post. 
https://meta.discourse.org/t/incorrect-message-key-in-temporarily-closed-topic/87773
 2018-05-18 16:32:12 +08:00
Guo Xiang Tan b9dfb0ba10 Partially revert https://github.com/discourse/discourse/commit/531baec5b585a7a82365a5733e8be5298fa1019d. 2018-05-18 15:01:36 +08:00
Guo Xiang Tan 1ff767559d Fix incorrect param. 2018-05-18 14:05:45 +08:00
Guo Xiang Tan 531baec5b5 Remove unused fabricator. 2018-05-18 13:37:39 +08:00
Guo Xiang Tan c42b65df5f find raises an error if the record is missing. 2018-05-18 13:37:07 +08:00
Guo Xiang Tan 416d19af27 FIX: Wrong target user displayed for user actions in activity stream. 
https://meta.discourse.org/t/wrong-assigned-username-in-activity-list/73816
 2018-05-18 11:28:13 +08:00
Guo Xiang Tan 417bcc5f2a Remove blank test. 2018-05-18 11:07:57 +08:00
Guo Xiang Tan b74c108c09 UX: Display group tabs in user's messages tab for non-staff as well. 
https://meta.discourse.org/t/group-inboxes-in-user-messages/86787
 2018-05-17 18:10:17 +08:00
Guo Xiang Tan 3f8e3a6f73 Don't intercept requests in smoke tests. 2018-05-17 16:56:39 +08:00
Guo Xiang Tan b3981ddc43 Shorten User.suggest_name further. 2018-05-17 16:35:03 +08:00
Guo Xiang Tan 147ea37115 FIX: Missing notification for watching first post users when topic is recategorized. 
https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/2?u=tgxworld
 2018-05-17 16:15:29 +08:00
Guo Xiang Tan 117763493b Refactor User#suggest_name. 
* Rename `email` to `string` as variable can be an email, username
  or any valid string.
 2018-05-17 14:54:14 +08:00
Guo Xiang Tan f21a47eadd Improve specs to assert for the right record instead of just a count. 2018-05-17 08:47:24 +08:00
Guo Xiang Tan 565fa1f60e Fix regression introduced in https://github.com/tgxworld/discourse/commit/8cf0f51eb2c9ef5c6155d77aab1d0d9c7b104af0. 2018-05-16 14:26:03 +08:00
Guo Xiang Tan bed039aebf Remove incorrect added code in https://github.com/discourse/discourse/commit/d31417d3af5b1742bc98f3a8e406281f7cdbf6a4#diff-655c787458e67d84dc1178f5d2b674f1 2018-05-11 13:19:20 +08:00
Guo Xiang Tan a0fc5de5c4 Revert "Static update for htmlHelper method within bound-avatar helper" 
This reverts commit ba383027e8.
 2018-05-11 13:19:20 +08:00
Guo Xiang Tan 186623acd0 FEATURE: Keep EmailLogs records without a reply_key for 90 days by default. 2018-05-10 15:33:49 +08:00
Guo Xiang Tan c720bf32c3 UX: Add proper titles to topic navigation links in hamburger menu. 
https://meta.discourse.org/t/what-is-the-difference-between-latest-and-new/47809/9?u=tgxworld
 2018-05-10 09:29:02 +08:00
Guo Xiang Tan 36d9f7f814 Revert "UX: Don't set width to auto for select kit combo box." 
This reverts commit c7b526b9e0.
 2018-05-09 14:28:45 +08:00
Guo Xiang Tan c7b526b9e0 UX: Don't set width to auto for select kit combo box. 2018-05-09 14:21:47 +08:00