Osama Sayegh
f3c07e27d9
FIX: correct translations for logs error rate notice ( #7622 )
...
The problem here is that hour and minute were passed to the %{duration} variable which made them impossible to translate in other languages.
I wonder if it's worth having 2 almost identical translations just for "reached" and "exceeded"? Perhaps we could combine them in one copy?
2019-05-28 22:10:51 +03:00
Osama Sayegh
169cc56bed
Copyedit for broken theme alert
2019-05-27 07:25:39 +03:00
Osama Sayegh
e20c30987c
FEATURE: detect theme errors and catch them ( #7589 )
...
* FEATURE: detect theme errors and catch them
* Bump COMPILER_VERSION
* Feedback
* Override eslint no console for one line
* Can't use our ajax method
* remove emoji from translation file
2019-05-24 17:25:55 +03:00
Osama Sayegh
c86d2666c4
Pull translations from Transifex ( #7578 )
2019-05-21 07:18:15 +03:00
Osama Sayegh
0b5924d61e
Refactor keyboard shortcuts modal to fix RTL locales ( #7545 )
...
* Refactor keyboard shortcuts modal to fix RTL locales
* Feedback
* Remove lowercase modifier keys
2019-05-21 06:39:32 +03:00
Osama Sayegh
14bae6d52d
Make email_excerpt method take an optional post param ( #7570 )
...
The spoiler alert plugin replaces spoiler text found in email excerpts with posts URL, which means it needs to have a reference to the post it's processing.
This change makes `email_excerpt` accepts an optional post param, which calls `PrettyText.format_for_email` which then triggers the `reduce_cooked` event that the plugin subscribes to.
2019-05-20 10:04:23 +02:00
Osama Sayegh
6ea14b591f
Bump logster to 2.3.0 ( #7251 )
...
Introduces a new feature that keeps track of number of logs that have been suppressed by each pattern.

https://github.com/discourse/logster/commit/d3146c0fe11b6a277062b8e021550e617701fea5
2019-03-26 07:51:58 +03:00
Osama Sayegh
67b96ad2ff
FIX: discourse client should know about Logster (simpler approach) ( #7237 )
...
* Revert "FIX: discourse client should know about Logster (#7232 )"
This reverts commit bfcbc4d2d6 .
* FIX: discourse client should know about Logster (simpler approach)
2019-03-22 08:48:57 +11:00
Osama Sayegh
bfcbc4d2d6
FIX: discourse client should know about Logster ( #7232 )
2019-03-21 16:54:55 +03:00
Osama Sayegh
da578e92f2
DEV: configure logster max logs via ENV ( #7225 )
2019-03-21 16:10:17 +03:00
Osama Sayegh
14c1af0a9e
Bump logster version to 2.2.0 ( #7200 )
2019-03-19 09:39:16 +01:00
Osama Sayegh
5e58cedfbd
FIX: retranspile theme JS when settings YAML changes ( #7131 )
2019-03-08 17:49:06 +03:00
Osama Sayegh
d5efe2d7ee
UX: make composer resize work on touch devices ( #7068 )
...
* UX: make composer resize work on touch devices
This also replaces a vendor dependency with a small built-in resize mechanism.
* Make blue bar's larger padding specific to touch devices
2019-02-26 08:04:14 +11:00
Osama Sayegh
f86ca5631a
Bump logster to v 2.1.2 ( #7052 )
2019-02-21 18:59:33 +03:00
Osama Sayegh
1c00e8a755
Bump logster to 2.1.0 ( #7000 )
2019-02-13 10:57:22 +01:00
Osama Sayegh
d0dc674875
Bump logster to 2.0.0.pre ( #6897 )
2019-01-17 18:13:47 +03:00
Osama Sayegh
abee39ecd0
Bump logster to 1.4.0.pre ( #6866 )
...
2 new features and a few fixes. More details here:
https://github.com/discourse/logster/pull/76
https://github.com/discourse/logster/pull/77
2019-01-09 13:50:48 +03:00
Osama Sayegh
8bd5c90b0c
Bump logster to version 1.3.4 ( #6834 )
...
Fixes linear-gradient CSS issue on iOS
Increases z-index for the actions menu to prevent the screen divider/splitter from obstructing the menu
https://github.com/discourse/logster/commit/e43e98dc616b9216b7e52146f89996ee061746d6
2018-12-31 06:58:46 +03:00
Osama Sayegh
8f65e4fb01
Bump logster to 1.3.3 ( #6813 )
...
Fixes a UI issue
2018-12-26 18:21:52 +03:00
Osama Sayegh
2ab02d6642
Bump logster version to 1.3.2 ( #6811 )
...
Logster 1.3.2 improves UX on mobile
2018-12-26 14:09:00 +08:00
Osama Sayegh
dd0b4c565b
Bump logster version ( #6584 )
2018-11-12 08:49:00 +08:00
OsamaSayegh
5625461c05
clear error if you can contact theme repo again
2018-09-17 09:49:53 +10:00
OsamaSayegh
c9a5438a88
use woman_artist emoji
2018-09-17 09:49:53 +10:00
OsamaSayegh
c7d81e2682
FIX/FEATURE: don't blow up when can't reach theme's repo, show problem themes on dashboard
2018-09-17 09:49:53 +10:00
OsamaSayegh
ca28548762
feedback (see commit description for details)
...
* fill blank space when no theme is selected
* animate row's height in themes/components list when selecting, and hide children list
* show warning when you move to a different page and have unsaved changes
* refactor `adminCustomizeThemes.show` controller
* allow collapsing/expanding children lists
* fix a bug when adding components to a theme (changed the way it works slightly)
* a bunch of other minor things
2018-09-17 09:49:53 +10:00
OsamaSayegh
a4f057a589
UX: improvements to admin theme UI
2018-09-17 09:49:53 +10:00
Osama Sayegh
16bd3f2cf2
FIX: use current user color scheme when filling theme-color attribute ( #6384 )
...
* FIX: use current user color scheme when filling `meta` attribute `theme-color`
* update manifest.webmanifest colors
2018-09-12 11:04:58 +10:00
Osama Sayegh
8e70b82baa
FIX: maintain theme preview when refreshing ( #6356 )
2018-09-02 17:23:46 +10:00
Osama Sayegh
60eff9421a
FIX: precompile desktop_theme and mobile_theme stylesheets
...
required for environments that pre stage docker images and keep old image running during the deploy
2018-08-31 21:23:55 +10:00
Osama Sayegh
9efbf2c49f
FIX: changing component settings should trigger refresh for parent theme CSS ( #6340 )
2018-08-30 20:53:03 +10:00
Osama Sayegh
e0cc29d658
FEATURE: themes and components split
...
* FEATURE: themes and components split
* two seperate methods to switch theme type
* use strict equality operator
2018-08-24 11:30:00 +10:00
Osama Sayegh
2711f173dc
FIX: don't allow inviting more than max_allowed_message_recipients
...
* FIX: don't allow inviting more than `max_allowed_message_recipients` setting allows
* add specs for guardian
* user preferences for auto track shouldn't be applicable to PMs (it auto watches on visit)
Execlude PMs from "Automatically track topics I enter..." and "When I post in a topic, set that topic to..." user preferences
* groups take only 1 slot in PM
* just return if topic is a PM
2018-08-23 14:36:49 +10:00
Osama Sayegh
865cb3feb9
FIX: allow selecting site's default theme from preference
2018-08-10 14:12:02 +03:00
Osama Sayegh
0d5ebcb21d
fix flaky specs ( #6255 )
2018-08-10 10:38:36 +10:00
Osama Sayegh
0d45826d22
fix theme previewing ( #6245 )
2018-08-08 10:58:45 +03:00
Osama Sayegh
0b7ed8ffaf
FEATURE: backend support for user-selectable components
...
* FEATURE: backend support for user-selectable components
* fix problems with previewing default theme
* rename preview_key => preview_theme_id
* omit default theme from child themes dropdown and try a different fix
* cache & freeze stylesheets arrays
2018-08-08 14:46:34 +10:00
Osama Sayegh
18b396ad56
FEATURE: add link to see new commits when updates are available for themes ( #6233 )
...
* FEATURE: add link to see new commits when updates are available for themes
* shorten regexp
2018-08-06 15:29:15 +10:00
Osama Sayegh
880462a41c
FEATURE: display out of date themes on admin dashboard
...
* FEATURE: disaply out of date themes on admin dashboard
* Update copy
2018-08-03 09:53:48 +10:00
OsamaSayegh
a157dfd418
UX: better rejection message when reply via email is too short
2018-08-02 22:43:53 +03:00
OsamaSayegh
69450750d1
shorter method name and better specs
2018-07-20 10:13:27 +03:00
OsamaSayegh
fa02df9985
FIX: don't suggest groups when inviting to a topic ( #6105 )
2018-07-19 17:02:34 +08:00
OsamaSayegh
547b571d84
FIX: topic owner should watch the new topic when moving posts to a new topic
2018-07-18 15:23:32 +03:00
OsamaSayegh
281538ae61
FIX: theme JS should only run when needed global objects exist ( #6098 )
2018-07-18 15:13:47 +10:00
OsamaSayegh
decf1f27cf
FEATURE: Groundwork for user-selectable theme components
...
* Phase 0 for user-selectable theme components
- Drops `key` column from the `themes` table
- Drops `theme_key` column from the `user_options` table
- Adds `theme_ids` (array of ints default []) column to the `user_options` table and migrates data from `theme_key` to the new column.
- Removes the `default_theme_key` site setting and adds `default_theme_id` instead.
- Replaces `theme_key` cookie with a new one called `theme_ids`
- no longer need Theme.settings_for_client
2018-07-12 14:18:21 +10:00
OsamaSayegh
f13a7226db
FIX: display tables in posts history diff ( #6032 )
2018-07-12 14:13:52 +10:00
OsamaSayegh
f2cc05c6c6
FIX: ignore self-quotes from the same post when saving ( #6082 )
2018-07-10 16:17:28 +08:00
OsamaSayegh
f4369fa99e
FIX: use logo_url settign when present for mobile layout instead of site name
2018-06-29 15:07:10 +10:00
OsamaSayegh
d81f8ea378
fix prettier
2018-06-26 15:31:43 +03:00
OsamaSayegh
bfe0178270
FIX: use the correct notification levels titles for PMs
2018-06-26 14:01:52 +02:00
OsamaSayegh
a603660ba5
FIX: scroll to top when accessing admin dashboard
2018-06-26 12:19:58 +02:00
OsamaSayegh
d58ff44b04
Simplify to only support topics list for now
2018-06-25 15:02:22 +10:00
OsamaSayegh
b4a13a1afa
UX: keyboard shortcuts (j/k) should work with /categories
2018-06-25 15:02:22 +10:00
OsamaSayegh
91b73e0c2d
FIX: remap shouldn't fail silently when an error occurs
2018-06-19 14:49:43 +10:00
OsamaSayegh
629a2fbc2b
add JS tests
2018-06-15 14:04:14 +10:00
OsamaSayegh
06777aa47d
FIX: use the correct notification levels descriptions for PMs
2018-06-15 14:04:14 +10:00
OsamaSayegh
2427c0a17c
FIX: theme CSS should recompile when theme uploads change
2018-06-15 13:12:09 +10:00
OsamaSayegh
4a9dadb646
Add test case for topic embed CSS
2018-06-13 16:22:54 +10:00
OsamaSayegh
6ddf32da7c
Merge pull request #5981 from OsamaSayegh/fix-build
...
Fix build
2018-06-11 09:13:10 +03:00
OsamaSayegh
249a256cd2
Fix build
2018-06-11 09:12:28 +03:00
OsamaSayegh
77f1cdf20e
REFACTOR: admin backups controller specs to requests ( #5953 )
2018-06-11 13:26:24 +08:00
OsamaSayegh
1dbe13886f
REFACTOR: admin site texts controller specs to requests ( #5958 )
2018-06-11 12:59:21 +08:00
OsamaSayegh
4f06d6078b
REFACTOR: admin themes controller specs to requests ( #5954 )
2018-06-11 12:54:16 +08:00
OsamaSayegh
1fe092da0a
REFACTOR: admin badges controller specs to requests ( #5960 )
2018-06-11 12:50:56 +08:00
OsamaSayegh
bf8d392a51
REFACTOR: admin user fields controller specs to requests ( #5961 )
2018-06-11 12:50:21 +08:00
OsamaSayegh
4c8939d530
REFACTOR: admin email controller specs to requests ( #5962 )
2018-06-11 12:50:08 +08:00
OsamaSayegh
c0776884dd
REFACTOR: admin reports controller specs to requests ( #5963 )
2018-06-11 12:49:28 +08:00
OsamaSayegh
da94eaa81d
REFACTOR: admin color schemes controller specs to requests ( #5964 )
2018-06-11 12:48:58 +08:00
OsamaSayegh
767f022b29
REFACTOR: admin screened ip addresses controller specs to requests ( #5965 )
2018-06-11 12:48:34 +08:00
OsamaSayegh
93b1386fb2
REFACTOR: admin site settings controller specs to requests ( #5966 )
2018-06-11 12:48:09 +08:00
OsamaSayegh
325f975ed3
REFACTOR: admin dashboard controller specs to requests ( #5967 )
2018-06-11 12:47:42 +08:00
OsamaSayegh
a4574cf2ca
REFACTOR: admin webhooks controller specs to requests ( #5969 )
2018-06-11 12:47:29 +08:00
OsamaSayegh
a914ec28fc
REFACTOR: admin impersonate controller specs to requests ( #5968 )
2018-06-11 12:47:14 +08:00
OsamaSayegh
d22b552c9b
REFACTOR: admin emojis controller specs to requests ( #5974 )
2018-06-11 12:39:31 +08:00
OsamaSayegh
12b1687e1f
REFACTOR: admin permalinks controller specs to requests ( #5970 )
2018-06-11 12:37:21 +08:00
OsamaSayegh
37c84451ed
REFACTOR: admin staff action logs controller specs to requests ( #5971 )
2018-06-11 12:37:06 +08:00
OsamaSayegh
65241c6778
REFACTOR: admin api controller specs to requests ( #5972 )
2018-06-11 12:35:45 +08:00
OsamaSayegh
2c8a9d36af
REFACTOR: admin versions controller specs to requests ( #5973 )
2018-06-11 12:35:05 +08:00
OsamaSayegh
237559c76f
REFACTOR: admin screened emails controller specs to requests ( #5975 )
2018-06-11 12:33:54 +08:00
OsamaSayegh
f30c2dacb2
REFACTOR: admin screened urls controller specs to requests ( #5976 )
2018-06-11 12:33:38 +08:00
OsamaSayegh
63b2207065
REFACTOR: admin plugins controller specs to requests ( #5977 )
2018-06-11 12:33:07 +08:00
OsamaSayegh
c6fe082fe4
REFACTOR: admin controller specs to requests ( #5978 )
2018-06-11 12:32:55 +08:00
OsamaSayegh
4ac7be1d1c
REFACTOR: admin embeddable hosts controller specs to requests ( #5979 )
2018-06-11 12:32:13 +08:00
OsamaSayegh
062aecd239
REFACTOR: admin embedding controller specs to requests ( #5980 )
2018-06-11 12:31:58 +08:00
OsamaSayegh
f5ad0022f7
REFACTOR: admin users controller specs to requests ( #5946 )
2018-06-08 12:42:06 +08:00
OsamaSayegh
1e805cfd3e
REFACTOR: composer messages controller specs to requests ( #5940 )
2018-06-07 13:51:52 +08:00
OsamaSayegh
c6c1ef71c1
REFACTOR: inline onebox controller specs to requests
2018-06-07 13:11:45 +08:00
OsamaSayegh
30be1b0d2b
REFACTOR: category hashtags controller specs to requests ( #5936 )
2018-06-07 13:09:23 +08:00
OsamaSayegh
9975f9751e
REFACTOR: metadata controller specs to requests ( #5935 )
2018-06-07 13:08:28 +08:00
OsamaSayegh
1957cb541b
REFACTOR: permalinks controller specs to requests ( #5934 )
2018-06-07 13:08:13 +08:00
OsamaSayegh
f2a5a84f0b
REFACTOR: similar topics controller specs to requests ( #5933 )
2018-06-07 13:07:53 +08:00
OsamaSayegh
37829a521a
REFACTOR: stylesheets controller specs to requests
2018-06-07 13:06:32 +08:00
OsamaSayegh
a8d33603f9
REFACTOR: export CSV controller specs to requests
2018-06-07 13:02:02 +08:00
OsamaSayegh
0124209a96
REFACTOR: site controller specs to requests
2018-06-07 12:58:33 +08:00
OsamaSayegh
3c96ee4b6f
REFACTOR: clicks controller specs to requests ( #5929 )
2018-06-07 12:57:29 +08:00
OsamaSayegh
2688cc6241
REFACTOR: post action users controller specs to requests
2018-06-07 12:55:01 +08:00
OsamaSayegh
e2e566214d
REFACTOR: user avatars controller spec to requests
2018-06-07 12:53:33 +08:00
OsamaSayegh
05c1fe5c8f
REFACTOR: user actions controller specs to requests
2018-06-07 12:52:06 +08:00
OsamaSayegh
7f21892ad0
REFACTOR: finish installation controller specs to requests
2018-06-07 12:49:47 +08:00
OsamaSayegh
5ecaa55e50
REFACTOR: webhooks controller specs to requests
2018-06-07 12:46:29 +08:00
OsamaSayegh
cc82fb33b5
REFACTOR: queued posts controller specs to requests
2018-06-07 12:41:26 +08:00