Guo Xiang Tan
2cbb513c98
FIX: Don't use Redis#keys
in production.
...
As per the documentation for KEYS
```
Warning: consider KEYS as a command that should only be used in production environments with extreme care. It may ruin performance when it is executed against large databases. This command is intended for debugging and special operations, such as changing your keyspace layout.
```
Instead SCAN
```
Since these commands allow for incremental iteration, returning only a small number of elements per call, they can be used in production without the downside of commands like KEYS or SMEMBERS that may block the server for a long time (even several seconds) when called against big collections of keys or elements.
```
2018-12-25 15:12:59 +02:00
Kyle Zhao
61dcd7c52c
FIX: validate YAML before save to avoid race condition
2018-12-25 15:08:17 +02:00
Arpit Jalan
1e2b81991f
fix the build
2018-12-25 10:27:51 +05:30
Jeff Atwood
a74e49c87c
use proper typographical × instead of x
2018-12-24 20:33:17 -08:00
Arpit Jalan
a8a0f97157
bump onebox version
...
- FEATURE: support YouTube `rel` parameter
2018-12-25 06:36:51 +05:30
Vinoth Kannan
a16bb32865
FIX: Do not raise error if most liked user is deleted
2018-12-25 01:04:55 +05:30
Régis Hanol
2988d281fc
DEV: group all collapsed notifications
2018-12-24 12:44:50 +01:00
Vinoth Kannan
b3df4bee9c
FIX: Hide group membership request button for existing members
2018-12-24 13:49:05 +05:30
Joffrey JAFFEUX
7b253dbe4a
FIX: gfycat oneboxing
2018-12-22 11:16:18 +01:00
Jeff Atwood
29c455bb7f
minor copyedit on embedding referer error
2018-12-21 17:27:56 -08:00
Jeff Atwood
6db19e494d
remove emoji from default discobot greeting PM
2018-12-21 16:39:25 -08:00
Saurabh Patel
f4d8a330c3
Merge pull request #6761 from mrfinch/saurabh/show-popup
...
FIX:show popup before bulk invite
2018-12-21 21:36:17 +01:00
Gerhard Schlager
126be6c478
FIX: Resetting bump date shouldn't fail when first post is hidden
2018-12-21 17:43:52 +01:00
Gerhard Schlager
fbd92916e5
FIX: Narrative bot should ignore action on deleted post
2018-12-21 17:43:52 +01:00
Robin Ward
0e710dc573
Improvements to Lazy Loading
...
- Now applied to all images over 150x150px
- Stores the width and height in the WeakMap rather than using
percentages for accuracy
- When oneboxed images are hidden, they are given a subtle border for better
visibility.
- Don't apply when in the composer. Causes flickering.
2018-12-21 11:31:27 -05:00
David Taylor
7feabd9e49
PERF: Eradicate N+1 queries from the theme admin page
2018-12-21 11:03:58 +02:00
Vinoth Kannan
2909e7fbdf
FIX: Subfolder path is missing in category permalinks after slug update
2018-12-21 09:29:54 +05:30
Robin Ward
a2ae67509d
Don't use getAttribute
if we don't need to
2018-12-20 16:41:04 -05:00
Kris
816acc6984
Improving color contrast of $danger-low for dark themes
2018-12-20 14:46:13 -05:00
Penar Musaraj
f4d37d05c3
Merge branch 'master' of github.com:discourse/discourse
2018-12-20 11:15:26 -05:00
Penar Musaraj
28283c2396
FIX: Workaround for Edge issue with clicks on SVGs
...
- Related Edge issue at https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/10583086/
2018-12-20 11:13:55 -05:00
Vinoth Kannan
e7e4074856
FIX: raises an error if q param is empty in search page
2018-12-20 21:43:14 +05:30
Sam Saffron
400eea4d13
UX: show lazy loaded images while they are downloading
...
Also shows fuzzy image right away prior to it being downloaded
2018-12-20 22:04:30 +08:00
Joe
d7466156ae
UX: adds missing wizard icons
...
With our recent move to SVG icons, the font file does not work in the wizard. I've opted for path2D, which accepts an SVG path
Path2D is not supported by IE11 but the chances of admins running the wizard on IE11 are practically none.
https://caniuse.com/#feat=path2d
2018-12-20 14:55:40 +02:00
Gerhard Schlager
0bc1fa8aa4
FEATURE: Don't create PM for successful automatic backups
2018-12-20 13:34:24 +01:00
Rishabh
3d2c72dd33
UX: Switch placeholder to an SSH url if importing a private theme
2018-12-20 17:01:50 +05:30
Bianca Nenciu
a06d310855
DEV: Refactor location string builders. ( #6794 )
2018-12-20 10:23:05 +01:00
Jeff Atwood
bd6d482d11
Update SECURITY.md
2018-12-19 16:55:54 -08:00
Jeff Atwood
358fbeba14
add CSP info for Discourse 2.2
2018-12-19 16:54:45 -08:00
Guo Xiang Tan
b64d760bb3
DEV: Improve tests to assert that the right HTML is generated.
2018-12-20 07:14:32 +08:00
Vinoth Kannan
dc292d4598
FIX: Use one-way binding to prevent unnecessary updates in site.periods
2018-12-20 03:39:05 +05:30
Arpit Jalan
bb67ca9d21
FIX: use correct post object when logging exception
2018-12-19 22:17:37 +05:30
Arpit Jalan
1ea0cbece8
FIX: skip adding sso diagnostics if sso object is nil
2018-12-19 20:55:35 +05:30
Joffrey JAFFEUX
e655e1863f
UX: Adding reports dashboard tab, new layout, report descriptions ( #6790 )
...
Co-Authored-By: Kris <shout@k-ris.com>
2018-12-19 14:44:43 +01:00
Arpit Jalan
e5fd018f44
DEV: assign constant to preserve_fragment_url_hosts
2018-12-19 17:37:39 +05:30
Bianca Nenciu
c928386c3e
FIX: Copy old status to new poll. ( #6788 )
2018-12-19 11:29:13 +01:00
Penar Musaraj
f5c4ab0573
Add category link renderer to plugin API ( #6787 )
...
* Add category link renderer to plugin API
- lets themes/plugins override the category link display
- planning to use this in a "category icons" theme component
* small code review fix
* Code review refactor
2018-12-19 10:26:09 +01:00
Bianca Nenciu
7050ce4638
FIX: Bypass draft check when switching to shared draft. ( #6782 )
2018-12-19 10:25:33 +01:00
Maja Komel
0ce5f05b2a
FIX: hide emails on admin user list for moderators ( #6781 )
2018-12-19 10:24:57 +01:00
Maja Komel
2fcbbead45
FIX: move sso provider into its own class so it doesn't interfere with sso client ( #6767 )
2018-12-19 10:22:10 +01:00
Bianca Nenciu
2eefe6d5d6
FIX: Use CDN for logos and icons. ( #6698 )
2018-12-19 10:20:48 +01:00
Arpit Jalan
1ab91f0474
FIX: preserve github fragment URL
2018-12-19 12:34:47 +05:30
Rishabh
cae5ba7356
FIX: Ensure that multisite s3 uploads are tombstoned correctly ( #6769 )
...
* FIX: Ensure that multisite uploads are tombstoned into the correct paths
* Move multisite specs to spec/multisite/s3_store_spec.rb
2018-12-19 13:32:32 +08:00
Kris
41e06efb94
Adding padding to mobile that was removed in 3710b016
2018-12-18 22:20:02 -05:00
Kris
3710b01660
Header was 16px too narrow due to border-box and padding
2018-12-18 20:38:43 -05:00
Kris
5b9c1bcf59
User page button style fix
2018-12-18 20:36:42 -05:00
Neil Lalonde
6774b64aef
FEATURE: add /conduct as an alias for /guidelines
2018-12-18 16:40:24 -05:00
Vinoth Kannan
9c6f77f9da
DEV: Remove the unique_searches column from select query
2018-12-19 02:45:48 +05:30
Robin Ward
6080e3a2c0
FIX: Broken spec
2018-12-18 14:55:09 -05:00
Robin Ward
662cfc416b
FEATURE: Show a blurry preview when lazy loading images
...
This generates a 10x10 PNG thumbnail for each lightboxed image.
If Image Lazy Loading is enabled (IntersectionObserver API) then
we'll load the low res version when offscreen. As the image scrolls
in we'll swap it for the high res version.
We use a WeakMap to track the old image attributes. It's much less
memory than storing them as `data-*` attributes and swapping them
back and forth all the time.
2018-12-19 01:57:30 +08:00