IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-09-05 04:40:41 -05:00
Code Issues Packages Projects Releases Wiki Activity
30,899 Commits 1,018 Branches 579 Tags
2feeba0f1cb095a461c95ff6fb90a15a83f2dc5b
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Guo Xiang Tan 2feeba0f1c DEV: Remove duplicated assertion. 2019-01-02 05:07:58 +08:00
Guo Xiang Tan 2cbb513c98 FIX: Don't use Redis#keys in production. 
As per the documentation for KEYS

```
Warning: consider KEYS as a command that should only be used in production environments with extreme care. It may ruin performance when it is executed against large databases. This command is intended for debugging and special operations, such as changing your keyspace layout.
```

Instead SCAN

```
Since these commands allow for incremental iteration, returning only a small number of elements per call, they can be used in production without the downside of commands like KEYS or SMEMBERS that may block the server for a long time (even several seconds) when called against big collections of keys or elements.
```
 2018-12-25 15:12:59 +02:00
Guo Xiang Tan b64d760bb3 DEV: Improve tests to assert that the right HTML is generated. 2018-12-20 07:14:32 +08:00
Guo Xiang Tan 5c2e194d01 SECURITY: Users can pick non-avatar uploads. 
https://meta.discourse.org/t/bug-report-idor-on-avatar-pick-function-discussions-udacity-com/103564
 2018-12-18 13:38:25 +08:00
Guo Xiang Tan 899caf35ba Revert "SECURITY: User could non-avatar uploads." 
This reverts commit 89581fa301.
 2018-12-18 13:37:31 +08:00
Guo Xiang Tan 89581fa301 SECURITY: User could non-avatar uploads. 
https://meta.discourse.org/t/bug-report-idor-on-avatar-pick-function-discussions-udacity-com/103564
 2018-12-18 13:35:33 +08:00
Guo Xiang Tan d7660dfe40 FIX: Enabling readonly mode should clear anon cache as well. 2018-12-18 11:56:25 +08:00
Guo Xiang Tan c0aae16f6b FIX: Clear anon cache when disabling readonly mode. 
`SiteSerializer#is_readonly` is cached for an anonymous user so we have
to clear the cache when disabling readonly mode. Otherwise, the site may
appear to be in readonly mode for an extended period of time.
 2018-12-17 17:27:44 +08:00
Guo Xiang Tan 9e795b9d90 Follow up to 704a122656. 2018-12-17 16:39:46 +08:00
Guo Xiang Tan e75ad37aaf FIX: Switch recently readonly mdoe cache to a DistributedCache. 
A per process cache is hard to reason about. During PostgreSQL
failovers. The site may bounce in and out of readonly mode depending on
which server and process that a request hits.
 2018-12-17 13:28:36 +08:00
Guo Xiang Tan 704a122656 Remove Ruby warning due to assignment in conditional. 2018-12-17 13:08:12 +08:00
Guo Xiang Tan e9ea0102a5 FIX: Consistency about our response for invalid user id in Admin::UsersController. 2018-12-15 08:01:35 +08:00
Guo Xiang Tan 05104600ea FIX: Incorrect translation key on admin search logs. 2018-12-14 17:12:33 +08:00
Guo Xiang Tan 71ce9ced47 FIX: Incorrect arguments were being passed to Jobs::ClosePoll. 
Also fix spec that wasn't testing anything.
 2018-12-13 16:46:00 +08:00
Guo Xiang Tan e564fe1866 FIX: Sidekiq fails to start if any of the multisite has problems. 2018-12-12 11:30:14 +08:00
Guo Xiang Tan 86926f4aee DEV: Let create! handle the check for persistence. 
This is unlikely to fail but we want to know when it does.
 2018-12-12 08:36:13 +08:00
Guo Xiang Tan 27c793a192 FIX: `UserNotificationsHelper#logo_url' to work with S3 based uploads. 
https://meta.discourse.org/t/digest-logo-not-working/103255
 2018-12-06 09:39:08 +08:00
Guo Xiang Tan dcf9c6da59 DEV: Don't publish post messages to non-human users. 2018-12-06 08:24:13 +08:00
Guo Xiang Tan cfa0321aaa FIX: Increase timeout when trying to reload unicorn. 
Also fail better when reloading takes too long by sending
unicorn a TERM.
 2018-12-04 13:43:14 +08:00
Guo Xiang Tan 125bb46052 Remove unused constant in the codebase. 2018-12-03 11:04:47 +08:00
Guo Xiang Tan df2d02a7bc Revert "Enable Style/BlockDelimiters rule." 
This reverts commit 3c22fb6b70.
 2018-11-30 10:59:45 +08:00
Guo Xiang Tan eecd1a7d8c FIX: Jobs::CleanUpUploads fails when value of upload data_type is an empty string. 2018-11-30 10:46:39 +08:00
Guo Xiang Tan 3c22fb6b70 Enable Style/BlockDelimiters rule. 2018-11-30 10:18:15 +08:00
Guo Xiang Tan ffdacba219 Remove extra apple-touch-icon link in head. 
The sizes attribute does not make a difference because both
image provided is of the same size.
 2018-11-29 15:24:52 +08:00
Guo Xiang Tan 56034c733a UX: Strip class when link is not oneboxed due to site setting limits. 2018-11-29 14:33:01 +08:00
Guo Xiang Tan ceaf234f89 DEV: Add tests for c92c56d986. 2018-11-29 13:51:31 +08:00
Guo Xiang Tan c92c56d986 FIX: Randomly failing QUnit test. 
The `post` variable can be an actual post object or a `new Placeholder("post-placeholder")` which does not define the function `get`.

* QUNIT_SEED=11414431645131211212599424733847938795
 2018-11-27 16:00:46 +08:00
Guo Xiang Tan 9cf9dee4cc DEV: Locale dates test needs to set default moment timzone. 
The tests were breaking on a machine configured to use SGT timezone.
 2018-11-27 13:50:57 +08:00
Guo Xiang Tan 68bef91dd6 DEV: Minor clean up of specs. 2018-11-27 13:09:58 +08:00
Guo Xiang Tan 565603ad0d Remove unused variable. 2018-11-26 14:45:00 +08:00
Guo Xiang Tan 3188d3506d Re-add option that was removed by mistake in https://github.com/discourse/discourse/commit/482013a1d4060e69cf78773892f13ef2d8220742. 2018-11-26 14:24:23 +08:00
Guo Xiang Tan 482013a1d4 FIX: Group mentions missing after post processing. 2018-11-26 12:57:07 +08:00
Guo Xiang Tan 0972516abe FIX: Incorrect "rel" used for apple icons in <head>. 
Nothing on the web I can find suggests that this should have been `rel=icon`.
See https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html
 2018-11-26 10:40:09 +08:00
Guo Xiang Tan d4aaa968bb Fix linting. 2018-11-26 09:38:22 +08:00
Guo Xiang Tan a1888b301b DEV: Don't require login for QUit test path. 2018-11-23 13:50:19 +08:00
Guo Xiang Tan a19780d7a6 DEV: Don't expose wizard qunit route in production. 2018-11-23 13:49:31 +08:00
Guo Xiang Tan 7f7464e3e6 DEV: Remove unused variable. 2018-11-23 08:32:29 +08:00
Guo Xiang Tan 96168cb3c6 DEV: Use a set in SiteSetting.settings_hash. 2018-11-22 17:16:40 +08:00
Guo Xiang Tan 4752ddc908 Avoid DB query when there are no mentions. 2018-11-22 16:44:17 +08:00
Guo Xiang Tan a57baeec2a Fix the build. 2018-11-22 16:37:24 +08:00
Guo Xiang Tan 28a6cf8228 FIX: Mention lookup should be case insensitive. 2018-11-22 16:32:56 +08:00
Guo Xiang Tan 3f636b2d19 FIX: Check whether group is mentionable by user when cooking post. 2018-11-22 16:16:33 +08:00
Guo Xiang Tan 672e95bcb4 FIX: Staged users should not be mentionable. 2018-11-22 15:00:46 +08:00
Guo Xiang Tan 6111b285d9 DEV: Remove comment that links to a private topic. 
Not going to be useful for other developers.
 2018-11-22 14:55:02 +08:00
Guo Xiang Tan 596e09aaf9 FIX: Wizard icons step fields have incorrect values. 
https://meta.discourse.org/t/is-the-wizard-supposed-to-not-let-you-skip-adding-icons/102417
 2018-11-22 14:19:36 +08:00
Guo Xiang Tan ba280f9cf3 FIX: Give up migrating url site setting if endpoint doesn't return data. 2018-11-22 12:16:52 +08:00
Guo Xiang Tan a8603e04ab FIX: Give up migration of URL site settings if there is an SSL error. 2018-11-22 12:14:27 +08:00
Guo Xiang Tan d298f00046 DEV: Improve specs to be more specific about what has changed. 2018-11-22 10:10:07 +08:00
Guo Xiang Tan 439b3fe10a Fix MigratePollsData failing when poll-votes have duplicated options. 2018-11-21 10:52:21 +08:00
Guo Xiang Tan f4020d9134 UX: Contain site setting uploads within the div. 2018-11-21 10:09:53 +08:00
Guo Xiang Tan 598ac69773 Stop Sidekiq first before reloading unicorn master. 2018-11-21 09:53:00 +08:00
Guo Xiang Tan 1def6c08ec Fix copy due to https://github.com/discourse/discourse/commit/050dd574941ef0c3619b2dfb1f0294fdef31c2ca. 2018-11-21 08:00:15 +08:00
Guo Xiang Tan df72674f24 Warn when migrate url site settings job encounters an error. 2018-11-21 07:55:50 +08:00
Guo Xiang Tan 1a57be3248 Avoid deprecated site setting logging in SiteSetting.settings_hash. 2018-11-20 11:59:38 +08:00
Guo Xiang Tan 81b3bdaabd FIX: Remove site settings override for deprecated url site settings. 2018-11-20 11:42:39 +08:00
Guo Xiang Tan cf21c7f5aa DEV: Fix typo in specs. 2018-11-19 15:13:54 +08:00
Guo Xiang Tan fe131c5ea2 Fix missing avatars on topic list page. 
Introduced in https://github.com/discourse/discourse/commit/b50fab2d72c14ead753b9adaa149a6372f5d14dd
 2018-11-19 14:55:41 +08:00
Guo Xiang Tan 9fd704735e Rescue from SocketError in migrate url onceoff job. 2018-11-19 13:07:34 +08:00
Guo Xiang Tan b50fab2d72 PERF: Fix N+1 for non-staff users when tagging is enabled. 2018-11-19 12:53:58 +08:00
Guo Xiang Tan 45f299dfdd PERF: Try to match users before groups. 
User mentions are more common than group mentions so
this will allow us to avoid an extra query.
 2018-11-16 16:41:20 +08:00
Guo Xiang Tan 222a7c2270 Fix restores failing due to missing migration file. 2018-11-16 11:49:24 +08:00
Guo Xiang Tan 0ac5126a78 FIX: Clear uploads cache on SiteSetting.refresh!. 
This fixes a bug where the return value of uploads site settings
may defer between processes even though we trigger a refresh via
MessageBus.
 2018-11-16 11:02:51 +08:00
Guo Xiang Tan 9e86b425bc FIX: Job to clean up old URL settings when new setting has been set. 
Related to https://github.com/discourse/discourse/commit/44391ee8ab7431ca572b6c340d6e770cdadd51b3
 2018-11-16 09:33:31 +08:00
Guo Xiang Tan a895626d10 DB based S3 settings fixes for s3:upload_assets. 2018-11-15 15:48:40 +08:00
Guo Xiang Tan 901611cb4e Fix migrate upload url site settings to rescue from invalid URLs. 2018-11-15 15:16:14 +08:00
Guo Xiang Tan 68b640f6a9 Allow s3:upload_assets to use site settings from DB take 2. 2018-11-15 15:10:39 +08:00
Guo Xiang Tan c56d682f45 Allow s3:upload_assets to use site settings from DB. 2018-11-15 15:06:19 +08:00
Guo Xiang Tan 6fde58ff90 FIX: Make Discobot image tutorial accept URL that points to images. 2018-11-15 10:52:18 +08:00
Guo Xiang Tan ee60ecc71f UX: Switch to neutral background color for image uploader in site settings. 2018-11-15 08:24:50 +08:00
Guo Xiang Tan 5b320e6652 DEV: Don't warn about using deprecated site settings in clean up uploads job. 2018-11-14 20:58:06 +08:00
Guo Xiang Tan df111259fe More URL site settings into a onceoff job. 
* Doing it in a post migration was a bad idea
  because the migration will fail if the site
  is down while trying to download uploads
  which points to the instance. This mainly
  affects self-hosters using `discourse_docker`
  where `./launcher rebuild` will take the
  existing container down.
 2018-11-14 20:29:20 +08:00
Guo Xiang Tan 777364df01 Rescue from read and connect timeouts when migration url site settings. 2018-11-14 18:46:34 +08:00
Guo Xiang Tan 861b52b6f3 Fix the build take 2. 2018-11-14 18:07:04 +08:00
Guo Xiang Tan 2220345a8b Fix the build. 2018-11-14 17:32:32 +08:00
Guo Xiang Tan 52a756b98c Generate URL without CDN when migrating upload site settings. 2018-11-14 16:16:55 +08:00
Guo Xiang Tan 72370b9c36 Add deprecation warnings for url based site settings. 2018-11-14 16:09:26 +08:00
Guo Xiang Tan d5df1db3c4 DEV: Improve tests to provide better errors when it fails. 2018-11-13 16:48:04 +08:00
Guo Xiang Tan e28af0429c DEV: Improve tests to be more specific. 2018-11-13 15:02:46 +08:00
Guo Xiang Tan 7b44339529 FIX: Prevent uploads used in site settings from being deleted. 2018-11-13 09:15:16 +08:00
Guo Xiang Tan c7377e2f2d UX: Trash icon displaying when there is no upload take 2. 2018-11-12 16:19:17 +08:00
Guo Xiang Tan d50f4fdd7a Oops. 2018-11-12 16:07:33 +08:00
Guo Xiang Tan 10c6211cdf UX: Trash icon displaying when there is no upload. 2018-11-12 16:06:32 +08:00
Guo Xiang Tan 575d6855ea DEV: Improve specs for Validators::UploadValidator. 2018-11-12 14:11:32 +08:00
Guo Xiang Tan 12da912c73 DEV: Avoid Discourse specific code in fixtures. 2018-11-09 17:15:37 +08:00
Guo Xiang Tan 5076487eaf Update discuz_x import script to not use Category#logo_url. 2018-11-09 14:15:31 +08:00
Guo Xiang Tan 7a53e0b186 DEV: Remove fields from fixtures that are no longer valid. 2018-11-09 13:52:40 +08:00
Guo Xiang Tan 14ff47f6f1 Fix typo. 2018-11-08 16:42:12 +08:00
Guo Xiang Tan 7290145641 PERF: Speed up migrate_to_s3 rake task. 
* Prioritizes non-image uploads
* Does one remap per upload instead of 3 remaps previously
* Every 100 uploads migrated, do 2 remaps which fixes broken
  URLs
* Exclude email_logs table from remap
 2018-11-08 16:39:56 +08:00
Guo Xiang Tan 57f92ac808 Revert "Swtich to regexp for DbHelper.remap." 
Regexp is so much slower.

This reverts commit c3f89e3cd7.
 2018-11-08 14:20:09 +08:00
Guo Xiang Tan c3f89e3cd7 Swtich to regexp for DbHelper.remap. 2018-11-08 14:08:38 +08:00
Guo Xiang Tan 0232a3b5e5 PERF: Exclude tables when remapping in migrate_to_s3 rake task. 2018-11-08 12:37:36 +08:00
Guo Xiang Tan 9737938a4a Add option to skip tabels when using DbHelper.remap. 2018-11-08 12:29:37 +08:00
Guo Xiang Tan 3365753bd0 PERF: Reduce number of database queries for DbHelper.remap 
* Cuts number of queries from 273 to 89
* Add some specs
* For a table with 500 posts, benchmarks locally shows a runtime
  reduction from 0.046929135 to 0.032694705.
 2018-11-08 10:54:39 +08:00
Guo Xiang Tan 1e64658c25 Fix brittle specs. 2018-11-07 15:02:53 +08:00
Guo Xiang Tan dfc0519cd3 Remove deprecation notice for old site settings. 2018-11-07 14:36:59 +08:00
Guo Xiang Tan 7534042427 DEV: Update annotations. 2018-11-07 11:11:19 +08:00
Guo Xiang Tan ee42a53436 Missing require. 2018-11-07 10:50:47 +08:00
Guo Xiang Tan bdb8e9efdb DEV: Remove mocks from specs. 2018-11-07 09:55:58 +08:00
Guo Xiang Tan 65faff5832 DEV: Improve specs to provide a better error message. 2018-10-19 14:31:17 +08:00
Guo Xiang Tan bbf542da01 DEV: Prefer <<~ over <<. 2018-10-18 14:17:30 +08:00