IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2024-11-22 17:06:31 -06:00
Code Issues Packages Projects Releases Wiki Activity
33,050 Commits 210 Branches 500 Tags 927 MiB
40328f055e
Commit Graph

33050 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vinoth Kannan
40328f055e FIX: retrieve original filename from s3 object's content disposition header 2019-05-16 09:47:22 +05:30
Guo Xiang Tan
227bedebf7 DEV: Fix modifying a frozen string. 2019-05-16 11:30:31 +08:00
Guo Xiang Tan
dd49be27d3 DEV: Fix undefined variable. 
Follow up to e8fafbc123.
 2019-05-16 11:28:48 +08:00
Sam Saffron
76173dea87 DEV: ensure we never fork v8 contexts from unicorn 
v8 forking is not supported and can lead to memory leaks.

This commit handles the most common case which is the unicorn master forking

There are still some cases related to backup where we fork, however those
forks are usually short lived so the memory leak is not severe, burning
the contexts in the master process could break sidekiq or web process that
do the actual forking
 2019-05-16 09:50:34 +10:00
Kris
7cd1067f3d FIX: Select-kit too narrow in topic timer 2019-05-15 17:58:40 -04:00
Orlando Del Aguila
2932b0e757 chore: bump ruby version in .ruby-version (#7552) 2019-05-15 23:47:51 +02:00
Régis Hanol
501bee56b7 Make prettier happy 2019-05-15 23:46:50 +02:00
Neil Lalonde
7eea55d564 PERF: remove "new posts" stat from summary email 
It performs horribly and isn't a personalized stat like the others.
 2019-05-15 16:28:21 -04:00
Régis Hanol
db89722a98 UX: ignore leading/trailing whitespaces in site settings search 2019-05-15 22:22:20 +02:00
Bianca Nenciu
b9fcb2bcdf
DEV: Add before button hook in post-menu. (#7550) 2019-05-15 22:48:23 +03:00
Kris
0ef25f7a66 prettier 2019-05-15 13:35:58 -04:00
Kris
a3f6c7d6af
REFACTOR: Remove table layout from modals, clean up styles (#7549) 2019-05-15 13:26:25 -04:00
Maja Komel
9a17b19636 FIX: don't hide back button at the bottom of timeline (#7544) 2019-05-15 19:02:48 +02:00
Penar Musaraj
fc5bb39096 FIX: Do not send duplicate alerts for the same post (#7476) 2019-05-15 18:47:36 +02:00
Régis Hanol
fd5c5e326f FIX: remove full quote on direct replies when "typographed" 
Use the cooked version of the post and the quote to compare their content in
order to take into account the "typographer" option of the markdown pipeline.
 2019-05-15 17:49:29 +02:00
David Taylor
1299c94a52 FIX: Make serverside and clientside omniauth origin redirects consistent 
Previously external domains were allowed in the client-side redirects, but not the server-side redirects. Now the behavior is to only allow local origins.
 2019-05-15 12:40:51 +01:00
Régis Hanol
64e81f0549
FIX: ensure get_a_room link starts with 'base_path translation 2019-05-15 12:41:38 +02:00
Régis Hanol
a0df676194
COPY: improve 'dominating_topic' and 'get_a_room' warnings 
cf. https://meta.discourse.org/t/how-to-suppress-the-warning-that-a-user-is-contributing-too-much-to-a-topic/63249/9
 2019-05-15 12:21:44 +02:00
Vinoth Kannan
be0555cc17 FIX: Add bucket folder path only if not exists 2019-05-15 15:37:40 +05:30
Bianca Nenciu
1d3375b176 FEATURE: Preserve notifications levels when splitting topics. (#7494) 2019-05-15 17:29:29 +10:00
Guo Xiang Tan
ab1684999c DEV: Improve specs to use upload_s3 fabricator. 2019-05-15 08:42:17 +08:00
Vinoth Kannan
42b10a646d FIX: return 404 only if upload url also not internal. 2019-05-15 02:06:54 +05:30
Maja Komel
e0fe01925e FIX: make frozen string mutable in incoming_domain 2019-05-14 17:44:53 +02:00
David Taylor
33bd47164f DEV: Re-enable uglifier for non-precompiled assets 
Keep `harmony` disabled
 2019-05-14 10:28:18 +01:00
David Taylor
f12709e24c DEV: Temporarily disable uglifier for non-precompiled assets 
This is causing performance issues which require further investigation
 2019-05-14 09:34:38 +01:00
Sam Saffron
bbcc39e66c FEATURE: update mini_racer to version including heap dump support 
We recently noticed a leak, this introduces a new method on MiniRacer::Context

```
context.write_heap_snapshot(path)
```

To dump current memory in v8 context to a file, this can then be analyzed
in chrome and other similar tools

Can be triggered in production using rbtrace
 2019-05-14 18:01:15 +10:00
Joffrey JAFFEUX
d127119549
REFACTOR: user-selector take 2 (#7540) 2019-05-14 09:43:29 +02:00
Sam Saffron
624184560e PERF: improve performance of publish_notifications_state 
User.publish_notifications_state is called every time a notification is
created, this can become a very critical code path.

On some heavy notification related sites this can be a major CPU user on PG

This index makes it much cheaper to publish notification state, cause a
simple index lookup does the trick.
 2019-05-14 16:02:55 +10:00
Sam Saffron
dafc941a04 FEATURE: allow shadowing all s3 settings 
Previously enable s3 uploads and s3 upload bucket were not shadowed.

This caused confusion when people were configuring stuff via env cause most
of s3 settings are shadowed.
 2019-05-14 10:24:14 +10:00
Neil Lalonde
6f747c6b71 FIX: don't allow username to be changed to same as password 
We were blocking user registrations with same username and password,
but allowing usernames to be changed to be same as password later.
Also disallow names to be the same as password.
 2019-05-13 16:43:40 -04:00
Gerhard Schlager
13e54bca3d DEV: Add specs for handling InvalidPluralizationData exception 
follow-up to 6d44be51
 2019-05-13 22:07:42 +02:00
Gerhard Schlager
bbab60fa9b FIX: Don’t try to delete inactive moderators 
follow-up to 6d77156a
 2019-05-13 21:44:03 +02:00
Régis Hanol
7707d5db2d Revert "REFACTOR: user-selector (#7529)" 
This reverts commit 9a56df89f0.
 2019-05-13 19:39:30 +02:00
Arpit Jalan
a2b1789c3e FIX: do not log username change if the save process was unsuccessful 2019-05-13 22:20:27 +05:30
David Taylor
5605dba85c DEV: Automatically annotate plugin models alongside core models 2019-05-13 16:37:47 +01:00
Robin Ward
fb1da53dff FIX: Issue with incorrect heights when cloaking plugin content in posts 
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.

Co-authored-by: nlalonde
Co-authored-by: pmusaraj
 2019-05-13 11:29:21 -04:00
Joffrey JAFFEUX
7326ddea6d
REFACTOR: tags mixin (#7533) 2019-05-13 17:05:21 +02:00
Joffrey JAFFEUX
b8db702a02
REFACTOR: admin-user-index route (#7534) 2019-05-13 17:04:41 +02:00
Joffrey JAFFEUX
717aa764b6
FIX: more efficient topic-footer-button-api (#7535) 2019-05-13 17:04:24 +02:00
David Taylor
750c125707 DEV: Include foreign keys in model annotations 2019-05-13 15:53:42 +01:00
Penar Musaraj
607c671003 Fix string literal when switching theme in dev env 2019-05-13 10:25:51 -04:00
Penar Musaraj
f1b0782624 UI: Adjust footer nav bar size in iOS app 2019-05-13 10:25:51 -04:00
David Taylor
1bff81419e DEV: Update annotations 2019-05-13 15:24:24 +01:00
Joffrey JAFFEUX
3912d6f806
DEV: pikaday 1.8.0 (#7536) 2019-05-13 15:09:04 +02:00
Gerhard Schlager
53d2232731 FIX: Remove trailing slash from topic URL 
this lead to duplicate slashes in concatenated URLs
 2019-05-13 14:51:45 +02:00
Joffrey JAFFEUX
df18243827
FIX: prevents exception if report doest define filters (#7532) 2019-05-13 13:34:28 +02:00
Joffrey JAFFEUX
9a56df89f0
REFACTOR: user-selector (#7529) 2019-05-13 13:03:12 +02:00
David Taylor
2b28abdc21 FIX: Allow underscores in s3_upload_bucket setting 
Underscores are not allowed in s3 bucket names, but they should be allowed in the subfolder name
 2019-05-13 11:18:24 +01:00
Arpit Jalan
25b39b86ae FIX: reload the user record instead of fetching via email 2019-05-13 15:16:53 +05:30
Joffrey JAFFEUX
e64ed9dbc1
REFACTOR: edit-category controller (#7527) 2019-05-13 11:30:32 +02:00