Guo Xiang Tan
40fa96777d
FEATURE: Post deployment migrations. ( #6406 )
...
This moves us away from the delayed drops pattern which
was problematic on two counts. First, it uses a hardcoded "delay for"
duration which may be too short for certain deployment strategies.
Second, delayed drop doesn't ensure that it only runs after
the latest application code has been deployed. If the migration runs
and the application code fails to deploy, running the migration after
"delay for" has been met will cause the application to blow up.
The new strategy allows post deployment migrations to be skipped if the
env `SKIP_POST_DEPLOYMENT_MIGRATIONS` is provided.
```
SKIP_POST_DEPLOYMENT_MIGRATIONS=1 rake db:migrate
-> deploy app servers
SKIP_POST_DEPLOYMENT_MIGRATIONS=0 rake db:migrate
```
To aid with the generation of a post deployment migration, a generator
has been added. Simply run `rails generate post_migration`.
2018-10-08 15:47:38 +08:00
Kyle Zhao
9bbc1ae7b2
FIX: raise if staged user creation failed ( #6461 )
2018-10-08 15:45:23 +08:00
Guo Xiang Tan
3c0ec317ac
DEV: Fix wizard qunit tests not running.
2018-10-08 14:45:56 +08:00
Arpit Jalan
c0bb04d89d
FIX: convert tag string to array when filtering topic list by tags
2018-10-08 08:56:25 +05:30
Jeff Atwood
8825cb1cc5
Merge pull request #6459 from k4rtik/patch-1
...
Add useful note about Elastic Email
2018-10-07 20:24:26 -07:00
Guo Xiang Tan
1b1ef21481
DEV: Improve Jobs::CleanUpEmailLogs
specs.
2018-10-08 11:11:20 +08:00
Penar Musaraj
26956bbe1a
FIX: Safari issue with some emojis ( #6456 )
...
https://meta.discourse.org/t/emojis-selected-on-ios-displaying-additional-rectangles/86132/8
2018-10-08 10:32:25 +08:00
Guo Xiang Tan
43512e9865
Merge pull request #6457 from pmusaraj/yarn-manage-test-vendor-dependencies
...
DEV: Use Yarn managed test vendor dependencies
2018-10-08 09:26:26 +08:00
Guo Xiang Tan
893c0e9d5f
Don't run the pre-release for bundler.
2018-10-08 09:23:39 +08:00
Sam
550e108a8c
FEATURE: only export settings that changed via rake task
2018-10-08 11:54:52 +11:00
Kartik Singhal
e43d9e8de7
Add useful note about Elastic Email
...
See https://meta.discourse.org/t/remove-or-merge-elastic-email-unsubscribe/70236
2018-10-07 11:52:16 -05:00
Vinoth Kannan
4000dddd32
Merge pull request #6458 from vinothkannans/fix-giphy
...
FIX: Display large/broken image placeholders for image oneboxes
2018-10-07 18:08:54 +05:30
Vinoth Kannan
c499872597
FIX: Display large/broken image placeholders for image oneboxes
2018-10-07 17:42:41 +05:30
Jeff Atwood
3b6a525e5b
minor copyedit for bookmarks
2018-10-07 04:17:59 -07:00
Arpit Jalan
2a94bf9dfb
UX: change staff actions logs user label
2018-10-06 13:54:46 +05:30
Kris
41ceb6ca88
topic body and small action widths inconsistent
2018-10-05 18:37:23 -04:00
David Taylor
cbb8f6f0fe
UX: Use 'trash' icon instead of 'times' for deleting small actions
2018-10-05 22:31:56 +01:00
Kris
0a1ac88f2c
last visit line needs more contrast
2018-10-05 15:28:10 -04:00
Kris
fa21b39875
FIX: topic admin menu was clipped on short posts due to overflow hidden
2018-10-05 10:51:27 -04:00
Penar Musaraj
be56f18cdd
Replace deprecated dropdown-button with DropdownSelectBoxComponent ( #6451 )
2018-10-05 09:48:17 -04:00
Grey Baker
6995fd12c6
build(deps): [security] bump nokogiri from 1.8.3 to 1.8.5 ( #6455 )
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.8.3 to 1.8.5. **This update includes security fixes.**
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/master/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.8.3...v1.8.5 )
Signed-off-by: dependabot[bot] <support@dependabot.com>
2018-10-05 09:43:17 -04:00
David Taylor
75488257c5
FIX: Redirect users to top when latest
is the homepage
2018-10-05 12:14:57 +01:00
David Taylor
9bf522f227
FEATURE: Mixed case tagging ( #6454 )
...
- By default, behaviour is not changed: tags are made lowercase upon creation and edit.
- If force_lowercase_tags is disabled, then mixed case tags are allowed.
- Tags must remain case-insensitively unique. This is enforced by ActiveRecord and Postgres.
- A migration is added to provide a `UNIQUE` index on `lower(name)`. Migration includes a safety to correct any current tags that do not meet the criteria.
- A `where_name` scope is added to `models/tag.rb`, to allow easy case-insensitive lookups. This is used instead of `Tag.where(name: "blah")`.
- URLs remain lowercase. Mixed case URLs are functional, but have the lowercase equivalent as the canonical.
2018-10-05 10:23:52 +01:00
Vinoth Kannan
8430ea927e
FIX: Generate webhook payloads before destroy events ( #6325 )
2018-10-05 16:53:59 +08:00
Sam
5b630f3188
FIX: stop logging every time invalid params are sent
...
Previously we were logging warning for invalid encoded params, this can
cause a log flood
2018-10-05 14:33:19 +10:00
Guo Xiang Tan
da39a310c3
Fix missing quotes in unicorn_launcher.
2018-10-05 12:21:07 +08:00
Guo Xiang Tan
07eca289d3
Fix invalid bash syntax.
2018-10-05 12:18:20 +08:00
Guo Xiang Tan
00ae94cb4d
DEV: Prevent unicorn_launcher
from looping forever.
...
For some reason, the new master unicorn process that we
detect might be replaced with another process causing
the script to loop forever.
2018-10-05 12:12:54 +08:00
Guo Xiang Tan
3400624d70
Log pid of launcher script when logging.
2018-10-05 11:48:32 +08:00
Guo Xiang Tan
77c293f82d
Prefer Process.clock_gettime
over Time.now
.
2018-10-05 10:25:52 +08:00
Jeff Atwood
2bdc36bd8c
very minor copyedit on bump date
2018-10-04 17:22:44 -07:00
Kris
948c556cc6
decrease contrast on danger-low color
2018-10-04 17:30:10 -04:00
Kris
98b9913033
UX: Disable button hover effects on touch devices
2018-10-04 17:15:37 -04:00
David Taylor
9554d657c5
DEV: Remove underscore from tags-test
2018-10-04 21:14:52 +01:00
Kris
ab1e5732d7
UX: Category colorpicker restyle
2018-10-04 15:47:46 -04:00
Vinoth Kannan
3faa022c6f
Merge pull request #6453 from vinothkannans/sso_provider_redirect
...
FIX: redirect users to SSO client URL after social login
2018-10-05 00:34:34 +05:30
Vinoth Kannan
ca74246651
FIX: redirect users to SSO client URL after social login
2018-10-05 00:01:08 +05:30
Penar Musaraj
4ae9cb28e4
remove probes.js, highlight.pack.js
2018-10-04 13:50:54 -04:00
Kris
2e28116243
Period-chooser should have visible overflow
2018-10-04 12:28:48 -04:00
Kris
09caf95e7d
create account inputs too wide on iOS
2018-10-04 12:02:28 -04:00
Kris
8e0fe32f37
Minor login layout fixes
2018-10-04 11:54:51 -04:00
Penar Musaraj
cd82107976
use yarn to manage test vendor dependencies, upgrade sinon to v6.3.5
2018-10-04 11:06:14 -04:00
Bianca Nenciu
e0e0a91e7d
FIX: Retry sending email in case of temporary issue. ( #6375 )
2018-10-04 22:56:24 +08:00
David Taylor
5b56a8cd09
DEV: Merge multiple discourse_tagging_spec files
2018-10-04 15:44:29 +01:00
David Taylor
3c2608d41c
FIX: Correctly censor strings starting or ending with non-word characters ( #6445 )
2018-10-04 15:15:10 +01:00
Maja Komel
361ad7ed2b
FEATURE: add indication if incoming email attachment was rejected and inform sender about it ( #6376 )
...
* FEATURE: add indication if incoming email attachment was rejected and inform sender about it
* include errors for rejected attachments in email
* don't send warning email to staged users
* use user object instead of user_id in add_attachments method
2018-10-04 22:08:28 +08:00
Bianca Nenciu
6ad13e5ae9
FIX: Avoid redirection when not leaving forum. ( #6419 )
...
* FIX: Avoid redirection when not leaving forum.
* DEV: Updated click-track's tests.
2018-10-04 22:06:31 +08:00
Paul Trippett
b8a1196b6b
Add missing fields to Upload Fabricator ( #6448 )
2018-10-04 22:00:07 +08:00
Gerhard Schlager
d902bb90ae
Update yarn.lock with integrity hashes
...
This should prevent the stable version of yarn from rewriting the lock file all the time.
2018-10-04 11:21:13 +02:00
Guo Xiang Tan
16dedb5498
Avoid hardcoded value in unicorn_launcher
take 2.
2018-10-04 17:13:27 +08:00