IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-09-05 04:40:41 -05:00
Code Issues Packages Projects Releases Wiki Activity
27,833 Commits 1,018 Branches 579 Tags
53f8f6095d806cca49af9cac21142035fded7bc8
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Guo Xiang Tan b74c108c09 UX: Display group tabs in user's messages tab for non-staff as well. 
https://meta.discourse.org/t/group-inboxes-in-user-messages/86787
 2018-05-17 18:10:17 +08:00
Guo Xiang Tan 3f8e3a6f73 Don't intercept requests in smoke tests. 2018-05-17 16:56:39 +08:00
Guo Xiang Tan b3981ddc43 Shorten User.suggest_name further. 2018-05-17 16:35:03 +08:00
Guo Xiang Tan 147ea37115 FIX: Missing notification for watching first post users when topic is recategorized. 
https://meta.discourse.org/t/not-receiving-notifications-for-announcements/87275/2?u=tgxworld
 2018-05-17 16:15:29 +08:00
Guo Xiang Tan 117763493b Refactor User#suggest_name. 
* Rename `email` to `string` as variable can be an email, username
  or any valid string.
 2018-05-17 14:54:14 +08:00
Guo Xiang Tan f21a47eadd Improve specs to assert for the right record instead of just a count. 2018-05-17 08:47:24 +08:00
Guo Xiang Tan 565fa1f60e Fix regression introduced in https://github.com/tgxworld/discourse/commit/8cf0f51eb2c9ef5c6155d77aab1d0d9c7b104af0. 2018-05-16 14:26:03 +08:00
Guo Xiang Tan bed039aebf Remove incorrect added code in https://github.com/discourse/discourse/commit/d31417d3af5b1742bc98f3a8e406281f7cdbf6a4#diff-655c787458e67d84dc1178f5d2b674f1 2018-05-11 13:19:20 +08:00
Guo Xiang Tan a0fc5de5c4 Revert "Static update for htmlHelper method within bound-avatar helper" 
This reverts commit ba383027e8.
 2018-05-11 13:19:20 +08:00
Guo Xiang Tan 186623acd0 FEATURE: Keep EmailLogs records without a reply_key for 90 days by default. 2018-05-10 15:33:49 +08:00
Guo Xiang Tan c720bf32c3 UX: Add proper titles to topic navigation links in hamburger menu. 
https://meta.discourse.org/t/what-is-the-difference-between-latest-and-new/47809/9?u=tgxworld
 2018-05-10 09:29:02 +08:00
Guo Xiang Tan 36d9f7f814 Revert "UX: Don't set width to auto for select kit combo box." 
This reverts commit c7b526b9e0.
 2018-05-09 14:28:45 +08:00
Guo Xiang Tan c7b526b9e0 UX: Don't set width to auto for select kit combo box. 2018-05-09 14:21:47 +08:00
Guo Xiang Tan 2eb2f273a8 Refactor of PushSubscriptionPusher. 2018-05-09 08:14:14 +08:00
Guo Xiang Tan bbc85258c9 Rename display_plugins -> visible_plugins. 2018-05-09 07:52:45 +08:00
Guo Xiang Tan 630a8ba3d8 Update annotations. 2018-05-09 07:52:45 +08:00
Guo Xiang Tan c6f45fcfdb Expose an API for plugins to be hidden on the admin plugin page. 2018-05-08 13:24:58 +08:00
Guo Xiang Tan 086cb0f849 Fix brittle spec. 2018-05-08 10:52:03 +08:00
Guo Xiang Tan 8cf0f51eb2 UX: Display site settings shortcut for poll and discourse-nginx-performance-report. 
https://meta.discourse.org/t/improving-admin-plugins/84585/29?u=tgxworld
 2018-05-08 10:34:32 +08:00
Guo Xiang Tan ee1eb1a5bd FIX: Retrigger notification when a topic is recategorized. 
https://meta.discourse.org/t/notifications-when-a-topic-is-recategorized/63079
 2018-05-07 21:29:06 +08:00
Guo Xiang Tan 5e45b682a2 Fix JS tests take 2. 2018-05-07 18:34:45 +08:00
Guo Xiang Tan 0042d94f76 Fix broken JS specs. 2018-05-07 18:21:48 +08:00
Guo Xiang Tan fc4fde453d PERF: Remove N+1 query. 2018-05-07 18:21:48 +08:00
Guo Xiang Tan 4f4c576311 FIX: Retrigger search scoped to a topic if topic changes. 
https://meta.discourse.org/t/highlight-the-search-results/10322/12?u=tgxworld
 2018-05-07 17:18:30 +08:00
Guo Xiang Tan b18e0825b5 Update Gemfile.lock. 2018-05-07 17:10:34 +08:00
Guo Xiang Tan 5a57a454fe Revert "FIX: Only show topic timer to staff" 
This reverts commit e3e6fd6ea0.
 2018-05-07 15:59:16 +08:00
Guo Xiang Tan 5993a3ae3a Don't pin version for the webpush gem. 2018-05-07 15:45:20 +08:00
Guo Xiang Tan 21007a4a8d Rewrite push notifications controller specs as request specs. 
* Improve assertions to test for the outcome we expected instead
  of just asserting for a 200 response.

* Remove duplicated assertion.
 2018-05-07 15:40:46 +08:00
Guo Xiang Tan 32147d4ff9 FIX: Search term scoped to topic should be highlighted in widget dom era. 
https://meta.discourse.org/t/highlight-the-search-results/10322/4?u=tgxworld
 2018-05-07 15:17:34 +08:00
Guo Xiang Tan ad833c4485 FIX: Don't downcase group name. 2018-05-07 14:02:11 +08:00
Guo Xiang Tan aa0d32231c FIX: Incorrect query when removing a group owner. 
https://meta.discourse.org/t/group-rename-and-group-owners-removal-problems/85596
 2018-05-07 13:57:00 +08:00
Guo Xiang Tan b618ffb715 Remove file that is no longer used. 2018-05-07 12:07:50 +08:00
Guo Xiang Tan 0d74c30fa7 Remove more uses of rescue nil. 2018-05-07 11:38:23 +08:00
Guo Xiang Tan 77eb93ffb7 Fabricate records with the right attributes during fabrication. 2018-05-07 11:26:38 +08:00
Guo Xiang Tan ee82abba3c Prefer save!/create! over save/create. 2018-04-25 13:39:45 +08:00
Guo Xiang Tan 0e38481d6d Add docker_manager to official plugin list. 2018-04-25 13:02:50 +08:00
Guo Xiang Tan bf6e548692 Remove plugin that is internal to us. 2018-04-24 11:07:49 -04:00
Guo Xiang Tan c148500d51 FIX: Deadlock when topic with auto close topic timers exceeds auto_close_topics_post_count. 2018-04-23 13:34:24 +08:00
Guo Xiang Tan d2d3c7d24e FIX: Only show offline page when user is offline. 
https://meta.discourse.org/t/cannot-load-app-in-firefox-sometimes-refresh-fixes-it/85258
 2018-04-23 10:22:20 +08:00
Guo Xiang Tan 9eabf7c02c Fix randomly failing specs due to SearchLog cache. 2018-04-23 10:10:10 +08:00
Guo Xiang Tan d0353fb2f2 Run plugin specs for discourse-staff-notes on travis. 2018-04-23 09:26:33 +08:00
Guo Xiang Tan 80847d83a8 Mark discourse-voting and discourse-staff-notes as official. 2018-04-23 09:26:13 +08:00
Guo Xiang Tan 98d880b67a Missed a spot in https://github.com/discourse/discourse/commit/45fe5dc793e8baf06c7d35e530842e5fff189828 2018-04-20 13:59:19 +08:00
Guo Xiang Tan 45fe5dc793 $redis.client -> $redis._client. 
See https://github.com/redis/redis-rb/commit/c239abb43c2dce99468bf94652a3c48b31a1041a
 2018-04-20 13:01:17 +08:00
Guo Xiang Tan 9c9fa4537c Update Redis gems. 2018-04-20 12:49:36 +08:00
Guo Xiang Tan 56b3527eb8 Upgrade Sidekiq. 2018-04-20 11:47:40 +08:00
Guo Xiang Tan 116ddec22e UX: Don't match emails in user selector in group add members modal. 
https://meta.discourse.org/t/cant-add-members-to-a-group/85738?u=tgxworld
 2018-04-20 10:28:52 +08:00
Guo Xiang Tan 70d181bff8 FIX: Better error message in GroupsController#add_members. 
https://meta.discourse.org/t/cant-add-members-to-a-group/85738?u=tgxworld
 2018-04-20 10:28:52 +08:00
Guo Xiang Tan 7bf9650e96 Remove comment that is no longer accurate. 2018-04-18 14:22:18 +08:00
Guo Xiang Tan ad4c25e004 PERF: Only save site setting if values have been changed. 2018-04-17 21:07:39 +08:00
Guo Xiang Tan 2d9d77d390 Fix the build. 2018-04-17 18:16:53 +08:00
Guo Xiang Tan 64a45b0980 FIX: Missing Group#bio_raw attribute for group owners. 
https://meta.discourse.org/t/group-description-does-not-load-in-editor-for-owners-who-are-not-staff/85345
 2018-04-17 15:57:52 +08:00
Guo Xiang Tan 28fbee04df Allow auto close site settings to be shadowed by global. 2018-04-17 14:23:44 +08:00
Guo Xiang Tan 2024ea5bd3 Make Eslint happy. 2018-04-17 12:15:13 +08:00
Guo Xiang Tan 1b9a38c5e2 FIX: Incorrect formatter used when logstash formatter is enabled. 2018-04-17 12:07:52 +08:00
Guo Xiang Tan 828bfd9d27 Add specs for https://github.com/discourse/discourse/commit/c74c933996e2775ca7765a82916adc6ca7055226. 2018-04-17 10:08:39 +08:00
Guo Xiang Tan 6cce839f0a FIX: Missing action to trigger add group members modal for group owners. 
https://meta.discourse.org/t/unable-to-add-members-to-a-group-as-group-owner-who-is-not-staff/85346?u=tgxworld
 2018-04-16 09:09:47 +08:00
Guo Xiang Tan a902d5b27f Replace ActiveSupport::Logger with DiscourseLogstashLogger when enabled. 2018-04-13 12:08:27 +08:00
Guo Xiang Tan e43baafa02 UX: Link to automatic group page on user admin page. 2018-04-13 10:46:30 +08:00
Guo Xiang Tan 67ab6ab751 UX: Better 'saved' indication on group manage form. 2018-04-13 10:18:09 +08:00
Guo Xiang Tan b3a88109a8 Minor UX tweaks to group pages. 2018-04-13 10:10:42 +08:00
Guo Xiang Tan 501d4ca564 UX: Align group members button/dropdown to the right. 2018-04-13 09:17:22 +08:00
Guo Xiang Tan 90dd12611c UX: Use a wrench for group-member-dropdown. 2018-04-13 08:01:00 +08:00
Guo Xiang Tan a389baeb07 FIX: Group pages should work when group name contains periods. 
https://meta.discourse.org/t/group-name-cant-have-dot-inside/48658
 2018-04-12 17:11:36 +08:00
Guo Xiang Tan 6e46f81123 Add a distributed mutex around user creation via SSO. 
* When two SSO requests containing the same email in the payload are
  sent at the same time, it would sometimes result in two users
  being created but one without an email record. Investigations
  points to ActiveRecord not generating the right statements but
  we have no figured out the reproduction steps yet. We should review
  this after upgrading to Rails 5.2.
 2018-04-12 16:18:49 +08:00
Guo Xiang Tan c0595ebe99 FIX: Disable save button when new group form is empty. 
https://meta.discourse.org/t/adding-owners-members-ux-is-inconsistent-and-misleading/58084/26?u=tgxworld
 2018-04-12 10:29:36 +08:00
Guo Xiang Tan 71b2f8ae1d Use an ENV to trigger --remote-debugging-port instead. 2018-04-12 10:12:02 +08:00
Guo Xiang Tan 560bb02f7c --remote-debugging-port is our best friend in headless mode. 2018-04-12 08:56:58 +08:00
Guo Xiang Tan 66abd340db Fix randomly failing JS build. 
For some reason, the test rack server would block on
a `/letter_avatar_proxy` route causing ajax requests to
stack up.
 2018-04-11 22:23:49 +08:00
Guo Xiang Tan 3b9a656439 FIX: An option in aliasLevelOptions was accidentally removed. 2018-04-11 11:03:44 +08:00
Guo Xiang Tan 9176b2591d UX: Replace route when users try to access invalid group management page. 
https://meta.discourse.org/t/unable-to-save-changes-to-a-group/84954
 2018-04-11 10:55:45 +08:00
Guo Xiang Tan 867f327055 Remove horizontal padding for group navigation links. 2018-04-10 14:22:57 +08:00
Guo Xiang Tan 874003b7b1 FIX: Group can't be deleted if certain users are demoted. 2018-04-10 14:19:35 +08:00
Guo Xiang Tan 9df4f7bf8e UX: Move group delete button to details container. 2018-04-10 14:19:35 +08:00
Guo Xiang Tan ffb7ec2543 Fix the build. 2018-04-10 09:50:00 +08:00
Guo Xiang Tan d9d86577ff FIX: Staff users are not affected by enable_group_directory site setting. 2018-04-10 09:22:01 +08:00
Guo Xiang Tan c82b2dcc24 Remove admin group management pages. 2018-04-09 15:14:50 +08:00
Guo Xiang Tan 4319273cf5 UX: Split up group form into smaller sections. 2018-04-09 15:14:50 +08:00
Guo Xiang Tan a2b9a55036 FIX: Binding style attributes need to be escaped. 
See http://emberjs.com/deprecations/v1.x/#toc_binding-style-attributes
 2018-04-06 14:58:38 +08:00
Guo Xiang Tan 802a327ee3 Update URL for presence plugin. 2018-04-06 12:46:42 +08:00
Guo Xiang Tan 63ac34ed79 Move official plugin icon under own header. 2018-04-06 12:44:31 +08:00
Guo Xiang Tan 0623785f69 FIX: Prevent group owners from editing admin only settings. 2018-04-06 11:44:58 +08:00
Guo Xiang Tan 2ddcdf8704 UX: Add an icon to indicate if a plugin is official. 
https://meta.discourse.org/t/improving-admin-plugins/84585
 2018-04-06 10:54:58 +08:00
Guo Xiang Tan eb755dd2a7 Fix the build. 2018-04-06 10:40:57 +08:00
Guo Xiang Tan e4a9242ada FIX: Can't upload backup. 
* Regression introduced in https://github.com/discourse/discourse/commit/142571bba010eedbdfc1452d42beccc72389c373
 2018-04-06 10:14:17 +08:00
Guo Xiang Tan 5da7c2a4ad FIX: Restorer wasn't rolling back if restore fails. 
* This only applies to backup file taken with
  pg_dump 10.3+ and pg_dump 9.5.12+.
 2018-04-06 09:43:32 +08:00
Guo Xiang Tan e36e9de28a Allow admin to view logs of automatic groups. 2018-04-05 16:31:55 +08:00
Guo Xiang Tan a26d3fc2de Missing save button when editing automatic groups. 2018-04-05 15:25:39 +08:00
Guo Xiang Tan d7943cc3db Make eslint happy. 2018-04-05 15:21:11 +08:00
Guo Xiang Tan 85bcda120a Basic UX improvements to the group profile management page. 2018-04-05 14:59:04 +08:00
Guo Xiang Tan 8760c4d68c Fix GroupsController#group_params to allow more group attributes to be updated. 2018-04-05 13:53:00 +08:00
Guo Xiang Tan 689144b2bf Upgrade Mail gem. 2018-04-04 18:35:40 +08:00
Guo Xiang Tan e04d09d148 Add Process pid to lograge output as well. 2018-04-04 18:31:29 +08:00
Guo Xiang Tan 746889bbc1 Include hostname in lograge payload. 2018-04-04 18:24:30 +08:00
Guo Xiang Tan e6d07fa6d8 UX: Allow admins to manage automatic groups on group page. 2018-04-04 11:07:11 +08:00
Guo Xiang Tan 4f7f733ab0 Upgrade docker:test to use PG 10. 2018-04-04 10:28:23 +08:00
Guo Xiang Tan 6f32de186a UX: Add a "add members" button on group page. 2018-04-03 17:35:18 +08:00
Guo Xiang Tan 00d879ec63 Fix the build. 2018-04-03 00:44:12 +08:00
Guo Xiang Tan 2498403bc3 Revert "FIX: Username uniqueness check should not happen to current user_id" 
This reverts commit f71a18facd.
 2018-04-03 00:44:04 +08:00
Guo Xiang Tan 221503cd10 FIX: Add server side uniqueness validations for Group#name and User#username. 
https://meta.discourse.org/t/groups-can-be-given-same-name-as-existing-username/74010
 2018-04-02 18:19:18 +08:00