This version corrects a bug where fluentui emojis didn't have a
transparent background. To ensure the cache is cleared and we don't
serve incorrect emojis anymore we had to bump the emoji version.
Previously, when staged users were disabled and a category allowed
strangers via `email_in_allow_strangers`, incoming emails would
automatically fallback to using the system user to create topics.
Change introduced in this PR
https://github.com/discourse/discourse/pull/34655
This change adds a new hidden site setting
`email_in_allow_system_user_fallback` (default: false) that controls
this behavior. When disabled, emails from strangers will raise a
UserNotFoundError instead of creating topics as system user.
The previous message states that the topic will be closed momentarily
but this is not true as the topic is closed immediately.
This commit also removes the `topic.auto_close_momentarily` i18n key
since it isn't being used anywhere else.
Some styling changes have also been made to make the warning message
clearer.
Steps to reproduce:
* Start drafting a reply to a topic
* Write some text.
* Navigate to a different topic while keeping the draft open
* Click reply on the composer and choose cancel in the modal asking
which topic you want to reply to.
* Write some more text.
* Copy the text you have written or memorize your input.
* Reload the page/ close the composer.
* Navigate back to the topic you replied to
* Open your draft.
* Everything written after clicking cancel is missing.
This was happening because we weren't doing anything on Cancel for
the topic reply choice dialog, and we were doing `disableDrafts` before
opening the dialog, so drafts never resumed.
The fix is to just save the current draft on cancel then turn on
draft saving again so the user can continue typing and delay the
question about "Which topic do you want to reply to?" until later.
c.f.
https://meta.discourse.org/t/draft-is-no-longer-automatically-saved-after-you-cancel-replying/386370
Also rename TopicLabelContent to TopicReplyChoiceDialog, it
is more specific and reflects what the component actually does.
When multiple flaky tests are encountered, we sometimes exceed the 20
minutes timeout. Since we are on self hosted runners now where costs are
much lower, it is OK for us to have longer timeouts.
When the user is editing a draft in multiple windows, they get a dialog
asking if they want to reload or ignore. The ignore button didn't have
the correct border radius, due to it missing `btn-default` (double `btn`
classes instead). This PR adds `btn-default` for that button.
```html
<div class="dialog-footer">
<button class="btn btn-primary" type="button">
<span class="d-button-label">Reload</span>
</button>
↓
<button class="btn btn" type="button">
<span class="d-button-label">Ignore</span>
</button>
</div>
```
<img width="1502" height="970" alt="image"
src="https://github.com/user-attachments/assets/bcc7ac5f-70d0-4c87-abee-dee6090ea1ec"
/>
In `Chat::ChannelFetcher.secured_direct_message_channels_search`,
`User.preload_custom_fields` is called with `channels.flat_map {
_1.chatable.users }`. However,
the `Chat::DirectMessageSerializer` was getting the users via
`object.direct_message_users.map(&:user)` which uses the
`Chat::DirectMessage.direct_message_users` scope instead of the
`Chat::DirectMessage.users` scope resulting in ActiveRecord returning
new `User` objects that do not have user custom fields preloaded.
This fixes the appearance of AI generated gists in the topic list on
/filter, and also includes the gist toggle via a new plugin outlet on
/filter called `after-filter-navigation-menu`.
This shares the state with the discovery route toggle (which is separate
from PM toggle state). I've also added tests to cover gist appearance on
/filter. Before the /filter state was shared with PM state, which was
incorrect.
Before:
<img width="2232" height="424" alt="image"
src="https://github.com/user-attachments/assets/b22ed7a6-388e-4b88-99d4-e9e10af6275a"
/>
After:
<img width="2272" height="506" alt="image"
src="https://github.com/user-attachments/assets/cae03f12-9153-4bcb-a9d3-52712fb2d945"
/>
Having it in d-ai's plugin.rb file solves it when running plugin tests.
But when running core tests, plugins are not loaded, but the tables
still exist in the database.
Followup to 6247fdc255
Updates `prosemirror-model` to use this fix: [When preserving
whitespace, replace newlines with line break replacements
](https://github.com/ProseMirror/prosemirror-model/commit/79e9f2b9497ec3aac70d180aa846267dafa48d9a)
Adds `linebreakReplacement: true` to our hard break node spec
definition.
Adds a system test to confirm a `white-space: pre` HTML pasted from the
clipboard parses new lines as hard breaks.
**Description**
Replaces separate @strip_images and @markdown_images boolean flags with
a single @image_mode variable that can be :strip, :markdown, or nil.
Keeping the interface but ensuring only one
When adding a note through the timeline tab, the note wasn't being
persisted to the reviewable's reviewable_notes array. This caused the
note to disappear when switching between tabs.
This is a follow up to cf4193e6e1.
When chat is being initialized, we initiate an async request to
`/chat/api/me/channels` via `this.chat.loadChannels` but do not await on the request to be completed.
This is fine when a user is not visiting a chat channel route directly.
However, not awaiting on `this.chat.loadChannels` can cause problems
like a user's thread list or drafts to not be displayed if the
`/chat/api/me/channels` request does not return before rendering
happens. To resolve this, we will now wait for the promise in
`this.chat.loadChannels` to resolve before allowing rendering to happen on the `ChatChannelRoute`.
When a `PUT`, `POST`, or `DELETE` operation doesn't need to return any
data, we've historically either returned nothing, or `{ success: "OK"
}`.
A more consistent way to return the same data would be with a 204 status
response. This gives the same information as the `{ success: "OK" }`
body (ie, that the operation successfully completed), without needing to
read or parse the response body.
This change adds a 204 response for `Admin::SiteSettingsController`.
Additional controllers could be migrated in follow-up PRs, or on an
ad-hoc basis.
This change adds a new `ReviewableActionBuilder#build_bundle` helper for
quickly defining action bundles that can be performed on reviewables.
`ReviewableActionBuilder#build_action` has also been updated to allow
plugin-defined actions to appear correctly.
The core reviewable types have been updated to use this new method, and
I've also added support for reviewable chat messages, to demonstrate
plugin support.
Co-authored-by: Krzysztof Kotlarek <kotlarek.krzysztof@gmail.com>
Since the new modifier has been added, some specs were not using using
the focus check on the composer (included in `fill_composer` method) and
we were actually not focused which was causing these specs to fail.
The `{{prevent-scroll-on-focus}}` modifier is a workaround for a bug in
iOS where safari won't follow `preventScroll: true` and will actually
scroll. I thought that not having the timeout would be good enough, but
we actually need this delay to ensure we are past the moment where
safari will start respecting `preventScroll: true`.
The `RSVP.Promise` polyfill has some subtle differences to native
promises. In this case, we ran into a problem where calling `reject()`
inside JQuery's `error` handler would throw an exception, and then stop
JQuery's own error cleanup from running. That caused subtle problems,
like the global `ajaxError` event failing to fire.
Switching from `RSVP.Promise` to `Promise` normally introducing subtle
timing changes. However, I think in this case we are insulated from that
because we're already calling resolve/reject via `@ember/runloop`'s
`run()` function. 🤞
To simplify our repository architecture, we're moving the admin panel from a separate package(/ember-addon) to a directory inside the main app package. This will make future configuration of tools like typescript/glint, and Vite, much easier. It also means that the admin panel is now transpiled via Webpack, and can internally make use of async-imports and bundle-splitting.
Admin modules will now be referenced like `discourse/admin/...`. Backwards-compatibility is maintained for the old import paths via a custom babel transform.
A 'compatModules' technique is used to keep all of the admin invokables and routes/controllers/templates available to Ember's resolver.
Adds a safe inset bottom for lightbox captions on mobile and removes
image padding on small screens. This change also applies bottom
depending on whether caption is being set or not.
How it looks:
<img width="225" height="487" alt="IMG_9334"
src="https://github.com/user-attachments/assets/d92d379a-ad63-44d0-8320-a0861b2a10e4"
/>
Instead of having to clean an array in a contract using a
`before_validation` block, for example, we can now pass `compact_blank:
true` to the attribute, like this:
```ruby
attribute :ids, :array, compact_blank: true
```
Updates `prosemirror-inputrules` to use this fix:
https://github.com/ProseMirror/prosemirror-inputrules/commit/7f63cfbb58310394ee83c578b2c910311b59428c
Adjusts our `markInputRule` so we can type something like
```
**`code`**
```
And the `code` will get the `strong` input rule applied, but cases like
these should not apply the `strong` input rule:
```
`** code` **
*`* code`**
**`code*`*
etc
```
And adds a simple test.
In "_correctMissingState()" we should not be breaking out of the for
loop on the first topic we've already seen, instead we should continue
iterating over all the information provided by the server.
Internal ref - t/105864/20
Co-authored-by: Kudzai Tuso <kudzai@discourse.org>
dependabot[bot]anddependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Joffrey JAFFEUX
Krzysztof Kotlarek
Alan Guo Xiang Tan
Martin Brennan
Bryce Huhtala
chapoi
Kris
Blake Erickson
Sérgio Saquetim
David Taylor
Renato Atilio
Juan David Martínez Cubillos
Tomas Vavrda
Justin Moore
Gary Pendergast
Jarek Radosz
David Battersby
Loïc Guitaut
Jordan Vidrine
Régis HanolandKudzai Tuso