IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-08-14 06:55:03 -05:00
Code Issues Packages Projects Releases Wiki Activity
33,349 Commits 976 Branches 574 Tags
6a274fd2cd8512bf384d7e4f67903dde3d63f366
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Robin Ward 2e0a40007b FIX: Category topics should not be deletable via review queue 2019-05-30 16:43:23 -04:00
Robin Ward c4fa20d644 FIX: Broken test, also typoed property 2019-05-30 14:27:28 -04:00
Robin Ward 5e89714f77 FIX: Linting via prettier 2019-05-30 13:58:06 -04:00
Robin Ward 7a9e85b1d7 FIX: Don't show the "Flag to delete" message to staff 
If they can't delete, flagging should not either.
 2019-05-30 13:31:40 -04:00
Robin Ward 9bdfaa195e FIX: We shouldn't memoize the last time something is read 2019-05-28 10:51:18 -04:00
Robin Ward b85fa62882 FIX: Don't send replies to flags that are ignored by expiry 
The `AutoQueueHandler` will ignore really old flags. In that case, don't
notify the user that the moderator is looking into it. They probably
never saw it because it didn't meet the reviewable minimum priority.
 2019-05-27 17:24:36 -04:00
Robin Ward 03b4131933 FIX: When deleting a user via queued posts, block urls, ip and email 2019-05-27 15:54:01 -04:00
Robin Ward d26c4509ea FIX: Adding a user to a group twice under concurrency 
This prevents an error from being raised / logged.
 2019-05-27 15:42:40 -04:00
Robin Ward d95a68b837 FEATURE: When suspending a user, allow the Delete + Replies action 
Previously you could only delete the post
 2019-05-27 12:27:16 -04:00
Robin Ward 912f1d83ac UX: Adjust text a little more 2019-05-27 09:06:46 -04:00
Robin Ward 0725b614c9 UX: Better language about sensitivity 2019-05-24 16:02:00 -04:00
Robin Ward 4b796eebe0 UX: Try tweaking how soon images are lazily loaded 2019-05-24 15:52:48 -04:00
Robin Ward 1e72f44c01 Tweak the default sensitivities 2019-05-24 15:49:29 -04:00
Robin Ward 89b84651c3 Migrate score settings to use sensitivities 
We hide scores so these settings no longer made sense.
 2019-05-24 15:44:24 -04:00
Robin Ward fad5d9c49b Use an Enum class for the Reviewable Priority Site Setting 2019-05-24 15:44:24 -04:00
Robin Ward 648af78298 FIX: Linting 2019-05-23 12:16:45 -04:00
Robin Ward f73988acd2 Remove unused computed property. 2019-05-23 12:06:18 -04:00
Robin Ward e74cd54fc6 REFACTOR: Replace score bonuses with low/med/high priorities 
We removed score from the UX so it makes more sense to have sites set
priorities instead of score bonuses.
 2019-05-23 11:54:45 -04:00
Robin Ward ca03baf2b2 UX: Hide pending score statuses 2019-05-22 11:26:17 -04:00
Robin Ward 225593d445 FIX: Small tweak to percentiles based on feedback 2019-05-16 13:45:36 -04:00
Robin Wardnlalondepmusaraj
 		fb1da53dff FIX: Issue with incorrect heights when cloaking plugin content in posts 
We noticed this with the house ads plugin. It inserted content after a
post, which was not taken into account when calculating and memoizing
the height of the element.

Co-authored-by: nlalonde
Co-authored-by: pmusaraj
 2019-05-13 11:29:21 -04:00
Robin Ward 01bd82139f FIX: Invalid URL for queued posts review 2019-05-10 10:00:52 -04:00
Robin Ward b3873b95d0 FIX: Pluralization error for tag error message 2019-05-10 09:54:54 -04:00
Robin Ward 643c75c419 FIX: Don't increment version if the reviewable operation fails 
In fact, roll back the entire operation in the database.
 2019-05-10 09:53:25 -04:00
Robin Ward b380ed5282 FEATURE: Claim Reviewables by Topic 
This is a feature that used to be present in discourse-assign but is
much easier to implement in core. It also allows a topic to be assigned
without it claiming for review and vice versa and allows it to work with
category group reviewers.
 2019-05-09 13:40:36 -04:00
Robin Ward b409dab77f Rename flags_default_topics to reviewable_default_topics 
This functionality regressed with the reviewable update. I took the
opporunity to rename it when fixing it for clarity.
 2019-05-08 10:07:10 -04:00
Robin Ward 5af7c90bab FEATURE: Hide Reviewable scores, change score filter to Priority 
We found score hard to understand. It is still there behind the scenes
for sorting purposes, but it is no longer shown.

You can now filter by minimum priority (low, med, high) instead of
score.
 2019-05-07 14:05:23 -04:00
Robin Ward c403569895 Remove unused translation keys 
cc @gschlager
 2019-05-07 08:27:30 -04:00
Robin Ward 47995d2d89 FIX: Your own likes were missing on posts 2019-05-06 20:03:50 -04:00
Robin Ward e9564c999f FIX: We just show likes to see like count 2019-05-06 18:19:45 -04:00
Robin Ward 310e196aca FIX: like-count has been removed from the post menu 2019-05-06 17:48:57 -04:00
Robin Ward 18d742d334 FIX: Broken spec 2019-05-06 17:09:08 -04:00
Robin Ward 31e100530f FEATURE: Flag count in post menu 
This change shows a notification number besides the flag icon in the
post menu if there is reviewable content associated with the post.
Additionally, if there is pending stuff to review, the icon has a red
background.

We have also removed the list of links below a post with the flag
status. A reviewer is meant to click the number beside the flag icon to
view the flags. As a consequence of losing those links, we've removed
the ability to undo or ignore flags below a post.
 2019-05-06 16:13:31 -04:00
Robin Ward 99a2a769d4 FIX: Conflict error (version was already used) 2019-05-03 16:36:37 -04:00
Robin Ward 15c9b00307 FEATURE: Show edit indicator on review queue 
If a flagged post has edits, show the pencil icon and pop up the history
window when clicked.
 2019-05-03 11:21:33 -04:00
Robin Ward 3cb0d27d38 DEV: Upgrade our widget handlebars compiler 
Now supports subexpressions such as i18n and concat, plus automatic
attaching of widgets similar to ember.
 2019-05-02 15:47:57 -04:00
Robin Ward 885f1e7e5f FIX: Allow category group reviewers to edit queued posts 
They can edit title, body and tags. Category is disabled for now as it
could lead to some odd security issues.
 2019-05-01 14:48:49 -04:00
Robin Ward 0f01c9d25f FIX: Posts in the approval queue were sometimes dropping category 2019-05-01 14:40:38 -04:00
Robin Ward da0e37512a FIX: Add test to confirm updating category works. 
Also replaces a missing translation key that 99.9% of users would never
see.
 2019-05-01 11:37:28 -04:00
Robin Ward 404b35bd04 FEATURE: Category Reviewable by Group 
Allow a group to review content in a particular category.
 2019-04-30 15:23:06 -04:00
Robin Ward dd29af4475 REFACTOR: {{avatar}} and {{date}} helpers in vdom templates 
This is a step towards a nicer flag display under posts.
 2019-04-30 15:22:38 -04:00
Robin Ward 812905cbb6 FIX: Recursively delete nested replies 
Previously we were only deleting top level replies
 2019-04-30 12:54:53 -04:00
Robin Ward 646cdfa449 FIX: Approved posts were not enqueueing alerts 2019-04-23 17:30:12 -04:00
Robin Ward fca3f53e9c FIX: Safer scoring with concurrency 2019-04-23 15:53:37 -04:00
Robin Ward 70097966ed FIX: Don't add the reviewable score twice 2019-04-23 15:46:18 -04:00
Robin Ward 21b975e71a FIX: Broken plugin spec 2019-04-23 15:29:26 -04:00
Robin Ward 6f56fba016 UX: Update post actions to "Approve Post" and "Reject Post" 
This should be more clear.
 2019-04-23 12:19:11 -04:00
Robin Ward a8e3ac90a0 FIX: nil error in list, incorrect count in reviewable pending 2019-04-22 12:18:57 -04:00
Robin Ward 85d8d5d092 FIX: Lint 2019-04-18 13:49:28 -04:00
Robin Ward 8e77b4d58e FIX: Replace references to flags in the header with review 2019-04-18 13:25:23 -04:00
Robin Ward cd2e93b598 FIX: Show when a post has been deleted in the flag review queue 2019-04-17 16:14:36 -04:00
Robin Ward 14f9d40e48 FEATURE: Clarify Reviewable User Actions 
"Approve" is now "Approve User" and "Delete" is a dropdown with a choice
that allows you to block.
 2019-04-17 11:44:17 -04:00
Robin Ward ba6d4b2a8d FIX: Better handling for toggling must_approve_users 
If you turn it on now, default all users to approved since they were
previously. Also support approving a user that doesn't have a reviewable
record (it will be created first.)

This also includes a refactor to move class method calls to
`DiscourseEvent` into an initializer. Otherwise the load order of
classes makes a difference in the test environment and some settings
might be triggered and others not, randomly.
 2019-04-16 15:56:35 -04:00
Robin Ward 3ceff0a92a FEATURE: Send the user a notification when their post is approved 2019-04-15 16:20:16 -04:00
Robin Ward fca3044b10 UX: When editing a reviewable, show created_by 2019-04-15 15:11:34 -04:00
Robin Ward d859e1594e UX: Add a description for scores 2019-04-15 14:21:25 -04:00
Robin Ward ef1af53e05 FIX: If creating an active user via the API, create reviewables 2019-04-12 15:25:02 -04:00
Robin Ward f7ebfb1acc FIX: Only consider pending queued posts for cleaning up uploads 2019-04-12 14:39:32 -04:00
Robin Ward 534d75310f FIX: Linting 2019-04-12 14:34:14 -04:00
Robin Ward a5d9afe397 FEATURE: Include a user's pending posts in the topic view 
Also includes a refactor to TopicView's serializer which was not
building our attributes using serializers properly.
 2019-04-12 14:25:12 -04:00
Robin Ward 1760069419 FIX: Our rspec suite should not require a network connection to github 2019-04-12 14:25:12 -04:00
Robin Ward c0c236f36e FIX: Better to put a ReviewableUser back into pending than silently fail 2019-04-11 16:36:47 -04:00
Robin Ward 6f7b6a3333 FIX: Disagree and Restore should not revert edits 2019-04-11 16:21:18 -04:00
Robin Ward d21dd521d2 FIX: Don't try to create a reviewable user twice 2019-04-11 12:30:54 -04:00
Robin Ward 331a809738 FEATURE: Display the reason for many reviewable items 
Queued Posts and Users will now display a reason why they are in the
review queue.
 2019-04-11 12:04:45 -04:00
Robin Ward 87de5d9e8f Record the reason that a post was put into the queue 2019-04-10 17:42:49 -04:00
Robin Ward 0489970f72 FIX: Missing translations 2019-04-10 16:51:08 -04:00
Robin Ward adb9009374 SECURITY: Update Handlebars to 4.1 
This is to address: https://www.npmjs.com/advisories/755

It is a low priority fix, as Discourse does not allow end users to input
raw handlebars templates.
 2019-04-10 15:38:21 -04:00
Robin Ward abf4ca9774 FIX: Should be able to recover a user deleted post if raw didn't change 2019-04-10 13:10:40 -04:00
Robin Ward cab83596ec FIX: Sites with SSO that required approval were not creating reviewables 2019-04-10 12:53:50 -04:00
Robin Ward 5d99346740 FIX: Always allow us to reject users, even if they are deleted 2019-04-10 11:00:39 -04:00
Robin Ward 9ebfdaa356 UX: Unify reviewable scores + history 2019-04-09 16:43:08 -04:00
Robin Ward 103918af0f FIX: Pending users email went to the wrong place 2019-04-09 15:35:16 -04:00
Robin Ward 9bcd7aacc8 Remove deprecation, the admin controller can approve just fine 2019-04-09 11:19:19 -04:00
Robin Ward 692e09d813 FIX: Only show "Approve" button for the admin user if reviewable 2019-04-09 11:14:52 -04:00
Robin Ward 4552d86605 FIX: Broken tests 2019-04-09 08:33:10 -04:00
Robin Ward bc949cf684 FIX: Display the username instead of {{username}} 2019-04-08 16:46:05 -04:00
Robin Ward 32a0346069 UX: Don't show the username of the first user in the conversation 2019-04-08 16:39:53 -04:00
Robin Ward cc53f902c6 FIX: Missing translation key for Reviewable -> Deleted 2019-04-08 16:12:41 -04:00
Robin Ward df1ab9259b FIX: Take action should agree with all pending flags 2019-04-08 12:39:18 -04:00
Robin Ward 0fc798c2ef UX: Show the score status 
If a review review score has been Approved/Rejected/Ignored then show it
 2019-04-08 12:08:18 -04:00
Robin Ward 13c6bf54d0 FIX: Sometimes queued post would have a string for a category 
In this case, don't migrate the old queued post category
 2019-04-06 20:38:38 -04:00
Robin Ward a6f283da30 UX: Show tags on flags too 2019-04-05 14:22:45 -04:00
Robin Ward 8181ad646b FIX: Queued Posts were not saving tags properly 2019-04-05 14:07:47 -04:00
Robin Ward b005a84530 FIX: decoratorHelper.widget is not always present 2019-04-05 12:07:24 -04:00
Robin Ward cbc311e4ed UX: Update the reviewable count before the message bus 
In certain edge cases, the message bus won't send the message to the
user about the updated review count and it can go out of sync.

This patch synchronizes the review count every time:

1. The user visits the "Needs Review" page

2. Every time the user performs an action
 2019-04-05 10:35:38 -04:00
Robin Ward 9c2e6b9a54 FIX: Migrated flags should be reviewable by moderators 2019-04-05 10:04:23 -04:00
Robin Ward c9ddc6ce30 FIX: Make sure the site setting works and fix build 2019-04-04 17:44:10 -04:00
Robin Ward aa4a38b08a FIX: computed is not used 2019-04-04 17:38:27 -04:00
Robin Ward 8af7237092 FIX: Only perform logic on create commits 2019-04-04 17:01:47 -04:00
Robin Ward df48c657fd FIX: Reviewable counts were not updating properly 
Sometimes sidekiq is so fast that it starts jobs before transactions
have comitted. This patch moves the message bus stuff until after things
have comitted.
 2019-04-04 16:07:34 -04:00
Robin Ward 2055804e95 FIX: The option to delete replies was missing from the new review queue 2019-04-04 15:51:36 -04:00
Robin Ward dd5b8bd85e FIX: Show replies to the post, not the topic 
This makes more sense when reviewing. How many people replied to this
objectionable thing?
 2019-04-04 15:13:59 -04:00
Robin Ward 9c8cc73c39 UX: Show user fields when reviewing a user 2019-04-04 14:45:40 -04:00
Robin Ward a5182b0d6c FIX: Rewrite old /admin/flags links to use the review queue 
Such links might be in present in old PMs. For example, a notification of
outstanding flags.

New PMs should receive the correct link but this prevents 404s in the
other case.
 2019-04-04 10:15:23 -04:00
Robin Ward 588f61f717 FIX: Linting 2019-04-03 18:08:07 -04:00
Robin Ward a4ff593506 UX: Slightly improved reviewable user display, plus link to admin if possible 2019-04-03 17:07:48 -04:00
Robin Ward 111a502231 FIX: Deleting Users should work nicely with Reviewable Users 
"Rejecting" a user in the queue is equivalent to deleting them, which
would then making it impossible to review rejected users. Now we store
information about the user in the payload so if they are deleted things
still display in the Rejected view.

Secondly, if a user is destroyed outside of the review queue, it will
now automatically "Reject" that queue item.
 2019-04-03 16:42:39 -04:00
Robin Ward 828cdf3fea FIX: Protected method called, I'll fire myself now 2019-04-03 16:10:36 -04:00
Robin Ward 82bddcbe51 FIX: Don't create two reviewable scores for a user 2019-04-03 16:03:32 -04:00