IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-09-05 04:40:41 -05:00
Code Issues Packages Projects Releases Wiki Activity
31,557 Commits 1,018 Branches 579 Tags
7cb194f2dbb8edbfa7b5fd9acf04c48ab48fe142
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Guo Xiang Tan 7da7a30e02 PERF: Restore exists? in favor of blank?. 
Regression from dcd7b92532.
 2019-02-18 10:04:21 +08:00
Guo Xiang Tan a1b4d9b061 DEV: Fix specs using deprecated site settings. 2019-02-01 12:31:03 +08:00
Guo Xiang Tan 60c1cd9f81 FIX: Return 400 when username params is invalid. 2019-01-30 16:06:55 +08:00
Guo Xiang Tan 0e5c7f5da7 DEV: Update annotations. 2019-01-30 09:34:51 +08:00
Guo Xiang Tan ac004297fa PERF: Add index on user_id to single_sign_on_records. 2019-01-30 09:34:19 +08:00
Guo Xiang Tan 49b21727ee Update rails_multisite to 2.0.6. 2019-01-23 17:42:59 +08:00
Guo Xiang Tan 0cf2df3028 Fix remap in migrate_to_s3 rake task. 
The current way of doing the remap only allows to run the rake task
once. Running the rake task more than once will end up badly.
 2019-01-23 15:50:44 +08:00
Guo Xiang Tan 07850994d3 Add ENV to skip multisite prefix when migrating to s3. 2019-01-23 15:19:50 +08:00
Guo Xiang Tan 979d03aa68 Remove s3 bucket check in migrate_to_s3 task. 
Bucket creation is expected to be handled by the user. If the bucket
does not exist, the script will fail anyway.
 2019-01-23 15:04:51 +08:00
Guo Xiang Tan 99cd3ff6ee FIX: migrate_to_s3 task not setting the right content_disposition. 2019-01-23 15:04:47 +08:00
Guo Xiang Tan 2fe9617dc1 Fix rubocop. 2019-01-22 18:37:55 +08:00
Guo Xiang Tan d32900292d FIX: Don't update User#last_seen_at when PG is in readonly take 3. 2019-01-22 18:07:48 +08:00
Guo Xiang Tan 4dee7ed6d9 DEV: Fix randomlly failing spec. 2019-01-22 15:19:31 +08:00
Guo Xiang Tan fe92b496a7 FIX: Don't clear connections on failover. 
Clearing connections can be really slow (up to 10 seconds).
 2019-01-22 14:48:01 +08:00
Guo Xiang Tan de197000e7 FIX: Clear connections before disabling readonly mode. 2019-01-22 14:14:13 +08:00
Guo Xiang Tan 4dbebb4915 Follow up to f6f2c38183. 
Master connection might fail.
 2019-01-22 12:51:59 +08:00
Guo Xiang Tan f6f2c38183 FIX: Fallback Redis by checking status on master instead of slave. 2019-01-22 12:38:12 +08:00
Guo Xiang Tan b0adffdef5 FIX: Clear anon cache when clearing recently readonly. 2019-01-22 09:53:04 +08:00
Guo Xiang Tan 426907cb88 FIX: Incorrect subscription in PostgreSQLFallbackHandler. 2019-01-21 17:39:31 +08:00
Guo Xiang Tan 27c421775e Fix broken spec. 2019-01-21 16:15:39 +08:00
Guo Xiang Tan 3c6a8a2bb1 Partially revert 4466fcf1bc. 2019-01-21 15:41:01 +08:00
Guo Xiang Tan 2d354ec9b0 FIX: ForumsController doesn't need to inherit from ApplicationController. 
Application controller has a whole bunch of before/after actions which
we have no need for.
 2019-01-21 14:37:04 +08:00
Guo Xiang Tan eb9565d8fc DEV: Rescue from readonly error in lograge. 2019-01-21 14:20:19 +08:00
Guo Xiang Tan 4466fcf1bc FIX: Don't update User#last_seen_at when PG is readonly take 2. 2019-01-21 13:49:08 +08:00
Guo Xiang Tan c732ae9ca9 FIX: Don't update User#last_seen_at when PG is in readonly. 2019-01-21 13:29:29 +08:00
Guo Xiang Tan cc83bc8fcf FIX: Avoid throwing an error when processing PG down message. 2019-01-21 11:48:54 +08:00
Guo Xiang Tan 53c0ad9388 Revert "DEV: Only install danger on Travis." 
This reverts commit 792dd033e6.
 2019-01-21 11:31:16 +08:00
Guo Xiang Tan 273714efad DEV: Logs are collapsed on Travis so we shouldn't avoid logging. 
Sending logs to oblivion makes it impossible to figure out when a
command fails.
 2019-01-21 11:21:22 +08:00
Guo Xiang Tan e2a20d90fe FIX: Don't log request when Discourse is in readonly due to PG. 2019-01-21 11:04:32 +08:00
Guo Xiang Tan d7f11be575 Bump mini_scheduler. 2019-01-21 10:57:30 +08:00
Guo Xiang Tan 792dd033e6 DEV: Only install danger on Travis. 2019-01-21 09:46:32 +08:00
Guo Xiang Tan ee7ab3e2ec Pause MiniScheduler when Sidekiq is paused. 2019-01-18 17:50:24 +08:00
Guo Xiang Tan 95e3841974 FIX: Remove old reference and use MiniScheduler::Stat. 2019-01-18 16:36:11 +08:00
Guo Xiang Tan f89a32e759 FIX: Text logo does not show up on non ember pages. 2019-01-18 15:11:42 +08:00
Guo Xiang Tan 234e0f35c5 Fix the build. 
6edf285c89
 2019-01-17 17:28:09 +08:00
Guo Xiang Tan 6edf285c89 FIX: Avoid rescuing error in login hint initializer. 
On the first migration, trying to access the users table will throw an
error in PostgreSQL's log which has been confusing since users will
report it to us when rebuild fails.
 2019-01-17 17:22:15 +08:00
Guo Xiang Tan aa2cc4ab31 FIX: Liked notification consolidation has to account for user like frequency setting. 2019-01-17 14:33:23 +08:00
Guo Xiang Tan b4c2d49b0c DEV: Consolidate and remove duplicated liked notifications tests. 2019-01-17 11:14:17 +08:00
Guo Xiang Tan c30f78793a Lower default for SiteSetting.likes_notification_consolidation_threshold. 2019-01-16 17:56:02 +08:00
Guo Xiang Tan f06b773d25 FIX: Don't show liked consolidated notification when frequency is never. 2019-01-16 17:08:59 +08:00
Guo Xiang Tan 0b47ef6e86 Fix the build. 
Ideally, I'll like to test with a different user but that is proving to
be a huge challenge in our acceptance test.
 2019-01-16 16:34:48 +08:00
Guo Xiang Tan e7b49c42c4 FIX: Allow liked notifications consolidation to be disabled. 2019-01-16 16:17:04 +08:00
Guo Xiang Tan f8db93df5f FIX: Consolidated like notifications links to wrong user on user page. 2019-01-16 15:55:18 +08:00
Guo Xiang Tan 27e2b6575b FIX: Liked notifications should not be consolidated across multiple users. 2019-01-16 15:01:13 +08:00
Guo Xiang Tan ed2be6a3c8 DEV: Make prettier happy. 2019-01-16 10:58:11 +08:00
Guo Xiang Tan 40533bc570 REFACTOR: filterBy in UserStream. 
Follow up to ebe65577ed.
 2019-01-16 10:53:44 +08:00
Guo Xiang Tan 51b19e945c DEV: Stablize the multisite tests. 
SiteSettingExtension triggers message bus which re-establishes a
DB connection in `SiteSettingExtension#process_message`. That happens
concurrently and a test that requires a connection to the db will
fail when the reconnection is happening.
 2019-01-16 10:29:36 +08:00
Guo Xiang Tan ec58c33e9e DEV: Improve postgresql fallover and multisite tests. 2019-01-15 12:52:45 +08:00
Guo Xiang Tan 78748f1501 DEV: Refactor tests for notification when liking a post. 
Tests were covering the same code path so I'm consolidating it.
 2019-01-14 11:43:09 +08:00
Guo Xiang Tan e453539e1e DEV: Refactor test to assert for the actual output. 
Also, generatnig the same json multiple times.
 2019-01-12 08:00:22 +08:00
Guo Xiang Tan 0fa92699e2 UX: Don't save automatically when resetting site settings in admin page. 2019-01-11 16:39:21 +08:00
Guo Xiang Tan 656d82665d Fix the build. 
Follow up to 2956c52e57.
 2019-01-11 16:00:41 +08:00
Guo Xiang Tan 2956c52e57 FIX: Show title as home logo if title has been set and logo is blank. 
https://meta.discourse.org/t/default-text-logo-not-working/103936
 2019-01-11 15:46:58 +08:00
Guo Xiang Tan 7896c74c2b DEV: Remove use of ActiveRecord in migration. 
It makes the migration brittle to changes. If I could I would go back in
time and tell the 2016 version of me that.
 2019-01-10 11:10:21 +08:00
Guo Xiang Tan c2bca9cabe Make rubocop happy. 2019-01-10 10:52:15 +08:00
Guo Xiang Tan d10694150e Revert "FIX: Partial reply key search in email sent logs." 
This reverts commit e9b2018bc8.
 2019-01-10 10:05:56 +08:00
Guo Xiang Tan cb0f6d653b DEV: Minor fixes to b63b399799. 2019-01-10 09:38:22 +08:00
Guo Xiang Tan e9b2018bc8 FIX: Partial reply key search in email sent logs. 
Follow up to c85b9c6ed3
 2019-01-10 09:25:14 +08:00
Guo Xiang Tan 4ddd8fad20 DEV: Raise error with stats. 2019-01-09 10:54:02 +08:00
Guo Xiang Tan ec27db78be FIX: Set unique post key for a user outside of transaction. 
Previously, the Redis key was set within the transaction and the key
isn't deleted if the transaction is not successful.

Note that this isn't tested because we don't have a repro of what can
raise an error within the transaction.

https://meta.discourse.org/t/body-is-too-similar-to-what-you-previously-posted-even-when-previous-post-didnt-go-through/105436
 2019-01-08 15:22:22 +08:00
Guo Xiang Tan ef72a9a1fe UX: Default search log index to yearly. 2019-01-08 13:40:38 +08:00
Guo Xiang Tan 5f0f7f909d FIX: Incorrect CDN URL for site setting uploads when s3 is enabled. 2019-01-04 07:52:13 +08:00
Guo Xiang Tan c666ef556d Fix the build. 
Ref 570877da3c
 2019-01-03 15:34:39 +08:00
Guo Xiang Tan 38ded77e16 FIX: Make test less fragile. 2019-01-02 16:33:50 +08:00
Guo Xiang Tan 9e50813252 FIX: Pass all necessary options in migrate_to_s3 rake task. 2019-01-02 09:11:23 +08:00
Guo Xiang Tan 0daaae1cf3 DEV: Fix rubocop after update. 2019-01-02 05:47:29 +08:00
Guo Xiang Tan 2feeba0f1c DEV: Remove duplicated assertion. 2019-01-02 05:07:58 +08:00
Guo Xiang Tan 2cbb513c98 FIX: Don't use Redis#keys in production. 
As per the documentation for KEYS

```
Warning: consider KEYS as a command that should only be used in production environments with extreme care. It may ruin performance when it is executed against large databases. This command is intended for debugging and special operations, such as changing your keyspace layout.
```

Instead SCAN

```
Since these commands allow for incremental iteration, returning only a small number of elements per call, they can be used in production without the downside of commands like KEYS or SMEMBERS that may block the server for a long time (even several seconds) when called against big collections of keys or elements.
```
 2018-12-25 15:12:59 +02:00
Guo Xiang Tan b64d760bb3 DEV: Improve tests to assert that the right HTML is generated. 2018-12-20 07:14:32 +08:00
Guo Xiang Tan 5c2e194d01 SECURITY: Users can pick non-avatar uploads. 
https://meta.discourse.org/t/bug-report-idor-on-avatar-pick-function-discussions-udacity-com/103564
 2018-12-18 13:38:25 +08:00
Guo Xiang Tan 899caf35ba Revert "SECURITY: User could non-avatar uploads." 
This reverts commit 89581fa301.
 2018-12-18 13:37:31 +08:00
Guo Xiang Tan 89581fa301 SECURITY: User could non-avatar uploads. 
https://meta.discourse.org/t/bug-report-idor-on-avatar-pick-function-discussions-udacity-com/103564
 2018-12-18 13:35:33 +08:00
Guo Xiang Tan d7660dfe40 FIX: Enabling readonly mode should clear anon cache as well. 2018-12-18 11:56:25 +08:00
Guo Xiang Tan c0aae16f6b FIX: Clear anon cache when disabling readonly mode. 
`SiteSerializer#is_readonly` is cached for an anonymous user so we have
to clear the cache when disabling readonly mode. Otherwise, the site may
appear to be in readonly mode for an extended period of time.
 2018-12-17 17:27:44 +08:00
Guo Xiang Tan 9e795b9d90 Follow up to 704a122656. 2018-12-17 16:39:46 +08:00
Guo Xiang Tan e75ad37aaf FIX: Switch recently readonly mdoe cache to a DistributedCache. 
A per process cache is hard to reason about. During PostgreSQL
failovers. The site may bounce in and out of readonly mode depending on
which server and process that a request hits.
 2018-12-17 13:28:36 +08:00
Guo Xiang Tan 704a122656 Remove Ruby warning due to assignment in conditional. 2018-12-17 13:08:12 +08:00
Guo Xiang Tan e9ea0102a5 FIX: Consistency about our response for invalid user id in Admin::UsersController. 2018-12-15 08:01:35 +08:00
Guo Xiang Tan 05104600ea FIX: Incorrect translation key on admin search logs. 2018-12-14 17:12:33 +08:00
Guo Xiang Tan 71ce9ced47 FIX: Incorrect arguments were being passed to Jobs::ClosePoll. 
Also fix spec that wasn't testing anything.
 2018-12-13 16:46:00 +08:00
Guo Xiang Tan e564fe1866 FIX: Sidekiq fails to start if any of the multisite has problems. 2018-12-12 11:30:14 +08:00
Guo Xiang Tan 86926f4aee DEV: Let create! handle the check for persistence. 
This is unlikely to fail but we want to know when it does.
 2018-12-12 08:36:13 +08:00
Guo Xiang Tan 27c793a192 FIX: `UserNotificationsHelper#logo_url' to work with S3 based uploads. 
https://meta.discourse.org/t/digest-logo-not-working/103255
 2018-12-06 09:39:08 +08:00
Guo Xiang Tan dcf9c6da59 DEV: Don't publish post messages to non-human users. 2018-12-06 08:24:13 +08:00
Guo Xiang Tan cfa0321aaa FIX: Increase timeout when trying to reload unicorn. 
Also fail better when reloading takes too long by sending
unicorn a TERM.
 2018-12-04 13:43:14 +08:00
Guo Xiang Tan 125bb46052 Remove unused constant in the codebase. 2018-12-03 11:04:47 +08:00
Guo Xiang Tan df2d02a7bc Revert "Enable Style/BlockDelimiters rule." 
This reverts commit 3c22fb6b70.
 2018-11-30 10:59:45 +08:00
Guo Xiang Tan eecd1a7d8c FIX: Jobs::CleanUpUploads fails when value of upload data_type is an empty string. 2018-11-30 10:46:39 +08:00
Guo Xiang Tan 3c22fb6b70 Enable Style/BlockDelimiters rule. 2018-11-30 10:18:15 +08:00
Guo Xiang Tan ffdacba219 Remove extra apple-touch-icon link in head. 
The sizes attribute does not make a difference because both
image provided is of the same size.
 2018-11-29 15:24:52 +08:00
Guo Xiang Tan 56034c733a UX: Strip class when link is not oneboxed due to site setting limits. 2018-11-29 14:33:01 +08:00
Guo Xiang Tan ceaf234f89 DEV: Add tests for c92c56d986. 2018-11-29 13:51:31 +08:00
Guo Xiang Tan c92c56d986 FIX: Randomly failing QUnit test. 
The `post` variable can be an actual post object or a `new Placeholder("post-placeholder")` which does not define the function `get`.

* QUNIT_SEED=11414431645131211212599424733847938795
 2018-11-27 16:00:46 +08:00
Guo Xiang Tan 9cf9dee4cc DEV: Locale dates test needs to set default moment timzone. 
The tests were breaking on a machine configured to use SGT timezone.
 2018-11-27 13:50:57 +08:00
Guo Xiang Tan 68bef91dd6 DEV: Minor clean up of specs. 2018-11-27 13:09:58 +08:00
Guo Xiang Tan 565603ad0d Remove unused variable. 2018-11-26 14:45:00 +08:00
Guo Xiang Tan 3188d3506d Re-add option that was removed by mistake in https://github.com/discourse/discourse/commit/482013a1d4060e69cf78773892f13ef2d8220742. 2018-11-26 14:24:23 +08:00
Guo Xiang Tan 482013a1d4 FIX: Group mentions missing after post processing. 2018-11-26 12:57:07 +08:00
Guo Xiang Tan 0972516abe FIX: Incorrect "rel" used for apple icons in <head>. 
Nothing on the web I can find suggests that this should have been `rel=icon`.
See https://developer.apple.com/library/archive/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html
 2018-11-26 10:40:09 +08:00
Guo Xiang Tan d4aaa968bb Fix linting. 2018-11-26 09:38:22 +08:00