IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-09-05 04:40:41 -05:00
Code Issues Packages Projects Releases Wiki Activity
26,942 Commits 1,018 Branches 579 Tags
89f5c90ce0923fd9b8d8464a43582aeb274d1c32
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Guo Xiang Tan 215d955e30 UX: Add a back link to groups page on group page. 2018-03-16 16:58:42 +08:00
Guo Xiang Tan 7138f6dd69 Fix incorrect condition while re-routing from group messages. 2018-03-16 16:39:02 +08:00
Guo Xiang Tan 19d6b9cb36 Redirect to group members tab if user cannot see messages tab. 2018-03-16 16:30:08 +08:00
Guo Xiang Tan aa91bd61a7 Improve specs for TopicQuery#list_group_topics. 2018-03-16 16:18:26 +08:00
Guo Xiang Tan c85e1fdb50 Revert "PERF: Query for email was not using index." 
This reverts commit 65eb046e69.
 2018-03-16 15:31:39 +08:00
Guo Xiang Tan 65eb046e69 PERF: Query for email was not using index. 2018-03-16 15:19:35 +08:00
Guo Xiang Tan 7e3e09d0ea Fix group messages style on mobile. 2018-03-16 14:56:10 +08:00
Guo Xiang Tan 5fec9a4dfe Fix incorrect CSS class on group messages. 2018-03-16 13:45:03 +08:00
Guo Xiang Tan fe96ef6ed2 UX: Use topic list for displaying group messages on group page. 
https://meta.discourse.org/t/group-inbox-on-a-groups-page-mockup/71319
 2018-03-16 11:56:40 +08:00
Guo Xiang Tan da8e15f954 FIX: Restorer was not extracting the patch version in dump file. 2018-03-16 11:09:56 +08:00
Guo Xiang Tan a35227918f UX: Display group topics in a topic list. 2018-03-15 11:37:55 +08:00
Guo Xiang Tan 8027096c09 Partially revert "Upgrade mail gem to remove dependency on mime-types." 
Still seeing heap_live_count spikes.

This reverts commit 58b8ea4f41.
 2018-03-14 20:21:45 +08:00
Guo Xiang Tan 58b8ea4f41 Upgrade mail gem to remove dependency on mime-types. 
* Use a EmailValidator.email_regexp for `Email.is_valid?`
  check as we're seeing an increase in allocation when
  parsing email addresses wih `Mail::Address`.
 2018-03-14 14:37:55 +08:00
Guo Xiang Tan 51657d3426 Allow polls to be added/renamed/removed as long as user can edit posts. 2018-03-14 11:00:57 +08:00
Guo Xiang Tan a9713ca20b REFACTOR: Always prefer to raise an error if record fails to save. 2018-03-13 12:01:01 +08:00
Guo Xiang Tan 1c208ef3f0 FIX: Suspended login error message not showing. 2018-03-13 11:28:59 +08:00
Guo Xiang Tan 2ad2ed2eb2 FIX: Couldn't move a topic into the uncategorized category. 2018-03-13 10:20:47 +08:00
Guo Xiang Tan d5c828213f FIX: Circular references warning in TopicTrackingState. 2018-03-13 08:35:15 +08:00
Guo Xiang Tan 5782a23a69 Allow uploads:missing to skip optimized image check. 2018-03-12 20:08:53 +08:00
Guo Xiang Tan 74ce2220a7 Make rubocop happy. 2018-03-12 09:48:41 +08:00
Guo Xiang Tan 0e1b896821 Explicitly assign primary_email record when creating a user 
* This looks like we're doing the same thing but
  we're debugging a race condition where a user
  can be created without an email record. Therefore,
  we prefer the more obvious method of assigning an
  association.
 2018-03-09 15:59:46 +08:00
Guo Xiang Tan 5ef75c9c61 Improve grep pattern in restorer. 2018-03-09 15:48:12 +08:00
Guo Xiang Tan 766b41d9f4 Fix version check in restorer. 2018-03-09 15:01:10 +08:00
Guo Xiang Tan 8fd47314d9 FIX: Restore process for dump taken with pg_dump 10.3+. 
* Since we can no longer restore into a different schema,
  we will move tables in the public schema into the backup schema
  first before restoring the dump file which goes into the public
  schema. The downside to this approach is that we will increase
  the downtime experienced during the restore process. Downtime
  would equal the duration of restoring the dump file.
 2018-03-09 13:24:58 +08:00
Guo Xiang Tan 2f54eab9a6 Running wrong type of plugin tests for qunit on travis. 2018-03-09 10:37:00 +08:00
Guo Xiang Tan a89f3160a5 Add new config to ensure backup/restore connects to PG directly. 
* In `pg_dump` 10.3+ and 9.5.12+, in
  it does a `SELECT pg_catalog.set_config('search_path', '', false)`
  which changes the state of the current connection. This is known
  to be problematic with Pgbouncer which reuses connections. As such,
  we'll always try to connect directly to PG directly during
  the backup/restore process.
 2018-03-09 10:28:03 +08:00
Guo Xiang Tan b77553a635 FIX: Staff should be able to updates polls when edit window expires. 
https://meta.discourse.org/t/moderators-cannot-remove-polls-from-posts/81804/7?u=tgxworld
 2018-03-08 16:45:06 +08:00
Guo Xiang Tan 10d6101eae Fix incorrect function name. 2018-03-08 15:52:07 +08:00
Guo Xiang Tan 152f64a18b Trigger is dropped along with the table. 2018-03-08 15:28:00 +08:00
Guo Xiang Tan 3ef5661608 Clean up unused function left in the database. 2018-03-08 15:25:10 +08:00
Guo Xiang Tan 9dc72537e5 FIX: TableMigrationHelper didn't clean up after itself. 2018-03-08 15:10:05 +08:00
Guo Xiang Tan e7cc2e6d33 FIX: loadBefore should include current params as well. 2018-03-07 16:57:06 +08:00
Guo Xiang Tan c6cb7f6693 UX: Add title to user messages page. 2018-03-07 15:24:11 +08:00
Guo Xiang Tan d02e2cbcca PERF: Avoid fetching a bunch of ids in polls updater. 2018-03-07 14:18:56 +08:00
Guo Xiang Tan 3045c589f6 FIX: Publish live messages to both team inbox and archive on update. 2018-03-07 14:01:20 +08:00
Guo Xiang Tan 5169be6080 FIX: User archiving message should also publish to sent section. 2018-03-07 11:39:23 +08:00
Guo Xiang Tan bef35f7be5 FIX: User archive messages should only publish to the user. 2018-03-07 11:28:29 +08:00
Guo Xiang Tan 82619c2445 FIX: Missing messages incoming indicator for mobile. 2018-03-07 10:27:18 +08:00
Guo Xiang Tan 76e2b6c825 Add "discourse-assign" to the list of official plugins. 2018-03-06 21:45:37 +08:00
Guo Xiang Tan 8f5349eaa1 FIX: Only unsubscribe channel if it was subscribed. 2018-03-06 21:39:30 +08:00
Guo Xiang Tan e09a4a353e FIX: Incorrectly deleting channel preventing us from unsubscribing MB. 2018-03-06 19:52:00 +08:00
Guo Xiang Tan 1365bab0d7 FEATURE: Live updates for user's messages page. 
https://meta.discourse.org/t/group-inbox-messages-not-updated-for-new-posts/38189
 2018-03-06 18:15:21 +08:00
Guo Xiang Tan 13764b31ec Remove unnecessary attribute in topic tracking payload. 2018-03-06 17:37:53 +08:00
Guo Xiang Tan d576056cff REFACTOR: Add basic tests for TopicTrackingState#publish_*. 
* Ensure we don't publish events for PMs.
 2018-03-06 17:37:53 +08:00
Guo Xiang Tan 821f3d0c15 REFACTOR: Remove code duplication. 2018-03-06 17:37:53 +08:00
Guo Xiang Tan bdb25338e5 Update bootsnap. 2018-03-06 17:37:02 +08:00
Guo Xiang Tan 2f65393706 REFACTOR: Use Topic#private_message? to reduce duplication. 2018-03-05 15:39:22 +08:00
Guo Xiang Tan 07f1d90b88 FIX: Inviting a group that I am part of creates a notification. 
https://meta.discourse.org/t/inviting-a-group-to-a-message-does-not-trigger-a-notification-mail/50509/10?u=tgxworld
 2018-03-05 13:51:32 +08:00
Guo Xiang Tan 42e0aaed61 FIX: Set first visit PM notification level to group default notification level. 
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/21?u=tgxworld
 2018-03-05 13:39:00 +08:00
Guo Xiang Tan 6b59a2827d Add more information to SSO user creation logging. 2018-03-02 18:27:15 +08:00
Guo Xiang Tan 642c60c310 Rename variable so that it is clearer which variable is being referred. 2018-03-02 16:41:02 +08:00
Guo Xiang Tan b9ff6d60b9 Fix the build. 2018-03-02 14:43:02 +08:00
Guo Xiang Tan d9b4b12694 UX: Display warning message about social logins disabled when 2FA is enabled. 2018-03-02 14:22:52 +08:00
Guo Xiang Tan 50eb582fb2 Remove cas oauth login method that is no longer used. 2018-03-02 14:22:52 +08:00
Guo Xiang Tan 939180efa8 FIX: Missing 2FA guards when sso is enabled or when local login is disabled. 2018-03-02 10:39:10 +08:00
Guo Xiang Tan 4f301905b6 Make rubocop happy. 2018-03-02 10:15:53 +08:00
Guo Xiang Tan 5c93d07d2a Remove duplication of params in tests. 2018-03-02 09:25:46 +08:00
Guo Xiang Tan 674239718c UX: Hide social login buttons when requesting for 2FA token. 2018-03-01 15:52:09 +08:00
Guo Xiang Tan fb75f188ba FEATURE: Disallow login via omniauth when user has 2FA enabled. 2018-03-01 15:47:07 +08:00
Guo Xiang Tan 0fabf80dca Migrate controller type specs to request types for omniauth. 2018-03-01 15:33:00 +08:00
Guo Xiang Tan 81ca3677f7 Add guard for nil in our RateLimiter. 2018-03-01 13:20:42 +08:00
Guo Xiang Tan 5d9f9c2614 FIX: RateLimiter max of zero or less should raise rate limit exceeded. 2018-03-01 13:14:46 +08:00
Guo Xiang Tan 47c41f474d Missing indentation. 2018-03-01 13:12:13 +08:00
Guo Xiang Tan 947b6fdf46 FIX: Incorrect rate limit applied to topics invitation flow. 2018-03-01 12:50:00 +08:00
Guo Xiang Tan 5a462b930d REFACTOR: Prefer exists? over present. 2018-03-01 10:22:41 +08:00
Guo Xiang Tan e7a7356986 Remove ancient votes code that is no longer used. 2018-02-28 14:37:22 +08:00
Guo Xiang Tan 902c5d11cf FIX: Don't allow other flag actions after notify_moderator has happened. 
https://meta.discourse.org/t/receiving-sorry-an-error-has-occurred-during-flagging-step-of-discobot-tutorial/77233/5
 2018-02-28 11:27:56 +08:00
Guo Xiang Tan 486bbe9cc2 FIX: Auto re-opened topics should restore category auto close settings. 
https://meta.discourse.org/t/topic-closed-temporarily-due-to-community-flags-overwrites-category-auto-close-timer/77421
 2018-02-27 15:33:31 +08:00
Guo Xiang Tan 06891ce51d FIX: Direct link to group activity page results in 400 error. 
https://meta.discourse.org/t/following-a-direct-link-to-group-activity-results-in-400-error/81596
 2018-02-27 13:43:22 +08:00
Guo Xiang Tan 519026a31f Trim attributes that are not useful from WebHookTopicViewSerializer. 2018-02-27 11:28:31 +08:00
Guo Xiang Tan 66d620f7b1 FEATURE: Trigger topic webhook when topic status is updated. 2018-02-27 11:07:37 +08:00
Guo Xiang Tan 104df3126b UX: Incorrect width for webhook events. Take 2. 2018-02-27 10:34:46 +08:00
Guo Xiang Tan 8d16ca2af2 UX: Incorrect width for webhook events. 2018-02-27 10:32:11 +08:00
Guo Xiang Tan 24bd310d7b Fix the build. 2018-02-27 10:15:13 +08:00
Guo Xiang Tan 24f3b78548 Fix incorrect ids for 2FA inputs. 2018-02-27 10:12:22 +08:00
Guo Xiang Tan 8c51ac448a FIX: Missing translation. 2018-02-27 09:37:12 +08:00
Guo Xiang Tan 70f14da732 UX: Use 'tel' input type for 2FA token inputs. 2018-02-27 09:30:44 +08:00
Guo Xiang Tan a9699da672 UX: Specify pattern and maxlength for 2FA input fields. 2018-02-26 18:29:46 +08:00
Guo Xiang Tan c1f53e1ece UX: Invited users should watch PM topic once topic has been visited. 
https://meta.discourse.org/t/notifications-not-received-for-private-messages-im-invited-to/71577/11
 2018-02-26 17:58:58 +08:00
Guo Xiang Tan 982e5bae3a Update annotations. 2018-02-26 15:32:04 +08:00
Guo Xiang Tan 65cb785374 Improve specs for Topic#invite. 2018-02-26 15:18:34 +08:00
Guo Xiang Tan 6a88f7db61 Notification created for wrong user after invite. 
Introduced in https://github.com/discourse/discourse/commit/c64f09b6b777cd8d979e939aff39bc1f7808aa5e
 2018-02-26 13:21:19 +08:00
Guo Xiang Tan 6c1c5fe2d6 Fix the build take 2. 2018-02-26 13:09:13 +08:00
Guo Xiang Tan 31242335a6 Revert "Fix the build." 
This reverts commit 07f928e05e.
 2018-02-26 13:08:10 +08:00
Guo Xiang Tan 1b5d955a34 Fix the build. 2018-02-26 12:46:15 +08:00
Guo Xiang Tan 07f928e05e Fix the build. 2018-02-26 12:42:55 +08:00
Guo Xiang Tan c64f09b6b7 REFACTOR: Simplify and DRY Group#invite. 2018-02-26 11:59:07 +08:00
Guo Xiang Tan 3e1afbedc5 FIX: Missing translation for non-admin when editing a group. 
https://meta.discourse.org/t/text-glitch-on-group-admin-page/77303
 2018-02-26 10:11:18 +08:00
Guo Xiang Tan 4791b39773 UX: Add reset password email button when confirming password before enabling 2FA. 2018-02-23 15:37:17 +08:00
Guo Xiang Tan 4250ab522a UX: Don't show admin 2FA edit icon on profile of other users. 2018-02-23 13:51:02 +08:00
Guo Xiang Tan 4ac5fc8cd3 Fix incorrect data type for SiteSetting.google_oauth2_prompt. 2018-02-23 12:20:21 +08:00
Guo Xiang Tan ea1733ca64 Fix failing spec. 2018-02-23 11:31:10 +08:00
Guo Xiang Tan 66062ed6d9 Add missing default choice for SiteSetting.google_oauth2_prompt. 2018-02-23 11:23:08 +08:00
Guo Xiang Tan 1f74509a75 FIX: 2FA prompt incorrectly displayed on admin login page. 2018-02-23 11:05:39 +08:00
Guo Xiang Tan 3637f0d3bb Update copy to reflect that 2FA key should be kept a secret. 2018-02-23 10:40:25 +08:00
Guo Xiang Tan e137b7f836 UX: Improve indication of 2FA status in user's preferences. 2018-02-23 10:36:48 +08:00
Guo Xiang Tan 5e60f6b533 UX: Don't disable submit button before transitioning in 2FA flow. 2018-02-23 10:36:48 +08:00
Guo Xiang Tan 2e2da3a6e2 Update copy for 2FA. 2018-02-23 10:36:48 +08:00
Guo Xiang Tan 24d0a7a4c7 Take 2 on https://github.com/discourse/discourse/commit/f74d6bb605f0395f4cba5e69d3c32206ca7c39a8. 
New options are left out by default when not configured so that an
incorrect default configuration doesn't blow up google oauth for
everyone.
 2018-02-23 07:53:01 +08:00
Guo Xiang Tan 18c1d1565c UX: Fix missing css styles on invite modal. 2018-02-23 07:08:19 +08:00