IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-07-29 23:58:12 -05:00
Code Issues Packages Projects Releases Wiki Activity
51,893 Commits 927 Branches 570 Tags
8a45f84277e6e13bc48b8f4e40350a9cbd5cd2ee
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Jarek Radosz 89bd2b7df0 DEV: Remove unnecessary js: true options from specs (#24463) 2023-11-20 17:22:14 +01:00
Jarek Radosz 8968887e24 DEV: Fix various typos (#24461) 
November 2023 edition
 2023-11-20 16:49:49 +01:00
Jarek Radosz 1a43010603 DEV: Add selectText option to auto-focus modifier (#24458) 2023-11-20 14:53:20 +01:00
Jarek Radosz e56005b783 DEV: Remove category-macro (#24395) 
This discourse-common decorator was dependent on the core app, hence creating a circular reference that was breaking the embroider upgrade. (see: #24391)
 2023-11-16 00:16:19 +01:00
Jarek Radosz 1e1bb45b96 FIX: Add a missing service injection (#24341) 
Fixes the reorder-categories modal.
 2023-11-13 01:31:04 +01:00
Jarek Radosz daf7608905 DEV: Migrate reorder-categories to the new modal API (#24209) 2023-11-08 16:28:53 +01:00
Jarek Radosz 1c8eaa9390 DEV: QUnit CSS tweaks (#24180) 
1. Prevent a white background flash
2. Dark-mode support for two more inputs
 2023-10-31 14:53:42 +01:00
Jarek Radosz 231e02446b DEV: Add a basic account creation system spec (#24179) 2023-10-31 14:53:24 +01:00
Jarek Radosz dbb532bae7 FIX: Full name validation regression (#24178) 
Regressed in 351cbab1a8
 2023-10-31 14:44:27 +01:00
Jarek Radosz bbcf8e421c DEV: Migrate associate-account-confirm to the new modal API (#24138) 
(+ glimmer)
 2023-10-31 11:45:14 +01:00
Jarek Radosz 360289e108 FIX: Account creation regression (#24169) 
Regressed in 351cbab1a8
 2023-10-31 02:05:35 +01:00
Jarek Radosz 08deedfd6e FIX: autotracking.mutation-after-consumption (#24164) 2023-10-31 00:39:52 +01:00
Jarek Radosz 351cbab1a8 DEV: Migrate create-account to the new modal API (#24098) 
plugin/theme-breaking changes:

1. `controller:create-account` is gone (use `component:modal/create-account` in modifyClass, **if** absolutely necessary)
2. `create-account-body` css class is gone (target `.d-modal.create-account` or any of the inner classes: `.modal-outer-container`, `.modal-middle-container`, `.modal-inner-container`, or `.modal-body`)
 2023-10-30 11:01:09 +01:00
Jarek Radosz 125c19e8f7 FIX: Username validation in create-account modal (#24114) 
* Move the create account test
* Clean up username-validation
* Fix the username validation bug
 2023-10-26 20:38:34 +02:00
Jarek Radosz 00dc063d40 FIX: Restore support for custom NavItem class (#24113) 
A followup to 930dc38500
 2023-10-26 18:26:36 +02:00
Jarek Radosz 125ab9f31d UX: Update user field styling in the create-account modal (#24091) 
1. Removes accidental bold from `text` and `multiselect` labels/placeholders
2. Adds the animated label/placeholder combo to `multiselect`
3. Makes the `multiselect` placeholder lighter to match other fields
4. Makes the `dropdown` values darker to match other fields
5. Removes the extra 5px spacing before `confirmation` fields
 2023-10-25 13:03:20 +02:00
Jarek Radosz 2f1acbb12d DEV: Convert user-field to gjs (#24082) 2023-10-24 20:28:47 +02:00
Jarek Radosz 930dc38500 DEV: Convert nav-item to gjs (#24076) 2023-10-24 17:55:09 +02:00
Jarek Radosz 9a497d9e22 DEV: Move toggleAnonymous out of app route (#24077) 2023-10-24 17:54:56 +02:00
Jarek Radosz b3caa90f6e DEV: Check for mobile upload button presence (#24059) 
If rendering would break before `_bindMobileUploadButton` - this would fail too, obscuring the original issue.
 2023-10-23 23:14:17 +02:00
Jarek Radosz c84fe69e10 DEV: Use @discourse/lint-configs (#24038) 2023-10-23 12:08:35 +02:00
Jarek Radosz e31859a33a FIX: Correctly set categoryId on Composer model (#23934) 2023-10-19 10:19:40 -07:00
Jarek Radosz 24dc36cf91 DEV: Fix ember/require-super-in-lifecycle-hooks (#24007) 
and `ember/no-ember-super-in-es-classes`
 2023-10-19 13:47:45 +02:00
Jarek Radosz ac30673b98 DEV: Fix ember/no-settled-after-test-helper (#24008) 2023-10-19 13:47:28 +02:00
Jarek Radosz b45720b158 DEV: Fix ember/no-incorrect-calls-with-inline-anonymous-functions (#24010) 2023-10-19 13:47:01 +02:00
Jarek Radosz 754d13f5fa DEV: Fix ember/require-valid-css-selector-in-test-helpers (#24011) 2023-10-19 13:46:48 +02:00
Jarek Radosz 23af6c23d0 DEV: Fix ember/prefer-ember-test-helpers (#24013) 2023-10-19 13:46:28 +02:00
Jarek Radosz 16d16c8969 DEV: Precompile the transpiler before themes:update (#23997) 2023-10-19 01:00:23 +02:00
Jarek Radosz 75c9635d8b DEV: Remove the transpilation message (#23998) 2023-10-19 01:00:15 +02:00
Jarek Radosz dca23d3a53 DEV: Group @types/* updates (#23992) 2023-10-19 00:01:16 +02:00
Jarek Radosz a5858e60e1 FIX: Transitioning to tag-intersection route (#23931) 
…didn't correctly update location query params.

A followup to 1df3ccc903 (things broke after merging `main` to PR's branch)
 2023-10-13 16:23:04 +01:00
Jarek Radosz 1df3ccc903 FIX: Pass category param on /tags/intersection (#23352) 2023-10-13 02:42:41 +02:00
Jarek Radosz 90743f162a DEV: Add a plugin outlet for conditional-loading-spinner (#23911) 2023-10-12 17:53:53 +02:00
Jarek Radosz 53c9c9c1e6 FIX: Fetch csrf token if needed before uploading (#23825) 2023-10-09 15:47:36 +02:00
Jarek Radosz 81de02525f DEV: Update the content-tag patch (#23840) 2023-10-09 12:01:58 +02:00
Jarek Radosz 484004fc5e DEV: Use Session service rather than singleton (#23813) 
(where applicable)
 2023-10-06 17:14:31 +02:00
Jarek Radosz 2c490773f1 FIX: Always use the current session token in uppy (#23812) 
…rather than the value at the time when uppy is initialized.

Future TODO: extract csrf-fetching logic from ajax helper to Session service.
 2023-10-06 15:26:39 +02:00
Jarek Radosz bd52b1ec7b FIX: Embroider breaking index html structure (#23811) 
The custom html elements we were using for bootstraping were causing Embroider to end the `<head>` tag and immediately start `<body>`. As a result most of `<meta>` tags ended up in the `<body>`.

That mean (among possibly other issues) that the app did not have CSRF token set properly on launch (in the development env)
 2023-10-06 13:41:47 +02:00
Jarek Radosz a27823fd3c DEV: Correctly test post-cooked "widget" (#23806) 
It's a special case widget - its constructor has different contructor arguments:

```js
export default class PostCooked {
  constructor(attrs, decoratorHelper, currentUser) {
...
```

vs

```js
export default class Widget {
  constructor(attrs, register, opts) {
...
```
 2023-10-05 22:19:54 +02:00
Jarek Radosz 8a6aaf9446 DEV: Convert user-status modal to a glimmer component (#23798) 2023-10-05 21:22:28 +02:00
Jarek Radosz 4db41ed28a DEV: Do not manually create app-events on models (#23799) 2023-10-05 21:22:16 +02:00
Jarek Radosz 8421327845 DEV: Format UserStatus#ends_at as a ISO8601 timestamp (#23796) 
…as we do when publishing a mesage bus update: https://github.com/discourse/discourse/blob/07c93918ecbc82cda6cd9a079f27cfed432bcb7e/app/models/user.rb#L871-L871
 2023-10-05 20:41:12 +02:00
Jarek RadoszandPenar Musaraj 1251757d48 DEV: Fix random typos (#23801) 
Co-authored-by: Penar Musaraj <pmusaraj@gmail.com>
 2023-10-05 20:40:53 +02:00
Jarek Radosz fbf92a2212 DEV: Build theme transpiler in custom envs (#23785) 
(i.e. non-production, non-test, non-development environments :P like `RAILS_ENV="profile"`)
 2023-10-05 02:06:58 +02:00
Jarek Radosz 6271e02369 DEV: Convert composer-editor tests to gjs (#23768) 2023-10-04 09:39:41 +08:00
Jarek Radosz 5a904949b2 DEV: Add gjs support for themes (#23473) 2023-10-02 12:36:06 +02:00
Jarek Radosz 1117640715 FIX: A regression in RequestGroupMembershipForm (#23699) 2023-09-28 15:39:49 +02:00
Jarek Radosz 6adc67a7a8 FIX: Broken error reporting in modals (and other places) (#23680) 
1. actually call `popupAjaxError`, thanks :P
2. don't close a modal on error
3. use `extractError()` instead of manually joining error messages
4. …or passing just the error object to `this.flash`
 2023-09-27 17:11:44 +02:00
Jarek Radosz 52722c7086 DEV: Use getOwner from @ember/application in tests (#23670) 2023-09-26 18:40:10 +02:00
Jarek Radosz 5484030162 DEV: Use disableImplicitInjections more extensively (#23579) 2023-09-25 19:30:07 +02:00
Jarek Radosz 0fb2812414 DEV: Rescue another http error in qunit task (#23651) 
Should take care of a flake issue. Also removes an extraneous `/` character in the used URL.
 2023-09-25 19:27:49 +02:00
Jarek Radosz 837cec6c3d DEV: Consistently call setupTest(hooks) in unit tests (#23610) 2023-09-25 12:43:41 +02:00
Jarek Radosz d811e96fa9 Revert "Build(deps): Bump sass-embedded from 1.66.1 to 1.67.0 (#23599)" (#23604) 
This reverts commit de32dfb780.

It broke compilation of qunit.scss
 2023-09-15 01:21:39 +02:00
Jarek Radosz 8cb8f130d9 DEV: Convert request-group-membership-form to new modal api (#23600) 2023-09-15 00:39:52 +02:00
Jarek Radosz 4a1621c677 DEV: Use the Store to create User records (#23584) 2023-09-14 23:26:51 +02:00
Jarek Radosz c75b379d6f DEV: Future-proof htmlSafe interactions (#23596) 
See https://github.com/discourse/discourse-encrypt/pull/282

> `cooked` was an Ember SafeString. The internal storage of the string changed from `.string` to `.__string` at some point between Ember 3.28 and Ember 5. Instead, we can use `toString()` which is guaranteed to work in all situations
 2023-09-14 23:04:57 +02:00
Jarek Radosz ed8d0656f9 DEV: Convert tag-upload to the new modal API (#23590) 2023-09-14 21:32:45 +02:00
Jarek Radosz 4571197e06 DEV: Convert global-notice to a native class (#23582) 2023-09-14 12:34:30 +02:00
Jarek Radosz 5df1b1c523 DEV: Upgrade the so-called share-and-invite modal (#23574) 2023-09-14 10:50:50 +02:00
Jarek Radosz 91e456ba30 DEV: Convert emoji-store into a native class (#23572) 2023-09-14 10:32:17 +02:00
Jarek Radosz 61f4af2995 DEV: Remove unused userInvitedShow logic (#23569) 
share-and-invite modal doesn't seem to use it anymore
 2023-09-13 23:07:19 +02:00
Jarek Radosz 6c20d8cc8c DEV: Convert document-title to a native class (#23570) 
Included: removed the `reset` method, used private fields, added explicit service injections
 2023-09-13 22:12:33 +02:00
Jarek Radosz 6b218636ab DEV: Convert ConditionalLoadingSpinner to gjs (#23565) 2023-09-13 20:12:38 +02:00
Jarek Radosz 80dcaf1e98 DEV: Skip flaky specs (#23523) 2023-09-12 08:01:30 +08:00
Jarek Radosz 60e7463476 DEV: Fix poll-results tests (#23518) 
`/t/-/load-more-poll-voters` is not a valid app path

(valid ones would be `/t/load-more-poll-voters/134` or `/t/-/134`)
 2023-09-12 07:41:56 +08:00
Jarek Radosz 1fcf07be32 FIX: Empty query param in group-index url (#23520) 
This prevents an empty `order=` query param from appearing in the URL when navigating from `/g` to a group page.
 2023-09-12 00:55:55 +02:00
Jarek Radosz 0f0d3470a9 DEV: Convert home-logo-test to gjs (#23180) 2023-09-11 20:27:03 +02:00
Jarek Radosz 992737e592 DEV: Fix setting-on-hash deprecation (#23506) 
```
deprecate-shim.js:33 DEPRECATION: You set the 'hasSavedVote' property on a {{hash}} object. Setting properties on objects generated by {{hash}} is deprecated. Please update to use an object created with a tracked property or getter, or with a custom helper. [deprecation id: setting-on-hash]
```
 2023-09-11 16:15:44 +02:00
Jarek Radosz f27800ff88 DEV: Replace _eak_seen with entries (#23507) 
TIL: `require._eak_seen` is an old alias for `require.entries` and it comes from Ember App Kit (a blast from the past!)
 2023-09-11 16:03:27 +02:00
Jarek Radosz 87d0336f05 DEV: Introduce {{body-class}}, soft-deprecate <DSection /> (#23479) 
`<DSection />` is now deprecated. Please use `{{body-class "foo-page" "bar"}}` and/or `<section></section>` instead.
 2023-09-11 13:44:52 +02:00
Jarek Radosz 935625ce2c FIX: Double footer in install-theme modal (#23503) 2023-09-11 12:04:32 +02:00
Jarek Radosz 217985fdc3 DEV: Remove an old mobile-nav deprecation (#23493) 2023-09-11 11:39:47 +02:00
Jarek Radosz ce6ac81b29 DEV: Remove deprecated BulkSelectButton (#23494) 2023-09-11 11:39:37 +02:00
Jarek Radosz 08336ed682 DEV: Remove deprecated HighlightText (#23495) 2023-09-11 11:38:28 +02:00
Jarek Radosz d393fdca31 DEV: Fix random typos (#23497) 2023-09-11 11:33:08 +02:00
Jarek Radosz 381f749f60 DEV: Remove unused files (#23498) 2023-09-11 11:32:54 +02:00
Jarek Radosz 7b7a59b576 DEV: Use import x rather than import { default as x } (#23496) 2023-09-11 11:32:36 +02:00
Jarek Radosz 8c6b1fbbc1 DEV: Move helper tests to the correct directory (#23485) 2023-09-09 14:03:13 +02:00
Jarek Radosz 02bd709bc3 DEV: Fix badge tests (#23442) 
`badge.save(["name", "description", "badge_type_id"])` api it was testing isn't a thing anymore.

Also: replaces `assert.expect(0)` with more useful assertions
 2023-09-07 09:53:37 +08:00
Jarek Radosz 60bc4efda4 DEV: Use a standard service injection (#23439) 
A follow up to f73d8346c2
 2023-09-06 17:10:08 +02:00
Jarek Radosz 19567daeb9 DEV: Update linting setup (#23434) 
* Update eslint-config-discourse
* Update eslint-plugin-ember
* Update ember-template-lint
* Update concurrently
* Update glint
* Dedup + yarn 
* Whitespace fix
 2023-09-06 14:23:06 +02:00
Jarek Radosz 5e7287eba5 DEV: Convert sticky-avatars into a modifier (#23060) 
Instead of a initializer and a lib class (that needed access to the ownership system)
 2023-09-06 11:32:08 +02:00
Jarek Radosz b55a5cbbb2 DEV: Remove unnecessary assert.expects (#23426) 
And one superfluous `run`. And add an assert to user-badge test. And replace `expect` with `allSettled` in rest-model tests.
 2023-09-06 02:16:50 +02:00
Jarek Radosz ee3ac739f3 DEV: Don't run dev-only code in specs (#23427) 
This was causing the following notice to be printed out when running system specs:

```
I did no detect a custom `config/dev.yml` file, creating one for you where you can amend defaults.
```

(since 61571bee43)
 2023-09-06 02:14:57 +02:00
Jarek Radosz d308360376 FIX: An incorrect import (#23414) 
Introduced in bb2d1f8703
 2023-09-05 22:11:20 +02:00
Jarek Radosz 1ca4e7241e UX: Fix checkbox slider (#23412) 2023-09-05 22:08:44 +02:00
Jarek Radosz 2dbec2e836 DEV: Apply ember-this-fallback patches sequentially (#23407) 2023-09-05 12:50:15 +02:00
Jarek RadoszandDavid Taylor c285f4133f DEV: Enable ember-this-fallback in themes (#23384) 
Co-authored-by: David Taylor <david@taylorhq.com>
 2023-09-05 11:16:12 +02:00
Jarek Radosz dac4f97032 DEV: Convert reviewable-bundled-action to gjs (#23320) 2023-08-31 16:59:19 +02:00
Jarek Radosz 06a9963cbb DEV: Don't fetch tagNotifications when additional tags are present (#23351) 
We don't display them, see: https://github.com/discourse/discourse/blob/006a5166e571861d088658d9e0f07c6967a59161/app/assets/javascripts/discourse/app/components/d-navigation.js#L55-L55
 2023-08-31 16:40:33 +02:00
Jarek Radosz 6bd66438d8 FIX: Add missing props to move-to-topic (#23349) 
Fixes tagging topics in that modal.
 2023-08-31 14:18:57 +02:00
Jarek Radosz 1c87bb7fe9 DEV: Update DButton uses (#23333) 
1. Use `this.` instead of `{{action}}` where applicable
2. Use `{{fn}}` instead of `@actionParam` where applicable
3. Use non-`@` versions of class/type/tabindex/aria-controls/aria-expanded
4. Remove `btn` class (it's added automatically to all DButtons)
5. Remove `type="button"` (it's the default)
6. Use `concat-class` helper
 2023-08-31 11:49:35 +02:00
Jarek Radosz 7b78895930 DEV: Group babel updates together (#23322) 
Grouped Dependabot updates are now available (https://github.blog/changelog/2023-08-24-grouped-version-updates-for-dependabot-are-generally-available/) so we can finally make it create a single PR for both `@babel/core` and `@babel/standalone` 😌
 2023-08-30 10:38:26 +02:00
Jarek Radosz f6cd8e5968 DEV: Remove redundant braces (#23321) 2023-08-30 10:37:03 +02:00
Jarek RadoszandGodfrey Chan 6f1d666323 DEV: Make index.html a valid html (#23289) 
Co-authored-by: Godfrey Chan <godfreykfc@gmail.com>
 2023-08-28 14:44:38 +02:00
Jarek Radosz 09446baf10 DEV: Fix redis.sadd warnings (#23244) 
```
Redis#sadd will always return an Integer in Redis 5.0.0. Use Redis#sadd? instead
```
 2023-08-28 12:58:47 +08:00
Jarek Radosz 0b74ba7c66 DEV: Add color to testem output (#23266) 2023-08-25 13:44:26 +02:00
Jarek Radosz 90ef8d3041 DEV: Add missing pluginId to a modifyClass test (#23265) 2023-08-25 11:44:42 +02:00
Jarek Radosz 3ce3c2ff81 DEV: Add a spec for assets:precompile:js_processor (#23220) 2023-08-25 11:44:30 +02:00
Jarek Radosz e60d227c8f DEV: Avoid constant redefinition warnings in specs (#23241) 
Specs sometimes do `Discourse::Application.load_tasks` which re-loads rake task files, causing constant redefinition.
 2023-08-24 23:16:32 +02:00