Guo Xiang Tan
9c66473c4c
Add index for EmailLog#topic_id and EmailLog#post_id.
2018-01-11 17:28:14 +08:00
Guo Xiang Tan
74ec100aff
Upgrade pg gem.
2018-01-08 10:27:19 +08:00
Guo Xiang Tan
6cab53abd4
Puppeteer page.authenticate messes up CSRF tokens in forms.
2018-01-04 21:30:04 +08:00
Guo Xiang Tan
8a3bbcb19a
FIX: Add guard to prevent a primary UserEmail from being reassigned.
2018-01-04 19:40:50 +08:00
Guo Xiang Tan
ad02437358
FIX: Missing post/topic created web hooks due to race condition.
2018-01-03 17:24:01 +08:00
Guo Xiang Tan
9644569a28
FIX: Wildcard webhooks could send duplicated events.
2018-01-03 17:00:44 +08:00
Guo Xiang Tan
647cf7545d
Fix randomly failing spec.
2018-01-03 14:42:16 +08:00
Guo Xiang Tan
af1e2865f7
Re-introduce ability to handle basic authentication in smoke tests.
2018-01-03 14:24:06 +08:00
Guo Xiang Tan
05df918b9f
Allow 2.5 to fail on Travis while we add support for it.
2017-12-26 11:36:11 +08:00
Guo Xiang Tan
0cf826a2f0
Run Ruby tests with 2.5 on Travis.
2017-12-26 10:05:45 +08:00
Guo Xiang Tan
47585202cb
Handle promise in smoke test.
2017-12-23 09:29:22 +08:00
Guo Xiang Tan
d80aca0484
FIX: Don't start discobot poll tutorial if polls are disabled.
...
https://meta.discourse.org/t/discobot-dont-take-users-through-the-poll-tutorial-if-its-not-enabled/76604/3
2017-12-22 15:46:46 +08:00
Guo Xiang Tan
80eb492c07
Add eslint and babel-eslint to yarn dev dependencies.
2017-12-22 13:24:39 +08:00
Guo Xiang Tan
32171ad286
FIX: Invalid logo in discobot's certificate when SiteSetting.logo_small_url is blank.
...
https://meta.discourse.org/t/broken-image-in-discobot-certificate-with-no-logo-small-url/76594/2
2017-12-22 09:36:53 +08:00
Guo Xiang Tan
ee1b90503c
FIX: Error when an invalid date is passed to certificate generator.
...
https://meta.discourse.org/t/broken-image-in-discobot-certificate-with-no-logo-small-url/76594/2
2017-12-22 09:36:52 +08:00
Guo Xiang Tan
6f89db4c24
Re-enable check for yarn when running qunit:test rake task.
2017-12-22 09:11:49 +08:00
Guo Xiang Tan
66aa8691ed
Fix JS travis tests incorrectly passing.
2017-12-21 16:03:43 +08:00
Guo Xiang Tan
e5cc0f1358
Test discourse-patreon on Travis as well.
2017-12-21 15:47:36 +08:00
Guo Xiang Tan
4b51871f6a
Treat non-ascii URLs in UrlValidator.
2017-12-21 14:22:55 +08:00
Guo Xiang Tan
6ecf37c482
Improve URL validation to check for a valid host.
...
Parsing a URL with `URI` is not sufficient as the following cases
are considered valid:
URI.parse("http://https://google.com ")
=> #<URI::HTTP http://https//google.com >
2017-12-21 13:50:15 +08:00
Guo Xiang Tan
8f6e2b7186
Fix unhandled promise in smoke test.
2017-12-21 10:32:43 +08:00
Guo Xiang Tan
aabac55edd
Better ENV name for QUnit's seed.
2017-12-21 09:47:32 +08:00
Guo Xiang Tan
6c4ee9d5b5
FEATURE: Trigger user webhook when a user logs in/out.
...
https://meta.discourse.org/t/how-do-you-learn-how-to-build-these-plugins/57946/10?u=tgxworld
2017-12-20 17:47:30 +08:00
Guo Xiang Tan
6e0b2a9f37
Bump timeout when logging in in smoke_test.
2017-12-20 17:08:57 +08:00
Guo Xiang Tan
ae75c19f4b
Run core and plugin JS tests separately for now on Travis.
...
Plugin JS acceptance tests are randomly failing due to core tests.
2017-12-20 15:32:37 +08:00
Guo Xiang Tan
4986132e1b
Fix missing variable in smoke test rake task.
2017-12-20 14:49:41 +08:00
Guo Xiang Tan
87c334c063
Fix randomly failing JS acceptance tests.
2017-12-20 11:04:47 +08:00
Guo Xiang Tan
ca8e4dfb43
Allow seed to be passed via ENV.
2017-12-19 21:35:51 +08:00
Guo Xiang Tan
141a4a059d
QUnit tests should be run in random order.
2017-12-19 21:33:31 +08:00
Guo Xiang Tan
dfed56cb57
Disable JS test that fails in headless mode.
2017-12-19 20:50:39 +08:00
Guo Xiang Tan
349dc8da29
Disable check for yarn in qunit tests first.
2017-12-19 20:09:36 +08:00
Guo Xiang Tan
6a4f391e38
Switch to chrome headless mode instead of phantomjs.
2017-12-19 16:00:43 +08:00
Guo Xiang Tan
30ddc1f222
Don't swallow errors when failing to create message for post action.
2017-12-19 10:58:26 +08:00
Guo Xiang Tan
b39d3a863d
FIX: moderators group wasn't being updated to be messagable by everyone.
...
https://meta.discourse.org/t/custom-flag-not-showing-text/76244
2017-12-19 10:14:56 +08:00
Guo Xiang Tan
8d44642b97
Add smoke test script that runs in chrome headless.
2017-12-18 16:39:01 +08:00
Guo Xiang Tan
97ceebb570
SECURITY: Don't pass email backup token to sidekiq as a parameter.
...
* This exposes the token in the Sidekiq dashboard which can be
viewed by an admin and defeats the purpose of using a token
in the download backup email ink.
2017-12-18 11:25:22 +08:00
Guo Xiang Tan
5489cd14c7
Skip validations when fixing Topic#featured_link in onceoff job.
2017-12-15 23:45:07 +08:00
Guo Xiang Tan
91e84433ff
Take two at fixing JS tests.
2017-12-15 15:46:09 +08:00
Guo Xiang Tan
77fbb2306d
Fix chrome-qunit-test.js wasn't exiting with the right error code.
2017-12-15 14:12:01 +08:00
Guo Xiang Tan
0f011e1c1c
Update fixtures to fix JS test.
2017-12-15 13:42:17 +08:00
Guo Xiang Tan
0a863dd031
Run JS test in chrome headless on Travis.
2017-12-15 12:29:45 +08:00
Guo Xiang Tan
f2565f6c7e
SECURITY: Any group can be invited into a PM.
2017-12-14 14:57:48 +08:00
Guo Xiang Tan
34342ad0d8
FIX: User#user_avatar may be nil.
2017-12-14 13:23:03 +08:00
Guo Xiang Tan
a9cac72fb9
Try this instead to fix yarn on travis.
2017-12-14 12:45:55 +08:00
Guo Xiang Tan
ec6428d572
Fix bash error in travis file.
2017-12-14 12:30:28 +08:00
Guo Xiang Tan
ab9b1be714
Fix eslint on travis.
2017-12-14 12:17:19 +08:00
Guo Xiang Tan
7aee1e3083
Remove specs that makes the build very sad.
2017-12-13 17:51:52 +08:00
Guo Xiang Tan
d5293aeae2
Clean Topic#slug when SiteSetting.slug_generation_method changes.
...
https://meta.discourse.org/t/removing-the-concept-of-slugs-for-some-languages/26643/24?u=tgxworld
2017-12-13 16:11:07 +08:00
Guo Xiang Tan
e2b64257b3
Fix undefined method for NilClass error.
2017-12-12 18:54:29 +08:00
Guo Xiang Tan
7d8cd84fa6
Improve lograge custom payload error handling.
2017-12-12 17:27:40 +08:00
Guo Xiang Tan
6ade508f39
FIX: Prevent 'rack.input' missing error.
2017-12-12 16:40:35 +08:00
Guo Xiang Tan
365bd771d9
Fix the build.
2017-12-11 17:03:05 +08:00
Guo Xiang Tan
4bd5acec47
FIX: Topic#featured_link may contain more than a URL.
2017-12-11 16:36:19 +08:00
Guo Xiang Tan
2ff3444568
Rescue from errors when trying to append custom payloads to lograge output.
2017-12-08 08:31:58 +08:00
Guo Xiang Tan
c64774f4f8
Remove debugging code.
2017-12-07 06:48:12 +08:00
Guo Xiang Tan
4531563717
Hide new advanced editor and preview sync behind a hidden site settings.
2017-12-06 12:34:58 +08:00
Guo Xiang Tan
6cb2b68b22
current_username -> username.
2017-12-05 12:29:02 +08:00
Guo Xiang Tan
dc858ec120
Include request.remote_ip and current_username in lograge logs.
2017-12-05 11:57:41 +08:00
Guo Xiang Tan
f5d45f797a
Fix broken Gemfile.lock.
2017-12-04 11:28:45 +08:00
Guo Xiang Tan
78f09f0489
Logster 1.2.9 is the version we want to be at.
2017-12-04 11:05:14 +08:00
Guo Xiang Tan
b18cc81609
Make rubocop happy.
2017-12-04 10:55:31 +08:00
Guo Xiang Tan
22140efa70
Tests are still leaking connection after skipping.
...
* Could be in the setup.
2017-12-04 10:46:30 +08:00
Guo Xiang Tan
e73fbfe265
FIX: Topic#featured_link_root_domain extracts URL before parsing.
2017-12-04 10:00:07 +08:00
Guo Xiang Tan
846b047847
Revert "Revert "Upgrade logster.""
...
This reverts commit 57ca4b20e2
2017-12-04 09:30:21 +08:00
Guo Xiang Tan
4c8402c50f
Skip test that is leaking connections.
2017-12-04 09:26:51 +08:00
Guo Xiang Tan
57ca4b20e2
Revert "Upgrade logster."
...
This reverts commit 1376a86bcc
2017-12-01 17:32:49 +08:00
Guo Xiang Tan
2e860eddc1
Don't sync scroll when input is not scrollable.
...
https://meta.discourse.org/t/composer-preview-scroll-not-syncing-with-editor/74975/14?u=tgxworld
2017-12-01 17:08:03 +08:00
Guo Xiang Tan
1376a86bcc
Upgrade logster.
2017-12-01 16:03:00 +08:00
Guo Xiang Tan
cffe50f856
Run specs for discourse-assign.
2017-12-01 16:03:00 +08:00
Guo Xiang Tan
900dec5bc1
Make logster ignore Rack::QueryParser::InvalidParameterError errors.
2017-11-30 15:29:19 +08:00
Guo Xiang Tan
c128e421c4
FIX: Don't run job if topic timer has already been deleted.
2017-11-30 15:26:26 +08:00
Guo Xiang Tan
853b51b519
Add uniqueness validation for SingleSignOnRecord#external_id.
2017-11-30 15:15:52 +08:00
Guo Xiang Tan
f7f743970b
Just use space to prettify SSO verbose error logging.
2017-11-30 15:10:00 +08:00
Guo Xiang Tan
3053499375
Update mini_suffix.
2017-11-30 11:14:06 +08:00
Guo Xiang Tan
9fbe1436b6
UX: Replace heuristic solution root domain extraction for topic featured link.
2017-11-29 21:52:41 +08:00
Guo Xiang Tan
b1375ef44e
Ensure that we disconnect connection in test.
2017-11-29 20:57:13 +08:00
Guo Xiang Tan
fffb7561c4
Update mini_suffix.
2017-11-29 17:07:41 +08:00
Guo Xiang Tan
8491c5fba5
UX: Replace heuristic solution for extracting root domain.
2017-11-29 16:26:46 +08:00
Guo Xiang Tan
3e9c3f6f13
Fix JS test.
...
* `new Array` doesn't seem to be available in phantomJS yet.
2017-11-29 16:03:00 +08:00
Guo Xiang Tan
5b965ab5d0
Sync editor and preview when preview is updated.
2017-11-29 11:19:04 +08:00
Guo Xiang Tan
ebc31975e8
Ember.run.schedule -> Ember.run.scheduleOnce.
2017-11-29 10:43:59 +08:00
Guo Xiang Tan
de17a8e856
UX: Sync input and preview when user is typing.
2017-11-29 09:56:15 +08:00
Guo Xiang Tan
4816619ba3
FIX: Editor and preview does not sync when scrolled to the bottom.
2017-11-29 08:38:57 +08:00
Guo Xiang Tan
bb0b7b61d7
FIX: Don't fail silently when updating a record.
2017-11-29 08:01:13 +08:00
Guo Xiang Tan
110dfbf42f
Uglify doesn't support ES6 yet.
2017-11-28 16:07:27 +08:00
Guo Xiang Tan
7b8699f3be
FIX: Can't load service-worker.js in production.
2017-11-28 15:40:57 +08:00
Guo Xiang Tan
46f8a6c97d
Fix broken lograge logs.
2017-11-28 14:00:13 +08:00
Guo Xiang Tan
5805979e88
FIX: Re-enable invalid interpolation keys check and allow default keys to be left out of translation overrides.
...
https://meta.discourse.org/t/bulk-invite-from-file-resets-the-invite-forum-mailer-customized-text/67606/16
2017-11-27 11:00:08 +08:00
Guo Xiang Tan
2e04ef97d9
Fix the build.
2017-11-27 10:53:05 +08:00
Guo Xiang Tan
a7030e80bf
Skip randomly failing test.
2017-11-27 10:51:18 +08:00
Guo Xiang Tan
c8157f6b07
Update seed-fu with PG10 support.
...
https://meta.discourse.org/t/discourse-appears-to-be-broken-with-postgres-10/71723
2017-11-27 10:26:59 +08:00
Guo Xiang Tan
b907f7d307
Add more metrics to lograge's output if MethodProfiler is enabled.
2017-11-25 08:16:40 +08:00
Guo Xiang Tan
f3f051a344
UX: Composer textarea should always start at the top.
2017-11-24 23:24:37 +08:00
Guo Xiang Tan
44333c5de3
REFACTORY: Dry up some composer syncing code.
2017-11-24 14:57:36 +08:00
Guo Xiang Tan
a509f466a0
Expose replica_postgresql_connection to ActiveRecord::Base.
2017-11-24 09:35:45 +08:00
Guo Xiang Tan
82222e8d18
Improve specs to test for the right response status.
2017-11-24 09:32:44 +08:00
Guo Xiang Tan
c5745feac6
Build scrollMap only on scroll.
2017-11-23 21:44:09 +08:00
Guo Xiang Tan
ab839d134b
Fix scrollmap included NaN values.
2017-11-23 18:08:43 +08:00
Guo Xiang Tan
486016acea
UX: Improve editor and preview scroll syncing.
2017-11-23 17:02:02 +08:00
Guo Xiang Tan
26d14dbcbb
Remove onceoff job in migrate rake task.
2017-11-22 12:50:01 +08:00
Guo Xiang Tan