Commit Graph
31 Commits
Author SHA1 Message Date
Jarek RadoszandLoïc Guitaut 71834c898f DEV: Update rubocop-discourse to 3.13 and autofix issues (#35073)
Co-authored-by: Loïc Guitaut <loic@discourse.org>
2025-10-06 16:11:01 +02:00
Jarek RadoszandLoïc Guitaut a54e3208cb DEV: Hand-pick Rails/WhereNot autofixes (#35117)
We can't enable `Rails/WhereNot` lint/autofix, because it would break
code that uses mini_sql instead of AR (which rubocop, and tbh also we,
can't easily differentiate)

Those are safe because they either:
* are executed in AR model scope definitions
* are clearly chained starting from a AR model
* are less-clearly chained, but still can be traced to a AR model/scope

---------

Co-authored-by: Loïc Guitaut <loic@discourse.org>
2025-10-03 13:29:22 +02:00
Régis Hanol e171530e14 FIX: post voting comments editing UX (#35108)
was showing up inconditionnaly even if you didn't have the permissions
to edit other people's comments.

This was only a UX issue as the server is doing the correct check.

The issue was the `hasPermission` method which wasn't a getter so it
wasn't checked for all the instances of the post comments but rather
once.

Also added some acceptance tests to ensure we don't regress.

Internal ref - t/163347
2025-10-01 11:31:19 +02:00
Discourse Translator Bot 5fbadcc2ec Update translations (#35065) 2025-09-30 16:06:14 +02:00
Jarek Radosz 1a6bf7d0a7 DEV: Remove obsolete register_svg_icon checks (#35067) 2025-09-30 15:51:44 +02:00
Jarek RadoszandLoïc Guitaut e372355fd0 DEV: Clean up scope resolution operators in plugins (#34979)
Co-authored-by: Loïc Guitaut <loic@discourse.org>
2025-09-30 14:36:34 +02:00
Sérgio Saquetim 813b494730 DEV: Replace deprecated Ember's array filterBy with filter (#35018)
Replaces Ember's deprecated `filterBy` with the native JavaScript method
`filter`. This aligns with modern JavaScript practices, improves code
clarity, and prepares for future deprecations.

Changes involve various components, controllers, and models across the
codebase.
2025-09-29 16:42:38 -03:00
Discourse Translator Bot cb6a8a5cf1 Update translations (#35031) 2025-09-29 10:26:53 +02:00
Jarek Radosz 2c84945853 DEV: Normalize route and namespace setup in plugins (#34962) 2025-09-25 12:35:29 +02:00
Discourse Translator Bot e0b849beac Update translations (#34839) 2025-09-24 14:48:18 +02:00
Discourse Translator Bot 3a8a9f27ce Update translations (#34745) 2025-09-12 16:17:25 +02:00
Discourse Translator Bot 5a8f5e8f07 Update translations (#34658) 2025-09-01 10:54:32 +02:00
Discourse Translator Bot 7f07453157 Update translations (#34633) 2025-08-29 17:24:43 +02:00
Discourse Translator Bot 0d4ca82c91 Update translations (#34568) 2025-08-27 11:00:03 +02:00
Discourse Translator Bot 9c429cd00e Update translations (#34510) 2025-08-25 11:43:23 +02:00
Discourse Translator Bot 7d3bfe978e Update translations (#34436) 2025-08-21 11:02:39 +02:00
Discourse Translator BotandGerhard Schlager ab0b0573a1 Update translations (#34413)
Co-authored-by: Gerhard Schlager <gerhard.schlager@discourse.org>
2025-08-19 16:23:59 +02:00
Discourse Translator Bot 74066bffa2 Update translations (#34116) 2025-08-19 12:14:51 +02:00
Jarek Radosz 89b108c4b2 DEV: Remove unused services from plugins/themes (#34231) 2025-08-12 22:47:31 +02:00
Discourse Translator Bot e3d1e75c76 Update translations (#34004) 2025-07-31 16:18:53 +02:00
Jarek Radosz ce6368ca98 DEV: Enable ember/no-classic-components (#33978)
…and apply lint-to-the-future
2025-07-30 14:54:24 +02:00
Discourse Translator Bot fa87576fcf Update translations (#33892) 2025-07-28 18:38:22 +02:00
dependabot[bot]dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>Discourse CIJarek Radosz
e7d3c344d1 Build(deps-dev): Bump the lint group across 1 directory with 4 updates (#33881)
Bumps the lint group with 4 updates in the / directory:
[@discourse/lint-configs](https://github.com/discourse/lint-configs),
[ember-template-lint](https://github.com/ember-template-lint/ember-template-lint),
[eslint](https://github.com/eslint/eslint) and
[stylelint](https://github.com/stylelint/stylelint).


Updates `@discourse/lint-configs` from 2.22.0 to 2.28.0
- [Commits](https://github.com/discourse/lint-configs/commits)

Updates `ember-template-lint` from 7.7.0 to 7.9.1
- [Release
notes](https://github.com/ember-template-lint/ember-template-lint/releases)
-
[Changelog](https://github.com/ember-template-lint/ember-template-lint/blob/master/CHANGELOG.md)
-
[Commits](https://github.com/ember-template-lint/ember-template-lint/commits)

Updates `eslint` from 9.27.0 to 9.32.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](https://github.com/eslint/eslint/compare/v9.27.0...v9.32.0)

Updates `stylelint` from 16.19.1 to 16.22.0
- [Release notes](https://github.com/stylelint/stylelint/releases)
-
[Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md)
-
[Commits](https://github.com/stylelint/stylelint/compare/16.19.1...16.22.0)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Discourse CI <ci@ci.invalid>
Co-authored-by: Jarek Radosz <jarek@cvx.dev>
2025-07-28 18:02:41 +02:00
Discourse Translator Bot 6c6c4f74ce Update translations (#33855) 2025-07-25 18:14:31 +02:00
Jarek Radosz cfb1ea0c2c DEV: Fix random typos (#33839)
July 2025 edition

@discourse-translator-bot keep_translations
2025-07-24 22:04:13 +02:00
Jarek Radosz 1cb3e2c070 DEV: Remove unnecessary rails_helper requires (#33812) 2025-07-24 13:50:04 +02:00
Discourse Translator Bot be72df118f Update translations (#33821) 2025-07-24 12:09:41 +02:00
Discourse Translator Bot 3d3fadd008 Update translations (#33788) 2025-07-23 12:39:43 +02:00
Alan Guo Xiang Tan ebf709f801 FEATURE: Add site setting to allow comments to be disabled in discourse-post-voting plugin (#33775)
This commit introduces a post_voting_comment_enabled site setting to
control whether comments are allowed on posts.
2025-07-23 11:03:01 +08:00
Discourse Translator Bot 0bad5c6104 Update translations (#33746) 2025-07-23 00:13:58 +02:00
Jarek Radosz 404810a6f1 DEV: Move discourse-post-voting to core (#33570)
https://meta.discourse.org/t/373574

Internal `/t/-/156778`
2025-07-15 16:38:05 +02:00