Joffrey JAFFEUX
ae1e4de286
[FIX] better control on value mutation
2017-10-20 13:40:56 -07:00
Joffrey JAFFEUX
df4102466c
[FIX] Prevents multiple rows from being selected
2017-10-20 07:34:29 -07:00
Joffrey JAFFEUX
7bccd47315
remove mistakenly checked file
2017-10-20 07:07:51 -07:00
Joffrey JAFFEUX
671af2690e
[FIX] Improves select positioning with direction=rtl in a modal
2017-10-20 07:01:04 -07:00
Joffrey JAFFEUX
21af7d7755
[FIX] Caret not showing in topic-footer-mobile-dropdown
2017-10-20 06:41:00 -07:00
Joffrey JAFFEUX
fd7af2e146
[FIX] dropdown tracking not showing in groups
2017-10-20 05:34:10 -07:00
Joffrey JAFFEUX
aa134294cc
[FIX] Improves positioning of select-box
2017-10-19 18:39:46 -07:00
Joffrey JAFFEUX
4d041d5b87
[FIX] Fix wizard spec
...
This commit introduces a mutation on input value given to select-box-kit when value is empty. The refactoring required to avoid this would be too heavy atm, but ultimately we would want to avoid this.
2017-10-19 17:34:56 -07:00
Joffrey JAFFEUX
42162c38b3
fix linting
2017-10-19 15:24:21 -07:00
Joffrey JAFFEUX
63c63c1bfd
Skip wizard tests
...
awaiting fixes on select-box-kit
2017-10-19 15:18:01 -07:00
Joffrey JAFFEUX
d77ef05ee1
Fix broken tests
2017-10-19 14:32:37 -07:00
Joffrey JAFFEUX
ae1743c61f
[WIP] select-box-kit refactoring
2017-10-19 12:51:08 -07:00
Joffrey JAFFEUX
2a17684546
FIX: do not display uncategorized as a possible parent category
2017-09-20 20:47:50 +02:00
Joffrey JAFFEUX
81def3b8b4
FIX: regression preventing display of custom emojis in the picker
2017-09-18 09:38:18 +02:00
Joffrey JAFFEUX
5acf3504bf
minor changes to emoji-picker
...
- refactoring of globals
- removing autofocus, causing issues on mobile
- improve unbinding of listeners
2017-09-15 16:03:28 +02:00
Joffrey JAFFEUX
e6385e4527
attempts to fix broken spec only on CI
2017-09-14 20:34:37 +02:00
Joffrey JAFFEUX
7f69ace112
FIX: makes sure select-box is under header and over avatar on mobile
2017-09-14 19:59:32 +02:00
Joffrey JAFFEUX
562e48dfb7
adds a dsl to simplify testing of the select-box
2017-09-14 19:50:32 +02:00
Joffrey JAFFEUX
7a4ddc2bb1
FIX: makes state of select-box more resilient to model changes
2017-09-13 18:44:40 +02:00
Joffrey JAFFEUX
b537bf1ba4
FIX: better alignments of categories/tags in .topic-category
2017-09-13 16:24:36 +02:00
Joffrey JAFFEUX
3713278a4b
FIX: reason paragraph styling broken on mobile
2017-09-13 10:24:02 +02:00
Joffrey JAFFEUX
64c154d9df
FIX: prevents click on select-box to close timeline-container on mobile
2017-09-13 10:00:10 +02:00
Joffrey JAFFEUX
c06c88b479
cleaner title attribute for select-box
2017-09-12 01:36:58 +02:00
Joffrey JAFFEUX
18114c7bdb
Revert "FIX: pinned-button sometimes not shown when unpinned is null"
...
This reverts commit 01f0b56331 .
2017-09-12 01:03:16 +02:00
Joffrey JAFFEUX
b875d17e1f
fix linter error
2017-09-11 23:51:42 +02:00
Joffrey JAFFEUX
2c284874b4
FIX: icon showing as null
2017-09-11 22:47:47 +02:00
Joffrey JAFFEUX
01f0b56331
FIX: pinned-button sometimes not shown when unpinned is null
2017-09-11 20:04:07 +02:00
Joffrey JAFFEUX
e924920bec
uses select-box for pinned-button
...
This commit also moves more logic in dropdown-select-box instead of
duplicating it for notifications-options and pinned-options
2017-09-11 19:14:22 +02:00
Joffrey JAFFEUX
2708243584
FIX: makes sure the select-box doesn’t go over header
2017-09-11 11:23:46 +02:00
Joffrey JAFFEUX
b2dcb51e48
adds missing spacing around links in reason text
2017-09-11 10:42:53 +02:00
Joffrey JAFFEUX
7f9220a2cd
minor select-box fixes
...
- select row when using tab
- makes sure tab order is correct
- highlight first row when filtering
2017-09-11 00:38:32 +02:00
Joffrey JAFFEUX
cf624bead0
FIX: cross browser issues on safari and edge
2017-09-10 22:25:31 +02:00
Joffrey JAFFEUX
a0f36a0401
fix broken spec
2017-09-10 21:07:13 +02:00
Joffrey JAFFEUX
6d6fe7b3a9
adds more specificity to .dropdown-select-box
2017-09-10 20:57:34 +02:00
Joffrey JAFFEUX
4b558638c8
FEATURE: improves keyboard handling of select-box
...
- arrow keys
- escape key
2017-09-10 19:12:03 +02:00
Joffrey JAFFEUX
a11eec47bb
FIX: display localised title when using notifications-button
2017-09-10 11:38:52 +02:00
Joffrey JAFFEUX
bba26e48a0
FIX: positioning issues with notifications-button
2017-09-10 11:36:57 +02:00
Joffrey JAFFEUX
1f8695b16a
fix broken build
2017-09-09 20:58:37 +02:00
Joffrey JAFFEUX
950b9e9eaf
FIX: keeps as much as possible the same api for select-box components
2017-09-09 20:29:07 +02:00
Joffrey JAFFEUX
8c3f7d9bbc
FIX: select-box width was incorrect on mobile
2017-09-09 02:41:31 +02:00
Joffrey JAFFEUX
753bf72921
FIX: adds correct spacing between footer buttons
2017-09-09 02:28:51 +02:00
Joffrey JAFFEUX
253672f3fa
makes notification-options design more compliant with existing design
2017-09-09 01:53:10 +02:00
Joffrey JAFFEUX
ab700d86ba
lighter icon color for categories-admin-actions
2017-09-09 01:52:36 +02:00
Joffrey JAFFEUX
a9aa11d7c4
use d-icon names
2017-09-09 01:48:03 +02:00
Joffrey JAFFEUX
5b9819f4ed
minor fixes to select-box
2017-09-09 00:49:33 +02:00
Joffrey JAFFEUX
1d52231f42
FIX: css regression on category-dropdown-button
2017-09-08 21:28:28 +02:00
Joffrey JAFFEUX
cf6fb7622e
Replaces all notification-options like dropdowns with select-box
2017-09-08 20:47:39 +02:00
Joffrey JAFFEUX
661ae38a03
FIX: makes sure we only autocomplete valid emoji tones
2017-09-08 09:42:13 +02:00
Joffrey JAFFEUX
d2d1c29f48
FIX: topic-notifications was taking too much space on mobile
2017-09-07 20:13:32 +02:00
Joffrey JAFFEUX
3c0a9d4d19
FIX: topic-notifications taking too much space in timeline
2017-09-07 19:55:56 +02:00
Joffrey JAFFEUX
5054065e81
FIX: broken spec
2017-09-07 19:18:27 +02:00
Joffrey JAFFEUX
70d0e175a2
FIX: default select-box-row should be aligned vertically
2017-09-07 17:03:48 +02:00
Joffrey JAFFEUX
0374dc1a0e
FIX: keys were incorrectly set to category
2017-09-07 16:56:38 +02:00
Joffrey JAFFEUX
633d2fde45
removes select-box minWidth property
...
Using css offers more flexibility
2017-09-07 16:56:16 +02:00
Joffrey JAFFEUX
ca58a8228c
minor css fixes on select-box
2017-09-07 16:56:00 +02:00
Joffrey JAFFEUX
d04aa5c7af
FIX: component height computation was wrong
2017-09-07 16:55:36 +02:00
Joffrey JAFFEUX
dd27c0c80e
FIX: supports emojis in pinned topic excerpt
2017-09-07 11:06:04 +02:00
Joffrey JAFFEUX
0fca5ed533
FIX: stricter check on presence of notification_level_change
...
When `notification_level_change` was `0` it was evaluating to false
2017-09-06 19:59:23 +02:00
Joffrey JAFFEUX
ccf5005feb
FEATURE: uses select-box for topic-notifications-button component
...
- Introduces ComponentConnector to use a component inside a widget
- Use css to set size of components instead of properties
- Smarted positionning
- Style tweaks
2017-09-06 16:58:00 +02:00
Joffrey JAFFEUX
afe6f46b03
merges after_save
2017-09-04 13:40:11 +02:00
Joffrey JAFFEUX
caedefd675
FIX: correctly resets user_themes template
...
This commit adds tests for this behaviour and also adds support for
reseting cache when updating a theme name and destroying a theme.
2017-09-04 13:27:58 +02:00
Joffrey JAFFEUX
56468582ee
FIX: visual regressions on title-wrapper
2017-08-31 15:08:09 +02:00
Joffrey JAFFEUX
0957ac9ee2
FIX: minor css tweaks to title-wrapper
2017-08-31 11:16:08 +02:00
Joffrey JAFFEUX
84e992363c
FIX: use maximum z-index for select-box when expanded
2017-08-31 00:55:05 +02:00
Joffrey JAFFEUX
746c5927e1
Replaces remaining {{category-chooser}} by {{category-select-box}}
...
To achieve replacement, this commit also adds support for:
- clearSelectionLabel which will allows to unselect any chosen category
- select-box inside a modal
- fixes minor css positioning issues
Note: {{category-chooser}} will be removed in the next weeks.
2017-08-30 17:04:17 +02:00
Joffrey JAFFEUX
1ea5205022
FIX: tests helper do not use es6
2017-08-29 16:16:51 +02:00
Joffrey JAFFEUX
98c6c7e35a
FIX: css regression on select-box
2017-08-29 15:52:38 +02:00
Joffrey JAFFEUX
1bcfa87d18
FIX: select-box broken spec
...
Introduces a test helper for selectBox to simplify these cases.
2017-08-29 15:51:25 +02:00
Joffrey JAFFEUX
cb4f690937
uses new select-box for quick topic edit
2017-08-29 15:15:17 +02:00
Joffrey JAFFEUX
dcc5f93344
FIX: disable highlighting when no value set on select-box
2017-08-29 14:32:23 +02:00
Joffrey JAFFEUX
21c4e38eec
clean select-box css
2017-08-29 14:31:03 +02:00
Joffrey JAFFEUX
f101fec19c
FIX: improves uncategorized support for category-select-box
2017-08-29 12:48:26 +02:00
Joffrey JAFFEUX
861dbe3b51
select-box refactoring
...
- more flexibility (allows custom title)
- less re-render
- more robustness
2017-08-29 12:25:54 +02:00
Joffrey JAFFEUX
b83c0747d9
FIX: select-box improvments
...
- more tests for category-select-box
- allows to clear selection
- fix positioning on safari
- focus on click
- do not display uncategorized if not allowed in settings
- fix component state impacting other specs
- better texts
- higher category-select-box on mobile
2017-08-28 14:34:04 +02:00
Joffrey JAFFEUX
5d12db1fb5
FIX: html not showing in select-box header
2017-08-26 02:44:36 +02:00
Joffrey JAFFEUX
918f5045b4
FEATURE: display subcategories when filtering on parent name
2017-08-26 02:01:34 +02:00
Joffrey JAFFEUX
2efb39289c
FIX: select-box fragile specs
2017-08-26 01:24:17 +02:00
Joffrey JAFFEUX
296ea6c7b1
FIX: castInteger on initial value
2017-08-25 22:41:35 +02:00
Joffrey JAFFEUX
14f06c2740
select-box minor fixes
2017-08-25 19:56:57 +02:00
Joffrey JAFFEUX
bbd428fb94
FIX: more consistent filter from keyboard on select-box
2017-08-25 01:48:32 +02:00
Joffrey JAFFEUX
f3388043db
FIX: avoids select-box being over composer popup
2017-08-24 18:49:35 +02:00
Joffrey JAFFEUX
39a89419b6
uses select-box for theme selection on user profile
2017-08-24 18:33:01 +02:00
Joffrey JAFFEUX
d05df4a337
FIX: better headerText handling on select-box
2017-08-24 18:31:33 +02:00
Joffrey JAFFEUX
9c446fcb4d
FIX: modify select-box orientation when composer resizes
2017-08-24 17:14:55 +02:00
Joffrey JAFFEUX
21d6c7f6b3
FIX: duplicated categories in select-box
2017-08-24 16:54:10 +02:00
Joffrey JAFFEUX
d52048ad34
Revert "Revert "FEATURE: improves select-box to support category selection on new topic""
...
This reverts commit 1d90f6016a .
2017-08-24 16:04:47 +02:00
Joffrey JAFFEUX
1d90f6016a
Revert "FEATURE: improves select-box to support category selection on new topic"
...
This reverts commit 7b4e302677 .
2017-08-23 16:33:03 +02:00
Joffrey JAFFEUX
7b4e302677
FEATURE: improves select-box to support category selection on new topic
2017-08-23 15:08:19 +02:00
Joffrey JAFFEUX
a3e9819158
FEATURE: allows to disable automaticPositioning of emoji-picker ( #5074 )
...
Usage:
{{emoji-picker automaticPositioning=false}}
2017-08-22 19:41:02 +02:00
Joffrey JAFFEUX
c264348fcb
FIX: avoids user-selector having no width
2017-08-21 18:55:44 +02:00
Joffrey JAFFEUX
cad6107624
refactors select-box
...
Note: this commit also now uses select-box for mobile topics controls
2017-08-16 00:41:56 +02:00
Joffrey JAFFEUX
506572bf04
FIX: display emojis (set, custom and native) in bio excerpt
2017-08-15 10:05:09 +02:00
Joffrey JAFFEUX
9e475860e0
theme color select-box should be filterable
2017-08-13 14:53:07 +02:00
Joffrey JAFFEUX
482924b161
FEATURE: initial implementation of an ember native select
2017-08-13 14:34:50 +02:00
Joffrey JAFFEUX
6cd8203686
FIX: allows onebox to force GET hosts returning wrong headers on HEAD
2017-08-08 11:44:27 +02:00
Joffrey JAFFEUX
da5e7dc876
FIX: Pull last emoji-db revision
...
This commit will add new images in some sets and fix a bug where
🤦♂️ was using :person_facepalming: image which is in fact
represented as a woman in most sets.
2017-07-29 13:12:45 +02:00
Joffrey JAFFEUX
8556d3c27f
FIX: emoji-picker do not reload all everything when changing diversity
2017-07-25 12:23:38 +02:00
Joffrey JAFFEUX
22c5fb20b4
FIX: emoji-picker broken and skipped specs
2017-07-25 12:23:38 +02:00
Joffrey JAFFEUX
d9696c98c3
FIX: broken spec
2017-07-24 13:59:36 +02:00
Joffrey JAFFEUX
995d253030
FIX: improves efficiency
2017-07-24 12:42:54 +02:00