IntenseWebs/discourse
3
0
Fork 0
mirror of https://github.com/discourse/discourse.git synced 2026-09-05 04:40:41 -05:00
Code Issues Packages Projects Releases Wiki Activity
56,411 Commits 1,018 Branches 579 Tags
bb13e18855d41619d45da69d1bfc1bcb84456574
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Mark VanLandingham 882c2da29e DEV: Add modifier to SuggestedTopicsBuilder#add_results (#29164) 2024-10-10 10:03:26 -05:00
Mark VanLandingham 909264ee75 DEV: Publish DiscourseEvent after top topic period is calculated (#29142) 2024-10-10 08:10:39 -05:00
Mark VanLandingham e4457ed2c6 FIX: Remove breaking super call in scroll-tracker component (#28810) 2024-09-09 15:30:17 -05:00
Mark VanLandingham 3e320ce225 DEV: Add 'multiple' class to login-buttons when there are multiple btns (#28649) 2024-08-30 08:36:08 -05:00
Mark VanLandingham ae111904ef DEV: Add container with classname to invited-by invite section (#28644) 2024-08-29 11:31:13 -05:00
Mark VanLandingham 9802d4040f DEV: Add class to span wrapping after-topic-list plugin outlet (#28445) 2024-08-20 14:08:06 -05:00
Mark VanLandingham 1ca06e1283 UX: Style reviewables in the user menu when avatars are enabled (#28388) 2024-08-15 10:26:36 -05:00
Mark VanLandingham 79f871b558 FIX: Display new DM button when public channels are disabled (#28306) 2024-08-12 08:44:51 -05:00
Mark VanLandingham 206bbb4255 UX: Add sidebar DM list back when public channels are disabled (#28301) 2024-08-09 09:16:14 -05:00
Mark VanLandingham 30c4c29946 DEV: Improve TagGroup.resolve_permissions method arg type handling (#28016) 2024-07-22 08:37:12 -05:00
Mark VanLandingham 6e77107ccc DEV: Publish DiscourseEvent in TopicUser.track_visit for first visit (#27975) 2024-07-19 10:53:12 -05:00
Mark VanLandingham d42a1c8885 DEV: Pass recipient email address to message_builder modifiers (#27308) 2024-06-04 08:00:30 -05:00
Mark VanLandingham 8eec9da0b4 DEV: Plugin modifier application for About admins (#27261) 2024-05-30 10:44:53 -05:00
Mark VanLandingham 971b66e440 DEV: Move webhook event header modifier for redelivery-recalucation (#27177) 2024-05-24 10:37:10 -05:00
Mark VanLandingham 9264479c27 DEV: Add modifier for webhook event header generation (#27054) 2024-05-17 09:33:39 -05:00
Mark VanLandingham 239eac7799 DEV: Allow auth errors to render HTML (#26686) 2024-04-19 09:11:03 -05:00
Mark VanLandingham 552203aa1d DEV: Add appEvents for composer / DEditor toolbar events (#26517) 2024-04-05 08:35:25 -05:00
Mark VanLandingham 797ab30d95 DEV: Modifier to add params to TopicsController redirect url (#26470) 2024-04-02 15:35:44 -05:00
Mark VanLandingham 3f1566eeb1 FIX: Use user's locale for chat push notifications (#26107) 2024-03-08 15:18:47 -06:00
Mark VanLandingham 5f8cbb9d83 FIX: Bug in desktopNotifications service not allowing unsubscription (#26103) 2024-03-08 13:53:16 -06:00
Mark VanLandingham 3b0b4e118c DEV: Include group_name in push notification payload for group mentions (#26081) 2024-03-07 09:47:21 -06:00
Mark VanLandingham 4e80ad0724 DEV: Return meaningful values from desktop noti enable/disable fns (#26061) 2024-03-06 11:31:42 -06:00
Mark VanLandingham 04b0f40db8 DEV: Modifier for Chat::Mailer to skip summary email for users (#26011) 2024-03-04 09:21:02 -06:00
Mark VanLandingham 6c2c690479 DEV: Add push notification filtering to MessageBus alerts (#25965) 2024-02-29 12:49:46 -06:00
Mark VanLandingham 0a58b18970 DEV: Move DiscourseEvent trigger in PostAlerter#push_notification (#25931) 2024-02-29 08:33:38 -06:00
Mark VanLandingham b426f85a81 DEV: Add modifiers for plugins to customize push notification translation arguments (#25889) 2024-02-27 14:03:55 -06:00
Mark VanLandingham 7adedfa37a DEV: appEvents when desktop/push JS notifications are opened (#25823) 2024-02-26 09:00:39 -06:00
Mark VanLandingham 4f75cee6d2 FIX: Don't unnecessarily scrub query params from homepage (#25665) 
Seems like an accident that the homepage route will always strip all query params from the URL.. This fixes that :)
 2024-02-13 14:50:27 -06:00
Mark VanLandingham d4fb6e1437 DEV: Use PosterSerializer for SuggestedTopicSerializer posters (#25650) 
The only addition is PosterSerializer is this:

discourse/app/serializers/poster_serializer.rb

Line 4 in 4a5616f

Which allows themes to check the posters' primary group!
 2024-02-12 14:04:02 -06:00
Mark VanLandingham 9c36d6ec48 UX: Don't display empty state while changing notification filter (#25631) 2024-02-12 08:23:46 -06:00
Mark VanLandingham 797dffd7cc DEV: Add PluginOutlet after user notifications filter 2024-02-08 14:58:11 -06:00
Mark VanLandingham 13186e6790 FIX: Correct className for notification avatars using system avatar (#25578) 2024-02-06 14:47:35 -06:00
Mark VanLandingham a239e8f27f DEV: Add classNames to user menu icon avatar wrapper (#25548) 2024-02-02 14:07:03 -06:00
Mark VanLandingham f6becaa0b6 DEV: Wrap user summary category rows in plugin outlet (#25466) 2024-01-29 15:48:36 -06:00
Mark VanLandingham 2665752732 DEV: PluginOutlet addition in user/notifications-index & summary class names (#25463) 2024-01-29 12:56:42 -06:00
Mark VanLandingham 9130a3cafd DEV: Add PluginOutlet wrapping user notifications EmptyState (#25406) 2024-01-24 11:34:43 -06:00
Mark VanLandingham 7bad0b1d8a DEV: Trigger DiscourseEvent on push notification send (#25375) 2024-01-22 15:30:35 -06:00
Mark VanLandingham d5e3a47d3c DEV: Reset DiscoursePluginRegistry after spec (#25369) 2024-01-22 08:51:36 -06:00
Mark VanLandingham 07a0c6c637 DEV: Add additional arg to appEvents triggered on notification click (#25317) 2024-01-19 10:01:33 -06:00
Mark VanLandingham 66fb2257cf DEV: Add apply_modifier in Email::Renderer for html modifications (#25205) 2024-01-12 09:14:55 -06:00
Mark VanLandingham 68963e40da FIX: Delete topicNotificationLevel from transformed post before creatingRecord in post widget (#25229) 2024-01-11 10:09:30 -06:00
Mark VanLandingham cef6aca6e5 DEV: Pass showDismiss to panel-body-bottom outlet (#25191) 2024-01-09 13:32:40 -06:00
Mark VanLandingham 6432b7f979 DEV: Add env var to bin/docker/exec (#25187) 2024-01-09 12:31:08 -06:00
Mark VanLandingham b3791a2be0 DEV: Add setUserMenuNotificationsLimit plugin-api method (#25119) 2024-01-09 08:38:00 +08:00
Mark VanLandingham af937581e9 DEV: Pass dismissButtonClick to panel-body-bottom outlet (#25163) 2024-01-08 10:12:52 -06:00
Mark VanLandingham 64438fff25 FIX: Bind events properly in search-menu.js & fix focus issue (#25006) 
The problem:
Removing the options to addEventListener results in events that are properly cleaned up when the search menu is removed. Previously every time you opened the search menu, the listeners would be attached again, and clicking outside even after it was closed would fire the function again and again (N times as you opened the search menu!)

This was made far far worse in this commit c91d053, where I called close() to remove focus from the search input in the event that the search menu is rendered outside the header.

The problem with this was 2-fold. The close function tried to focus the search header button in core here. When the events aren't cleanup up and that happens... you can't do anything in the app.

The solution:
We don't need the event listeners to close the search menu when it's rendered from the header. The widget header handles clicks outside of the header. Sooo

1. Only register them for standalone search menus
2. Remove the passive options to the listeners so that they are properly removed on close
3. Call close() to unfocus input rather than just closing panel
4. Rename passed in are closeSearchMenu -> onClose because it's more accurate. It's really a callback.
 2023-12-22 09:48:00 -06:00
Mark VanLandingham fe8b1a1074 REVERT: "FIX: Properly close search menu on click/touch outside (#25000)" (#25005) 
This reverts commit c91d053dec.
 2023-12-21 15:54:17 -06:00
Mark VanLandingham 7c7e2aeff8 DEV: Move menu-item-end PluginOutlet outside <a> tag (#25001) 2023-12-21 12:39:17 -06:00
Mark VanLandingham c91d053dec FIX: Properly close search menu on click/touch outside (#25000) 2023-12-21 11:05:36 -06:00
Mark VanLandingham 3c6362bb26 DEV: PluginApi function to customize search menu assistant item behavior (#24992) 2023-12-20 15:25:45 -06:00
Mark VanLandingham 6d5dd92ea1 DEV: Half-revert search-menu flicker fix (#24975) 2023-12-19 16:22:30 -06:00
Mark VanLandingham fe06a76cab REVERT: "UX: fix overlap obstructed anon topic reply (#24921)" (#24925) 
This reverts commit 368f4ef24d.
 2023-12-15 15:08:34 -06:00
Mark VanLandingham 25d9927785 DEV: Remove DefaultNotificationItem widget (#24906) 
These are no longer used anymore because we use glimmer notification items everywhere 🎉
 2023-12-14 13:45:59 -06:00
Mark VanLandingham 74f964f2b4 DEV: Add current menu-panel tab ID as data attribute to panel (#24901) 2023-12-14 10:36:51 -06:00
Mark VanLandingham c051bfc2fc DEV: Plugin-api methods for user-notifications route customizations (#24873) 2023-12-13 15:15:42 -06:00
Mark VanLandingham 097cef7d21 UX: Improve layout of avatar+icon notifications (#24851) 2023-12-12 14:28:29 -06:00
Mark VanLandingham c6a2c80441 UX: Adjust notification items when avatar is shown (#24832) 2023-12-11 14:44:14 -06:00
Mark VanLandingham 6fc992f66a FIX: Color of notification icons in user-notifications index (#24826) 2023-12-11 11:35:02 -06:00
Mark VanLandingham 223e413a6c DEV: Render glimmer notification items for user notification list (#24802) 
This removes the widget notifications list and renders the glimmer user menu notification items instead.
 2023-12-11 11:04:43 -06:00
Mark VanLandingham ddf3c571cf FIX: Prevent error when poster isn't present in message notification item (#24776) 2023-12-07 13:21:45 -06:00
Mark VanLandingham ee05f57e2d FEATURE: Site setting to display user avatars in user menu (#24514) 2023-12-07 11:30:44 -06:00
Mark VanLandingham efcb5bb3df DEV: Plugin outlet around user menu empty state (#24730) 2023-12-06 08:06:50 -06:00
Mark VanLandingham d4c02d738b DEV: Add topicNotificationLevel fn to post model (#24723) 2023-12-05 12:08:29 -06:00
Mark VanLandingham fb06cd6712 DEV: Add JS API to adjust desktop topic timeline min/max height (#24669) 2023-12-01 10:29:12 -06:00
Mark VanLandingham c4767158df DEV: Move desktop notifications logic to service (#24466) 2023-11-29 08:20:48 -06:00
Mark VanLandingham aff3d36f35 FIX: Only labels for bold & italic in composer when language doesn't match icon 2023-11-20 15:58:46 -06:00
Mark VanLandingham 1e0de818e6 DEV: Support search menu APIs in glimmer version (#24061) 2023-11-17 11:17:45 -06:00
Mark VanLandingham 7d35e406ba DEV: Add support for limit in notifications index w/o recent param (#24423) 
Currently to use a limit in the notifications index, you have to also pass recent: true as a param.

This PR:

Adds optional limit param to be used in the notifications query, regardless of the presence of recent
Raises the max limit of the response with recent present from 50 -> 60. It is super weird we have a hard-limit of 50 before with recent param, and 60 without the param.
 2023-11-17 08:22:18 -06:00
Mark VanLandingham 69464cbbe2 FIX: Add desktop notification translation for watching_category_or_tag (#24276) 2023-11-16 08:34:58 -06:00
Mark VanLandingham 00f7e58da4 DEV: Add support for condition option when adding toolbar buttons (#24370) 2023-11-14 15:40:34 -06:00
Mark VanLandingham e3f8e9c0fb DEV: Email notification filter plugin API (#24271) 2023-11-08 10:29:00 -06:00
Mark VanLandingham 047cae4b3f FEATURE: Improve push notification message for watching_category_or_tag notifications (#24228) 2023-11-06 10:13:23 -06:00
Mark VanLandingham 1d96b0a99a FIX: Add translation for new push notification (#24203) 2023-11-01 15:45:22 -05:00
Mark VanLandingham 88874389d2 FIX: Send push notifications for category/tag watching notifications (#24196) 
Problem and solution are outlined here on Meta - https://meta.discourse.org/t/watching-a-category-does-not-cause-push-notifications/282794
 2023-11-01 10:06:33 -05:00
Mark VanLandingham e58efa2c2e DEV: Add a couple PluginOutlets to admin theme show (#24184) 2023-10-31 13:34:29 -05:00
Mark VanLandingham cfbe16f9cc DEV: Add option to float-kit toast to force auto-close (#24022) 2023-10-19 10:14:49 -05:00
Mark VanLandingham 585bb0df27 DEV: Add class name of action type for flag-action-type container (#23972) 2023-10-18 10:18:52 -05:00
Mark VanLandingham 55e4fd63be DEV: add class to bookmark-list TD (#23914) 2023-10-12 11:27:00 -05:00
Mark VanLandingham d4399b4f3d FIX: Prevent browser refresh when clicking search menu result (#23881) 2023-10-10 13:05:13 -05:00
Mark VanLandinghamandSérgio Saquetim 4c584f6e03 FIX: List parent/child tags correctly for categories restricted to tag groups (#23708) 
Co-authored-by: Sérgio Saquetim <saquetim@discourse.org>
 2023-10-10 17:30:24 +00:00
Mark VanLandingham f29c476521 DEV: Add hooks to allow overriding notify_user behavior (#23850) 
Adds new plugin registry `:post_action_notify_user_handlers` and more!
 2023-10-10 12:21:57 -05:00
Mark VanLandingham e110256cb0 DEV: Restructure search menu so that it can be rendered outside of header (#23852) 2023-10-10 11:36:32 -05:00
Mark VanLandingham 20700c7c19 DEV: Wrap bookmark-list table header in plugin outlet (#23817) 2023-10-10 08:18:31 -05:00
Mark VanLandingham affcb44557 DEV: Don't attempt to render to empty element in RawRenderGlimmer (#23803) 2023-10-05 13:23:49 -05:00
Mark VanLandingham d64d053f4d DEV: Add body class for user activity bookmarks (#23759) 2023-10-05 12:59:43 -05:00
Mark VanLandingham 576c76e4cb FEATURE: addBeforeAuthCompleteCallback plugin API method (#23441) 2023-09-06 08:48:51 -07:00
Mark VanLandingham 9c65e2140a DEV: Use Notice API for mention warnings (#23238) 
This PR swaps out the custom pathway to publishing and rendering mention warnings after a message is sent.

ChatPublisher#publish_notice is used, and expanded. Now, instead of only accepting text_content as an argument, component and component_args are accepted and there is a renderer for these components.

Translations moved to server, as notices expect text to be passed in unless a component is rendered

The warnings are rendered at the top now, outside of the scope of the single message that sent it.

I entirely removed the jit_messages_spec b/c it's duplicate testing of other parts of the app. IMO we don't need a backend test for a feature, a component test for the feature AND a system test (that is slow and potentially even flakey due to timing issues with wait) to test the same thing. So jit_messages_spec is gone.
 2023-09-01 09:07:23 -05:00
Mark VanLandingham 68eba53e09 FEATURE: Chat global mention warnings (pre-send & post-send) (#22764) 
This is also fixes the issue of chat composer warnings persisting across channels. Currently if you try to mention more groups than is allowed for example, a mention warning pops up. When you change channels the mention warning will not disappear even if there is no text in the composer.

This adds a reset function to the chat-composer-warnings-tracker.js, which is called when the channel is changed and the message is empty. In the event that the message is not empty we call captureMentions to check the loaded drafts' mentions.

This PR would be nicer if the post-send notice used the new chat notices API to publish the mention warnings but we would have to change the existing ones and I thought that would be too much change for this PR. It'd be a good followup though.
 2023-08-22 15:54:35 -05:00
Mark VanLandingham 730f652255 DEV: Add plugin modifier locations for user search locations (#23169) 2023-08-21 12:23:42 -05:00
Mark VanLandingham 291749e35b DEV: Move PluginOutlet at bottom of TopicNavigation (#23149) 2023-08-18 11:41:09 -05:00
Mark VanLandingham fbf7b106cc DEV: Bump selenium-webdriver version to fix system spec running (#23117) 
We can no long user Webdriver - SeleniumHQ/selenium#11066. Bumping selenium-webdriver did the trick, as well as manually setting the user_agent for mobile system specs. Unsure what changed to make this necessary, but it is necessary to get the app to boot in mobile view.
 2023-08-16 15:07:03 -05:00
Mark VanLandingham 51a976eab9 FIX: Display 'shown on X' user field flags (#23109) 
In this commit 2.5 years ago, variables for showOnUserCard and showOnProfile were removed, but we still used them in the component. e29605b

This corrects the variable names and adds a test to confirm the text is now shown.
 2023-08-15 15:59:04 -05:00
Mark VanLandingham bd7a10d705 DEV: Skip flakey network disconnected spec (#23087) 2023-08-14 12:24:16 -05:00
Mark VanLandingham ab3a9b4690 DEV: Add plugin outlet after TopicNavigation (#23038) 2023-08-09 09:49:28 -05:00
Mark VanLandingham 1b63e046af DEV: Plugin API method to replace post-menu buttons (#22995) 2023-08-08 14:00:45 -05:00
Mark VanLandingham 14348fc2f5 FIX: Attempt to connect with navigator.onLine is initially false (#22981) 2023-08-04 09:43:45 -05:00
Mark VanLandingham b91228d6c2 FIX: Looping attempt to reconnect in network connectivity service (#22783) 2023-07-25 11:57:28 -05:00
Mark VanLandingham 3171fd1a0a DEV: Introduce Chat Notices with publishing method (#22369) 2023-07-06 08:26:25 -05:00
Mark VanLandingham acaea2b5c5 DEV: Add plugin_modifier for groups in users_controller#search_users (#22329) 2023-06-28 14:04:22 -05:00
Mark VanLandingham 36b9572bb1 FIX: Attempt to reconnect to server when browser visibilty changes (#22259) 2023-06-23 11:32:34 -05:00