Commit Graph
100 Commits
Author SHA1 Message Date
Penar Musaraj 0cd4da51c7 FIX: Include json_schemer in prod (#12351) 2021-03-10 21:32:23 -05:00
Penar Musaraj 10780d2448 DEV: support json_schema in theme settings (#12294) 2021-03-10 20:15:04 -05:00
Penar Musaraj b3bcf2769a UX: Consistent labels in invite form (#12339) 2021-03-10 12:27:53 -05:00
Penar Musaraj de6474a85f DEV: Update highlight.js dependency to 10.6.0 (#12303) 2021-03-10 11:35:00 -05:00
Penar Musaraj 4071af1d09 DEV: Refactor font and category background importers (#12312) 2021-03-10 11:05:56 -05:00
Penar Musaraj 0a656767c7 DEV: use Redis data for version check in DiscourseUpdates (#12293)
A version bump caused the specs to fail, this switches to using what is
stored in Redis, which is also what is stubbed in the specs.
2021-03-08 09:05:08 -05:00
Penar Musaraj 6809cccd88 DEV: Add experimental json_scheme site setting type (#12226) 2021-03-01 09:15:17 -05:00
Penar Musaraj bfa3e24e48 FIX: Update digest when updating color definitions in theme component (#12233) 2021-03-01 09:14:58 -05:00
Penar Musaraj cf0192018e FIX: Do not output empty style tags for components (#12229) 2021-03-01 09:14:25 -05:00
Penar Musaraj aa1442fdc3 DEV: Use separate files for theme component stylesheets (take 2) (#12225)
This switches to outputting a separate file for each theme component CSS
asset. We have separate CSS plugin files, separate JS files
(for plugins/themes/components), it makes sense to do the same for
component CSS assets.

Benefits:
- easier debugging
- fixes a regression with theme component sourcemaps
- changes to theme components are updated individually

With HTTP/2, there is also no performance downside to having additional
files in the initial request.
2021-02-26 12:30:23 -05:00
Penar Musaraj e74bdfdf8e Revert "DEV: Use separate files for theme component stylesheets (#12214)" (#12224)
This reverts commit f57a49c2f9.

This had some unexpected side effects, needs some more work.
2021-02-26 08:20:39 -05:00
Penar Musaraj 45c5fd2172 DEV: Remove JoyPixels emoji option (#12197)
- removes the option from site settings
- deletes the site setting on existing sites that have it
- marks posts using emojis as requiring a rebake

Note that the actual image files are not removed here, the plan is to
remove them in a few weeks/months (when presumably the rebaking of old
posts has been completed).
2021-02-26 07:44:52 -05:00
Penar Musaraj f57a49c2f9 DEV: Use separate files for theme component stylesheets (#12214)
This switches to outputting a separate file for each theme component CSS
asset. We have separate CSS plugin files, separate JS files
(for plugins/themes/components), it makes sense to do the same for
component CSS assets.

Benefits:
- easier debugging
- fixes a regression with theme component sourcemaps
- changes to theme components are updated individually

With HTTP/2, there is also no performance downside to having additional
files in the initial request.
2021-02-26 07:44:15 -05:00
Penar Musaraj c0fd4ab9d6 DEV: Remove deprecated plugins variables importer (#12168) 2021-02-23 16:20:59 -05:00
Penar Musaraj bd679b95a7 UX: Remove redundant focus style (#12192)
This style is unnecessary because text inputs and textareas have
focus styles set elsewhere (lines 228 and 288 respectively) and we don't
have any `select` elements.
2021-02-23 16:20:39 -05:00
Penar Musaraj 76967ee788 UX: use default browser focus styling for checkbox and radio inputs (#12173) 2021-02-23 14:01:02 -05:00
Penar Musaraj e58922e1e3 UX: Styling adjustments for admin new features (#12189)
- Fixes an alignment issue when emojis have varying widths
- Adjusts mobile alignment
2021-02-23 11:58:20 -05:00
Penar Musaraj 7fb4633b5a DEV: Remove very old mocha deprecation workaround (#12151) 2021-02-22 20:26:49 -05:00
Penar Musaraj 9063520d89 FIX: Avoid Safari service worker error on back navigation (#12171) 2021-02-22 14:11:20 -05:00
Penar Musaraj 0620f6298e UX: Remove emoji step in wizard (#12169) 2021-02-22 12:14:18 -05:00
Penar Musaraj 5604ce70d4 DEV: More refactoring of SCSS importers (#12143) 2021-02-19 11:22:24 -05:00
Penar Musaraj 7ee660a017 FIX: Sort admin dashboard new updates by latest (#12146) 2021-02-19 11:03:36 -05:00
Penar Musaraj 916e1d85cf FEATURE: Quick theme installs via query parameters (#12128) 2021-02-18 12:51:44 -05:00
Penar Musaraj 4739bdac0a UX: Adjustments to admin theme editor (#12112) 2021-02-17 13:00:34 -05:00
Penar Musaraj 431c6de480 UX: Add editing guidance for remote themes (#12111) 2021-02-17 10:24:34 -05:00
Penar Musaraj 5d8673321f DEV: Add poll:voted event (#12070) 2021-02-12 13:06:27 -05:00
Penar Musaraj 74ca5ec743 FIX: Regression in admin new features (#12068) 2021-02-12 10:49:10 -05:00
Penar Musaraj 900d4187ef DEV: Prevents rate limits for new feature checks on multisite (#12053) 2021-02-12 08:52:59 -05:00
Penar Musaraj 578f753a13 UX: Adjust focus styles for autocomplete input (#12051) 2021-02-11 13:11:21 -05:00
Penar Musaraj a6bb7e6d25 DEV: Live reload styles in Ember CLI (#12043) 2021-02-11 10:36:34 -05:00
Penar Musaraj f188091a55 UX: Remove Convert option for system themes (#12033) 2021-02-10 19:20:13 -05:00
Penar Musaraj a1955b0542 Dev: --dev option does nothing in yarn (#12032) 2021-02-10 19:19:47 -05:00
Penar Musaraj 544a4e4b48 UX: Changes to new features section in admin dashboard (#12029) 2021-02-10 13:12:04 -05:00
Penar Musaraj f2de7842bb FEATURE: Support keyboard back/forward navigation on DiscourseHub (#12028) 2021-02-10 11:25:32 -05:00
Penar Musaraj 015ea28778 UX: Small fix for Chrome focus style on replies button (#11996) 2021-02-05 14:02:30 -05:00
Penar Musaraj 2bc739eaa5 UX: Use bright color for primary button hover on dark schemes (#11979) 2021-02-04 13:31:09 -05:00
Penar Musaraj 85310f82f5 FIX: Don't cancel filtering on second "n replies" tap (#11975)
Fixes an issue introduced in 0f31a221c9.
2021-02-04 11:41:01 -05:00
Penar Musaraj eb29827e9d UX: Adjust focus styles for topic post menu, composer cancel (#11977) 2021-02-04 10:28:35 -05:00
Penar Musaraj 12ffba771c FIX: Improve SCSS handling in components (#11963)
- ignores errors when including component SCSS in parent theme
- adds support for SCSS `@import`s in components' `color_definitions.scss` files
2021-02-04 08:51:18 -05:00
Penar Musaraj 3da2e85855 FIX: Save updated remote theme, only update enabled themes/components (#11960) 2021-02-04 14:44:07 +11:00
Penar Musaraj 2dc48fd6c1 UX: Uniformize styles for focus states (#11933) 2021-02-03 11:45:54 -05:00
Penar Musaraj 04dd4a75af UX: Always show confirmation dialog when converting themes/components (#11953) 2021-02-03 11:45:25 -05:00
Penar Musaraj 2309032e68 FIX: Include extra SCSS in child theme (#11952) 2021-02-03 11:02:53 -05:00
Penar Musaraj e8b82724fd DEV: Refactor theme SCSS compilation (#11919) 2021-02-02 13:09:41 -05:00
Penar Musaraj 0f31a221c9 DEV: Performance fixes to filtered replies (#11916) 2021-02-01 11:53:13 -05:00
Penar Musaraj 49e97279c7 FEATURE: Add daily job to check for new features 2021-02-01 10:31:44 +08:00
Penar Musaraj ce904dc765 DEV: Remove tabindex property from selected name template (#11882) 2021-01-28 13:42:59 -05:00
Penar Musaraj e1c0a003fe FIX: external auth account creation in iOS app (#11859) 2021-01-27 08:31:27 -05:00
Penar Musaraj 4228c7e7d1 UX: Small tweak to category delete warning (#11799) 2021-01-26 09:43:47 -05:00
Penar Musaraj 568bad75c1 FIX: Support version in new feature payload (#11841)
Followup to 4f01ca87e3
2021-01-25 16:30:43 -05:00
Penar Musaraj 73cb083b7b FIX: Cannot find currentThemeColorSchemeId when no themeId is present (#11817) 2021-01-22 16:27:19 -05:00
Penar Musaraj 4f01ca87e3 FEATURE: Add new features section in admin dashboard (#11731) 2021-01-22 10:09:02 -05:00
Penar Musaraj a9dfc5a547 DEV: Use absolute path for popper.js sourcemap (#11762) 2021-01-20 08:59:34 -05:00
Penar Musaraj b547b8415d FIX: Check for user presence before granting badge (#11745) 2021-01-18 15:12:38 -05:00
Penar Musaraj 670b438ca5 UX: Use uniform style for tag counts (#11743) 2021-01-18 15:11:23 -05:00
Penar Musaraj 26337408a9 FIX: Safari iOS page title and url regression when sharing (#11699) 2021-01-13 11:10:43 -05:00
Penar Musaraj c819284660 UX: Improve color scheme choices in user prefs (#11656) 2021-01-07 11:15:38 -05:00
Penar Musaraj 5f846531a5 DEV: Cleanup variables/mixins SCSS imports (#11618)
Prepends variables.scss and mixins.scss globally for all assets. With
one notable exception, theme fields, which will be addressed in a
separate PR.
2021-01-05 14:05:34 -05:00
Penar Musaraj 95df15bad9 UX: transition to edit URL when adding a category (#11634) 2021-01-05 08:34:35 -05:00
Penar Musaraj 303f229e98 DEV: Use indexes when importing SCSS from a folder (#11591)
By default, SCSS does not support globbing. This removes our magic and uses index files to import all files in a folder.
2020-12-30 15:29:10 -05:00
Penar Musaraj 79fe97c2bc DEV: Fix precompile SCSS specs (#11590) 2020-12-28 15:28:37 -05:00
Penar Musaraj 7f1bafcf63 DEV: Deprecate SCSS variable overrides in plugins (#11589) 2020-12-28 15:28:11 -05:00
Penar Musaraj 3c5d91afae DEV: Add "before-manage-group-tags" plugin outlet (#11560) 2020-12-22 15:35:55 -05:00
Penar Musaraj 2b8b252249 UX: Move reply filter button on mobile (#11524) 2020-12-18 14:51:13 +11:00
Penar Musaraj 9870a0b6a1 FIX: missing default notification level on group creation (#11512) 2020-12-16 15:52:34 -05:00
Penar Musaraj 230fe0427e DEV: More events for filtered replies (#11511) 2020-12-16 12:11:01 -05:00
Penar Musaraj d1058f4e4c UX: Blend header colors (#11422) 2020-12-16 09:38:51 -05:00
Penar Musaraj 89bf64c0bf DEV: Trigger events when filtering replies (#11498) 2020-12-16 16:46:40 +11:00
Penar Musaraj 8922a878f3 DEV: Add site header organism to styleguide (#11495) 2020-12-15 12:48:47 -05:00
Penar Musaraj 2b2c840297 DEV: Fix JS errors in styleguide (#11494)
Replaces latest topic list component with basic topic list (the former
no longer exists). And fixes the display of the topic footer buttons.
2020-12-15 12:35:14 -05:00
Penar Musaraj 31fe0e91ad UX: Tweaks to filtered replies (#11485)
Include the enable_filtered_replies_view site setting in the admin UI
Adds title label to in-reply-to widget
Invokes the filtered UI when using replies_to_post_number as a query
parameter
Replaces the "Show All" button icon
Fixes grammar for "Viewing 1 reply to..." label
2020-12-15 11:23:44 -05:00
Penar Musaraj d06ac6c353 FIX: Show quote replies when filtering (#11483)
Only applies when using the `enable_filtered_replies_view` site setting.

The filter query was not accounting for quote replies.
2020-12-14 15:24:36 -05:00
Penar Musaraj 0e210df79a FIX: Show correct avatar in post stream bar (#11481)
Also fixes the displayed count of posts when filtered by user.
2020-12-14 15:24:15 -05:00
Penar Musaraj 820b3e672a DEV: Remove jquery.ba-resize (#11457) 2020-12-11 11:36:32 -05:00
Penar Musaraj b24a77ff91 DEV: Run post stream scroll events less often (#11463)
See PR for details.
2020-12-10 14:09:11 -05:00
Penar Musaraj 8940e0f163 DEV: Fix position of filtered replies notice on DiscourseHub (#11462) 2020-12-10 13:25:09 -05:00
Penar Musaraj adda53c462 FEATURE: Optional filtered replies view (#11387)
See PR for details
2020-12-10 12:02:07 -05:00
Penar Musaraj fb2e24a77a UX: Fix unreachable buttons on menus in Safari iOS (#11458)
Safari overlays its own nav at the bottom 10% or so of the screen. This
makes buttons in that area virtually unclickable, so to ensure buttons
there are reachable, we need to add enough bottom padding to menu panels.
2020-12-10 08:11:58 -05:00
Penar Musaraj 3e1b84963d DEV: Remove duplicate (and deprecated) SK option (#11435) 2020-12-08 13:21:02 -05:00
Penar Musaraj 28feb7c2ff DEV: Add header colors to styleguide (#11421) 2020-12-07 14:50:45 -05:00
Penar Musaraj dd9ec827e5 FIX: Adjust reviewable menu placement on mobile (#11420)
Shows the actions dropdown above the triggering button to avoid some
options from displaying below mobile navigation in DiscourseHub.
2020-12-07 13:39:18 -05:00
Penar Musaraj 490e1cfbbb DEV: Use tag renderer in tags filter dropdown (#11378)
A small change that would allow components to extend the tag
display in the filter dropdown, like they can in other contexts.

Was requested in the tag icons component, see
https://meta.discourse.org/t/tag-icons-component/109757/60?u=pmusaraj

The PR also standardises tag styling in select-kit dropdowns.
2020-12-07 12:10:21 -05:00
Penar Musaraj 67979b2b21 Remove "Alternative Logos" from popular themes list (#11337)
Core has had support for dark theme logos for a while now.
2020-11-24 10:13:16 -05:00
Penar Musaraj 4b538e7cb9 DEV: Skip missing icon warnings in production (#11334)
The list of SVG icons is unavailable in production, and the previous
refactor here was causing incorrect and noisy console warnings.

This also parses the `svgIconList` string in a dev environment, icons
should now match more accurately.
2020-11-23 21:41:54 -05:00
Penar Musaraj 7539c2ed7f UX: Revamp category security tab (#11273) 2020-11-20 10:44:34 -05:00
Penar Musaraj 82c1c0c48c DEV: Fix flakey spec in export_user_archive (#11278) 2020-11-18 11:12:06 -05:00
Penar Musaraj d90b852cd0 UX: bottom padding for menu panel on iOS notch devices (#11270) 2020-11-17 15:42:03 -05:00
Penar Musaraj 89fc11e93b UX: Layout changes to edit category page (#11222) 2020-11-12 12:51:25 -05:00
Penar Musaraj 7fe0830fa8 DEV: Delete en-SG moment-locale (#11220)
This is now in the lowercase en-sg file, and it causes issues on macOS dev environments to have both en-SG and en-sg files in the same location.
2020-11-12 11:24:59 -05:00
Penar Musaraj 698b7ace10 FIX: Reset category edit page button state (#11218)
Fixes two small issues:
- buttons stayed disabled after deleting a category
- on a newly-created category, the Edit button was missing on the category landing page
2020-11-12 10:03:58 -05:00
Penar Musaraj fc4910b556 FIX: Use more specific selector for header (#11185) 2020-11-10 11:53:56 -05:00
Penar Musaraj 0b7f43fba8 REFACTOR: Remove SweetAlert dependency (#11183) 2020-11-10 11:31:54 -05:00
Penar Musaraj bfc3bc0733 FIX: Small copy change in wizard (#11174) 2020-11-09 12:19:58 -08:00
Penar Musaraj 57bd85af31 UX: Minor cosmetic fixes to the wizard (#11172)
- Does not force users to type a description or a welcome topic
- Adds * marker for required text fields (site title and email)
2020-11-09 15:14:57 -05:00
Penar Musaraj 707ed01f33 UX: Wider canvas buttons in wizard (#11124) 2020-11-05 09:55:35 -05:00
Penar Musaraj 9f6c4ad71a FIX: inconsistency in S3 inventory config (#11112)
Ensures it matches S3 inventory config generation in our hosting.
2020-11-05 08:39:40 -05:00
Penar Musaraj c1f3bd6a1c FIX: secure_media stripping on lightboxes, non-image links (#11121)
- Fixes stripping of lightboxes with empty srcset attribute
- Does not fail when email has links with secure media URLs but no child image elements
2020-11-04 15:45:50 -05:00
Penar Musaraj 5041ebe612 UX: Fix confusing admin UI for color scheme updates (#11100) 2020-11-02 11:28:04 -05:00
Penar Musaraj f5a726e52b FIX: Disabled action buttons on newly-created category (#11080)
Ensures the newly created category record gives the current user permission to create a new topic and sets her notification level to the default (regular).
2020-11-02 09:36:27 -05:00
Penar Musaraj d5fb0b9435 DEV: Ignore VSCode and DirEnv config files (#11083) 2020-10-30 12:32:48 -04:00